[INFO] updating cached repository Vanglant/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Vanglant/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Vanglant/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/Vanglant/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Vanglant/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Vanglant/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vanglant/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vanglant/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 09112574d89ec5ff5bb84a51105298afea319012 [INFO] sha for GitHub repo Vanglant/advent-of-code-2018: 09112574d89ec5ff5bb84a51105298afea319012 [INFO] validating manifest of Vanglant/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Vanglant/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Vanglant/advent-of-code-2018 [INFO] finished frobbing Vanglant/advent-of-code-2018 [INFO] frobbed toml for Vanglant/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/Vanglant/advent-of-code-2018/Cargo.toml [INFO] started frobbing Vanglant/advent-of-code-2018 [INFO] finished frobbing Vanglant/advent-of-code-2018 [INFO] frobbed toml for Vanglant/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vanglant/advent-of-code-2018/Cargo.toml [INFO] crate Vanglant/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Vanglant/advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Vanglant/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a2f3bbd6f50060811d154bb8bf35b96ca33499259932080bfa1ebb8d62980f9 [INFO] running `"docker" "start" "-a" "8a2f3bbd6f50060811d154bb8bf35b96ca33499259932080bfa1ebb8d62980f9"` [INFO] [stderr] Checking AdventOfCode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: couldn't read src/day9.rs: No such file or directory (os error 2) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `AdventOfCode`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/day6plus.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | writeln!(file, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(file, "")` [INFO] [stderr] --> src/day6plus.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | writeln!(file, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(file)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/day2.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | let lines = stdin.lock().lines().map(Result::unwrap).into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `stdin.lock().lines().map(Result::unwrap)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/day2.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | fn calculate_coincidences(matches: &(u32, u32), box_id: &str) -> (u32, u32) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(u32, u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/day6plus.rs:86:48 [INFO] [stderr] | [INFO] [stderr] 86 | let addition = &hmap.iter().fold(0, |acc, (x , y)| acc + *y); [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/day6plus.rs:86:48 [INFO] [stderr] | [INFO] [stderr] 86 | let addition = &hmap.iter().fold(0, |acc, (x , y)| acc + *y); [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/day10.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | use std::{thread, time}; [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day6plus.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | let coords: Vec<&str> = s.split(",").map(|x| x.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/day6plus.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | let coords: Vec<&str> = s.split(",").map(|x| x.trim()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6plus.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | fn new(points: &Vec) -> Grid { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6plus.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | fn new(points: &Vec) -> Grid { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6plus.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | fn fill_cells(cells: Vec>, points: &Vec) -> Grid { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/day6plus.rs:116:32 [INFO] [stderr] | [INFO] [stderr] 116 | if closer_point == "#".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"#"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day6plus.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | fn fill_cells(cells: Vec>, points: &Vec) -> Grid { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Point]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/day6plus.rs:116:32 [INFO] [stderr] | [INFO] [stderr] 116 | if closer_point == "#".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `"#"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `fabric`. [INFO] [stderr] --> src/day3.rs:70:14 [INFO] [stderr] | [INFO] [stderr] 70 | for x in 0..1000 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 70 | for in fabric.iter().take(1000) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `thread`, `time` [INFO] [stderr] --> src/day10.rs:7:11 [INFO] [stderr] | [INFO] [stderr] 7 | use std::{thread, time}; [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | fn run_simulation(s: i64, points: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[PointOfLight]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day10.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | x = x - min_x; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `x -= min_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day10.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | x = x + min_x.abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `x += min_x.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day10.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | y = y - min_y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `y -= min_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day10.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | y = y + min_y.abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += min_y.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | fn print_map(map: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec<&str>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:79:35 [INFO] [stderr] | [INFO] [stderr] 79 | fn run_simulation(s: i64, points: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[PointOfLight]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day10.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | x = x - min_x; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `x -= min_x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day10.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | x = x + min_x.abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `x += min_x.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day10.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | y = y - min_y; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `y -= min_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/day10.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | y = y + min_y.abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `y += min_y.abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day10.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | fn print_map(map: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec<&str>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8a2f3bbd6f50060811d154bb8bf35b96ca33499259932080bfa1ebb8d62980f9"` [INFO] running `"docker" "rm" "-f" "8a2f3bbd6f50060811d154bb8bf35b96ca33499259932080bfa1ebb8d62980f9"` [INFO] [stdout] 8a2f3bbd6f50060811d154bb8bf35b96ca33499259932080bfa1ebb8d62980f9