[INFO] updating cached repository Valtis/YATCP [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Valtis/YATCP [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Valtis/YATCP" "work/ex/clippy-test-run/sources/stable/gh/Valtis/YATCP"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Valtis/YATCP'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Valtis/YATCP" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Valtis/YATCP"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Valtis/YATCP'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 925bebd9ae7268f961dbd1accb8480d329725ff3 [INFO] sha for GitHub repo Valtis/YATCP: 925bebd9ae7268f961dbd1accb8480d329725ff3 [INFO] validating manifest of Valtis/YATCP on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Valtis/YATCP on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Valtis/YATCP [INFO] finished frobbing Valtis/YATCP [INFO] frobbed toml for Valtis/YATCP written to work/ex/clippy-test-run/sources/stable/gh/Valtis/YATCP/Cargo.toml [INFO] started frobbing Valtis/YATCP [INFO] finished frobbing Valtis/YATCP [INFO] frobbed toml for Valtis/YATCP written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Valtis/YATCP/Cargo.toml [INFO] crate Valtis/YATCP has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Valtis/YATCP against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Valtis/YATCP:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3d4eeb58da2786771522331dba4923c9c857930dd4d6f7d97775e14cd23299b [INFO] running `"docker" "start" "-a" "c3d4eeb58da2786771522331dba4923c9c857930dd4d6f7d97775e14cd23299b"` [INFO] [stderr] Checking compiler v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/mod.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | Token { token_type: token_type, token_subtype: subtype, line: line, column: column, length: length } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/mod.rs:203:61 [INFO] [stderr] | [INFO] [stderr] 203 | Token { token_type: token_type, token_subtype: subtype, line: line, column: column, length: length } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/mod.rs:203:73 [INFO] [stderr] | [INFO] [stderr] 203 | Token { token_type: token_type, token_subtype: subtype, line: line, column: column, length: length } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/mod.rs:203:89 [INFO] [stderr] | [INFO] [stderr] 203 | Token { token_type: token_type, token_subtype: subtype, line: line, column: column, length: length } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | error_reporter: error_reporter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_reporter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer/mod.rs:50:11 [INFO] [stderr] | [INFO] [stderr] 50 | error_reporter: error_reporter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_reporter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:449:13 [INFO] [stderr] | [INFO] [stderr] 449 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tac_generator/mod.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/basic_block.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/basic_block.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cfg/dom_front.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | basic_blocks: basic_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `basic_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | adjacency_list: adjacency_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjacency_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | dominance_frontier: dominance_frontier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dominance_frontier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | src1: src1, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `src1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | src2: src2, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `src2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:201:26 [INFO] [stderr] | [INFO] [stderr] 201 | UnaryOperation { src: src, dest: dest } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:201:36 [INFO] [stderr] | [INFO] [stderr] 201 | UnaryOperation { src: src, dest: dest } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:209:27 [INFO] [stderr] | [INFO] [stderr] 209 | BinaryOperation { src1: src1, src2: src2, dest: op_dest } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `src1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:209:39 [INFO] [stderr] | [INFO] [stderr] 209 | BinaryOperation { src1: src1, src2: src2, dest: op_dest } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `src2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator/x64.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | bytecode_functions: bytecode_functions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytecode_functions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | bytecode_functions: bytecode_functions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytecode_functions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | endianess: endianess, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `endianess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | machine: machine, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `machine` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | header_size: header_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | architecture: architecture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `architecture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | input_file: input_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | output_file: output_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:391:13 [INFO] [stderr] | [INFO] [stderr] 391 | code: code [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:435:13 [INFO] [stderr] | [INFO] [stderr] 435 | strings: strings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | strings: strings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:537:13 [INFO] [stderr] | [INFO] [stderr] 537 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error_reporter/mod.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error_reporter/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error_reporter/mod.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | message: message [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/mod.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | Token { token_type: token_type, token_subtype: subtype, line: line, column: column, length: length } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/mod.rs:203:61 [INFO] [stderr] | [INFO] [stderr] 203 | Token { token_type: token_type, token_subtype: subtype, line: line, column: column, length: length } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/mod.rs:203:73 [INFO] [stderr] | [INFO] [stderr] 203 | Token { token_type: token_type, token_subtype: subtype, line: line, column: column, length: length } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/token/mod.rs:203:89 [INFO] [stderr] | [INFO] [stderr] 203 | Token { token_type: token_type, token_subtype: subtype, line: line, column: column, length: length } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/mod.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | error_reporter: error_reporter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_reporter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer/mod.rs:50:11 [INFO] [stderr] | [INFO] [stderr] 50 | error_reporter: error_reporter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_reporter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:449:13 [INFO] [stderr] | [INFO] [stderr] 449 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:451:13 [INFO] [stderr] | [INFO] [stderr] 451 | return_type: return_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast/mod.rs:484:13 [INFO] [stderr] | [INFO] [stderr] 484 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tac_generator/mod.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/basic_block.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/basic_block.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cfg/dom_front.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | basic_blocks: basic_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `basic_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | adjacency_list: adjacency_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjacency_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | dominance_frontier: dominance_frontier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dominance_frontier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cfg/mod.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | src1: src1, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `src1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | src2: src2, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `src2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:201:26 [INFO] [stderr] | [INFO] [stderr] 201 | UnaryOperation { src: src, dest: dest } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `src` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:201:36 [INFO] [stderr] | [INFO] [stderr] 201 | UnaryOperation { src: src, dest: dest } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dest` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:209:27 [INFO] [stderr] | [INFO] [stderr] 209 | BinaryOperation { src1: src1, src2: src2, dest: op_dest } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `src1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/byte_generator/mod.rs:209:39 [INFO] [stderr] | [INFO] [stderr] 209 | BinaryOperation { src1: src1, src2: src2, dest: op_dest } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `src2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator/x64.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | bytecode_functions: bytecode_functions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytecode_functions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/code_generator/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | bytecode_functions: bytecode_functions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytecode_functions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:208:13 [INFO] [stderr] | [INFO] [stderr] 208 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | endianess: endianess, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `endianess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | machine: machine, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `machine` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | header_size: header_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `header_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | architecture: architecture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `architecture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | input_file: input_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | output_file: output_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:391:13 [INFO] [stderr] | [INFO] [stderr] 391 | code: code [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:435:13 [INFO] [stderr] | [INFO] [stderr] 435 | strings: strings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | strings: strings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/obj_generator/elf_obj.rs:537:13 [INFO] [stderr] | [INFO] [stderr] 537 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error_reporter/mod.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error_reporter/mod.rs:166:17 [INFO] [stderr] | [INFO] [stderr] 166 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error_reporter/mod.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | message: message [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tac_generator/mod.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | const TMP_NAME : &'static str = "%tmp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cfg/mod.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return parents; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `parents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/cfg/mod.rs:205:21 [INFO] [stderr] | [INFO] [stderr] 205 | / if id == block { [INFO] [stderr] 206 | | if !parents.contains(&i) { [INFO] [stderr] 207 | | parents.push(i); [INFO] [stderr] 208 | | continue; [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 205 | if id == block && !parents.contains(&i) { [INFO] [stderr] 206 | parents.push(i); [INFO] [stderr] 207 | continue; [INFO] [stderr] 208 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/optimizer/const_prop.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/optimizer/const_prop.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/optimizer/merge_block.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | }; val } ).collect::>(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/optimizer/merge_block.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | map(|v| { let val = if let Adj::Block(id) = *v { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 92 | | if id > child { [INFO] [stderr] 93 | | Adj::Block(id-1) [INFO] [stderr] 94 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 98 | | Adj::End [INFO] [stderr] 99 | | }; val } ).collect::>(); [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/obj_generator/elf_obj.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | const MAGIC_NUMBER : &'static str ="\u{007f}ELF"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:100:26 [INFO] [stderr] | [INFO] [stderr] 100 | const SHT_LOPROC : u32 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:101:26 [INFO] [stderr] | [INFO] [stderr] 101 | const SHT_HIPROC : u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | const SHT_LOUSER : u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | const SHT_HIUSER : u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | const SHF_MASKPROC : u32 = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tac_generator/mod.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | const TMP_NAME : &'static str = "%tmp"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cfg/mod.rs:217:5 [INFO] [stderr] | [INFO] [stderr] 217 | return parents; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `parents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/cfg/mod.rs:205:21 [INFO] [stderr] | [INFO] [stderr] 205 | / if id == block { [INFO] [stderr] 206 | | if !parents.contains(&i) { [INFO] [stderr] 207 | | parents.push(i); [INFO] [stderr] 208 | | continue; [INFO] [stderr] 209 | | } [INFO] [stderr] 210 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 205 | if id == block && !parents.contains(&i) { [INFO] [stderr] 206 | parents.push(i); [INFO] [stderr] 207 | continue; [INFO] [stderr] 208 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/optimizer/const_prop.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/optimizer/const_prop.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/optimizer/merge_block.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | }; val } ).collect::>(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/optimizer/merge_block.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | map(|v| { let val = if let Adj::Block(id) = *v { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 92 | | if id > child { [INFO] [stderr] 93 | | Adj::Block(id-1) [INFO] [stderr] 94 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 98 | | Adj::End [INFO] [stderr] 99 | | }; val } ).collect::>(); [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/obj_generator/elf_obj.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | const MAGIC_NUMBER : &'static str ="\u{007f}ELF"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:100:26 [INFO] [stderr] | [INFO] [stderr] 100 | const SHT_LOPROC : u32 = 0x70000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:101:26 [INFO] [stderr] | [INFO] [stderr] 101 | const SHT_HIPROC : u32 = 0x7fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | const SHT_LOUSER : u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | const SHT_HIUSER : u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/obj_generator/elf_obj.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | const SHF_MASKPROC : u32 = 0xf0000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xf000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: value assigned to `changes` is never read [INFO] [stderr] --> src/optimizer/merge_block.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | changes = true; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `changes` is never read [INFO] [stderr] --> src/optimizer/merge_block.rs:24:21 [INFO] [stderr] | [INFO] [stderr] 24 | changes = true; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RSP` [INFO] [stderr] --> src/code_generator/x64.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | RSP, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `string_table::StringTable` [INFO] [stderr] --> src/string_table/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> StringTable { [INFO] [stderr] 15 | | StringTable { [INFO] [stderr] 16 | | strings: vec![], [INFO] [stderr] 17 | | str_indices: HashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/mod.rs:204:21 [INFO] [stderr] | [INFO] [stderr] 204 | format!("Variable declaration must be followed by initialization")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Variable declaration must be followed by initialization".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser/mod.rs:645:17 [INFO] [stderr] | [INFO] [stderr] 645 | for ref token_type in types.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^ ------------ help: try: `let token_type = &types.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/mod.rs:696:57 [INFO] [stderr] | [INFO] [stderr] 696 | fn report_unexpected_token_mul(&mut self, expected: &Vec, actual: &Token) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[TokenType]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / loop { [INFO] [stderr] 69 | | match self.next_char() { [INFO] [stderr] 70 | | Some(ch) => if ch == '\n' { break }, [INFO] [stderr] 71 | | None => break, [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(ch) = self.next_char() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lexer/mod.rs:292:24 [INFO] [stderr] | [INFO] [stderr] 292 | if separator_error == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!separator_error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lexer/mod.rs:491:21 [INFO] [stderr] | [INFO] [stderr] 491 | match *(res.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 491 | match *&(*res).clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 491 | match *&std::result::Result::clone(res) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/semcheck/mod.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | for ref mut child in children { [INFO] [stderr] | ^^^^^^^^^^^^^ -------- help: try: `let child = &mut children;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/semcheck/mod.rs:440:15 [INFO] [stderr] | [INFO] [stderr] 440 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> src/semcheck/mod.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | arith_info.node_type == Type::Invalid; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/semcheck/mod.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | arith_info.node_type == Type::Invalid; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/semcheck/mod.rs:752:57 [INFO] [stderr] | [INFO] [stderr] 752 | fn check_identifier_is_initialized(&mut self, name: &String, info: &NodeInfo) -> [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `symbol_table::TableEntry` [INFO] [stderr] --> src/symbol_table/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> TableEntry { [INFO] [stderr] 19 | | TableEntry { [INFO] [stderr] 20 | | symbols: vec![], [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table/mod.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn find_symbol(&self, name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/symbol_table/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / if let &Symbol::Function(ref info) = s { [INFO] [stderr] 49 | | return Some(info.clone()) [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | if let Symbol::Function(ref info) = *s { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `symbol_table::SymbolTable` [INFO] [stderr] --> src/symbol_table/mod.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> SymbolTable { [INFO] [stderr] 62 | | SymbolTable { [INFO] [stderr] 63 | | entries: vec![], [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/symbol_table/mod.rs:80:17 [INFO] [stderr] | [INFO] [stderr] 80 | assert!(self.entries.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.entries.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table/mod.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn find_symbol(&self, name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / match *statement { [INFO] [stderr] 38 | | Statement::Label(id) => { [INFO] [stderr] 39 | | label_id_pos.insert(id, i); [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | _ => {}, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Statement::Label(id) = *statement { [INFO] [stderr] 38 | label_id_pos.insert(id, i); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match *statement { [INFO] [stderr] 49 | | Statement::Jump(ref mut id) => { [INFO] [stderr] 50 | | let mut changes = true; [INFO] [stderr] 51 | | while changes { [INFO] [stderr] ... | [INFO] [stderr] 65 | | _ => {}, [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | if let Statement::Jump(ref mut id) = *statement { [INFO] [stderr] 49 | let mut changes = true; [INFO] [stderr] 50 | while changes { [INFO] [stderr] 51 | changes = false; [INFO] [stderr] 52 | let idx = label_id_pos[&*id] + 1; [INFO] [stderr] 53 | if idx < cloned.len() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | / match cloned[idx] { [INFO] [stderr] 56 | | Statement::Jump(other_id) => { [INFO] [stderr] 57 | | *id = other_id; [INFO] [stderr] 58 | | changes = true; [INFO] [stderr] 59 | | }, [INFO] [stderr] 60 | | _ => {}, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | if let Statement::Jump(other_id) = cloned[idx] { [INFO] [stderr] 56 | *id = other_id; [INFO] [stderr] 57 | changes = true; [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match function.statements[i].clone() { [INFO] [stderr] 92 | | Statement::Assignment( [INFO] [stderr] 93 | | None, [INFO] [stderr] 94 | | Some(Operand::Variable(ref var_info, ref var_id)), [INFO] [stderr] ... | [INFO] [stderr] 126 | | _ => {}, [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 91 | if let Statement::Assignment( [INFO] [stderr] 92 | None, [INFO] [stderr] 93 | Some(Operand::Variable(ref var_info, ref var_id)), [INFO] [stderr] 94 | None, [INFO] [stderr] 95 | Some(Operand::Variable(ref tmp_info, ref tmp_id))) = function.statements[i].clone() { [INFO] [stderr] 96 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | / match function.statements[i-1] { [INFO] [stderr] 109 | | Statement::Assignment( [INFO] [stderr] 110 | | _, [INFO] [stderr] 111 | | Some(Operand::Variable(ref mut prev_info, ref mut prev_id)), [INFO] [stderr] ... | [INFO] [stderr] 123 | | _ => {} [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | if let Statement::Assignment( [INFO] [stderr] 109 | _, [INFO] [stderr] 110 | Some(Operand::Variable(ref mut prev_info, ref mut prev_id)), [INFO] [stderr] 111 | _, [INFO] [stderr] 112 | _) = function.statements[i-1] { [INFO] [stderr] 113 | // if this is the same temporary than in the previous, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `remove_list`. [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | for j in i..remove_list.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 134 | for in remove_list.iter_mut().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / match function.statements[i] { [INFO] [stderr] 151 | | Statement::Label(cur_label) => { [INFO] [stderr] 152 | | if let Statement::Label(prev_label) = function.statements[i-1] { [INFO] [stderr] 153 | | i -= 1; [INFO] [stderr] ... | [INFO] [stderr] 157 | | _ => {}, [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 150 | if let Statement::Label(cur_label) = function.statements[i] { [INFO] [stderr] 151 | if let Statement::Label(prev_label) = function.statements[i-1] { [INFO] [stderr] 152 | i -= 1; [INFO] [stderr] 153 | merge_labels(function, i, cur_label, prev_label); [INFO] [stderr] 154 | } [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tac_generator/mod.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | children: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[AstNode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/tac_generator/mod.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | for ref child in children { [INFO] [stderr] | ^^^^^^^^^ -------- help: try: `let child = &children;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tac_generator/mod.rs:298:15 [INFO] [stderr] | [INFO] [stderr] 298 | args: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[AstNode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tac_generator/mod.rs:336:15 [INFO] [stderr] | [INFO] [stderr] 336 | name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tac_generator/mod.rs:343:15 [INFO] [stderr] | [INFO] [stderr] 343 | name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tac_generator/mod.rs:406:43 [INFO] [stderr] | [INFO] [stderr] 406 | fn handle_identifier(&mut self, name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tac_generator/mod.rs:489:16 [INFO] [stderr] | [INFO] [stderr] 489 | if let Some(_) = *opt_else_blk { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 490 | | self.current_function().statements.push( [INFO] [stderr] 491 | | Statement::Jump(else_blk_label)); [INFO] [stderr] 492 | | } [INFO] [stderr] | |_________- help: try this: `if *opt_else_blk.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tac_generator/mod.rs:532:44 [INFO] [stderr] | [INFO] [stderr] 532 | Operand::Initialized(ref t) => t.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tac_generator/mod.rs:566:46 [INFO] [stderr] | [INFO] [stderr] 566 | fn get_variable_info_and_id(&self, name: &String) -> (DeclarationInfo, u32) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/cfg/dom_front.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | func_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 9 | pub fn calculate_dominance_frontier( [INFO] [stderr] 10 | func_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cfg/dom_front.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | if parents.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `opt_idom` [INFO] [stderr] --> src/cfg/dom_front.rs:161:14 [INFO] [stderr] | [INFO] [stderr] 161 | for i in 0..opt_idom.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for (i, ) in opt_idom.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cfg/dom_front.rs:171:15 [INFO] [stderr] | [INFO] [stderr] 171 | opt_idom: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `remove_list`. [INFO] [stderr] --> src/cfg/mod.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | for j in (i+1)..remove_list.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 117 | for in remove_list.iter_mut().skip((i+1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cfg/mod.rs:195:32 [INFO] [stderr] | [INFO] [stderr] 195 | fn get_parents(adjacency_list: &Vec>, block: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg/mod.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | / match *b { [INFO] [stderr] 204 | | Adj::Block(id) => { [INFO] [stderr] 205 | | if id == block { [INFO] [stderr] 206 | | if !parents.contains(&i) { [INFO] [stderr] ... | [INFO] [stderr] 212 | | _ => {}, [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 203 | if let Adj::Block(id) = *b { [INFO] [stderr] 204 | if id == block { [INFO] [stderr] 205 | if !parents.contains(&i) { [INFO] [stderr] 206 | parents.push(i); [INFO] [stderr] 207 | continue; [INFO] [stderr] 208 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cfg/mod.rs:240:34 [INFO] [stderr] | [INFO] [stderr] 240 | fn create_adj_list(basic_blocks: &Vec, f: &Function) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[BasicBlock]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg/mod.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | / match *adj { [INFO] [stderr] 347 | | Adj::Block(ref mut id) => { [INFO] [stderr] 348 | | if *id > bb_id { [INFO] [stderr] 349 | | *id -= 1; [INFO] [stderr] ... | [INFO] [stderr] 352 | | _ => {}, [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 346 | if let Adj::Block(ref mut id) = *adj { [INFO] [stderr] 347 | if *id > bb_id { [INFO] [stderr] 348 | *id -= 1; [INFO] [stderr] 349 | } [INFO] [stderr] 350 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/ssa_generator/mod.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | function_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 12 | pub fn convert_to_ssa( [INFO] [stderr] 13 | functions: &mut Vec, [INFO] [stderr] 14 | function_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ssa_generator/mod.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / match function.statements[insertion] { [INFO] [stderr] 94 | | Statement::Label(_) => insertion += 1, // insert after label [INFO] [stderr] 95 | | _ => {}, [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ help: try this: `if let Statement::Label(_) = function.statements[insertion] { insertion += 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ssa_generator/mod.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | basic_blocks: &Vec) -> (HashMap>, HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[BasicBlock]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/ssa_generator/mod.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | / if !decl_info.contains_key(&id) { [INFO] [stderr] 134 | | decl_info.insert(id, info.clone()); [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________________^ help: consider using: `decl_info.entry(id).or_insert(info.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/ssa_generator/mod.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | / if !definitions.contains_key(&id) { [INFO] [stderr] 137 | | definitions.insert(id, vec![]); [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________________^ help: consider using: `definitions.entry(id).or_insert(< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/ssa_generator/mod.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | / 'outer: for i in cfg.basic_blocks[block].start..cfg.basic_blocks[block].end { [INFO] [stderr] 221 | | match function.statements[i] { [INFO] [stderr] 222 | | Statement::PhiFunction(Operand::Variable(_, var_id), ref mut operands) | [INFO] [stderr] 223 | | Statement::PhiFunction(Operand::SSAVariable(_, var_id, _), ref mut operands) => { [INFO] [stderr] ... | [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/ssa_generator/mod.rs:336:25 [INFO] [stderr] | [INFO] [stderr] 336 | function_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 334 | pub fn destroy_ssa( [INFO] [stderr] 335 | functions: &mut Vec, [INFO] [stderr] 336 | function_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match s.clone() { [INFO] [stderr] 33 | | // integer assignment [INFO] [stderr] 34 | | Statement::Assignment( [INFO] [stderr] 35 | | Some(operator), [INFO] [stderr] ... | [INFO] [stderr] 56 | | _ => {}, [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Statement::Assignment( [INFO] [stderr] 33 | Some(operator), [INFO] [stderr] 34 | Some(var @ Operand::SSAVariable(_, _, _)), [INFO] [stderr] 35 | Some(Operand::Integer(val)) , [INFO] [stderr] 36 | Some(Operand::Integer(val2))) = s.clone() { [INFO] [stderr] 37 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / match *val1 { [INFO] [stderr] 89 | | Operand::SSAVariable(_, var_id, ssa_id) => { [INFO] [stderr] 90 | | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 91 | | [INFO] [stderr] ... | [INFO] [stderr] 98 | | _ => {}, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | if let Operand::SSAVariable(_, var_id, ssa_id) = *val1 { [INFO] [stderr] 89 | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 90 | [INFO] [stderr] 91 | if let Statement::Assignment(_, _, ref mut op, _) = *s { [INFO] [stderr] 92 | *op = Some(known_constants[&(var_id, ssa_id)].clone()); [INFO] [stderr] 93 | changes = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / match *val2 { [INFO] [stderr] 102 | | Operand::SSAVariable(_, var_id, ssa_id) => { [INFO] [stderr] 103 | | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 104 | | if let Statement::Assignment(_, _, _, ref mut op) = *s { [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => {}, [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Operand::SSAVariable(_, var_id, ssa_id) = *val2 { [INFO] [stderr] 102 | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 103 | if let Statement::Assignment(_, _, _, ref mut op) = *s { [INFO] [stderr] 104 | *op = Some(known_constants[&(var_id, ssa_id)].clone()); [INFO] [stderr] 105 | changes = true; [INFO] [stderr] 106 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match *val { [INFO] [stderr] 117 | | Operand::SSAVariable(_, var_id, ssa_id) => { [INFO] [stderr] 118 | | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 119 | | if let Statement::JumpIfTrue(ref mut op, _) = *s { [INFO] [stderr] ... | [INFO] [stderr] 125 | | _ => {}, [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | if let Operand::SSAVariable(_, var_id, ssa_id) = *val { [INFO] [stderr] 117 | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 118 | if let Statement::JumpIfTrue(ref mut op, _) = *s { [INFO] [stderr] 119 | *op = known_constants[&(var_id, ssa_id)].clone(); [INFO] [stderr] 120 | return true; [INFO] [stderr] 121 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / match *val { [INFO] [stderr] 130 | | Operand::SSAVariable(_, var_id, ssa_id) => { [INFO] [stderr] 131 | | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 132 | | if let Statement::Return(ref mut op) = *s { [INFO] [stderr] ... | [INFO] [stderr] 138 | | _ => {}, [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | if let Operand::SSAVariable(_, var_id, ssa_id) = *val { [INFO] [stderr] 130 | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 131 | if let Statement::Return(ref mut op) = *s { [INFO] [stderr] 132 | *op = Some(known_constants[&(var_id, ssa_id)].clone()); [INFO] [stderr] 133 | return true; [INFO] [stderr] 134 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/optimizer/dead_code.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | function_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 17 | pub fn remove_dead_code( [INFO] [stderr] 18 | functions: &mut Vec, [INFO] [stderr] 19 | function_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / match *s { [INFO] [stderr] 86 | | Statement::PhiFunction( [INFO] [stderr] 87 | | _, [INFO] [stderr] 88 | | ref mut operands) => { [INFO] [stderr] ... | [INFO] [stderr] 97 | | _ => {}, [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let Statement::PhiFunction( [INFO] [stderr] 86 | _, [INFO] [stderr] 87 | ref mut operands) = *s { [INFO] [stderr] 88 | operands.retain(|v| { [INFO] [stderr] 89 | if let Operand::SSAVariable(_, ref var_id, ref ssa_id) = *v { [INFO] [stderr] 90 | !writes.contains(&(*var_id, *ssa_id)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `unconnected_blocks`. [INFO] [stderr] --> src/optimizer/dead_code.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | for j in i..unconnected_blocks.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in unconnected_blocks.iter_mut().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / match *s { [INFO] [stderr] 153 | | Statement::PhiFunction( [INFO] [stderr] 154 | | Operand::SSAVariable(_, dst_var_id, dst_ssa_id), [INFO] [stderr] 155 | | ref operands) => { [INFO] [stderr] ... | [INFO] [stderr] 176 | | _ => {}, [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | if let Statement::PhiFunction( [INFO] [stderr] 153 | Operand::SSAVariable(_, dst_var_id, dst_ssa_id), [INFO] [stderr] 154 | ref operands) = *s { [INFO] [stderr] 155 | if operands.len() == 1 { [INFO] [stderr] 156 | if let Operand::SSAVariable(_, src_var_id, src_ssa_id) = operands[0] { [INFO] [stderr] 157 | remove_list.push(i); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/optimizer/dead_code.rs:163:40 [INFO] [stderr] | [INFO] [stderr] 163 | let prev = renames[&(src_var_id, src_ssa_id)].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `renames[&(src_var_id, src_ssa_id)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | / match *val { [INFO] [stderr] 191 | | Operand::SSAVariable(_, ref mut var_id, ref mut ssa_id) => { [INFO] [stderr] 192 | | if renames.contains_key(&(*var_id, *ssa_id)) { [INFO] [stderr] 193 | | let (new_var_id, new_ssa_id) = renames[&(*var_id, *ssa_id)]; [INFO] [stderr] ... | [INFO] [stderr] 198 | | _ => {}, [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 190 | if let Operand::SSAVariable(_, ref mut var_id, ref mut ssa_id) = *val { [INFO] [stderr] 191 | if renames.contains_key(&(*var_id, *ssa_id)) { [INFO] [stderr] 192 | let (new_var_id, new_ssa_id) = renames[&(*var_id, *ssa_id)]; [INFO] [stderr] 193 | *var_id = new_var_id; [INFO] [stderr] 194 | *ssa_id = new_ssa_id; [INFO] [stderr] 195 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | / match *val2 { [INFO] [stderr] 202 | | Operand::SSAVariable(_, ref mut var_id, ref mut ssa_id) => { [INFO] [stderr] 203 | | if renames.contains_key(&(*var_id, *ssa_id)) { [INFO] [stderr] 204 | | let (new_var_id, new_ssa_id) = renames[&(*var_id, *ssa_id)]; [INFO] [stderr] ... | [INFO] [stderr] 209 | | _ => {}, [INFO] [stderr] 210 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | if let Operand::SSAVariable(_, ref mut var_id, ref mut ssa_id) = *val2 { [INFO] [stderr] 202 | if renames.contains_key(&(*var_id, *ssa_id)) { [INFO] [stderr] 203 | let (new_var_id, new_ssa_id) = renames[&(*var_id, *ssa_id)]; [INFO] [stderr] 204 | *var_id = new_var_id; [INFO] [stderr] 205 | *ssa_id = new_ssa_id; [INFO] [stderr] 206 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | / match *s { [INFO] [stderr] 259 | | Statement::Label(ref label_id) => { labels.insert(*label_id); }, [INFO] [stderr] 260 | | _ => {}, [INFO] [stderr] 261 | | } [INFO] [stderr] | |_________^ help: try this: `if let Statement::Label(ref label_id) = *s { labels.insert(*label_id); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | / match *s { [INFO] [stderr] 267 | | Statement::Jump(ref label_id) => { [INFO] [stderr] 268 | | if !labels.contains(label_id) { [INFO] [stderr] 269 | | remove_list.push(i); [INFO] [stderr] ... | [INFO] [stderr] 272 | | _ => {}, [INFO] [stderr] 273 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 266 | if let Statement::Jump(ref label_id) = *s { [INFO] [stderr] 267 | if !labels.contains(label_id) { [INFO] [stderr] 268 | remove_list.push(i); [INFO] [stderr] 269 | } [INFO] [stderr] 270 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | / match function.statements[i] { [INFO] [stderr] 292 | | Statement::Label(label_id) => { [INFO] [stderr] 293 | | if let Statement::Jump(jump_id) = function.statements[i-1] { [INFO] [stderr] 294 | | if jump_id == label_id { [INFO] [stderr] ... | [INFO] [stderr] 300 | | _ => {}, [INFO] [stderr] 301 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 291 | if let Statement::Label(label_id) = function.statements[i] { [INFO] [stderr] 292 | if let Statement::Jump(jump_id) = function.statements[i-1] { [INFO] [stderr] 293 | if jump_id == label_id { [INFO] [stderr] 294 | i -= 1; [INFO] [stderr] 295 | cfg.remove_statements(function, vec![i]); [INFO] [stderr] 296 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_store.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | / match *val { [INFO] [stderr] 49 | | Operand::SSAVariable(_, ref var_id, ref ssa_id) => { [INFO] [stderr] 50 | | reads.insert((*var_id, *ssa_id)); [INFO] [stderr] 51 | | }, [INFO] [stderr] 52 | | _ => {}, [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | if let Operand::SSAVariable(_, ref var_id, ref ssa_id) = *val { [INFO] [stderr] 49 | reads.insert((*var_id, *ssa_id)); [INFO] [stderr] 50 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_store.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | / match *val2 { [INFO] [stderr] 56 | | Operand::SSAVariable(_, ref var_id, ref ssa_id) => { [INFO] [stderr] 57 | | reads.insert((*var_id, *ssa_id)); [INFO] [stderr] 58 | | }, [INFO] [stderr] 59 | | _ => {}, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | if let Operand::SSAVariable(_, ref var_id, ref ssa_id) = *val2 { [INFO] [stderr] 56 | reads.insert((*var_id, *ssa_id)); [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/optimizer/dead_store.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | if remove_list.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!remove_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/optimizer/merge_block.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | cfg.basic_blocks.get_mut(parent).unwrap().end += instructions.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cfg.basic_blocks[parent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in instructions.enumerate()` or similar iterators [INFO] [stderr] --> src/optimizer/merge_block.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | for inst in instructions { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/optimizer/merge_block.rs:170:26 [INFO] [stderr] | [INFO] [stderr] 170 | let append_jump = if child_instructions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `child_instructions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/optimizer/merge_block.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | let succ = cfg.basic_blocks.get_mut(successor).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cfg.basic_blocks[successor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/optimizer/merge_block.rs:223:27 [INFO] [stderr] | [INFO] [stderr] 223 | let blk = cfg.basic_blocks.get_mut(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cfg.basic_blocks[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match function.statements[bb.start] { [INFO] [stderr] 21 | | Statement::Label(ref label_id) => {label_to_block.insert(*label_id, bb_id); }, [INFO] [stderr] 22 | | _ => {}, [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ help: try this: `if let Statement::Label(ref label_id) = function.statements[bb.start] {label_to_block.insert(*label_id, bb_id); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match function.statements[bb.end-1] { [INFO] [stderr] 28 | | Statement::JumpIfTrue(Operand::Boolean(val), label_id) => { [INFO] [stderr] 29 | | if val { [INFO] [stderr] 30 | | function.statements[bb.end-1] = Statement::Jump(label_id); [INFO] [stderr] ... | [INFO] [stderr] 42 | | _ => {}, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Statement::JumpIfTrue(Operand::Boolean(val), label_id) = function.statements[bb.end-1] { [INFO] [stderr] 28 | if val { [INFO] [stderr] 29 | function.statements[bb.end-1] = Statement::Jump(label_id); [INFO] [stderr] 30 | // remove the next block from adjacency_list, as this is [INFO] [stderr] 31 | // no longer connected to this block [INFO] [stderr] 32 | cfg.adjacency_list[bb_id].retain(|v| *v != Adj::Block(bb_id + 1)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | / match function.statements[s] { [INFO] [stderr] 63 | | Statement::PhiFunction( [INFO] [stderr] 64 | | Operand::SSAVariable(_, id, _), [INFO] [stderr] 65 | | ref mut operands) => { [INFO] [stderr] ... | [INFO] [stderr] 74 | | [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Statement::PhiFunction( [INFO] [stderr] 63 | Operand::SSAVariable(_, id, _), [INFO] [stderr] 64 | ref mut operands) = function.statements[s] { [INFO] [stderr] 65 | remove_non_reaching_defs_from_phi( [INFO] [stderr] 66 | operands, [INFO] [stderr] 67 | &reaching_defs, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | immediate_dominators: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RSP` [INFO] [stderr] --> src/code_generator/x64.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | RSP, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:152:27 [INFO] [stderr] | [INFO] [stderr] 152 | immediate_dominators: &Vec>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | reaching_defs: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[HashMap]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:175:14 [INFO] [stderr] | [INFO] [stderr] 175 | parents: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `string_table::StringTable` [INFO] [stderr] --> src/string_table/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> StringTable { [INFO] [stderr] 15 | | StringTable { [INFO] [stderr] 16 | | strings: vec![], [INFO] [stderr] 17 | | str_indices: HashMap::new(), [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/optimizer/mod.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | function_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 15 | pub fn optimize( [INFO] [stderr] 16 | functions: &mut Vec, [INFO] [stderr] 17 | function_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/byte_generator/mod.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / if self.variable_id_to_register.contains_key(&variable) { [INFO] [stderr] 230 | | let reg = self.variable_id_to_register[&variable]; [INFO] [stderr] 231 | | Source::Register(reg) [INFO] [stderr] 232 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 236 | | Source::Register(reg) [INFO] [stderr] 237 | | } [INFO] [stderr] | |_________^ help: consider using: `self.variable_id_to_register.entry(variable)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/code_generator/x64.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | fn encoding(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/code_generator/x64.rs:153:24 [INFO] [stderr] | [INFO] [stderr] 153 | fn is_extended_reg(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/code_generator/x64.rs:259:44 [INFO] [stderr] | [INFO] [stderr] 259 | fn get_used_registers(&mut self, code: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[ByteCode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:266:52 [INFO] [stderr] | [INFO] [stderr] 266 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:270:52 [INFO] [stderr] | [INFO] [stderr] 270 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:278:52 [INFO] [stderr] | [INFO] [stderr] 278 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:282:52 [INFO] [stderr] | [INFO] [stderr] 282 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:286:52 [INFO] [stderr] | [INFO] [stderr] 286 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:291:52 [INFO] [stderr] | [INFO] [stderr] 291 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:295:52 [INFO] [stderr] | [INFO] [stderr] 295 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/code_generator/x64.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / fn transform_code(&mut self) { [INFO] [stderr] 306 | | [INFO] [stderr] 307 | | for f in self.bytecode_functions.iter_mut() { [INFO] [stderr] 308 | | let mut free_register = 0; [INFO] [stderr] ... | [INFO] [stderr] 592 | | [INFO] [stderr] 593 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `new_operands.src1` and `new_operands.src2` manually [INFO] [stderr] --> src/code_generator/x64.rs:490:37 [INFO] [stderr] | [INFO] [stderr] 490 | / let tmp = new_operands.src1; [INFO] [stderr] 491 | | new_operands.src1 = new_operands.src2; [INFO] [stderr] 492 | | new_operands.src2 = tmp; [INFO] [stderr] | |___________________________________________________________^ help: try: `std::mem::swap(&mut new_operands.src1, &mut new_operands.src2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:680:9 [INFO] [stderr] | [INFO] [stderr] 680 | / match operand.src1 { [INFO] [stderr] 681 | | Source::IntegerConstant(_) => { [INFO] [stderr] 682 | | ice!("Immediate operand as first argument to add: {:?}", operand); [INFO] [stderr] 683 | | }, [INFO] [stderr] 684 | | _ => {}, [INFO] [stderr] 685 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 680 | if let Source::IntegerConstant(_) = operand.src1 { [INFO] [stderr] 681 | ice!("Immediate operand as first argument to add: {:?}", operand); [INFO] [stderr] 682 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:687:9 [INFO] [stderr] | [INFO] [stderr] 687 | / match operand.src2 { [INFO] [stderr] 688 | | Source::IntegerConstant(val) => { [INFO] [stderr] 689 | | self.emit_const_integer_add(dest, val); [INFO] [stderr] 690 | | return; [INFO] [stderr] 691 | | }, [INFO] [stderr] 692 | | _ => {}, [INFO] [stderr] 693 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 687 | if let Source::IntegerConstant(val) = operand.src2 { [INFO] [stderr] 688 | self.emit_const_integer_add(dest, val); [INFO] [stderr] 689 | return; [INFO] [stderr] 690 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:757:9 [INFO] [stderr] | [INFO] [stderr] 757 | / match operand.src1 { [INFO] [stderr] 758 | | Source::IntegerConstant(_) => { [INFO] [stderr] 759 | | panic!("Internal compiler error: Immediate operand as first argument to sub: {:?}", operand); [INFO] [stderr] 760 | | }, [INFO] [stderr] 761 | | _ => {}, [INFO] [stderr] 762 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 757 | if let Source::IntegerConstant(_) = operand.src1 { [INFO] [stderr] 758 | panic!("Internal compiler error: Immediate operand as first argument to sub: {:?}", operand); [INFO] [stderr] 759 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:764:9 [INFO] [stderr] | [INFO] [stderr] 764 | / match operand.src2 { [INFO] [stderr] 765 | | Source::IntegerConstant(val) => { [INFO] [stderr] 766 | | // not tested so let's not invoke it yet [INFO] [stderr] 767 | | self.emit_const_integer_sub(dest, val); return; }, [INFO] [stderr] 768 | | _ => {}, [INFO] [stderr] 769 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 764 | if let Source::IntegerConstant(val) = operand.src2 { [INFO] [stderr] 765 | // not tested so let's not invoke it yet [INFO] [stderr] 766 | self.emit_const_integer_sub(dest, val); return; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/mod.rs:204:21 [INFO] [stderr] | [INFO] [stderr] 204 | format!("Variable declaration must be followed by initialization")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Variable declaration must be followed by initialization".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:833:9 [INFO] [stderr] | [INFO] [stderr] 833 | / match operand.src1 { [INFO] [stderr] 834 | | Source::IntegerConstant(val) => { [INFO] [stderr] 835 | | self.emit_const_integer_mult( [INFO] [stderr] 836 | | dest_reg_id, [INFO] [stderr] ... | [INFO] [stderr] 841 | | _ => {}, [INFO] [stderr] 842 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 833 | if let Source::IntegerConstant(val) = operand.src1 { [INFO] [stderr] 834 | self.emit_const_integer_mult( [INFO] [stderr] 835 | dest_reg_id, [INFO] [stderr] 836 | &operand.src2, [INFO] [stderr] 837 | val); [INFO] [stderr] 838 | return; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:844:9 [INFO] [stderr] | [INFO] [stderr] 844 | / match operand.src2 { [INFO] [stderr] 845 | | Source::IntegerConstant(val) => { [INFO] [stderr] 846 | | self.emit_const_integer_mult( [INFO] [stderr] 847 | | dest_reg_id, [INFO] [stderr] ... | [INFO] [stderr] 851 | | _ => {}, [INFO] [stderr] 852 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 844 | if let Source::IntegerConstant(val) = operand.src2 { [INFO] [stderr] 845 | self.emit_const_integer_mult( [INFO] [stderr] 846 | dest_reg_id, [INFO] [stderr] 847 | &operand.src1, [INFO] [stderr] 848 | val); [INFO] [stderr] 849 | return; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:855:9 [INFO] [stderr] | [INFO] [stderr] 855 | / match (&operand.dest, &operand.src1, &operand.src2) { [INFO] [stderr] 856 | | ( [INFO] [stderr] 857 | | &Source::Register(dest), [INFO] [stderr] 858 | | &Source::Register(src1), [INFO] [stderr] ... | [INFO] [stderr] 876 | | _ => {}, [INFO] [stderr] 877 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 855 | if let ( [INFO] [stderr] 856 | &Source::Register(dest), [INFO] [stderr] 857 | &Source::Register(src1), [INFO] [stderr] 858 | &Source::Register(src2) [INFO] [stderr] 859 | ) = (&operand.dest, &operand.src1, &operand.src2) { [INFO] [stderr] 860 | if src1 != dest { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buffer`. [INFO] [stderr] --> src/code_generator/x64.rs:1046:22 [INFO] [stderr] | [INFO] [stderr] 1046 | for i in 0..constant_size { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1046 | for in buffer.iter().take(constant_size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buffer` [INFO] [stderr] --> src/code_generator/x64.rs:1175:34 [INFO] [stderr] | [INFO] [stderr] 1175 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1175 | for (i, ) in buffer.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:215:22 [INFO] [stderr] | [INFO] [stderr] 215 | version: EV_CURRENT as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(EV_CURRENT)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:238:32 [INFO] [stderr] | [INFO] [stderr] 238 | ElfSize::Elf64(self.header_size as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:240:32 [INFO] [stderr] | [INFO] [stderr] 240 | ElfSize::Elf32(self.header_size as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:245:30 [INFO] [stderr] | [INFO] [stderr] 245 | let mut offset = self.header_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:246:23 [INFO] [stderr] | [INFO] [stderr] 246 | offset += (self.program_header_entry_size*self.program_header_entry_count) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.program_header_entry_size*self.program_header_entry_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:249:30 [INFO] [stderr] | [INFO] [stderr] 249 | let mut offset = self.header_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:250:23 [INFO] [stderr] | [INFO] [stderr] 250 | offset += (self.program_header_entry_size*self.program_header_entry_count) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.program_header_entry_size*self.program_header_entry_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | file.write(self.magic_number.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | / file.write(&[ [INFO] [stderr] 258 | | self.format, [INFO] [stderr] 259 | | self.endianess, [INFO] [stderr] 260 | | self.ident_version, [INFO] [stderr] ... | [INFO] [stderr] 269 | | PADDING_BYTE [INFO] [stderr] 270 | | ])?; [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser/mod.rs:645:17 [INFO] [stderr] | [INFO] [stderr] 645 | for ref token_type in types.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^ ------------ help: try: `let token_type = &types.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | file.write(str.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | file.write("\0".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | file.write(self.code.as_slice())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | file.write(&[self.info, self.other])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/mod.rs:696:57 [INFO] [stderr] | [INFO] [stderr] 696 | fn report_unexpected_token_mul(&mut self, expected: &Vec, actual: &Token) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[TokenType]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer/mod.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / loop { [INFO] [stderr] 69 | | match self.next_char() { [INFO] [stderr] 70 | | Some(ch) => if ch == '\n' { break }, [INFO] [stderr] 71 | | None => break, [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(ch) = self.next_char() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:585:49 [INFO] [stderr] | [INFO] [stderr] 585 | Architecture::X64 => ElfSize::Elf64((SHF_ALLOC | SHF_EXECINSTR) as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_ALLOC | SHF_EXECINSTR)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:615:25 [INFO] [stderr] | [INFO] [stderr] 615 | (self.elf_header.section_header_entry_size*self.elf_header.section_header_entry_count) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.elf_header.section_header_entry_size*self.elf_header.section_header_entry_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:672:5 [INFO] [stderr] | [INFO] [stderr] 672 | file.write(&buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:682:5 [INFO] [stderr] | [INFO] [stderr] 682 | file.write(&buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:693:5 [INFO] [stderr] | [INFO] [stderr] 693 | file.write(&buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lexer/mod.rs:292:24 [INFO] [stderr] | [INFO] [stderr] 292 | if separator_error == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!separator_error` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lexer/mod.rs:491:21 [INFO] [stderr] | [INFO] [stderr] 491 | match *(res.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 491 | match *&(*res).clone() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 491 | match *&std::result::Result::clone(res) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/error_reporter/mod.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | write_stderr(format!("{}", line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `line.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/error_reporter/mod.rs:114:32 [INFO] [stderr] | [INFO] [stderr] 114 | if !line.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/semcheck/mod.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | for ref mut child in children { [INFO] [stderr] | ^^^^^^^^^^^^^ -------- help: try: `let child = &mut children;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `compiler`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/semcheck/mod.rs:440:15 [INFO] [stderr] | [INFO] [stderr] 440 | name: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> src/semcheck/mod.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | arith_info.node_type == Type::Invalid; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/semcheck/mod.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | arith_info.node_type == Type::Invalid; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/semcheck/mod.rs:752:57 [INFO] [stderr] | [INFO] [stderr] 752 | fn check_identifier_is_initialized(&mut self, name: &String, info: &NodeInfo) -> [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `symbol_table::TableEntry` [INFO] [stderr] --> src/symbol_table/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> TableEntry { [INFO] [stderr] 19 | | TableEntry { [INFO] [stderr] 20 | | symbols: vec![], [INFO] [stderr] 21 | | } [INFO] [stderr] 22 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table/mod.rs:28:37 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn find_symbol(&self, name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/symbol_table/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | / if let &Symbol::Function(ref info) = s { [INFO] [stderr] 49 | | return Some(info.clone()) [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | if let Symbol::Function(ref info) = *s { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `symbol_table::SymbolTable` [INFO] [stderr] --> src/symbol_table/mod.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / pub fn new() -> SymbolTable { [INFO] [stderr] 62 | | SymbolTable { [INFO] [stderr] 63 | | entries: vec![], [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/symbol_table/mod.rs:80:17 [INFO] [stderr] | [INFO] [stderr] 80 | assert!(self.entries.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.entries.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/symbol_table/mod.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn find_symbol(&self, name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / match *statement { [INFO] [stderr] 38 | | Statement::Label(id) => { [INFO] [stderr] 39 | | label_id_pos.insert(id, i); [INFO] [stderr] 40 | | }, [INFO] [stderr] 41 | | _ => {}, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Statement::Label(id) = *statement { [INFO] [stderr] 38 | label_id_pos.insert(id, i); [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / match *statement { [INFO] [stderr] 49 | | Statement::Jump(ref mut id) => { [INFO] [stderr] 50 | | let mut changes = true; [INFO] [stderr] 51 | | while changes { [INFO] [stderr] ... | [INFO] [stderr] 65 | | _ => {}, [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | if let Statement::Jump(ref mut id) = *statement { [INFO] [stderr] 49 | let mut changes = true; [INFO] [stderr] 50 | while changes { [INFO] [stderr] 51 | changes = false; [INFO] [stderr] 52 | let idx = label_id_pos[&*id] + 1; [INFO] [stderr] 53 | if idx < cloned.len() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | / match cloned[idx] { [INFO] [stderr] 56 | | Statement::Jump(other_id) => { [INFO] [stderr] 57 | | *id = other_id; [INFO] [stderr] 58 | | changes = true; [INFO] [stderr] 59 | | }, [INFO] [stderr] 60 | | _ => {}, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | if let Statement::Jump(other_id) = cloned[idx] { [INFO] [stderr] 56 | *id = other_id; [INFO] [stderr] 57 | changes = true; [INFO] [stderr] 58 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | / match function.statements[i].clone() { [INFO] [stderr] 92 | | Statement::Assignment( [INFO] [stderr] 93 | | None, [INFO] [stderr] 94 | | Some(Operand::Variable(ref var_info, ref var_id)), [INFO] [stderr] ... | [INFO] [stderr] 126 | | _ => {}, [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 91 | if let Statement::Assignment( [INFO] [stderr] 92 | None, [INFO] [stderr] 93 | Some(Operand::Variable(ref var_info, ref var_id)), [INFO] [stderr] 94 | None, [INFO] [stderr] 95 | Some(Operand::Variable(ref tmp_info, ref tmp_id))) = function.statements[i].clone() { [INFO] [stderr] 96 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | / match function.statements[i-1] { [INFO] [stderr] 109 | | Statement::Assignment( [INFO] [stderr] 110 | | _, [INFO] [stderr] 111 | | Some(Operand::Variable(ref mut prev_info, ref mut prev_id)), [INFO] [stderr] ... | [INFO] [stderr] 123 | | _ => {} [INFO] [stderr] 124 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 108 | if let Statement::Assignment( [INFO] [stderr] 109 | _, [INFO] [stderr] 110 | Some(Operand::Variable(ref mut prev_info, ref mut prev_id)), [INFO] [stderr] 111 | _, [INFO] [stderr] 112 | _) = function.statements[i-1] { [INFO] [stderr] 113 | // if this is the same temporary than in the previous, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `remove_list`. [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | for j in i..remove_list.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 134 | for in remove_list.iter_mut().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tac_generator/peephole_optimizations.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / match function.statements[i] { [INFO] [stderr] 151 | | Statement::Label(cur_label) => { [INFO] [stderr] 152 | | if let Statement::Label(prev_label) = function.statements[i-1] { [INFO] [stderr] 153 | | i -= 1; [INFO] [stderr] ... | [INFO] [stderr] 157 | | _ => {}, [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 150 | if let Statement::Label(cur_label) = function.statements[i] { [INFO] [stderr] 151 | if let Statement::Label(prev_label) = function.statements[i-1] { [INFO] [stderr] 152 | i -= 1; [INFO] [stderr] 153 | merge_labels(function, i, cur_label, prev_label); [INFO] [stderr] 154 | } [INFO] [stderr] 155 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tac_generator/mod.rs:234:19 [INFO] [stderr] | [INFO] [stderr] 234 | children: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[AstNode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/tac_generator/mod.rs:245:13 [INFO] [stderr] | [INFO] [stderr] 245 | for ref child in children { [INFO] [stderr] | ^^^^^^^^^ -------- help: try: `let child = &children;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tac_generator/mod.rs:298:15 [INFO] [stderr] | [INFO] [stderr] 298 | args: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[AstNode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tac_generator/mod.rs:336:15 [INFO] [stderr] | [INFO] [stderr] 336 | name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tac_generator/mod.rs:343:15 [INFO] [stderr] | [INFO] [stderr] 343 | name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tac_generator/mod.rs:406:43 [INFO] [stderr] | [INFO] [stderr] 406 | fn handle_identifier(&mut self, name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tac_generator/mod.rs:489:16 [INFO] [stderr] | [INFO] [stderr] 489 | if let Some(_) = *opt_else_blk { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 490 | | self.current_function().statements.push( [INFO] [stderr] 491 | | Statement::Jump(else_blk_label)); [INFO] [stderr] 492 | | } [INFO] [stderr] | |_________- help: try this: `if *opt_else_blk.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tac_generator/mod.rs:532:44 [INFO] [stderr] | [INFO] [stderr] 532 | Operand::Initialized(ref t) => t.clone(), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tac_generator/mod.rs:566:46 [INFO] [stderr] | [INFO] [stderr] 566 | fn get_variable_info_and_id(&self, name: &String) -> (DeclarationInfo, u32) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/cfg/dom_front.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | func_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 9 | pub fn calculate_dominance_frontier( [INFO] [stderr] 10 | func_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cfg/dom_front.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | if parents.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `opt_idom` [INFO] [stderr] --> src/cfg/dom_front.rs:161:14 [INFO] [stderr] | [INFO] [stderr] 161 | for i in 0..opt_idom.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for (i, ) in opt_idom.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cfg/dom_front.rs:171:15 [INFO] [stderr] | [INFO] [stderr] 171 | opt_idom: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `remove_list`. [INFO] [stderr] --> src/cfg/mod.rs:117:22 [INFO] [stderr] | [INFO] [stderr] 117 | for j in (i+1)..remove_list.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 117 | for in remove_list.iter_mut().skip((i+1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cfg/mod.rs:195:32 [INFO] [stderr] | [INFO] [stderr] 195 | fn get_parents(adjacency_list: &Vec>, block: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg/mod.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | / match *b { [INFO] [stderr] 204 | | Adj::Block(id) => { [INFO] [stderr] 205 | | if id == block { [INFO] [stderr] 206 | | if !parents.contains(&i) { [INFO] [stderr] ... | [INFO] [stderr] 212 | | _ => {}, [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 203 | if let Adj::Block(id) = *b { [INFO] [stderr] 204 | if id == block { [INFO] [stderr] 205 | if !parents.contains(&i) { [INFO] [stderr] 206 | parents.push(i); [INFO] [stderr] 207 | continue; [INFO] [stderr] 208 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cfg/mod.rs:240:34 [INFO] [stderr] | [INFO] [stderr] 240 | fn create_adj_list(basic_blocks: &Vec, f: &Function) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[BasicBlock]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cfg/mod.rs:346:21 [INFO] [stderr] | [INFO] [stderr] 346 | / match *adj { [INFO] [stderr] 347 | | Adj::Block(ref mut id) => { [INFO] [stderr] 348 | | if *id > bb_id { [INFO] [stderr] 349 | | *id -= 1; [INFO] [stderr] ... | [INFO] [stderr] 352 | | _ => {}, [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 346 | if let Adj::Block(ref mut id) = *adj { [INFO] [stderr] 347 | if *id > bb_id { [INFO] [stderr] 348 | *id -= 1; [INFO] [stderr] 349 | } [INFO] [stderr] 350 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/ssa_generator/mod.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | function_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 12 | pub fn convert_to_ssa( [INFO] [stderr] 13 | functions: &mut Vec, [INFO] [stderr] 14 | function_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ssa_generator/mod.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / match function.statements[insertion] { [INFO] [stderr] 94 | | Statement::Label(_) => insertion += 1, // insert after label [INFO] [stderr] 95 | | _ => {}, [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ help: try this: `if let Statement::Label(_) = function.statements[insertion] { insertion += 1 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ssa_generator/mod.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | basic_blocks: &Vec) -> (HashMap>, HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[BasicBlock]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/ssa_generator/mod.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | / if !decl_info.contains_key(&id) { [INFO] [stderr] 134 | | decl_info.insert(id, info.clone()); [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________________^ help: consider using: `decl_info.entry(id).or_insert(info.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/ssa_generator/mod.rs:136:21 [INFO] [stderr] | [INFO] [stderr] 136 | / if !definitions.contains_key(&id) { [INFO] [stderr] 137 | | definitions.insert(id, vec![]); [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________________^ help: consider using: `definitions.entry(id).or_insert(< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/ssa_generator/mod.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | / 'outer: for i in cfg.basic_blocks[block].start..cfg.basic_blocks[block].end { [INFO] [stderr] 221 | | match function.statements[i] { [INFO] [stderr] 222 | | Statement::PhiFunction(Operand::Variable(_, var_id), ref mut operands) | [INFO] [stderr] 223 | | Statement::PhiFunction(Operand::SSAVariable(_, var_id, _), ref mut operands) => { [INFO] [stderr] ... | [INFO] [stderr] 234 | | } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/ssa_generator/mod.rs:336:25 [INFO] [stderr] | [INFO] [stderr] 336 | function_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 334 | pub fn destroy_ssa( [INFO] [stderr] 335 | functions: &mut Vec, [INFO] [stderr] 336 | function_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / match s.clone() { [INFO] [stderr] 33 | | // integer assignment [INFO] [stderr] 34 | | Statement::Assignment( [INFO] [stderr] 35 | | Some(operator), [INFO] [stderr] ... | [INFO] [stderr] 56 | | _ => {}, [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Statement::Assignment( [INFO] [stderr] 33 | Some(operator), [INFO] [stderr] 34 | Some(var @ Operand::SSAVariable(_, _, _)), [INFO] [stderr] 35 | Some(Operand::Integer(val)) , [INFO] [stderr] 36 | Some(Operand::Integer(val2))) = s.clone() { [INFO] [stderr] 37 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / match *val1 { [INFO] [stderr] 89 | | Operand::SSAVariable(_, var_id, ssa_id) => { [INFO] [stderr] 90 | | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 91 | | [INFO] [stderr] ... | [INFO] [stderr] 98 | | _ => {}, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | if let Operand::SSAVariable(_, var_id, ssa_id) = *val1 { [INFO] [stderr] 89 | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 90 | [INFO] [stderr] 91 | if let Statement::Assignment(_, _, ref mut op, _) = *s { [INFO] [stderr] 92 | *op = Some(known_constants[&(var_id, ssa_id)].clone()); [INFO] [stderr] 93 | changes = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | / match *val2 { [INFO] [stderr] 102 | | Operand::SSAVariable(_, var_id, ssa_id) => { [INFO] [stderr] 103 | | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 104 | | if let Statement::Assignment(_, _, _, ref mut op) = *s { [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => {}, [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | if let Operand::SSAVariable(_, var_id, ssa_id) = *val2 { [INFO] [stderr] 102 | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 103 | if let Statement::Assignment(_, _, _, ref mut op) = *s { [INFO] [stderr] 104 | *op = Some(known_constants[&(var_id, ssa_id)].clone()); [INFO] [stderr] 105 | changes = true; [INFO] [stderr] 106 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | / match *val { [INFO] [stderr] 117 | | Operand::SSAVariable(_, var_id, ssa_id) => { [INFO] [stderr] 118 | | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 119 | | if let Statement::JumpIfTrue(ref mut op, _) = *s { [INFO] [stderr] ... | [INFO] [stderr] 125 | | _ => {}, [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 116 | if let Operand::SSAVariable(_, var_id, ssa_id) = *val { [INFO] [stderr] 117 | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 118 | if let Statement::JumpIfTrue(ref mut op, _) = *s { [INFO] [stderr] 119 | *op = known_constants[&(var_id, ssa_id)].clone(); [INFO] [stderr] 120 | return true; [INFO] [stderr] 121 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/const_prop.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | / match *val { [INFO] [stderr] 130 | | Operand::SSAVariable(_, var_id, ssa_id) => { [INFO] [stderr] 131 | | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 132 | | if let Statement::Return(ref mut op) = *s { [INFO] [stderr] ... | [INFO] [stderr] 138 | | _ => {}, [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | if let Operand::SSAVariable(_, var_id, ssa_id) = *val { [INFO] [stderr] 130 | if known_constants.contains_key(&(var_id, ssa_id)) { [INFO] [stderr] 131 | if let Statement::Return(ref mut op) = *s { [INFO] [stderr] 132 | *op = Some(known_constants[&(var_id, ssa_id)].clone()); [INFO] [stderr] 133 | return true; [INFO] [stderr] 134 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/optimizer/dead_code.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | function_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 17 | pub fn remove_dead_code( [INFO] [stderr] 18 | functions: &mut Vec, [INFO] [stderr] 19 | function_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / match *s { [INFO] [stderr] 86 | | Statement::PhiFunction( [INFO] [stderr] 87 | | _, [INFO] [stderr] 88 | | ref mut operands) => { [INFO] [stderr] ... | [INFO] [stderr] 97 | | _ => {}, [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let Statement::PhiFunction( [INFO] [stderr] 86 | _, [INFO] [stderr] 87 | ref mut operands) = *s { [INFO] [stderr] 88 | operands.retain(|v| { [INFO] [stderr] 89 | if let Operand::SSAVariable(_, ref var_id, ref ssa_id) = *v { [INFO] [stderr] 90 | !writes.contains(&(*var_id, *ssa_id)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `unconnected_blocks`. [INFO] [stderr] --> src/optimizer/dead_code.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | for j in i..unconnected_blocks.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in unconnected_blocks.iter_mut().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / match *s { [INFO] [stderr] 153 | | Statement::PhiFunction( [INFO] [stderr] 154 | | Operand::SSAVariable(_, dst_var_id, dst_ssa_id), [INFO] [stderr] 155 | | ref operands) => { [INFO] [stderr] ... | [INFO] [stderr] 176 | | _ => {}, [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | if let Statement::PhiFunction( [INFO] [stderr] 153 | Operand::SSAVariable(_, dst_var_id, dst_ssa_id), [INFO] [stderr] 154 | ref operands) = *s { [INFO] [stderr] 155 | if operands.len() == 1 { [INFO] [stderr] 156 | if let Operand::SSAVariable(_, src_var_id, src_ssa_id) = operands[0] { [INFO] [stderr] 157 | remove_list.push(i); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/optimizer/dead_code.rs:163:40 [INFO] [stderr] | [INFO] [stderr] 163 | let prev = renames[&(src_var_id, src_ssa_id)].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `renames[&(src_var_id, src_ssa_id)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | / match *val { [INFO] [stderr] 191 | | Operand::SSAVariable(_, ref mut var_id, ref mut ssa_id) => { [INFO] [stderr] 192 | | if renames.contains_key(&(*var_id, *ssa_id)) { [INFO] [stderr] 193 | | let (new_var_id, new_ssa_id) = renames[&(*var_id, *ssa_id)]; [INFO] [stderr] ... | [INFO] [stderr] 198 | | _ => {}, [INFO] [stderr] 199 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 190 | if let Operand::SSAVariable(_, ref mut var_id, ref mut ssa_id) = *val { [INFO] [stderr] 191 | if renames.contains_key(&(*var_id, *ssa_id)) { [INFO] [stderr] 192 | let (new_var_id, new_ssa_id) = renames[&(*var_id, *ssa_id)]; [INFO] [stderr] 193 | *var_id = new_var_id; [INFO] [stderr] 194 | *ssa_id = new_ssa_id; [INFO] [stderr] 195 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | / match *val2 { [INFO] [stderr] 202 | | Operand::SSAVariable(_, ref mut var_id, ref mut ssa_id) => { [INFO] [stderr] 203 | | if renames.contains_key(&(*var_id, *ssa_id)) { [INFO] [stderr] 204 | | let (new_var_id, new_ssa_id) = renames[&(*var_id, *ssa_id)]; [INFO] [stderr] ... | [INFO] [stderr] 209 | | _ => {}, [INFO] [stderr] 210 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 201 | if let Operand::SSAVariable(_, ref mut var_id, ref mut ssa_id) = *val2 { [INFO] [stderr] 202 | if renames.contains_key(&(*var_id, *ssa_id)) { [INFO] [stderr] 203 | let (new_var_id, new_ssa_id) = renames[&(*var_id, *ssa_id)]; [INFO] [stderr] 204 | *var_id = new_var_id; [INFO] [stderr] 205 | *ssa_id = new_ssa_id; [INFO] [stderr] 206 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | / match *s { [INFO] [stderr] 259 | | Statement::Label(ref label_id) => { labels.insert(*label_id); }, [INFO] [stderr] 260 | | _ => {}, [INFO] [stderr] 261 | | } [INFO] [stderr] | |_________^ help: try this: `if let Statement::Label(ref label_id) = *s { labels.insert(*label_id); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | / match *s { [INFO] [stderr] 267 | | Statement::Jump(ref label_id) => { [INFO] [stderr] 268 | | if !labels.contains(label_id) { [INFO] [stderr] 269 | | remove_list.push(i); [INFO] [stderr] ... | [INFO] [stderr] 272 | | _ => {}, [INFO] [stderr] 273 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 266 | if let Statement::Jump(ref label_id) = *s { [INFO] [stderr] 267 | if !labels.contains(label_id) { [INFO] [stderr] 268 | remove_list.push(i); [INFO] [stderr] 269 | } [INFO] [stderr] 270 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_code.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | / match function.statements[i] { [INFO] [stderr] 292 | | Statement::Label(label_id) => { [INFO] [stderr] 293 | | if let Statement::Jump(jump_id) = function.statements[i-1] { [INFO] [stderr] 294 | | if jump_id == label_id { [INFO] [stderr] ... | [INFO] [stderr] 300 | | _ => {}, [INFO] [stderr] 301 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 291 | if let Statement::Label(label_id) = function.statements[i] { [INFO] [stderr] 292 | if let Statement::Jump(jump_id) = function.statements[i-1] { [INFO] [stderr] 293 | if jump_id == label_id { [INFO] [stderr] 294 | i -= 1; [INFO] [stderr] 295 | cfg.remove_statements(function, vec![i]); [INFO] [stderr] 296 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_store.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | / match *val { [INFO] [stderr] 49 | | Operand::SSAVariable(_, ref var_id, ref ssa_id) => { [INFO] [stderr] 50 | | reads.insert((*var_id, *ssa_id)); [INFO] [stderr] 51 | | }, [INFO] [stderr] 52 | | _ => {}, [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | if let Operand::SSAVariable(_, ref var_id, ref ssa_id) = *val { [INFO] [stderr] 49 | reads.insert((*var_id, *ssa_id)); [INFO] [stderr] 50 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/dead_store.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | / match *val2 { [INFO] [stderr] 56 | | Operand::SSAVariable(_, ref var_id, ref ssa_id) => { [INFO] [stderr] 57 | | reads.insert((*var_id, *ssa_id)); [INFO] [stderr] 58 | | }, [INFO] [stderr] 59 | | _ => {}, [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | if let Operand::SSAVariable(_, ref var_id, ref ssa_id) = *val2 { [INFO] [stderr] 56 | reads.insert((*var_id, *ssa_id)); [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/optimizer/dead_store.rs:109:12 [INFO] [stderr] | [INFO] [stderr] 109 | if remove_list.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!remove_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/optimizer/merge_block.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | cfg.basic_blocks.get_mut(parent).unwrap().end += instructions.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cfg.basic_blocks[parent]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in instructions.enumerate()` or similar iterators [INFO] [stderr] --> src/optimizer/merge_block.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | for inst in instructions { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/optimizer/merge_block.rs:170:26 [INFO] [stderr] | [INFO] [stderr] 170 | let append_jump = if child_instructions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `child_instructions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/optimizer/merge_block.rs:217:28 [INFO] [stderr] | [INFO] [stderr] 217 | let succ = cfg.basic_blocks.get_mut(successor).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cfg.basic_blocks[successor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/optimizer/merge_block.rs:223:27 [INFO] [stderr] | [INFO] [stderr] 223 | let blk = cfg.basic_blocks.get_mut(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `cfg.basic_blocks[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / match function.statements[bb.start] { [INFO] [stderr] 21 | | Statement::Label(ref label_id) => {label_to_block.insert(*label_id, bb_id); }, [INFO] [stderr] 22 | | _ => {}, [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ help: try this: `if let Statement::Label(ref label_id) = function.statements[bb.start] {label_to_block.insert(*label_id, bb_id); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match function.statements[bb.end-1] { [INFO] [stderr] 28 | | Statement::JumpIfTrue(Operand::Boolean(val), label_id) => { [INFO] [stderr] 29 | | if val { [INFO] [stderr] 30 | | function.statements[bb.end-1] = Statement::Jump(label_id); [INFO] [stderr] ... | [INFO] [stderr] 42 | | _ => {}, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Statement::JumpIfTrue(Operand::Boolean(val), label_id) = function.statements[bb.end-1] { [INFO] [stderr] 28 | if val { [INFO] [stderr] 29 | function.statements[bb.end-1] = Statement::Jump(label_id); [INFO] [stderr] 30 | // remove the next block from adjacency_list, as this is [INFO] [stderr] 31 | // no longer connected to this block [INFO] [stderr] 32 | cfg.adjacency_list[bb_id].retain(|v| *v != Adj::Block(bb_id + 1)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | / match function.statements[s] { [INFO] [stderr] 63 | | Statement::PhiFunction( [INFO] [stderr] 64 | | Operand::SSAVariable(_, id, _), [INFO] [stderr] 65 | | ref mut operands) => { [INFO] [stderr] ... | [INFO] [stderr] 74 | | [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Statement::PhiFunction( [INFO] [stderr] 63 | Operand::SSAVariable(_, id, _), [INFO] [stderr] 64 | ref mut operands) = function.statements[s] { [INFO] [stderr] 65 | remove_non_reaching_defs_from_phi( [INFO] [stderr] 66 | operands, [INFO] [stderr] 67 | &reaching_defs, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:101:27 [INFO] [stderr] | [INFO] [stderr] 101 | immediate_dominators: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:152:27 [INFO] [stderr] | [INFO] [stderr] 152 | immediate_dominators: &Vec>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Option]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | reaching_defs: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[HashMap]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/optimizer/conditional_jump_conversion.rs:175:14 [INFO] [stderr] | [INFO] [stderr] 175 | parents: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/optimizer/mod.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | function_cfgs: &mut HashMap, CFG>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 15 | pub fn optimize( [INFO] [stderr] 16 | functions: &mut Vec, [INFO] [stderr] 17 | function_cfgs: &mut HashMap, CFG, S>) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/byte_generator/mod.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / if self.variable_id_to_register.contains_key(&variable) { [INFO] [stderr] 230 | | let reg = self.variable_id_to_register[&variable]; [INFO] [stderr] 231 | | Source::Register(reg) [INFO] [stderr] 232 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 236 | | Source::Register(reg) [INFO] [stderr] 237 | | } [INFO] [stderr] | |_________^ help: consider using: `self.variable_id_to_register.entry(variable)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/code_generator/x64.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | fn encoding(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/code_generator/x64.rs:153:24 [INFO] [stderr] | [INFO] [stderr] 153 | fn is_extended_reg(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/code_generator/x64.rs:259:44 [INFO] [stderr] | [INFO] [stderr] 259 | fn get_used_registers(&mut self, code: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[ByteCode]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:266:52 [INFO] [stderr] | [INFO] [stderr] 266 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:270:52 [INFO] [stderr] | [INFO] [stderr] 270 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:278:52 [INFO] [stderr] | [INFO] [stderr] 278 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:282:52 [INFO] [stderr] | [INFO] [stderr] 282 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:286:52 [INFO] [stderr] | [INFO] [stderr] 286 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:291:52 [INFO] [stderr] | [INFO] [stderr] 291 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/code_generator/x64.rs:295:52 [INFO] [stderr] | [INFO] [stderr] 295 | self.used_registers.insert(self.reg_map[®].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.reg_map[®]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/code_generator/x64.rs:305:5 [INFO] [stderr] | [INFO] [stderr] 305 | / fn transform_code(&mut self) { [INFO] [stderr] 306 | | [INFO] [stderr] 307 | | for f in self.bytecode_functions.iter_mut() { [INFO] [stderr] 308 | | let mut free_register = 0; [INFO] [stderr] ... | [INFO] [stderr] 592 | | [INFO] [stderr] 593 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `new_operands.src1` and `new_operands.src2` manually [INFO] [stderr] --> src/code_generator/x64.rs:490:37 [INFO] [stderr] | [INFO] [stderr] 490 | / let tmp = new_operands.src1; [INFO] [stderr] 491 | | new_operands.src1 = new_operands.src2; [INFO] [stderr] 492 | | new_operands.src2 = tmp; [INFO] [stderr] | |___________________________________________________________^ help: try: `std::mem::swap(&mut new_operands.src1, &mut new_operands.src2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:680:9 [INFO] [stderr] | [INFO] [stderr] 680 | / match operand.src1 { [INFO] [stderr] 681 | | Source::IntegerConstant(_) => { [INFO] [stderr] 682 | | ice!("Immediate operand as first argument to add: {:?}", operand); [INFO] [stderr] 683 | | }, [INFO] [stderr] 684 | | _ => {}, [INFO] [stderr] 685 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 680 | if let Source::IntegerConstant(_) = operand.src1 { [INFO] [stderr] 681 | ice!("Immediate operand as first argument to add: {:?}", operand); [INFO] [stderr] 682 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:687:9 [INFO] [stderr] | [INFO] [stderr] 687 | / match operand.src2 { [INFO] [stderr] 688 | | Source::IntegerConstant(val) => { [INFO] [stderr] 689 | | self.emit_const_integer_add(dest, val); [INFO] [stderr] 690 | | return; [INFO] [stderr] 691 | | }, [INFO] [stderr] 692 | | _ => {}, [INFO] [stderr] 693 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 687 | if let Source::IntegerConstant(val) = operand.src2 { [INFO] [stderr] 688 | self.emit_const_integer_add(dest, val); [INFO] [stderr] 689 | return; [INFO] [stderr] 690 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:757:9 [INFO] [stderr] | [INFO] [stderr] 757 | / match operand.src1 { [INFO] [stderr] 758 | | Source::IntegerConstant(_) => { [INFO] [stderr] 759 | | panic!("Internal compiler error: Immediate operand as first argument to sub: {:?}", operand); [INFO] [stderr] 760 | | }, [INFO] [stderr] 761 | | _ => {}, [INFO] [stderr] 762 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 757 | if let Source::IntegerConstant(_) = operand.src1 { [INFO] [stderr] 758 | panic!("Internal compiler error: Immediate operand as first argument to sub: {:?}", operand); [INFO] [stderr] 759 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:764:9 [INFO] [stderr] | [INFO] [stderr] 764 | / match operand.src2 { [INFO] [stderr] 765 | | Source::IntegerConstant(val) => { [INFO] [stderr] 766 | | // not tested so let's not invoke it yet [INFO] [stderr] 767 | | self.emit_const_integer_sub(dest, val); return; }, [INFO] [stderr] 768 | | _ => {}, [INFO] [stderr] 769 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 764 | if let Source::IntegerConstant(val) = operand.src2 { [INFO] [stderr] 765 | // not tested so let's not invoke it yet [INFO] [stderr] 766 | self.emit_const_integer_sub(dest, val); return; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:833:9 [INFO] [stderr] | [INFO] [stderr] 833 | / match operand.src1 { [INFO] [stderr] 834 | | Source::IntegerConstant(val) => { [INFO] [stderr] 835 | | self.emit_const_integer_mult( [INFO] [stderr] 836 | | dest_reg_id, [INFO] [stderr] ... | [INFO] [stderr] 841 | | _ => {}, [INFO] [stderr] 842 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 833 | if let Source::IntegerConstant(val) = operand.src1 { [INFO] [stderr] 834 | self.emit_const_integer_mult( [INFO] [stderr] 835 | dest_reg_id, [INFO] [stderr] 836 | &operand.src2, [INFO] [stderr] 837 | val); [INFO] [stderr] 838 | return; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:844:9 [INFO] [stderr] | [INFO] [stderr] 844 | / match operand.src2 { [INFO] [stderr] 845 | | Source::IntegerConstant(val) => { [INFO] [stderr] 846 | | self.emit_const_integer_mult( [INFO] [stderr] 847 | | dest_reg_id, [INFO] [stderr] ... | [INFO] [stderr] 851 | | _ => {}, [INFO] [stderr] 852 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 844 | if let Source::IntegerConstant(val) = operand.src2 { [INFO] [stderr] 845 | self.emit_const_integer_mult( [INFO] [stderr] 846 | dest_reg_id, [INFO] [stderr] 847 | &operand.src1, [INFO] [stderr] 848 | val); [INFO] [stderr] 849 | return; } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/code_generator/x64.rs:855:9 [INFO] [stderr] | [INFO] [stderr] 855 | / match (&operand.dest, &operand.src1, &operand.src2) { [INFO] [stderr] 856 | | ( [INFO] [stderr] 857 | | &Source::Register(dest), [INFO] [stderr] 858 | | &Source::Register(src1), [INFO] [stderr] ... | [INFO] [stderr] 876 | | _ => {}, [INFO] [stderr] 877 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 855 | if let ( [INFO] [stderr] 856 | &Source::Register(dest), [INFO] [stderr] 857 | &Source::Register(src1), [INFO] [stderr] 858 | &Source::Register(src2) [INFO] [stderr] 859 | ) = (&operand.dest, &operand.src1, &operand.src2) { [INFO] [stderr] 860 | if src1 != dest { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buffer`. [INFO] [stderr] --> src/code_generator/x64.rs:1046:22 [INFO] [stderr] | [INFO] [stderr] 1046 | for i in 0..constant_size { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1046 | for in buffer.iter().take(constant_size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buffer` [INFO] [stderr] --> src/code_generator/x64.rs:1175:34 [INFO] [stderr] | [INFO] [stderr] 1175 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1175 | for (i, ) in buffer.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:215:22 [INFO] [stderr] | [INFO] [stderr] 215 | version: EV_CURRENT as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(EV_CURRENT)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:238:32 [INFO] [stderr] | [INFO] [stderr] 238 | ElfSize::Elf64(self.header_size as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:240:32 [INFO] [stderr] | [INFO] [stderr] 240 | ElfSize::Elf32(self.header_size as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:245:30 [INFO] [stderr] | [INFO] [stderr] 245 | let mut offset = self.header_size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:246:23 [INFO] [stderr] | [INFO] [stderr] 246 | offset += (self.program_header_entry_size*self.program_header_entry_count) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.program_header_entry_size*self.program_header_entry_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:249:30 [INFO] [stderr] | [INFO] [stderr] 249 | let mut offset = self.header_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.header_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:250:23 [INFO] [stderr] | [INFO] [stderr] 250 | offset += (self.program_header_entry_size*self.program_header_entry_count) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.program_header_entry_size*self.program_header_entry_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | file.write(self.magic_number.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | / file.write(&[ [INFO] [stderr] 258 | | self.format, [INFO] [stderr] 259 | | self.endianess, [INFO] [stderr] 260 | | self.ident_version, [INFO] [stderr] ... | [INFO] [stderr] 269 | | PADDING_BYTE [INFO] [stderr] 270 | | ])?; [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | file.write(str.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:331:13 [INFO] [stderr] | [INFO] [stderr] 331 | file.write("\0".as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | file.write(self.code.as_slice())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | file.write(&[self.info, self.other])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:585:49 [INFO] [stderr] | [INFO] [stderr] 585 | Architecture::X64 => ElfSize::Elf64((SHF_ALLOC | SHF_EXECINSTR) as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(SHF_ALLOC | SHF_EXECINSTR)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/obj_generator/elf_obj.rs:615:25 [INFO] [stderr] | [INFO] [stderr] 615 | (self.elf_header.section_header_entry_size*self.elf_header.section_header_entry_count) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.elf_header.section_header_entry_size*self.elf_header.section_header_entry_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:672:5 [INFO] [stderr] | [INFO] [stderr] 672 | file.write(&buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:682:5 [INFO] [stderr] | [INFO] [stderr] 682 | file.write(&buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/obj_generator/elf_obj.rs:693:5 [INFO] [stderr] | [INFO] [stderr] 693 | file.write(&buffer)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/error_reporter/mod.rs:113:26 [INFO] [stderr] | [INFO] [stderr] 113 | write_stderr(format!("{}", line)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `line.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/error_reporter/mod.rs:114:32 [INFO] [stderr] | [INFO] [stderr] 114 | if !line.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `compiler`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c3d4eeb58da2786771522331dba4923c9c857930dd4d6f7d97775e14cd23299b"` [INFO] running `"docker" "rm" "-f" "c3d4eeb58da2786771522331dba4923c9c857930dd4d6f7d97775e14cd23299b"` [INFO] [stdout] c3d4eeb58da2786771522331dba4923c9c857930dd4d6f7d97775e14cd23299b