[INFO] updating cached repository Vagelis-Prokopiou/rs_fibonacci
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Vagelis-Prokopiou/rs_fibonacci
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Vagelis-Prokopiou/rs_fibonacci" "work/ex/clippy-test-run/sources/stable/gh/Vagelis-Prokopiou/rs_fibonacci"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Vagelis-Prokopiou/rs_fibonacci'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Vagelis-Prokopiou/rs_fibonacci" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vagelis-Prokopiou/rs_fibonacci"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vagelis-Prokopiou/rs_fibonacci'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 795f75602f4469f1abb5b8039fa687b1952511d8
[INFO] sha for GitHub repo Vagelis-Prokopiou/rs_fibonacci: 795f75602f4469f1abb5b8039fa687b1952511d8
[INFO] validating manifest of Vagelis-Prokopiou/rs_fibonacci on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Vagelis-Prokopiou/rs_fibonacci on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Vagelis-Prokopiou/rs_fibonacci
[INFO] finished frobbing Vagelis-Prokopiou/rs_fibonacci
[INFO] frobbed toml for Vagelis-Prokopiou/rs_fibonacci written to work/ex/clippy-test-run/sources/stable/gh/Vagelis-Prokopiou/rs_fibonacci/Cargo.toml
[INFO] started frobbing Vagelis-Prokopiou/rs_fibonacci
[INFO] finished frobbing Vagelis-Prokopiou/rs_fibonacci
[INFO] frobbed toml for Vagelis-Prokopiou/rs_fibonacci written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vagelis-Prokopiou/rs_fibonacci/Cargo.toml
[INFO] crate Vagelis-Prokopiou/rs_fibonacci has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Vagelis-Prokopiou/rs_fibonacci against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Vagelis-Prokopiou/rs_fibonacci:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 79a6ac078a9baa07929fdd8bd97fd0c11bae0c27f751c42310aafb1b52a02cee
[INFO] running `"docker" "start" "-a" "79a6ac078a9baa07929fdd8bd97fd0c11bae0c27f751c42310aafb1b52a02cee"`
[INFO] [stderr]     Checking rust_fibonacci v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     return result;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return result;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     return current;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `current`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:19:5
[INFO] [stderr]    |
[INFO] [stderr] 19 |     return result;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:39:5
[INFO] [stderr]    |
[INFO] [stderr] 39 |     return result;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     return current;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `current`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]  --> src/lib.rs:3:63
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn fibonacci_with_hashmap_memoization(n: u64, cache: &mut HashMap<u64, u64>) -> u64 {
[INFO] [stderr]   |                                                               ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn fibonacci_with_hashmap_memoization<S: ::std::hash::BuildHasher>(n: u64, cache: &mut HashMap<u64, u64, S>) -> u64 {
[INFO] [stderr]   |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/lib.rs:50:15
[INFO] [stderr]    |
[INFO] [stderr] 50 |     for _i in 3..n + 1 {
[INFO] [stderr]    |               ^^^^^^^^ help: use: `3..=n`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]  --> src/lib.rs:3:63
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn fibonacci_with_hashmap_memoization(n: u64, cache: &mut HashMap<u64, u64>) -> u64 {
[INFO] [stderr]   |                                                               ^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn fibonacci_with_hashmap_memoization<S: ::std::hash::BuildHasher>(n: u64, cache: &mut HashMap<u64, u64, S>) -> u64 {
[INFO] [stderr]   |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/lib.rs:50:15
[INFO] [stderr]    |
[INFO] [stderr] 50 |     for _i in 3..n + 1 {
[INFO] [stderr]    |               ^^^^^^^^ help: use: `3..=n`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/tests.rs:12:82
[INFO] [stderr]    |
[INFO] [stderr] 12 |     assert_eq!(fibonacci::fibonacci_with_hashmap_memoization(29, &mut hash_map), 514229);
[INFO] [stderr]    |                                                                                  ^^^^^^ help: consider: `514_229`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/tests.rs:22:77
[INFO] [stderr]    |
[INFO] [stderr] 22 |     assert_eq!(fibonacci::fibonacci_with_array_memoization(29, &mut array), 514229);
[INFO] [stderr]    |                                                                             ^^^^^^ help: consider: `514_229`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/tests.rs:31:52
[INFO] [stderr]    |
[INFO] [stderr] 31 |     assert_eq!(fibonacci::fibonacci_iterative(29), 514229);
[INFO] [stderr]    |                                                    ^^^^^^ help: consider: `514_229`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/tests.rs:32:52
[INFO] [stderr]    |
[INFO] [stderr] 32 |     assert_eq!(fibonacci::fibonacci_iterative(60), 1548008755920);
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^ help: consider: `1_548_008_755_920`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.59s
[INFO] running `"docker" "inspect" "79a6ac078a9baa07929fdd8bd97fd0c11bae0c27f751c42310aafb1b52a02cee"`
[INFO] running `"docker" "rm" "-f" "79a6ac078a9baa07929fdd8bd97fd0c11bae0c27f751c42310aafb1b52a02cee"`
[INFO] [stdout] 79a6ac078a9baa07929fdd8bd97fd0c11bae0c27f751c42310aafb1b52a02cee