[INFO] updating cached repository Vagelis-Prokopiou/rs_employees-in-memory
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Vagelis-Prokopiou/rs_employees-in-memory
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Vagelis-Prokopiou/rs_employees-in-memory" "work/ex/clippy-test-run/sources/stable/gh/Vagelis-Prokopiou/rs_employees-in-memory"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Vagelis-Prokopiou/rs_employees-in-memory'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Vagelis-Prokopiou/rs_employees-in-memory" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vagelis-Prokopiou/rs_employees-in-memory"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vagelis-Prokopiou/rs_employees-in-memory'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 20fea33b612541dc48d4360e5bd17e44b2569b7f
[INFO] sha for GitHub repo Vagelis-Prokopiou/rs_employees-in-memory: 20fea33b612541dc48d4360e5bd17e44b2569b7f
[INFO] validating manifest of Vagelis-Prokopiou/rs_employees-in-memory on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Vagelis-Prokopiou/rs_employees-in-memory on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Vagelis-Prokopiou/rs_employees-in-memory
[INFO] finished frobbing Vagelis-Prokopiou/rs_employees-in-memory
[INFO] frobbed toml for Vagelis-Prokopiou/rs_employees-in-memory written to work/ex/clippy-test-run/sources/stable/gh/Vagelis-Prokopiou/rs_employees-in-memory/Cargo.toml
[INFO] started frobbing Vagelis-Prokopiou/rs_employees-in-memory
[INFO] finished frobbing Vagelis-Prokopiou/rs_employees-in-memory
[INFO] frobbed toml for Vagelis-Prokopiou/rs_employees-in-memory written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Vagelis-Prokopiou/rs_employees-in-memory/Cargo.toml
[INFO] crate Vagelis-Prokopiou/rs_employees-in-memory has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Vagelis-Prokopiou/rs_employees-in-memory against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Vagelis-Prokopiou/rs_employees-in-memory:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8982dc07ef44449cf52de3acdcff1f6980ae9a34362383dd313e5e8beadb9484
[INFO] running `"docker" "start" "-a" "8982dc07ef44449cf52de3acdcff1f6980ae9a34362383dd313e5e8beadb9484"`
[INFO] [stderr]     Checking employees_in_memory v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/helpers.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     return user_input.trim().to_string();
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `user_input.trim().to_string()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return vector.len() == 4 && vector[0] == "Add" && vector[2] == "to";
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vector.len() == 4 && vector[0] == "Add" && vector[2] == "to"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/helpers.rs:9:43
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn is_valid_employee_provided(vector: &Vec<&str>) -> bool {
[INFO] [stderr]   |                                           ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap`
[INFO] [stderr]   --> src/main.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 | /             if employees_database.contains_key(&employee_department) {
[INFO] [stderr] 35 | |                 let employees: &mut Vec<String> = employees_database.get_mut(&employee_department).unwrap();
[INFO] [stderr] 36 | |                 employees.push(employee_name);
[INFO] [stderr] 37 | |                 employees.sort();
[INFO] [stderr] 38 | |             } else {
[INFO] [stderr] 39 | |                 employees_database.insert(employee_department, vec![employee_name]);
[INFO] [stderr] 40 | |             }
[INFO] [stderr]    | |_____________^ help: consider using: `employees_database.entry(employee_department)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:58:41
[INFO] [stderr]    |
[INFO] [stderr] 58 |             println!("Employees: {:?}", employees_database.get(&department).unwrap());
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&employees_database[&department]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/helpers.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     return user_input.trim().to_string();
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `user_input.trim().to_string()`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     return vector.len() == 4 && vector[0] == "Add" && vector[2] == "to";
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vector.len() == 4 && vector[0] == "Add" && vector[2] == "to"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/helpers.rs:9:43
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn is_valid_employee_provided(vector: &Vec<&str>) -> bool {
[INFO] [stderr]   |                                           ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap`
[INFO] [stderr]   --> src/main.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 | /             if employees_database.contains_key(&employee_department) {
[INFO] [stderr] 35 | |                 let employees: &mut Vec<String> = employees_database.get_mut(&employee_department).unwrap();
[INFO] [stderr] 36 | |                 employees.push(employee_name);
[INFO] [stderr] 37 | |                 employees.sort();
[INFO] [stderr] 38 | |             } else {
[INFO] [stderr] 39 | |                 employees_database.insert(employee_department, vec![employee_name]);
[INFO] [stderr] 40 | |             }
[INFO] [stderr]    | |_____________^ help: consider using: `employees_database.entry(employee_department)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:58:41
[INFO] [stderr]    |
[INFO] [stderr] 58 |             println!("Employees: {:?}", employees_database.get(&department).unwrap());
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&employees_database[&department]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.36s
[INFO] running `"docker" "inspect" "8982dc07ef44449cf52de3acdcff1f6980ae9a34362383dd313e5e8beadb9484"`
[INFO] running `"docker" "rm" "-f" "8982dc07ef44449cf52de3acdcff1f6980ae9a34362383dd313e5e8beadb9484"`
[INFO] [stdout] 8982dc07ef44449cf52de3acdcff1f6980ae9a34362383dd313e5e8beadb9484