[INFO] updating cached repository UncleIroh/multi-raspa [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/UncleIroh/multi-raspa [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/UncleIroh/multi-raspa" "work/ex/clippy-test-run/sources/stable/gh/UncleIroh/multi-raspa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/UncleIroh/multi-raspa'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/UncleIroh/multi-raspa" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/UncleIroh/multi-raspa"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/UncleIroh/multi-raspa'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c9cee68b424e9254cb18b914ced0f0ab9fb58fe [INFO] sha for GitHub repo UncleIroh/multi-raspa: 8c9cee68b424e9254cb18b914ced0f0ab9fb58fe [INFO] validating manifest of UncleIroh/multi-raspa on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of UncleIroh/multi-raspa on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing UncleIroh/multi-raspa [INFO] finished frobbing UncleIroh/multi-raspa [INFO] frobbed toml for UncleIroh/multi-raspa written to work/ex/clippy-test-run/sources/stable/gh/UncleIroh/multi-raspa/Cargo.toml [INFO] started frobbing UncleIroh/multi-raspa [INFO] finished frobbing UncleIroh/multi-raspa [INFO] frobbed toml for UncleIroh/multi-raspa written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/UncleIroh/multi-raspa/Cargo.toml [INFO] crate UncleIroh/multi-raspa has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting UncleIroh/multi-raspa against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/UncleIroh/multi-raspa:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e6ea2cbd69f092bc0b02c420ef3ba79909971e4da5f241671dafd80f3268b93f [INFO] running `"docker" "start" "-a" "e6ea2cbd69f092bc0b02c420ef3ba79909971e4da5f241671dafd80f3268b93f"` [INFO] [stderr] Compiling cpython v0.1.0 [INFO] [stderr] Compiling memchr v0.1.11 [INFO] [stderr] Compiling thread-id v2.0.0 [INFO] [stderr] Compiling thread_local v0.2.7 [INFO] [stderr] Compiling aho-corasick v0.5.3 [INFO] [stderr] Compiling regex v0.1.80 [INFO] [stderr] Compiling python3-sys v0.1.3 [INFO] [stderr] Checking setup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unit_cells.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return uc; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `uc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `next` is never read [INFO] [stderr] --> src/unit_cells.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | let mut next = x.next(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/unit_cells.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | Err(_) => panic!("Failed to read line of cif file"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/unit_cells.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | return uc; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `uc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `next` is never read [INFO] [stderr] --> src/unit_cells.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | let mut next = x.next(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/unit_cells.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | Err(_) => panic!("Failed to read line of cif file"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / match std::fs::remove_dir_all(&output_path_new) { [INFO] [stderr] 104 | | Err(_) => (), [INFO] [stderr] 105 | | Ok(_) => (), [INFO] [stderr] 106 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(_) = std::fs::remove_dir_all(&output_path_new) { () }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | Err(_) => panic!("Can't open temp simulation.input"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | Err(_) => panic!("Can't open temp file, temp.input"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | Err(_) => panic!("problem reading line!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | / sim_file_temp.write(&framework.as_bytes()) [INFO] [stderr] 145 | | .expect("Failed to write MOF name to FrameworkName line in sim.input"); [INFO] [stderr] | |______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | / sim_file_temp.write(&cell_line.as_bytes()) [INFO] [stderr] 150 | | .expect("Failed to write MOF name ot FrameworkName line in sim.input"); [INFO] [stderr] | |______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | / sim_file_temp.write(&line.as_bytes()) [INFO] [stderr] 154 | | .expect("Failed to write to temp.input file"); [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | / sim_file_temp.write(&"\n".as_bytes()) [INFO] [stderr] 157 | | .expect("Writing to temp.input failed"); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:167:59 [INFO] [stderr] | [INFO] [stderr] 167 | let output_path_vec: Vec<&str> = bash_file_path.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | Err(_) => panic!("Unable to resolve absolute path of output directory"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | / match std::fs::remove_dir_all(&output_path_new) { [INFO] [stderr] 104 | | Err(_) => (), [INFO] [stderr] 105 | | Ok(_) => (), [INFO] [stderr] 106 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(_) = std::fs::remove_dir_all(&output_path_new) { () }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | Err(_) => panic!("Failed to create bash script in mof output dir"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | job_file.write(&file_contents.as_bytes()).expect("Failed to write to bash script inside mof output directory"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | Err(_) => panic!("Can't open temp simulation.input"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | Err(_) => panic!("Can't open temp file, temp.input"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | Err(_) => panic!("problem reading line!"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | / sim_file_temp.write(&framework.as_bytes()) [INFO] [stderr] 145 | | .expect("Failed to write MOF name to FrameworkName line in sim.input"); [INFO] [stderr] | |______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | / sim_file_temp.write(&cell_line.as_bytes()) [INFO] [stderr] 150 | | .expect("Failed to write MOF name ot FrameworkName line in sim.input"); [INFO] [stderr] | |______________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:153:21 [INFO] [stderr] | [INFO] [stderr] 153 | / sim_file_temp.write(&line.as_bytes()) [INFO] [stderr] 154 | | .expect("Failed to write to temp.input file"); [INFO] [stderr] | |_____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | / sim_file_temp.write(&"\n".as_bytes()) [INFO] [stderr] 157 | | .expect("Writing to temp.input failed"); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:167:59 [INFO] [stderr] | [INFO] [stderr] 167 | let output_path_vec: Vec<&str> = bash_file_path.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | Err(_) => panic!("Unable to resolve absolute path of output directory"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | Err(_) => panic!("Failed to create bash script in mof output dir"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | job_file.write(&file_contents.as_bytes()).expect("Failed to write to bash script inside mof output directory"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `setup`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `setup`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e6ea2cbd69f092bc0b02c420ef3ba79909971e4da5f241671dafd80f3268b93f"` [INFO] running `"docker" "rm" "-f" "e6ea2cbd69f092bc0b02c420ef3ba79909971e4da5f241671dafd80f3268b93f"` [INFO] [stdout] e6ea2cbd69f092bc0b02c420ef3ba79909971e4da5f241671dafd80f3268b93f