[INFO] updating cached repository UMWACM/Archinbald [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/UMWACM/Archinbald [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/UMWACM/Archinbald" "work/ex/clippy-test-run/sources/stable/gh/UMWACM/Archinbald"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/UMWACM/Archinbald'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/UMWACM/Archinbald" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/UMWACM/Archinbald"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/UMWACM/Archinbald'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dc90cf914a3c30b5e6700a135fe6b266b9e266d5 [INFO] sha for GitHub repo UMWACM/Archinbald: dc90cf914a3c30b5e6700a135fe6b266b9e266d5 [INFO] validating manifest of UMWACM/Archinbald on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of UMWACM/Archinbald on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing UMWACM/Archinbald [INFO] finished frobbing UMWACM/Archinbald [INFO] frobbed toml for UMWACM/Archinbald written to work/ex/clippy-test-run/sources/stable/gh/UMWACM/Archinbald/Cargo.toml [INFO] started frobbing UMWACM/Archinbald [INFO] finished frobbing UMWACM/Archinbald [INFO] frobbed toml for UMWACM/Archinbald written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/UMWACM/Archinbald/Cargo.toml [INFO] crate UMWACM/Archinbald has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting UMWACM/Archinbald against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/UMWACM/Archinbald:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8686fec6bd77c9c06ed4cfc163d3df544cc9739b4113e22ceebcdbfe03db137 [INFO] running `"docker" "start" "-a" "b8686fec6bd77c9c06ed4cfc163d3df544cc9739b4113e22ceebcdbfe03db137"` [INFO] [stderr] Compiling openssl v0.9.22 [INFO] [stderr] Checking serde_json v1.0.6 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking tokio-core v0.1.10 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking irc v0.12.5 [INFO] [stderr] Checking archinbald v0.1.8 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 55 | | if msg.contains(server.config().get_option("stop_pass")) { [INFO] [stderr] 56 | | server.send_privmsg(target, decorate("Okay...goodby cruel world.").as_str()).unwrap(); [INFO] [stderr] 57 | | panic!("User forced stop."); [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if msg.contains(server.config().get_option("stop_pass")) { [INFO] [stderr] 55 | server.send_privmsg(target, decorate("Okay...goodby cruel world.").as_str()).unwrap(); [INFO] [stderr] 56 | panic!("User forced stop."); [INFO] [stderr] 57 | } else { [INFO] [stderr] 58 | server.send_privmsg(target, decorate("What is that rubbish password!?").as_str()).unwrap(); [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / server.for_each_incoming(|message| { [INFO] [stderr] 24 | | print!("{}", message); [INFO] [stderr] 25 | | match message.command { [INFO] [stderr] 26 | | Command::PRIVMSG(ref target, ref msg) => { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match message.command { [INFO] [stderr] 26 | | Command::PRIVMSG(ref target, ref msg) => { [INFO] [stderr] 27 | | if msg.contains("@archinbald help") { [INFO] [stderr] 28 | | server.send_privmsg(target, decorate(server.config().get_option("help")).as_str()).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 77 | | _ => (), [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | if let Command::PRIVMSG(ref target, ref msg) = message.command { [INFO] [stderr] 26 | if msg.contains("@archinbald help") { [INFO] [stderr] 27 | server.send_privmsg(target, decorate(server.config().get_option("help")).as_str()).unwrap(); [INFO] [stderr] 28 | } [INFO] [stderr] 29 | if msg.contains("@archinbald ping") { [INFO] [stderr] 30 | server.send_privmsg(target, decorate("I'm right here...oh, sorry...PONG!").as_str()).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:60 [INFO] [stderr] | [INFO] [stderr] 72 | let lines_vec: Vec<&str> = lines.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:74:49 [INFO] [stderr] | [INFO] [stderr] 74 | server.send_privmsg(target, lines_vec.get(rand_num).unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `lines_vec[rand_num]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:54:28 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 55 | | if msg.contains(server.config().get_option("stop_pass")) { [INFO] [stderr] 56 | | server.send_privmsg(target, decorate("Okay...goodby cruel world.").as_str()).unwrap(); [INFO] [stderr] 57 | | panic!("User forced stop."); [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if msg.contains(server.config().get_option("stop_pass")) { [INFO] [stderr] 55 | server.send_privmsg(target, decorate("Okay...goodby cruel world.").as_str()).unwrap(); [INFO] [stderr] 56 | panic!("User forced stop."); [INFO] [stderr] 57 | } else { [INFO] [stderr] 58 | server.send_privmsg(target, decorate("What is that rubbish password!?").as_str()).unwrap(); [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / server.for_each_incoming(|message| { [INFO] [stderr] 24 | | print!("{}", message); [INFO] [stderr] 25 | | match message.command { [INFO] [stderr] 26 | | Command::PRIVMSG(ref target, ref msg) => { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match message.command { [INFO] [stderr] 26 | | Command::PRIVMSG(ref target, ref msg) => { [INFO] [stderr] 27 | | if msg.contains("@archinbald help") { [INFO] [stderr] 28 | | server.send_privmsg(target, decorate(server.config().get_option("help")).as_str()).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 77 | | _ => (), [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 25 | if let Command::PRIVMSG(ref target, ref msg) = message.command { [INFO] [stderr] 26 | if msg.contains("@archinbald help") { [INFO] [stderr] 27 | server.send_privmsg(target, decorate(server.config().get_option("help")).as_str()).unwrap(); [INFO] [stderr] 28 | } [INFO] [stderr] 29 | if msg.contains("@archinbald ping") { [INFO] [stderr] 30 | server.send_privmsg(target, decorate("I'm right here...oh, sorry...PONG!").as_str()).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:60 [INFO] [stderr] | [INFO] [stderr] 72 | let lines_vec: Vec<&str> = lines.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:74:49 [INFO] [stderr] | [INFO] [stderr] 74 | server.send_privmsg(target, lines_vec.get(rand_num).unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `lines_vec[rand_num]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.05s [INFO] running `"docker" "inspect" "b8686fec6bd77c9c06ed4cfc163d3df544cc9739b4113e22ceebcdbfe03db137"` [INFO] running `"docker" "rm" "-f" "b8686fec6bd77c9c06ed4cfc163d3df544cc9739b4113e22ceebcdbfe03db137"` [INFO] [stdout] b8686fec6bd77c9c06ed4cfc163d3df544cc9739b4113e22ceebcdbfe03db137