[INFO] updating cached repository Twinklebear/spline-viewer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Twinklebear/spline-viewer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Twinklebear/spline-viewer" "work/ex/clippy-test-run/sources/stable/gh/Twinklebear/spline-viewer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Twinklebear/spline-viewer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Twinklebear/spline-viewer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Twinklebear/spline-viewer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Twinklebear/spline-viewer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 1e0815290d5a4d78d81723924343e5d15b2b8c9f
[INFO] sha for GitHub repo Twinklebear/spline-viewer: 1e0815290d5a4d78d81723924343e5d15b2b8c9f
[INFO] validating manifest of Twinklebear/spline-viewer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Twinklebear/spline-viewer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Twinklebear/spline-viewer
[INFO] finished frobbing Twinklebear/spline-viewer
[INFO] frobbed toml for Twinklebear/spline-viewer written to work/ex/clippy-test-run/sources/stable/gh/Twinklebear/spline-viewer/Cargo.toml
[INFO] started frobbing Twinklebear/spline-viewer
[INFO] finished frobbing Twinklebear/spline-viewer
[INFO] frobbed toml for Twinklebear/spline-viewer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Twinklebear/spline-viewer/Cargo.toml
[INFO] crate Twinklebear/spline-viewer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Twinklebear/spline-viewer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Twinklebear/spline-viewer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6e67e1be08183a7a510dfc1164649adc7145af141936bbc8d5fc2d22d8053f41
[INFO] running `"docker" "start" "-a" "6e67e1be08183a7a510dfc1164649adc7145af141936bbc8d5fc2d22d8053f41"`
[INFO] [stderr]    Compiling serde_json v0.9.10
[INFO] [stderr]     Checking shared_library v0.1.5
[INFO] [stderr]    Compiling imgui-sys v0.0.13
[INFO] [stderr]     Checking cgmath v0.14.0
[INFO] [stderr]     Checking x11-dl v2.13.0
[INFO] [stderr]    Compiling target_build_utils v0.3.0
[INFO] [stderr]     Checking tempfile v2.1.5
[INFO] [stderr]     Checking backtrace v0.2.3
[INFO] [stderr]     Checking docopt v0.7.0
[INFO] [stderr]     Checking rulinalg v0.4.2
[INFO] [stderr]     Checking memmap v0.4.0
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking arcball v0.2.0
[INFO] [stderr]    Compiling libloading v0.3.4
[INFO] [stderr]     Checking dlib v0.3.1
[INFO] [stderr]     Checking wayland-sys v0.7.8
[INFO] [stderr]     Checking wayland-client v0.7.8
[INFO] [stderr]     Checking wayland-window v0.4.4
[INFO] [stderr]     Checking wayland-kbd v0.6.3
[INFO] [stderr]     Checking winit v0.5.11
[INFO] [stderr]     Checking glutin v0.7.4
[INFO] [stderr]     Checking glium v0.16.0
[INFO] [stderr]     Checking imgui v0.0.13
[INFO] [stderr]     Checking imgui-glium-renderer v0.0.13
[INFO] [stderr]     Checking spline-viewer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/imgui_support.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             imgui: imgui,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `imgui`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bezier.rs:56:18
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Bezier { control_points: control_points }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline.rs:40:36
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let mut spline = BSpline { degree: degree, control_points: control_points, knots: knots };
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: replace it with: `degree`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline.rs:40:52
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let mut spline = BSpline { degree: degree, control_points: control_points, knots: knots };
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline.rs:40:84
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let mut spline = BSpline { degree: degree, control_points: control_points, knots: knots };
[INFO] [stderr]    |                                                                                    ^^^^^^^^^^^^ help: replace it with: `knots`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/point.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |         let p = *a + v * t;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/point.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let d = (p - *self).length();
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:54:24
[INFO] [stderr]    |
[INFO] [stderr] 54 |         DisplayCurve { display: display,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:55:24
[INFO] [stderr]    |
[INFO] [stderr] 55 |                        curve: curve,
[INFO] [stderr]    |                        ^^^^^^^^^^^^ help: replace it with: `curve`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:56:24
[INFO] [stderr]    |
[INFO] [stderr] 56 |                        curve_points_vbo: curve_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curve_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:57:24
[INFO] [stderr]    |
[INFO] [stderr] 57 |                        control_points_vbo: control_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:58:24
[INFO] [stderr]    |
[INFO] [stderr] 58 |                        break_points_vbo: break_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `break_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve3d.rs:46:26
[INFO] [stderr]    |
[INFO] [stderr] 46 |         DisplayCurve3D { display: display,
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve3d.rs:47:24
[INFO] [stderr]    |
[INFO] [stderr] 47 |                        curve: curve,
[INFO] [stderr]    |                        ^^^^^^^^^^^^ help: replace it with: `curve`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve3d.rs:48:24
[INFO] [stderr]    |
[INFO] [stderr] 48 |                        curve_points_vbo: curve_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curve_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve3d.rs:49:24
[INFO] [stderr]    |
[INFO] [stderr] 49 |                        control_points_vbo: control_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/polyline.rs:24:20
[INFO] [stderr]    |
[INFO] [stderr] 24 |         Polyline { points_vbo: points_vbo,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_surf.rs:33:23
[INFO] [stderr]    |
[INFO] [stderr] 33 |                       control_mesh: control_mesh
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_mesh`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:161:23
[INFO] [stderr]     |
[INFO] [stderr] 161 |         DisplaySurf { isolines_u_vbos: isolines_u_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `isolines_u_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:162:23
[INFO] [stderr]     |
[INFO] [stderr] 162 |                       isolines_v_vbos: isolines_v_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `isolines_v_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:163:23
[INFO] [stderr]     |
[INFO] [stderr] 163 |                       greville_u_vbos: greville_u_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `greville_u_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:164:23
[INFO] [stderr]     |
[INFO] [stderr] 164 |                       greville_v_vbos: greville_v_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `greville_v_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:165:23
[INFO] [stderr]     |
[INFO] [stderr] 165 |                       knot_u_vbos: knot_u_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `knot_u_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:166:23
[INFO] [stderr]     |
[INFO] [stderr] 166 |                       knot_v_vbos: knot_v_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `knot_v_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:167:23
[INFO] [stderr]     |
[INFO] [stderr] 167 |                       control_points_vbo: control_points_vbo,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points_vbo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_surf_interp.rs:56:36
[INFO] [stderr]    |
[INFO] [stderr] 56 |         DisplaySurfInterpolation { display: display,
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_surf_interp.rs:57:23
[INFO] [stderr]    |
[INFO] [stderr] 57 |                       curves: curves,
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^ help: replace it with: `curves`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_surf_interp.rs:60:23
[INFO] [stderr]    |
[INFO] [stderr] 60 |                       input_curves_vbo: input_curves_vbo,
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_curves_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:22:24
[INFO] [stderr]    |
[INFO] [stderr] 22 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^ help: replace it with: `degree`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:22:40
[INFO] [stderr]    |
[INFO] [stderr] 22 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                                        ^^^^^^^^^^^^ help: replace it with: `knots`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:22:54
[INFO] [stderr]    |
[INFO] [stderr] 22 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modified_knot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:33:24
[INFO] [stderr]    |
[INFO] [stderr] 33 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^ help: replace it with: `degree`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:33:40
[INFO] [stderr]    |
[INFO] [stderr] 33 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                                        ^^^^^^^^^^^^ help: replace it with: `knots`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:33:54
[INFO] [stderr]    |
[INFO] [stderr] 33 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modified_knot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/bspline_basis.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 |             let mut b = (self.knots[i + k + 1] - t) / (self.knots[i + k + 1] - self.knots[i + 1]);
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/bspline_basis.rs:87:17
[INFO] [stderr]    |
[INFO] [stderr] 87 |             let c = self.evaluate_basis(t, i, k - 1);
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/bspline_basis.rs:88:17
[INFO] [stderr]    |
[INFO] [stderr] 88 |             let d = self.evaluate_basis(t, i + 1, k - 1);
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/imgui_support.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             imgui: imgui,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `imgui`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bezier.rs:56:18
[INFO] [stderr]    |
[INFO] [stderr] 56 |         Bezier { control_points: control_points }
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline.rs:40:36
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let mut spline = BSpline { degree: degree, control_points: control_points, knots: knots };
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^ help: replace it with: `degree`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline.rs:40:52
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let mut spline = BSpline { degree: degree, control_points: control_points, knots: knots };
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline.rs:40:84
[INFO] [stderr]    |
[INFO] [stderr] 40 |         let mut spline = BSpline { degree: degree, control_points: control_points, knots: knots };
[INFO] [stderr]    |                                                                                    ^^^^^^^^^^^^ help: replace it with: `knots`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/point.rs:62:13
[INFO] [stderr]    |
[INFO] [stderr] 62 |         let p = *a + v * t;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/point.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let d = (p - *self).length();
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:54:24
[INFO] [stderr]    |
[INFO] [stderr] 54 |         DisplayCurve { display: display,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:55:24
[INFO] [stderr]    |
[INFO] [stderr] 55 |                        curve: curve,
[INFO] [stderr]    |                        ^^^^^^^^^^^^ help: replace it with: `curve`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:56:24
[INFO] [stderr]    |
[INFO] [stderr] 56 |                        curve_points_vbo: curve_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curve_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:57:24
[INFO] [stderr]    |
[INFO] [stderr] 57 |                        control_points_vbo: control_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve.rs:58:24
[INFO] [stderr]    |
[INFO] [stderr] 58 |                        break_points_vbo: break_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `break_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve3d.rs:46:26
[INFO] [stderr]    |
[INFO] [stderr] 46 |         DisplayCurve3D { display: display,
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve3d.rs:47:24
[INFO] [stderr]    |
[INFO] [stderr] 47 |                        curve: curve,
[INFO] [stderr]    |                        ^^^^^^^^^^^^ help: replace it with: `curve`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve3d.rs:48:24
[INFO] [stderr]    |
[INFO] [stderr] 48 |                        curve_points_vbo: curve_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `curve_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_curve3d.rs:49:24
[INFO] [stderr]    |
[INFO] [stderr] 49 |                        control_points_vbo: control_points_vbo,
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/polyline.rs:24:20
[INFO] [stderr]    |
[INFO] [stderr] 24 |         Polyline { points_vbo: points_vbo,
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `points_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_surf.rs:33:23
[INFO] [stderr]    |
[INFO] [stderr] 33 |                       control_mesh: control_mesh
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_mesh`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:161:23
[INFO] [stderr]     |
[INFO] [stderr] 161 |         DisplaySurf { isolines_u_vbos: isolines_u_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `isolines_u_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:162:23
[INFO] [stderr]     |
[INFO] [stderr] 162 |                       isolines_v_vbos: isolines_v_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `isolines_v_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:163:23
[INFO] [stderr]     |
[INFO] [stderr] 163 |                       greville_u_vbos: greville_u_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `greville_u_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:164:23
[INFO] [stderr]     |
[INFO] [stderr] 164 |                       greville_v_vbos: greville_v_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `greville_v_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:165:23
[INFO] [stderr]     |
[INFO] [stderr] 165 |                       knot_u_vbos: knot_u_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `knot_u_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:166:23
[INFO] [stderr]     |
[INFO] [stderr] 166 |                       knot_v_vbos: knot_v_vbos,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `knot_v_vbos`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/display_surf.rs:167:23
[INFO] [stderr]     |
[INFO] [stderr] 167 |                       control_points_vbo: control_points_vbo,
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `control_points_vbo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_surf_interp.rs:56:36
[INFO] [stderr]    |
[INFO] [stderr] 56 |         DisplaySurfInterpolation { display: display,
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_surf_interp.rs:57:23
[INFO] [stderr]    |
[INFO] [stderr] 57 |                       curves: curves,
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^ help: replace it with: `curves`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/display_surf_interp.rs:60:23
[INFO] [stderr]    |
[INFO] [stderr] 60 |                       input_curves_vbo: input_curves_vbo,
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_curves_vbo`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:22:24
[INFO] [stderr]    |
[INFO] [stderr] 22 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^ help: replace it with: `degree`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:22:40
[INFO] [stderr]    |
[INFO] [stderr] 22 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                                        ^^^^^^^^^^^^ help: replace it with: `knots`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:22:54
[INFO] [stderr]    |
[INFO] [stderr] 22 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modified_knot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:33:24
[INFO] [stderr]    |
[INFO] [stderr] 33 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^ help: replace it with: `degree`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:33:40
[INFO] [stderr]    |
[INFO] [stderr] 33 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                                        ^^^^^^^^^^^^ help: replace it with: `knots`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bspline_basis.rs:33:54
[INFO] [stderr]    |
[INFO] [stderr] 33 |         BSplineBasis { degree: degree, knots: knots, modified_knot: modified_knot }
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `modified_knot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/bspline_basis.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 |             let mut b = (self.knots[i + k + 1] - t) / (self.knots[i + k + 1] - self.knots[i + 1]);
[INFO] [stderr]    |                     ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/bspline_basis.rs:87:17
[INFO] [stderr]    |
[INFO] [stderr] 87 |             let c = self.evaluate_basis(t, i, k - 1);
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/bspline_basis.rs:88:17
[INFO] [stderr]    |
[INFO] [stderr] 88 |             let d = self.evaluate_basis(t, i + 1, k - 1);
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/display_curve.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 | /         if ui.slider_int(im_str!("Curve Degree"), &mut curve_degree, 1,
[INFO] [stderr] 173 | |             self.curve.max_possible_degree() as i32).build()
[INFO] [stderr] 174 | |         {
[INFO] [stderr] 175 | |             if self.curve.max_possible_degree() != 0 {
[INFO] [stderr] ...   |
[INFO] [stderr] 178 | |             }
[INFO] [stderr] 179 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 172 |         if ui.slider_int(im_str!("Curve Degree"), &mut curve_degree, 1,
[INFO] [stderr] 173 |             self.curve.max_possible_degree() as i32).build() && self.curve.max_possible_degree() != 0 {
[INFO] [stderr] 174 |     self.curve.set_degree(curve_degree as usize);
[INFO] [stderr] 175 |     curve_changed = true;
[INFO] [stderr] 176 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/display_curve3d.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 | /         if ui.slider_int(im_str!("Curve Degree"), &mut curve_degree, 1,
[INFO] [stderr] 110 | |             self.curve.max_possible_degree() as i32).build()
[INFO] [stderr] 111 | |         {
[INFO] [stderr] 112 | |             if self.curve.max_possible_degree() != 0 {
[INFO] [stderr] ...   |
[INFO] [stderr] 115 | |             }
[INFO] [stderr] 116 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 109 |         if ui.slider_int(im_str!("Curve Degree"), &mut curve_degree, 1,
[INFO] [stderr] 110 |             self.curve.max_possible_degree() as i32).build() && self.curve.max_possible_degree() != 0 {
[INFO] [stderr] 111 |     self.curve.set_degree(curve_degree as usize);
[INFO] [stderr] 112 |     curve_changed = true;
[INFO] [stderr] 113 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/main.rs:107:15
[INFO] [stderr]     |
[INFO] [stderr] 107 | const USAGE: &'static str = "
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/display_curve.rs:172:9
[INFO] [stderr]     |
[INFO] [stderr] 172 | /         if ui.slider_int(im_str!("Curve Degree"), &mut curve_degree, 1,
[INFO] [stderr] 173 | |             self.curve.max_possible_degree() as i32).build()
[INFO] [stderr] 174 | |         {
[INFO] [stderr] 175 | |             if self.curve.max_possible_degree() != 0 {
[INFO] [stderr] ...   |
[INFO] [stderr] 178 | |             }
[INFO] [stderr] 179 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 172 |         if ui.slider_int(im_str!("Curve Degree"), &mut curve_degree, 1,
[INFO] [stderr] 173 |             self.curve.max_possible_degree() as i32).build() && self.curve.max_possible_degree() != 0 {
[INFO] [stderr] 174 |     self.curve.set_degree(curve_degree as usize);
[INFO] [stderr] 175 |     curve_changed = true;
[INFO] [stderr] 176 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/display_curve3d.rs:109:9
[INFO] [stderr]     |
[INFO] [stderr] 109 | /         if ui.slider_int(im_str!("Curve Degree"), &mut curve_degree, 1,
[INFO] [stderr] 110 | |             self.curve.max_possible_degree() as i32).build()
[INFO] [stderr] 111 | |         {
[INFO] [stderr] 112 | |             if self.curve.max_possible_degree() != 0 {
[INFO] [stderr] ...   |
[INFO] [stderr] 115 | |             }
[INFO] [stderr] 116 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 109 |         if ui.slider_int(im_str!("Curve Degree"), &mut curve_degree, 1,
[INFO] [stderr] 110 |             self.curve.max_possible_degree() as i32).build() && self.curve.max_possible_degree() != 0 {
[INFO] [stderr] 111 |     self.curve.set_degree(curve_degree as usize);
[INFO] [stderr] 112 |     curve_changed = true;
[INFO] [stderr] 113 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/main.rs:107:15
[INFO] [stderr]     |
[INFO] [stderr] 107 | const USAGE: &'static str = "
[INFO] [stderr]     |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/bezier.rs:94:65
[INFO] [stderr]    |
[INFO] [stderr] 94 |         } else if nearest.0 == self.control_points.len() - 2 && nearest.2 == 1.0 {
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(nearest.2 - 1.0).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/bezier.rs:94:65
[INFO] [stderr]    |
[INFO] [stderr] 94 |         } else if nearest.0 == self.control_points.len() - 2 && nearest.2 == 1.0 {
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:118:34
[INFO] [stderr]     |
[INFO] [stderr] 118 |             .fold(true, |acc, x| *x == self.knots[0] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*x - self.knots[0]).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:118:34
[INFO] [stderr]     |
[INFO] [stderr] 118 |             .fold(true, |acc, x| *x == self.knots[0] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:120:34
[INFO] [stderr]     |
[INFO] [stderr] 120 |             .fold(true, |acc, x| *x == self.knots[self.knots.len() - 1] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*x - self.knots[self.knots.len() - 1]).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:120:34
[INFO] [stderr]     |
[INFO] [stderr] 120 |             .fold(true, |acc, x| *x == self.knots[self.knots.len() - 1] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:132:34
[INFO] [stderr]     |
[INFO] [stderr] 132 |             .fold(true, |acc, x| *x == self.knots[0] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*x - self.knots[0]).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:132:34
[INFO] [stderr]     |
[INFO] [stderr] 132 |             .fold(true, |acc, x| *x == self.knots[0] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:134:34
[INFO] [stderr]     |
[INFO] [stderr] 134 |             .fold(true, |acc, x| *x == self.knots[self.knots.len() - 1] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*x - self.knots[self.knots.len() - 1]).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:134:34
[INFO] [stderr]     |
[INFO] [stderr] 134 |             .fold(true, |acc, x| *x == self.knots[self.knots.len() - 1] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/bspline.rs:143:16
[INFO] [stderr]     |
[INFO] [stderr] 143 |               if !(left_clamped && i < self.degree)
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 144 | |                 && !(right_clamped && i >= self.knots_required() - 1 - self.degree) {
[INFO] [stderr]     | |___________________________________________________________________________________^ help: try: `!(right_clamped && i >= self.knots_required() - 1 - self.degree || left_clamped && i < self.degree)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/bspline.rs:156:18
[INFO] [stderr]     |
[INFO] [stderr] 156 |         for j in 0..self.degree + 1 {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^ help: use: `0..=self.degree`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:199:65
[INFO] [stderr]     |
[INFO] [stderr] 199 |         } else if nearest.0 == self.control_points.len() - 2 && nearest.2 == 1.0 {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(nearest.2 - 1.0).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:199:65
[INFO] [stderr]     |
[INFO] [stderr] 199 |         } else if nearest.0 == self.control_points.len() - 2 && nearest.2 == 1.0 {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/display_curve.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         let break_points_vbo;
[INFO] [stderr] 35 | |         if !curve.control_points.is_empty() {
[INFO] [stderr] 36 | |             let step_size = 0.01;
[INFO] [stderr] 37 | |             let t_range = curve.knot_domain();
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |             break_points_vbo = VertexBuffer::empty(display, 10).unwrap();
[INFO] [stderr] 53 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let break_points_vbo = if !curve.control_points.is_empty() { ..; VertexBuffer::new(display, &break_points[..]).unwrap() } else { ..; VertexBuffer::empty(display, 10).unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_curve.rs:42:22
[INFO] [stderr]    |
[INFO] [stderr] 42 |             for s in 0..steps + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_curve.rs:95:22
[INFO] [stderr]    |
[INFO] [stderr] 95 |             for s in 0..steps + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/display_curve.rs:187:22
[INFO] [stderr]     |
[INFO] [stderr] 187 |             for s in 0..steps + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/display_curve3d.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         let curve_points_vbo;
[INFO] [stderr] 30 | |         if !curve.control_points.is_empty() {
[INFO] [stderr] 31 | |             let step_size = 0.01;
[INFO] [stderr] 32 | |             let t_range = curve.knot_domain();
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |             curve_points_vbo = VertexBuffer::empty(display, 10).unwrap();
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let curve_points_vbo = if !curve.control_points.is_empty() { ..; VertexBuffer::new(display, &points[..]).unwrap() } else { ..; VertexBuffer::empty(display, 10).unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_curve3d.rs:37:22
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for s in 0..steps + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/display_curve3d.rs:124:22
[INFO] [stderr]     |
[INFO] [stderr] 124 |             for s in 0..steps + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf.rs:55:36
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let mut t_vals_u: Vec<_> = (0..isoline_start_steps_u + 1).map(|us| isoline_step_size * us as f32 + t_range_u.0)
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=isoline_start_steps_u)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/display_surf.rs:56:20
[INFO] [stderr]    |
[INFO] [stderr] 56 |             .chain(abscissa_u.iter().map(|x| *x))
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `abscissa_u.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf.rs:64:36
[INFO] [stderr]    |
[INFO] [stderr] 64 |         let mut t_vals_v: Vec<_> = (0..isoline_start_steps_v + 1).map(|vs| isoline_step_size * vs as f32 + t_range_v.0)
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=isoline_start_steps_v)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/display_surf.rs:65:20
[INFO] [stderr]    |
[INFO] [stderr] 65 |             .chain(abscissa_v.iter().map(|x| *x))
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `abscissa_v.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf.rs:73:44
[INFO] [stderr]    |
[INFO] [stderr] 73 |         let mut isoline_u_t_vals: Vec<_> = (0..steps_u + 1).map(|u| step_size * u as f32 + t_range_u.0)
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^ help: use: `(0..=steps_u)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/display_surf.rs:74:20
[INFO] [stderr]    |
[INFO] [stderr] 74 |             .chain(t_vals_u.iter().map(|x| *x)).collect();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t_vals_u.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf.rs:79:44
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let mut isoline_v_t_vals: Vec<_> = (0..steps_v + 1).map(|u| step_size * u as f32 + t_range_v.0)
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^ help: use: `(0..=steps_v)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/display_surf.rs:80:20
[INFO] [stderr]    |
[INFO] [stderr] 80 |             .chain(t_vals_v.iter().map(|x| *x)).collect();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t_vals_v.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/display_surf.rs:129:19
[INFO] [stderr]     |
[INFO] [stderr] 129 |         for vs in 0..isoline_start_steps_v + 1 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=isoline_start_steps_v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/display_surf.rs:131:70
[INFO] [stderr]     |
[INFO] [stderr] 131 |             if !abscissa_v.iter().chain(surf.knots_v.iter()).any(|x| *x == v) {
[INFO] [stderr]     |                                                                      ^^^^^^^ help: consider comparing them within some error: `(*x - v).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/display_surf.rs:131:70
[INFO] [stderr]     |
[INFO] [stderr] 131 |             if !abscissa_v.iter().chain(surf.knots_v.iter()).any(|x| *x == v) {
[INFO] [stderr]     |                                                                      ^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/display_surf.rs:141:19
[INFO] [stderr]     |
[INFO] [stderr] 141 |         for us in 0..isoline_start_steps_u + 1 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=isoline_start_steps_u`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/display_surf.rs:143:70
[INFO] [stderr]     |
[INFO] [stderr] 143 |             if !abscissa_u.iter().chain(surf.knots_u.iter()).any(|x| *x == u) {
[INFO] [stderr]     |                                                                      ^^^^^^^ help: consider comparing them within some error: `(*x - u).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/display_surf.rs:143:70
[INFO] [stderr]     |
[INFO] [stderr] 143 |             if !abscissa_u.iter().chain(surf.knots_u.iter()).any(|x| *x == u) {
[INFO] [stderr]     |                                                                      ^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf_interp.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 |             for s in 0..steps + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/display_surf_interp.rs:117:57
[INFO] [stderr]     |
[INFO] [stderr] 117 |     let basis_u = BSplineBasis::new(curves[0].degree(), curves[0].knots().map(|x| *x).collect());
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `curves[0].knots().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/display_surf_interp.rs:147:9
[INFO] [stderr]     |
[INFO] [stderr] 147 |         x = x + 1;
[INFO] [stderr]     |         ^^^^^^^^^ help: replace it with: `x += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/bspline_basis.rs:70:49
[INFO] [stderr]    |
[INFO] [stderr] 70 |                   } else if t < self.knots[i + 1] {
[INFO] [stderr]    |  _________________________________________________^
[INFO] [stderr] 71 | |                     1.0
[INFO] [stderr] 72 | |                 } else {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/bspline_basis.rs:68:70
[INFO] [stderr]    |
[INFO] [stderr] 68 |                   if i == self.modified_knot && t <= self.knots[i + 1] {
[INFO] [stderr]    |  ______________________________________________________________________^
[INFO] [stderr] 69 | |                     1.0
[INFO] [stderr] 70 | |                 } else if t < self.knots[i + 1] {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/bspline_basis.rs:100:16
[INFO] [stderr]     |
[INFO] [stderr] 100 |             if !(clamped && i < degree) && !(clamped && i >= knots_required - 1 - degree) {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 100 |             if i >= degree && i < knots_required - 1 - degree || !clamped {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 100 |             if !(clamped && i >= knots_required - 1 - degree || clamped && i < degree) {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 32
[INFO] [stderr]    --> src/main.rs:116:1
[INFO] [stderr]     |
[INFO] [stderr] 116 | / fn main() {
[INFO] [stderr] 117 | |     let args = Docopt::new(USAGE).and_then(|d| d.parse()).unwrap_or_else(|e| e.exit());
[INFO] [stderr] 118 | |     let target_gl_versions = glutin::GlRequest::GlThenGles {
[INFO] [stderr] 119 | |         opengl_version: (3, 3),
[INFO] [stderr] ...   |
[INFO] [stderr] 415 | |     }
[INFO] [stderr] 416 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:180:26
[INFO] [stderr]     |
[INFO] [stderr] 180 |       let shader_program = program!(&display,
[INFO] [stderr]     |  __________________________^
[INFO] [stderr] 181 | |         330 => {
[INFO] [stderr] 182 | |             vertex: "
[INFO] [stderr] 183 | |                 #version 330 core
[INFO] [stderr] ...   |
[INFO] [stderr] 198 | |         },
[INFO] [stderr] 199 | |     ).unwrap();
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 9 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `spline-viewer`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/bezier.rs:94:65
[INFO] [stderr]    |
[INFO] [stderr] 94 |         } else if nearest.0 == self.control_points.len() - 2 && nearest.2 == 1.0 {
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(nearest.2 - 1.0).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/bezier.rs:94:65
[INFO] [stderr]    |
[INFO] [stderr] 94 |         } else if nearest.0 == self.control_points.len() - 2 && nearest.2 == 1.0 {
[INFO] [stderr]    |                                                                 ^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:118:34
[INFO] [stderr]     |
[INFO] [stderr] 118 |             .fold(true, |acc, x| *x == self.knots[0] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*x - self.knots[0]).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:118:34
[INFO] [stderr]     |
[INFO] [stderr] 118 |             .fold(true, |acc, x| *x == self.knots[0] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:120:34
[INFO] [stderr]     |
[INFO] [stderr] 120 |             .fold(true, |acc, x| *x == self.knots[self.knots.len() - 1] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*x - self.knots[self.knots.len() - 1]).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:120:34
[INFO] [stderr]     |
[INFO] [stderr] 120 |             .fold(true, |acc, x| *x == self.knots[self.knots.len() - 1] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:132:34
[INFO] [stderr]     |
[INFO] [stderr] 132 |             .fold(true, |acc, x| *x == self.knots[0] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*x - self.knots[0]).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:132:34
[INFO] [stderr]     |
[INFO] [stderr] 132 |             .fold(true, |acc, x| *x == self.knots[0] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:134:34
[INFO] [stderr]     |
[INFO] [stderr] 134 |             .fold(true, |acc, x| *x == self.knots[self.knots.len() - 1] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*x - self.knots[self.knots.len() - 1]).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:134:34
[INFO] [stderr]     |
[INFO] [stderr] 134 |             .fold(true, |acc, x| *x == self.knots[self.knots.len() - 1] && acc);
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/bspline.rs:143:16
[INFO] [stderr]     |
[INFO] [stderr] 143 |               if !(left_clamped && i < self.degree)
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 144 | |                 && !(right_clamped && i >= self.knots_required() - 1 - self.degree) {
[INFO] [stderr]     | |___________________________________________________________________________________^ help: try: `!(right_clamped && i >= self.knots_required() - 1 - self.degree || left_clamped && i < self.degree)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/bspline.rs:156:18
[INFO] [stderr]     |
[INFO] [stderr] 156 |         for j in 0..self.degree + 1 {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^ help: use: `0..=self.degree`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/bspline.rs:199:65
[INFO] [stderr]     |
[INFO] [stderr] 199 |         } else if nearest.0 == self.control_points.len() - 2 && nearest.2 == 1.0 {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(nearest.2 - 1.0).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/bspline.rs:199:65
[INFO] [stderr]     |
[INFO] [stderr] 199 |         } else if nearest.0 == self.control_points.len() - 2 && nearest.2 == 1.0 {
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/display_curve.rs:34:9
[INFO] [stderr]    |
[INFO] [stderr] 34 | /         let break_points_vbo;
[INFO] [stderr] 35 | |         if !curve.control_points.is_empty() {
[INFO] [stderr] 36 | |             let step_size = 0.01;
[INFO] [stderr] 37 | |             let t_range = curve.knot_domain();
[INFO] [stderr] ...  |
[INFO] [stderr] 52 | |             break_points_vbo = VertexBuffer::empty(display, 10).unwrap();
[INFO] [stderr] 53 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let break_points_vbo = if !curve.control_points.is_empty() { ..; VertexBuffer::new(display, &break_points[..]).unwrap() } else { ..; VertexBuffer::empty(display, 10).unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_curve.rs:42:22
[INFO] [stderr]    |
[INFO] [stderr] 42 |             for s in 0..steps + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_curve.rs:95:22
[INFO] [stderr]    |
[INFO] [stderr] 95 |             for s in 0..steps + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/display_curve.rs:187:22
[INFO] [stderr]     |
[INFO] [stderr] 187 |             for s in 0..steps + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/display_curve3d.rs:29:9
[INFO] [stderr]    |
[INFO] [stderr] 29 | /         let curve_points_vbo;
[INFO] [stderr] 30 | |         if !curve.control_points.is_empty() {
[INFO] [stderr] 31 | |             let step_size = 0.01;
[INFO] [stderr] 32 | |             let t_range = curve.knot_domain();
[INFO] [stderr] ...  |
[INFO] [stderr] 44 | |             curve_points_vbo = VertexBuffer::empty(display, 10).unwrap();
[INFO] [stderr] 45 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let curve_points_vbo = if !curve.control_points.is_empty() { ..; VertexBuffer::new(display, &points[..]).unwrap() } else { ..; VertexBuffer::empty(display, 10).unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_curve3d.rs:37:22
[INFO] [stderr]    |
[INFO] [stderr] 37 |             for s in 0..steps + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/display_curve3d.rs:124:22
[INFO] [stderr]     |
[INFO] [stderr] 124 |             for s in 0..steps + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf.rs:55:36
[INFO] [stderr]    |
[INFO] [stderr] 55 |         let mut t_vals_u: Vec<_> = (0..isoline_start_steps_u + 1).map(|us| isoline_step_size * us as f32 + t_range_u.0)
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=isoline_start_steps_u)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/display_surf.rs:56:20
[INFO] [stderr]    |
[INFO] [stderr] 56 |             .chain(abscissa_u.iter().map(|x| *x))
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `abscissa_u.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf.rs:64:36
[INFO] [stderr]    |
[INFO] [stderr] 64 |         let mut t_vals_v: Vec<_> = (0..isoline_start_steps_v + 1).map(|vs| isoline_step_size * vs as f32 + t_range_v.0)
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=isoline_start_steps_v)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/display_surf.rs:65:20
[INFO] [stderr]    |
[INFO] [stderr] 65 |             .chain(abscissa_v.iter().map(|x| *x))
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `abscissa_v.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf.rs:73:44
[INFO] [stderr]    |
[INFO] [stderr] 73 |         let mut isoline_u_t_vals: Vec<_> = (0..steps_u + 1).map(|u| step_size * u as f32 + t_range_u.0)
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^ help: use: `(0..=steps_u)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/display_surf.rs:74:20
[INFO] [stderr]    |
[INFO] [stderr] 74 |             .chain(t_vals_u.iter().map(|x| *x)).collect();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t_vals_u.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf.rs:79:44
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let mut isoline_v_t_vals: Vec<_> = (0..steps_v + 1).map(|u| step_size * u as f32 + t_range_v.0)
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^ help: use: `(0..=steps_v)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/display_surf.rs:80:20
[INFO] [stderr]    |
[INFO] [stderr] 80 |             .chain(t_vals_v.iter().map(|x| *x)).collect();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `t_vals_v.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/display_surf.rs:129:19
[INFO] [stderr]     |
[INFO] [stderr] 129 |         for vs in 0..isoline_start_steps_v + 1 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=isoline_start_steps_v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/display_surf.rs:131:70
[INFO] [stderr]     |
[INFO] [stderr] 131 |             if !abscissa_v.iter().chain(surf.knots_v.iter()).any(|x| *x == v) {
[INFO] [stderr]     |                                                                      ^^^^^^^ help: consider comparing them within some error: `(*x - v).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/display_surf.rs:131:70
[INFO] [stderr]     |
[INFO] [stderr] 131 |             if !abscissa_v.iter().chain(surf.knots_v.iter()).any(|x| *x == v) {
[INFO] [stderr]     |                                                                      ^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/display_surf.rs:141:19
[INFO] [stderr]     |
[INFO] [stderr] 141 |         for us in 0..isoline_start_steps_u + 1 {
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=isoline_start_steps_u`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/display_surf.rs:143:70
[INFO] [stderr]     |
[INFO] [stderr] 143 |             if !abscissa_u.iter().chain(surf.knots_u.iter()).any(|x| *x == u) {
[INFO] [stderr]     |                                                                      ^^^^^^^ help: consider comparing them within some error: `(*x - u).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/display_surf.rs:143:70
[INFO] [stderr]     |
[INFO] [stderr] 143 |             if !abscissa_u.iter().chain(surf.knots_u.iter()).any(|x| *x == u) {
[INFO] [stderr]     |                                                                      ^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/display_surf_interp.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 |             for s in 0..steps + 1 {
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: use: `0..=steps`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/display_surf_interp.rs:117:57
[INFO] [stderr]     |
[INFO] [stderr] 117 |     let basis_u = BSplineBasis::new(curves[0].degree(), curves[0].knots().map(|x| *x).collect());
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `curves[0].knots().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/display_surf_interp.rs:147:9
[INFO] [stderr]     |
[INFO] [stderr] 147 |         x = x + 1;
[INFO] [stderr]     |         ^^^^^^^^^ help: replace it with: `x += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/bspline_basis.rs:70:49
[INFO] [stderr]    |
[INFO] [stderr] 70 |                   } else if t < self.knots[i + 1] {
[INFO] [stderr]    |  _________________________________________________^
[INFO] [stderr] 71 | |                     1.0
[INFO] [stderr] 72 | |                 } else {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/bspline_basis.rs:68:70
[INFO] [stderr]    |
[INFO] [stderr] 68 |                   if i == self.modified_knot && t <= self.knots[i + 1] {
[INFO] [stderr]    |  ______________________________________________________________________^
[INFO] [stderr] 69 | |                     1.0
[INFO] [stderr] 70 | |                 } else if t < self.knots[i + 1] {
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/bspline_basis.rs:100:16
[INFO] [stderr]     |
[INFO] [stderr] 100 |             if !(clamped && i < degree) && !(clamped && i >= knots_required - 1 - degree) {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 100 |             if i >= degree && i < knots_required - 1 - degree || !clamped {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 100 |             if !(clamped && i >= knots_required - 1 - degree || clamped && i < degree) {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 32
[INFO] [stderr]    --> src/main.rs:116:1
[INFO] [stderr]     |
[INFO] [stderr] 116 | / fn main() {
[INFO] [stderr] 117 | |     let args = Docopt::new(USAGE).and_then(|d| d.parse()).unwrap_or_else(|e| e.exit());
[INFO] [stderr] 118 | |     let target_gl_versions = glutin::GlRequest::GlThenGles {
[INFO] [stderr] 119 | |         opengl_version: (3, 3),
[INFO] [stderr] ...   |
[INFO] [stderr] 415 | |     }
[INFO] [stderr] 416 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:180:26
[INFO] [stderr]     |
[INFO] [stderr] 180 |       let shader_program = program!(&display,
[INFO] [stderr]     |  __________________________^
[INFO] [stderr] 181 | |         330 => {
[INFO] [stderr] 182 | |             vertex: "
[INFO] [stderr] 183 | |                 #version 330 core
[INFO] [stderr] ...   |
[INFO] [stderr] 198 | |         },
[INFO] [stderr] 199 | |     ).unwrap();
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 9 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `spline-viewer`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "6e67e1be08183a7a510dfc1164649adc7145af141936bbc8d5fc2d22d8053f41"`
[INFO] running `"docker" "rm" "-f" "6e67e1be08183a7a510dfc1164649adc7145af141936bbc8d5fc2d22d8053f41"`
[INFO] [stdout] 6e67e1be08183a7a510dfc1164649adc7145af141936bbc8d5fc2d22d8053f41