[INFO] updating cached repository Turbo87/multifix [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Turbo87/multifix [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Turbo87/multifix" "work/ex/clippy-test-run/sources/stable/gh/Turbo87/multifix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Turbo87/multifix'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Turbo87/multifix" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Turbo87/multifix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Turbo87/multifix'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 08fd7e148d453ef026e56dd05c9067dd007a639c [INFO] sha for GitHub repo Turbo87/multifix: 08fd7e148d453ef026e56dd05c9067dd007a639c [INFO] validating manifest of Turbo87/multifix on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Turbo87/multifix on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Turbo87/multifix [INFO] finished frobbing Turbo87/multifix [INFO] frobbed toml for Turbo87/multifix written to work/ex/clippy-test-run/sources/stable/gh/Turbo87/multifix/Cargo.toml [INFO] started frobbing Turbo87/multifix [INFO] finished frobbing Turbo87/multifix [INFO] frobbed toml for Turbo87/multifix written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Turbo87/multifix/Cargo.toml [INFO] crate Turbo87/multifix has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Turbo87/multifix against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Turbo87/multifix:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a158d51f3602498c6cede9ef67ce99ac7b8febfc0ec0d29234c9d91f7b4ecb50 [INFO] running `"docker" "start" "-a" "a158d51f3602498c6cede9ef67ce99ac7b8febfc0ec0d29234c9d91f7b4ecb50"` [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Checking webbrowser v0.3.1 [INFO] [stderr] Compiling ncurses v5.97.0 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking num-complex v0.2.1 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Compiling enumset_derive v0.2.0 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking enumset v0.3.14 [INFO] [stderr] Checking cursive v0.10.0 [INFO] [stderr] Checking os_type v2.2.0 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking human-panic v1.0.1 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Checking multifix v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | let stdout = match stdout.is_empty() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 44 | | false => format!("\n\nstdout: {}", stdout.trim()), [INFO] [stderr] 45 | | true => stdout, [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if stdout.is_empty() { stdout } else { format!("\n\nstdout: {}", stdout.trim()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | let stderr = match stderr.is_empty() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 50 | | false => format!("\n\nstderr: {}", stderr.trim()), [INFO] [stderr] 51 | | true => stderr, [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if stderr.is_empty() { stderr } else { format!("\n\nstderr: {}", stderr.trim()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | let stdout = match stdout.is_empty() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 44 | | false => format!("\n\nstdout: {}", stdout.trim()), [INFO] [stderr] 45 | | true => stdout, [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if stdout.is_empty() { stdout } else { format!("\n\nstdout: {}", stdout.trim()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | let stderr = match stderr.is_empty() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 50 | | false => format!("\n\nstderr: {}", stderr.trim()), [INFO] [stderr] 51 | | true => stderr, [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if stderr.is_empty() { stderr } else { format!("\n\nstderr: {}", stderr.trim()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match output.status.success() { [INFO] [stderr] 66 | | true => Ok(output), [INFO] [stderr] 67 | | false => Err(FailedExecution::from_output(output).into()), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if output.status.success() { Ok(output) } else { Err(FailedExecution::from_output(output).into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/project_select.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn show_list<'a>(input: &'a Vec<(&'a &'a PathBuf, String)>) -> Vec<&'a (&'a &'a PathBuf, String)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&'a &'a PathBuf, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | .map(|it| PathBuf::from(it)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match output.status.success() { [INFO] [stderr] 66 | | true => Ok(output), [INFO] [stderr] 67 | | false => Err(FailedExecution::from_output(output).into()), [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if output.status.success() { Ok(output) } else { Err(FailedExecution::from_output(output).into()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/project_select.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn show_list<'a>(input: &'a Vec<(&'a &'a PathBuf, String)>) -> Vec<&'a (&'a &'a PathBuf, String)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&'a &'a PathBuf, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:150:43 [INFO] [stderr] | [INFO] [stderr] 150 | static ref RE: Regex = Regex::new(r"sudo: false").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:164:35 [INFO] [stderr] | [INFO] [stderr] 164 | fn add_labels_and_sort<'a>(paths: &'a Vec<&'a PathBuf>, root_path: &PathBuf) -> Vec<(&'a &'a PathBuf, String)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[&'a PathBuf]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | .map(|it| PathBuf::from(it)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:150:43 [INFO] [stderr] | [INFO] [stderr] 150 | static ref RE: Regex = Regex::new(r"sudo: false").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:164:35 [INFO] [stderr] | [INFO] [stderr] 164 | fn add_labels_and_sort<'a>(paths: &'a Vec<&'a PathBuf>, root_path: &PathBuf) -> Vec<(&'a &'a PathBuf, String)> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[&'a PathBuf]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.36s [INFO] running `"docker" "inspect" "a158d51f3602498c6cede9ef67ce99ac7b8febfc0ec0d29234c9d91f7b4ecb50"` [INFO] running `"docker" "rm" "-f" "a158d51f3602498c6cede9ef67ce99ac7b8febfc0ec0d29234c9d91f7b4ecb50"` [INFO] [stdout] a158d51f3602498c6cede9ef67ce99ac7b8febfc0ec0d29234c9d91f7b4ecb50