[INFO] updating cached repository Tubaias/perspective_projection_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Tubaias/perspective_projection_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Tubaias/perspective_projection_rust" "work/ex/clippy-test-run/sources/stable/gh/Tubaias/perspective_projection_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tubaias/perspective_projection_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Tubaias/perspective_projection_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tubaias/perspective_projection_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tubaias/perspective_projection_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 01c156d8fea5c76a6e73550d75f1f2fc9b434f36 [INFO] sha for GitHub repo Tubaias/perspective_projection_rust: 01c156d8fea5c76a6e73550d75f1f2fc9b434f36 [INFO] validating manifest of Tubaias/perspective_projection_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Tubaias/perspective_projection_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Tubaias/perspective_projection_rust [INFO] finished frobbing Tubaias/perspective_projection_rust [INFO] frobbed toml for Tubaias/perspective_projection_rust written to work/ex/clippy-test-run/sources/stable/gh/Tubaias/perspective_projection_rust/Cargo.toml [INFO] started frobbing Tubaias/perspective_projection_rust [INFO] finished frobbing Tubaias/perspective_projection_rust [INFO] frobbed toml for Tubaias/perspective_projection_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tubaias/perspective_projection_rust/Cargo.toml [INFO] crate Tubaias/perspective_projection_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Tubaias/perspective_projection_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Tubaias/perspective_projection_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] efb6d8d78fb145f20d12195c9ef84bb3c4252a6a940fca34aaa87fd8bbf4add8 [INFO] running `"docker" "start" "-a" "efb6d8d78fb145f20d12195c9ef84bb3c4252a6a940fca34aaa87fd8bbf4add8"` [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking x11-dl v2.17.3 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking gfx_device_gl v0.15.1 [INFO] [stderr] Checking glutin v0.12.2 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.2 [INFO] [stderr] Checking piston-gfx_texture v0.31.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.50.0 [INFO] [stderr] Checking piston_window v0.77.0 [INFO] [stderr] Checking asdf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:51 [INFO] [stderr] | [INFO] [stderr] 30 | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:54 [INFO] [stderr] | [INFO] [stderr] 30 | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:57 [INFO] [stderr] | [INFO] [stderr] 30 | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:60 [INFO] [stderr] | [INFO] [stderr] 30 | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:51 [INFO] [stderr] | [INFO] [stderr] 30 | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:54 [INFO] [stderr] | [INFO] [stderr] 30 | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:57 [INFO] [stderr] | [INFO] [stderr] 30 | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:30:60 [INFO] [stderr] | [INFO] [stderr] 30 | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | println!("{a}", a = 1000000000.0 / elaps.subsec_nanos() as f32); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | return elements; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `elements` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Rect` [INFO] [stderr] --> src/main.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | struct Rect { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | / match e { [INFO] [stderr] 30 | | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] 31 | | rectangle([r, g, b, a], [x, y, h, w], context.transform, graphics); [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *e { [INFO] [stderr] 30 | Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:73 [INFO] [stderr] | [INFO] [stderr] 92 | let rect = Shape::Rectangle(color_r, color_g, color_b, 1.0, index_x as f64, index_y as f64, pixelsize, pixelsize); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(index_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:89 [INFO] [stderr] | [INFO] [stderr] 92 | let rect = Shape::Rectangle(color_r, color_g, color_b, 1.0, index_x as f64, index_y as f64, pixelsize, pixelsize); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(index_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:37:33 [INFO] [stderr] | [INFO] [stderr] 37 | println!("{a}", a = 1000000000.0 / elaps.subsec_nanos() as f32); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `1_000_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | return elements; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `elements` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Rect` [INFO] [stderr] --> src/main.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | struct Rect { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | / match e { [INFO] [stderr] 30 | | &Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] 31 | | rectangle([r, g, b, a], [x, y, h, w], context.transform, graphics); [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *e { [INFO] [stderr] 30 | Shape::Rectangle(r, g, b, a, x, y, h, w) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:73 [INFO] [stderr] | [INFO] [stderr] 92 | let rect = Shape::Rectangle(color_r, color_g, color_b, 1.0, index_x as f64, index_y as f64, pixelsize, pixelsize); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(index_x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:89 [INFO] [stderr] | [INFO] [stderr] 92 | let rect = Shape::Rectangle(color_r, color_g, color_b, 1.0, index_x as f64, index_y as f64, pixelsize, pixelsize); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(index_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 59.15s [INFO] running `"docker" "inspect" "efb6d8d78fb145f20d12195c9ef84bb3c4252a6a940fca34aaa87fd8bbf4add8"` [INFO] running `"docker" "rm" "-f" "efb6d8d78fb145f20d12195c9ef84bb3c4252a6a940fca34aaa87fd8bbf4add8"` [INFO] [stdout] efb6d8d78fb145f20d12195c9ef84bb3c4252a6a940fca34aaa87fd8bbf4add8