[INFO] updating cached repository TuBieJun/stat_mut_sampleratio [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TuBieJun/stat_mut_sampleratio [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TuBieJun/stat_mut_sampleratio" "work/ex/clippy-test-run/sources/stable/gh/TuBieJun/stat_mut_sampleratio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TuBieJun/stat_mut_sampleratio'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TuBieJun/stat_mut_sampleratio" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TuBieJun/stat_mut_sampleratio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TuBieJun/stat_mut_sampleratio'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0163827d32c94da365c78519e8ce537f7b7a211c [INFO] sha for GitHub repo TuBieJun/stat_mut_sampleratio: 0163827d32c94da365c78519e8ce537f7b7a211c [INFO] validating manifest of TuBieJun/stat_mut_sampleratio on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TuBieJun/stat_mut_sampleratio on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TuBieJun/stat_mut_sampleratio [INFO] finished frobbing TuBieJun/stat_mut_sampleratio [INFO] frobbed toml for TuBieJun/stat_mut_sampleratio written to work/ex/clippy-test-run/sources/stable/gh/TuBieJun/stat_mut_sampleratio/Cargo.toml [INFO] started frobbing TuBieJun/stat_mut_sampleratio [INFO] finished frobbing TuBieJun/stat_mut_sampleratio [INFO] frobbed toml for TuBieJun/stat_mut_sampleratio written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TuBieJun/stat_mut_sampleratio/Cargo.toml [INFO] crate TuBieJun/stat_mut_sampleratio has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TuBieJun/stat_mut_sampleratio against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TuBieJun/stat_mut_sampleratio:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6793cf837f4d608cb62b326184176ca71f22c4f770e1944bdfd94dcd17263a01 [INFO] running `"docker" "start" "-a" "6793cf837f4d608cb62b326184176ca71f22c4f770e1944bdfd94dcd17263a01"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking stat_germline_pos v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `SubCommand` [INFO] [stderr] --> src/main.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | use clap::{Arg, App, SubCommand}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let mut f = File::open(vcf_l) [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `D_germline` should have a snake case name such as `d_germline` [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | D_germline:&mut HashMap>) -> u32 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:37:38 [INFO] [stderr] | [INFO] [stderr] 37 | if !vcf_info.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | fre = (support as f64)/(depth as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(support)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | fre = (support as f64)/(depth as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | / let mut n_index:usize; [INFO] [stderr] 59 | | if info_l[9].contains("0/1") { [INFO] [stderr] 60 | | n_index = 10; [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | else { [INFO] [stderr] 63 | | n_index = 9; [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let n_index = if info_l[9].contains("0/1") { 10 } else { 9 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:68:59 [INFO] [stderr] | [INFO] [stderr] 68 | let temp:Vec<&str> = dp_info[1].split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | / if D_germline.contains_key(&k) { [INFO] [stderr] 80 | | *D_germline.get_mut(&k).unwrap() [INFO] [stderr] 81 | | .entry(panel_s).or_insert(0) += 1; [INFO] [stderr] 82 | | } [INFO] [stderr] ... | [INFO] [stderr] 86 | | D_germline.insert(k, panel_d); [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____________________^ help: consider using: `D_germline.entry(k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:96:39 [INFO] [stderr] | [INFO] [stderr] 96 | fn out_info(out_file:&str, panel_list:&Vec, D_germline:&HashMap>, sample_num_list:&Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:96:120 [INFO] [stderr] | [INFO] [stderr] 96 | fn out_info(out_file:&str, panel_list:&Vec, D_germline:&HashMap>, sample_num_list:&Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `D_germline` should have a snake case name such as `d_germline` [INFO] [stderr] --> src/main.rs:96:53 [INFO] [stderr] | [INFO] [stderr] 96 | fn out_info(out_file:&str, panel_list:&Vec, D_germline:&HashMap>, sample_num_list:&Vec) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | writer.write(header.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:41 [INFO] [stderr] | [INFO] [stderr] 106 | temp.push(format!("{}", (*v.get(panel).unwrap() as f64 / sample_num_list[i] as f64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*v.get(panel).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:73 [INFO] [stderr] | [INFO] [stderr] 106 | temp.push(format!("{}", (*v.get(panel).unwrap() as f64 / sample_num_list[i] as f64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sample_num_list[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | writer.write(info.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `D_germline` should have a snake case name such as `d_germline` [INFO] [stderr] --> src/main.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | let mut D_germline:HashMap> = HashMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let mut f = File::open(vcf_l) [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `D_germline` should have a snake case name such as `d_germline` [INFO] [stderr] --> src/main.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | D_germline:&mut HashMap>) -> u32 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:37:38 [INFO] [stderr] | [INFO] [stderr] 37 | if !vcf_info.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | fre = (support as f64)/(depth as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(support)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:53:48 [INFO] [stderr] | [INFO] [stderr] 53 | fre = (support as f64)/(depth as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(depth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | / let mut n_index:usize; [INFO] [stderr] 59 | | if info_l[9].contains("0/1") { [INFO] [stderr] 60 | | n_index = 10; [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | else { [INFO] [stderr] 63 | | n_index = 9; [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let n_index = if info_l[9].contains("0/1") { 10 } else { 9 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:68:59 [INFO] [stderr] | [INFO] [stderr] 68 | let temp:Vec<&str> = dp_info[1].split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/main.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | / if D_germline.contains_key(&k) { [INFO] [stderr] 80 | | *D_germline.get_mut(&k).unwrap() [INFO] [stderr] 81 | | .entry(panel_s).or_insert(0) += 1; [INFO] [stderr] 82 | | } [INFO] [stderr] ... | [INFO] [stderr] 86 | | D_germline.insert(k, panel_d); [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____________________^ help: consider using: `D_germline.entry(k)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:96:39 [INFO] [stderr] | [INFO] [stderr] 96 | fn out_info(out_file:&str, panel_list:&Vec, D_germline:&HashMap>, sample_num_list:&Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:96:120 [INFO] [stderr] | [INFO] [stderr] 96 | fn out_info(out_file:&str, panel_list:&Vec, D_germline:&HashMap>, sample_num_list:&Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable `D_germline` should have a snake case name such as `d_germline` [INFO] [stderr] --> src/main.rs:96:53 [INFO] [stderr] | [INFO] [stderr] 96 | fn out_info(out_file:&str, panel_list:&Vec, D_germline:&HashMap>, sample_num_list:&Vec) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | writer.write(header.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:41 [INFO] [stderr] | [INFO] [stderr] 106 | temp.push(format!("{}", (*v.get(panel).unwrap() as f64 / sample_num_list[i] as f64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(*v.get(panel).unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:73 [INFO] [stderr] | [INFO] [stderr] 106 | temp.push(format!("{}", (*v.get(panel).unwrap() as f64 / sample_num_list[i] as f64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(sample_num_list[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | writer.write(info.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `D_germline` should have a snake case name such as `d_germline` [INFO] [stderr] --> src/main.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | let mut D_germline:HashMap> = HashMap::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.24s [INFO] running `"docker" "inspect" "6793cf837f4d608cb62b326184176ca71f22c4f770e1944bdfd94dcd17263a01"` [INFO] running `"docker" "rm" "-f" "6793cf837f4d608cb62b326184176ca71f22c4f770e1944bdfd94dcd17263a01"` [INFO] [stdout] 6793cf837f4d608cb62b326184176ca71f22c4f770e1944bdfd94dcd17263a01