[INFO] updating cached repository TrueXPixels/idle_game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TrueXPixels/idle_game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TrueXPixels/idle_game" "work/ex/clippy-test-run/sources/stable/gh/TrueXPixels/idle_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TrueXPixels/idle_game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TrueXPixels/idle_game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TrueXPixels/idle_game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TrueXPixels/idle_game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 005ff78adb8a0a1c73322cbea34a0a00f62c31e0 [INFO] sha for GitHub repo TrueXPixels/idle_game: 005ff78adb8a0a1c73322cbea34a0a00f62c31e0 [INFO] validating manifest of TrueXPixels/idle_game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TrueXPixels/idle_game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TrueXPixels/idle_game [INFO] finished frobbing TrueXPixels/idle_game [INFO] frobbed toml for TrueXPixels/idle_game written to work/ex/clippy-test-run/sources/stable/gh/TrueXPixels/idle_game/Cargo.toml [INFO] started frobbing TrueXPixels/idle_game [INFO] finished frobbing TrueXPixels/idle_game [INFO] frobbed toml for TrueXPixels/idle_game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TrueXPixels/idle_game/Cargo.toml [INFO] crate TrueXPixels/idle_game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TrueXPixels/idle_game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TrueXPixels/idle_game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1a86c33892e24f0654361b0418d607ef6038c4ee663154f460548403d1abb36 [INFO] running `"docker" "start" "-a" "a1a86c33892e24f0654361b0418d607ef6038c4ee663154f460548403d1abb36"` [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking x11-dl v2.17.5 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking idle_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let data = User { name: name, balance: 100 }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | println!(""); // Add Line Space [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | let data = User { name: name, balance: 100 }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:122:5 [INFO] [stderr] | [INFO] [stderr] 122 | println!(""); // Add Line Space [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/main.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(u) = e.update_args() { [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `btn` [INFO] [stderr] --> src/main.rs:115:27 [INFO] [stderr] | [INFO] [stderr] 115 | fn pressed(&mut self, btn: &Button) { [INFO] [stderr] | ^^^ help: consider using `_btn` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/main.rs:154:21 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(u) = e.update_args() { [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `btn` [INFO] [stderr] --> src/main.rs:115:27 [INFO] [stderr] | [INFO] [stderr] 115 | fn pressed(&mut self, btn: &Button) { [INFO] [stderr] | ^^^ help: consider using `_btn` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `user` [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | user: User, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `user` [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | user: User, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | file.unwrap().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `BLURPLE` should have a snake case name such as `blurple` [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | let BLURPLE: [f32; 4] = [0.447, 0.537, 0.854, 1.0]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:143:22 [INFO] [stderr] | [INFO] [stderr] 143 | balance: user_info.balance.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_info.balance` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | file.unwrap().read_to_string(&mut buffer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: variable `BLURPLE` should have a snake case name such as `blurple` [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | let BLURPLE: [f32; 4] = [0.447, 0.537, 0.854, 1.0]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:143:22 [INFO] [stderr] | [INFO] [stderr] 143 | balance: user_info.balance.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_info.balance` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 45.11s [INFO] running `"docker" "inspect" "a1a86c33892e24f0654361b0418d607ef6038c4ee663154f460548403d1abb36"` [INFO] running `"docker" "rm" "-f" "a1a86c33892e24f0654361b0418d607ef6038c4ee663154f460548403d1abb36"` [INFO] [stdout] a1a86c33892e24f0654361b0418d607ef6038c4ee663154f460548403d1abb36