[INFO] updating cached repository TrueXPixels/Rust_Bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TrueXPixels/Rust_Bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TrueXPixels/Rust_Bot" "work/ex/clippy-test-run/sources/stable/gh/TrueXPixels/Rust_Bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TrueXPixels/Rust_Bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TrueXPixels/Rust_Bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TrueXPixels/Rust_Bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TrueXPixels/Rust_Bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 292d78aff617342edf7ce18f9dba266ff997a5bc [INFO] sha for GitHub repo TrueXPixels/Rust_Bot: 292d78aff617342edf7ce18f9dba266ff997a5bc [INFO] validating manifest of TrueXPixels/Rust_Bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TrueXPixels/Rust_Bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TrueXPixels/Rust_Bot [INFO] finished frobbing TrueXPixels/Rust_Bot [INFO] frobbed toml for TrueXPixels/Rust_Bot written to work/ex/clippy-test-run/sources/stable/gh/TrueXPixels/Rust_Bot/Cargo.toml [INFO] started frobbing TrueXPixels/Rust_Bot [INFO] finished frobbing TrueXPixels/Rust_Bot [INFO] frobbed toml for TrueXPixels/Rust_Bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TrueXPixels/Rust_Bot/Cargo.toml [INFO] crate TrueXPixels/Rust_Bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TrueXPixels/Rust_Bot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TrueXPixels/Rust_Bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50e34a78095f3093be93f1e3b0be3c9d4beb113f1a7bfbd178554b533b98fd8a [INFO] running `"docker" "start" "-a" "50e34a78095f3093be93f1e3b0be3c9d4beb113f1a7bfbd178554b533b98fd8a"` [INFO] [stderr] Checking base64 v0.8.0 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Compiling quote v0.6.2 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Compiling syn v0.14.0 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking evzht9h3nznqzwl v0.0.3 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Compiling serde_derive v1.0.63 [INFO] [stderr] Checking serenity v0.5.3 [INFO] [stderr] Checking discord_bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:53:8 [INFO] [stderr] | [INFO] [stderr] 53 | if message_content.len() == 0 { // Run if the whitespace after the command is less than 2 characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `message_content.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:60:31 [INFO] [stderr] | [INFO] [stderr] 60 | .description(&format!("**NOTE:** This command displays information relating to the **Rust** programming language, for a bot commands list type **`rb!commands`**\n\n**Usage: `rb!help topic`**")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"**NOTE:** This command displays information relating to the **Rust** programming language, for a bot commands list type **`rb!commands`**\n\n**Usage: `rb!help topic`**".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | let response = match message_content.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `message_content.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:168:31 [INFO] [stderr] | [INFO] [stderr] 168 | let game = Game::playing(&format!("{}", content)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `content.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:53:8 [INFO] [stderr] | [INFO] [stderr] 53 | if message_content.len() == 0 { // Run if the whitespace after the command is less than 2 characters [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `message_content.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:60:31 [INFO] [stderr] | [INFO] [stderr] 60 | .description(&format!("**NOTE:** This command displays information relating to the **Rust** programming language, for a bot commands list type **`rb!commands`**\n\n**Usage: `rb!help topic`**")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"**NOTE:** This command displays information relating to the **Rust** programming language, for a bot commands list type **`rb!commands`**\n\n**Usage: `rb!help topic`**".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | let response = match message_content.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `message_content.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:168:31 [INFO] [stderr] | [INFO] [stderr] 168 | let game = Game::playing(&format!("{}", content)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `content.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `"docker" "inspect" "50e34a78095f3093be93f1e3b0be3c9d4beb113f1a7bfbd178554b533b98fd8a"` [INFO] running `"docker" "rm" "-f" "50e34a78095f3093be93f1e3b0be3c9d4beb113f1a7bfbd178554b533b98fd8a"` [INFO] [stdout] 50e34a78095f3093be93f1e3b0be3c9d4beb113f1a7bfbd178554b533b98fd8a