[INFO] updating cached repository TrevorDev/rust_test_project [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TrevorDev/rust_test_project [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TrevorDev/rust_test_project" "work/ex/clippy-test-run/sources/stable/gh/TrevorDev/rust_test_project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TrevorDev/rust_test_project'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TrevorDev/rust_test_project" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TrevorDev/rust_test_project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TrevorDev/rust_test_project'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1fdf6a487e93bf6f194a97e307c3e4d80173f28b [INFO] sha for GitHub repo TrevorDev/rust_test_project: 1fdf6a487e93bf6f194a97e307c3e4d80173f28b [INFO] validating manifest of TrevorDev/rust_test_project on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TrevorDev/rust_test_project on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TrevorDev/rust_test_project [INFO] finished frobbing TrevorDev/rust_test_project [INFO] frobbed toml for TrevorDev/rust_test_project written to work/ex/clippy-test-run/sources/stable/gh/TrevorDev/rust_test_project/Cargo.toml [INFO] started frobbing TrevorDev/rust_test_project [INFO] finished frobbing TrevorDev/rust_test_project [INFO] frobbed toml for TrevorDev/rust_test_project written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TrevorDev/rust_test_project/Cargo.toml [INFO] crate TrevorDev/rust_test_project has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TrevorDev/rust_test_project against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TrevorDev/rust_test_project:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07e3104f3baf090d4a20e77ef79cc51d857c3e0531d5a925a2008fb5485e8c08 [INFO] running `"docker" "start" "-a" "07e3104f3baf090d4a20e77ef79cc51d857c3e0531d5a925a2008fb5485e8c08"` [INFO] [stderr] Checking rust_calculater v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/print.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | fn split_by_spaces(s: &String) -> Vec<&str>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/print.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | split_words.push( &s[start..i+1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `start..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/print.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | fn split_by_spaces(s: &String) -> Vec<&str>{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/print.rs:27:34 [INFO] [stderr] | [INFO] [stderr] 27 | split_words.push( &s[start..i+1]); [INFO] [stderr] | ^^^^^^^^^^ help: use: `start..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.86s [INFO] running `"docker" "inspect" "07e3104f3baf090d4a20e77ef79cc51d857c3e0531d5a925a2008fb5485e8c08"` [INFO] running `"docker" "rm" "-f" "07e3104f3baf090d4a20e77ef79cc51d857c3e0531d5a925a2008fb5485e8c08"` [INFO] [stdout] 07e3104f3baf090d4a20e77ef79cc51d857c3e0531d5a925a2008fb5485e8c08