[INFO] updating cached repository ToucheSir/s-expressiveness [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ToucheSir/s-expressiveness [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ToucheSir/s-expressiveness" "work/ex/clippy-test-run/sources/stable/gh/ToucheSir/s-expressiveness"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ToucheSir/s-expressiveness'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ToucheSir/s-expressiveness" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToucheSir/s-expressiveness"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToucheSir/s-expressiveness'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 92e72d698b324a3db6851034deebe4c4a40810c4 [INFO] sha for GitHub repo ToucheSir/s-expressiveness: 92e72d698b324a3db6851034deebe4c4a40810c4 [INFO] validating manifest of ToucheSir/s-expressiveness on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ToucheSir/s-expressiveness on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ToucheSir/s-expressiveness [INFO] finished frobbing ToucheSir/s-expressiveness [INFO] frobbed toml for ToucheSir/s-expressiveness written to work/ex/clippy-test-run/sources/stable/gh/ToucheSir/s-expressiveness/Cargo.toml [INFO] started frobbing ToucheSir/s-expressiveness [INFO] finished frobbing ToucheSir/s-expressiveness [INFO] frobbed toml for ToucheSir/s-expressiveness written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToucheSir/s-expressiveness/Cargo.toml [INFO] crate ToucheSir/s-expressiveness has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ToucheSir/s-expressiveness against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ToucheSir/s-expressiveness:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51bc964608cdc0124b8ee673335b3bcfd81a049c531b1d8b064e91670b51c854 [INFO] running `"docker" "start" "-a" "51bc964608cdc0124b8ee673335b3bcfd81a049c531b1d8b064e91670b51c854"` [INFO] [stderr] Checking yetanotherlisp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | tail: tail, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cell.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | tail: tail, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tail` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return ch as char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ch as char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return ch as char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ch as char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | fn new(input: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | input: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the `res @ _` pattern can be written as just `res` [INFO] [stderr] --> src/parser.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | res @ _ => res, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `res @ _` pattern can be written as just `res` [INFO] [stderr] --> src/parser.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | res @ _ => res, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / loop { [INFO] [stderr] 80 | | if let Some(idx) = s_exp(&mut input, &mut output, &mut buf, &mut storage, &mut env) { [INFO] [stderr] 81 | | print_exp(idx, &mut storage, &env); [INFO] [stderr] 82 | | match eval(idx, &mut storage, &mut env, &ns) { [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(idx) = s_exp(&mut input, &mut output, &mut buf, &mut storage, &mut env) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: The function/method `print_exp` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | print_exp(idx, &mut storage, &env); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | fn new(input: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | input: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the `res @ _` pattern can be written as just `res` [INFO] [stderr] --> src/parser.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | res @ _ => res, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `res @ _` pattern can be written as just `res` [INFO] [stderr] --> src/parser.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | res @ _ => res, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | / loop { [INFO] [stderr] 80 | | if let Some(idx) = s_exp(&mut input, &mut output, &mut buf, &mut storage, &mut env) { [INFO] [stderr] 81 | | print_exp(idx, &mut storage, &env); [INFO] [stderr] 82 | | match eval(idx, &mut storage, &mut env, &ns) { [INFO] [stderr] ... | [INFO] [stderr] 99 | | } [INFO] [stderr] 100 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(idx) = s_exp(&mut input, &mut output, &mut buf, &mut storage, &mut env) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: The function/method `print_exp` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | print_exp(idx, &mut storage, &env); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.33s [INFO] running `"docker" "inspect" "51bc964608cdc0124b8ee673335b3bcfd81a049c531b1d8b064e91670b51c854"` [INFO] running `"docker" "rm" "-f" "51bc964608cdc0124b8ee673335b3bcfd81a049c531b1d8b064e91670b51c854"` [INFO] [stdout] 51bc964608cdc0124b8ee673335b3bcfd81a049c531b1d8b064e91670b51c854