[INFO] updating cached repository TotalKrill/snet [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TotalKrill/snet [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TotalKrill/snet" "work/ex/clippy-test-run/sources/stable/gh/TotalKrill/snet"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TotalKrill/snet'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TotalKrill/snet" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TotalKrill/snet"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TotalKrill/snet'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 301ab81fa3ef5d6de4ce10fe7dc75dcdfad29a0f [INFO] sha for GitHub repo TotalKrill/snet: 301ab81fa3ef5d6de4ce10fe7dc75dcdfad29a0f [INFO] validating manifest of TotalKrill/snet on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TotalKrill/snet on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TotalKrill/snet [INFO] finished frobbing TotalKrill/snet [INFO] frobbed toml for TotalKrill/snet written to work/ex/clippy-test-run/sources/stable/gh/TotalKrill/snet/Cargo.toml [INFO] started frobbing TotalKrill/snet [INFO] finished frobbing TotalKrill/snet [INFO] frobbed toml for TotalKrill/snet written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TotalKrill/snet/Cargo.toml [INFO] crate TotalKrill/snet has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TotalKrill/snet against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TotalKrill/snet:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c2d7e7238d7e757443da5c361b8f759ff8c2c410922880eb370380612ce5539 [INFO] running `"docker" "start" "-a" "8c2d7e7238d7e757443da5c361b8f759ff8c2c410922880eb370380612ce5539"` [INFO] [stderr] Checking atomic-option v0.1.2 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking bus v2.0.0 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking serialport v3.0.0 [INFO] [stderr] Checking snet v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:111:6 [INFO] [stderr] | [INFO] [stderr] 111 | matches [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | let matches = App::new("snet") [INFO] [stderr] | ____________________^ [INFO] [stderr] 84 | | .version("1.0") [INFO] [stderr] 85 | | .author("Kristoffer Ödmark") [INFO] [stderr] 86 | | .about("Forward serialport bytes to tcp connections") [INFO] [stderr] ... | [INFO] [stderr] 109 | | ) [INFO] [stderr] 110 | | .get_matches(); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:111:6 [INFO] [stderr] | [INFO] [stderr] 111 | matches [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | let matches = App::new("snet") [INFO] [stderr] | ____________________^ [INFO] [stderr] 84 | | .version("1.0") [INFO] [stderr] 85 | | .author("Kristoffer Ödmark") [INFO] [stderr] 86 | | .about("Forward serialport bytes to tcp connections") [INFO] [stderr] ... | [INFO] [stderr] 109 | | ) [INFO] [stderr] 110 | | .get_matches(); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.49s [INFO] running `"docker" "inspect" "8c2d7e7238d7e757443da5c361b8f759ff8c2c410922880eb370380612ce5539"` [INFO] running `"docker" "rm" "-f" "8c2d7e7238d7e757443da5c361b8f759ff8c2c410922880eb370380612ce5539"` [INFO] [stdout] 8c2d7e7238d7e757443da5c361b8f759ff8c2c410922880eb370380612ce5539