[INFO] updating cached repository Torrencem/braid-crypto [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Torrencem/braid-crypto [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Torrencem/braid-crypto" "work/ex/clippy-test-run/sources/stable/gh/Torrencem/braid-crypto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Torrencem/braid-crypto'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Torrencem/braid-crypto" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Torrencem/braid-crypto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Torrencem/braid-crypto'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 547ecbc167eab92d7dab2ea446b921b053a0567f [INFO] sha for GitHub repo Torrencem/braid-crypto: 547ecbc167eab92d7dab2ea446b921b053a0567f [INFO] validating manifest of Torrencem/braid-crypto on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Torrencem/braid-crypto on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Torrencem/braid-crypto [INFO] finished frobbing Torrencem/braid-crypto [INFO] frobbed toml for Torrencem/braid-crypto written to work/ex/clippy-test-run/sources/stable/gh/Torrencem/braid-crypto/Cargo.toml [INFO] started frobbing Torrencem/braid-crypto [INFO] finished frobbing Torrencem/braid-crypto [INFO] frobbed toml for Torrencem/braid-crypto written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Torrencem/braid-crypto/Cargo.toml [INFO] crate Torrencem/braid-crypto has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Torrencem/braid-crypto against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Torrencem/braid-crypto:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 80a693f1b1d4faea124672d75a1e9e30cce888549ec037677d16f2209f6f9c6d [INFO] running `"docker" "start" "-a" "80a693f1b1d4faea124672d75a1e9e30cce888549ec037677d16f2209f6f9c6d"` [INFO] [stderr] Checking braid-crypto v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/braid/garside.rs:222:22 [INFO] [stderr] | [INFO] [stderr] 222 | GarsideForm {delta_exp: delta_exp, permutations: result} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_exp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/braid/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/braid/garside.rs:222:22 [INFO] [stderr] | [INFO] [stderr] 222 | GarsideForm {delta_exp: delta_exp, permutations: result} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_exp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/braid/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/braid/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/braid/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/braid/random.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | let tmp = self.contents[indx].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.contents[indx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/braid/random.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | let tmp = self.contents[indx].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.contents[indx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/braid/mod.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | for k in (1..n+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/braid/garside.rs:222:22 [INFO] [stderr] | [INFO] [stderr] 222 | GarsideForm {delta_exp: delta_exp, permutations: result} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_exp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/braid/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/braid/garside.rs:255:43 [INFO] [stderr] | [INFO] [stderr] 255 | let expected = Braid::from_sigmas(&vec![3, 3, 2, 1, 3, 2, 2], 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[3, 3, 2, 1, 3, 2, 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/braid/random.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | let tmp = self.contents[indx].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.contents[indx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/braid/random.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | let tmp = self.contents[indx].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.contents[indx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/braid/mod.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | for k in (1..n+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/braid/mod.rs:288:37 [INFO] [stderr] | [INFO] [stderr] 288 | let b1 = Braid::from_sigmas(&vec![1,2], 3); [INFO] [stderr] | ^^^^^^^^^^ help: you can use a slice directly: `&[1,2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/braid/mod.rs:289:37 [INFO] [stderr] | [INFO] [stderr] 289 | let b2 = Braid::from_sigmas(&vec![2,1,2], 3); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[2,1,2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/braid/garside.rs:222:22 [INFO] [stderr] | [INFO] [stderr] 222 | GarsideForm {delta_exp: delta_exp, permutations: result} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delta_exp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/braid/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/braid/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/braid/random.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | let tmp = self.contents[indx].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.contents[indx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/braid/random.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | let tmp = self.contents[indx].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.contents[indx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/braid/mod.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | for k in (1..n+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/braid/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | #[allow(many_single_char_names)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/braid/garside.rs:255:43 [INFO] [stderr] | [INFO] [stderr] 255 | let expected = Braid::from_sigmas(&vec![3, 3, 2, 1, 3, 2, 2], 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[3, 3, 2, 1, 3, 2, 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/braid/random.rs:86:35 [INFO] [stderr] | [INFO] [stderr] 86 | let tmp = self.contents[indx].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.contents[indx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/braid/random.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | let tmp = self.contents[indx].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.contents[indx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/braid/mod.rs:166:18 [INFO] [stderr] | [INFO] [stderr] 166 | for k in (1..n+1).rev() { [INFO] [stderr] | ^^^^^^^^ help: use: `(1..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/braid/mod.rs:288:37 [INFO] [stderr] | [INFO] [stderr] 288 | let b1 = Braid::from_sigmas(&vec![1,2], 3); [INFO] [stderr] | ^^^^^^^^^^ help: you can use a slice directly: `&[1,2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/braid/mod.rs:289:37 [INFO] [stderr] | [INFO] [stderr] 289 | let b2 = Braid::from_sigmas(&vec![2,1,2], 3); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[2,1,2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.13s [INFO] running `"docker" "inspect" "80a693f1b1d4faea124672d75a1e9e30cce888549ec037677d16f2209f6f9c6d"` [INFO] running `"docker" "rm" "-f" "80a693f1b1d4faea124672d75a1e9e30cce888549ec037677d16f2209f6f9c6d"` [INFO] [stdout] 80a693f1b1d4faea124672d75a1e9e30cce888549ec037677d16f2209f6f9c6d