[INFO] updating cached repository ToolsForHumans/shyaml [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ToolsForHumans/shyaml [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ToolsForHumans/shyaml" "work/ex/clippy-test-run/sources/stable/gh/ToolsForHumans/shyaml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ToolsForHumans/shyaml'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ToolsForHumans/shyaml" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToolsForHumans/shyaml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToolsForHumans/shyaml'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb51f3f84609f2be98c868bd8d7da67e0ff0ae4b [INFO] sha for GitHub repo ToolsForHumans/shyaml: cb51f3f84609f2be98c868bd8d7da67e0ff0ae4b [INFO] validating manifest of ToolsForHumans/shyaml on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ToolsForHumans/shyaml on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ToolsForHumans/shyaml [INFO] finished frobbing ToolsForHumans/shyaml [INFO] frobbed toml for ToolsForHumans/shyaml written to work/ex/clippy-test-run/sources/stable/gh/ToolsForHumans/shyaml/Cargo.toml [INFO] started frobbing ToolsForHumans/shyaml [INFO] finished frobbing ToolsForHumans/shyaml [INFO] frobbed toml for ToolsForHumans/shyaml written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ToolsForHumans/shyaml/Cargo.toml [INFO] crate ToolsForHumans/shyaml has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ToolsForHumans/shyaml against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ToolsForHumans/shyaml:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b6a0063b33c14c070f6320fc22371ab8c49d5d520a8b4176372867ec6fafcc2 [INFO] running `"docker" "start" "-a" "2b6a0063b33c14c070f6320fc22371ab8c49d5d520a8b4176372867ec6fafcc2"` [INFO] [stderr] Checking shyaml v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:169:20 [INFO] [stderr] | [INFO] [stderr] 169 | fn prefix_lines(s: &String, prefix: &'static str) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / match value1 { [INFO] [stderr] 198 | | &YValue::Sequence(ref s1) => { [INFO] [stderr] 199 | | match value2.as_sequence() { [INFO] [stderr] 200 | | None => (), [INFO] [stderr] ... | [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 197 | match *value1 { [INFO] [stderr] 198 | YValue::Sequence(ref s1) => { [INFO] [stderr] 199 | match value2.as_sequence() { [INFO] [stderr] 200 | None => (), [INFO] [stderr] 201 | Some(s2) => { [INFO] [stderr] 202 | let mut s2 = s2.iter(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:240:96 [INFO] [stderr] | [INFO] [stderr] 240 | } else if value1.is_u64() && value2.is_u64() && value1.as_u64() == value2.as_u64() { [INFO] [stderr] | ________________________________________________________________________________________________^ [INFO] [stderr] 241 | | return Ok(()); [INFO] [stderr] 242 | | } else if value1.is_i64() && value2.is_i64() && value1.as_i64() == value2.as_i64() { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | / { [INFO] [stderr] 239 | | return Ok(()); [INFO] [stderr] 240 | | } else if value1.is_u64() && value2.is_u64() && value1.as_u64() == value2.as_u64() { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | / match doc { [INFO] [stderr] 278 | | &YValue::Mapping(ref m) => { [INFO] [stderr] 279 | | let mut keys: Vec<(YValue, YValue)> = m.clone().into_iter().collect(); [INFO] [stderr] 280 | | keys.sort_unstable_by(|a, b| a.0.partial_cmp(&b.0).unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 297 | | &YValue::String(ref s) => YValue::String(s.clone()), [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 277 | match *doc { [INFO] [stderr] 278 | YValue::Mapping(ref m) => { [INFO] [stderr] 279 | let mut keys: Vec<(YValue, YValue)> = m.clone().into_iter().collect(); [INFO] [stderr] 280 | keys.sort_unstable_by(|a, b| a.0.partial_cmp(&b.0).unwrap()); [INFO] [stderr] 281 | YValue::Mapping(serde_yaml::Mapping::from_iter(keys.iter().map( [INFO] [stderr] 282 | |kv| (kv.0.clone(), sort_mapping_keys(&kv.1)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:295:46 [INFO] [stderr] | [INFO] [stderr] 295 | &YValue::Bool(ref b) => YValue::Bool(b.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:326:5 [INFO] [stderr] | [INFO] [stderr] 326 | / if let &YValue::Mapping(ref m) = doc { [INFO] [stderr] 327 | | if let &YValue::Mapping(_) = parent { [INFO] [stderr] 328 | | writer.write_all(b":\n")?; [INFO] [stderr] 329 | | } [INFO] [stderr] ... | [INFO] [stderr] 384 | | } [INFO] [stderr] 385 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 326 | if let YValue::Mapping(ref m) = *doc { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 328 | | writer.write_all(b":\n")?; [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 327 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:337:12 [INFO] [stderr] | [INFO] [stderr] 337 | } else if let &YValue::Sequence(ref s) = doc { [INFO] [stderr] | ____________^ [INFO] [stderr] 338 | | if let &YValue::Mapping(_) = parent { [INFO] [stderr] 339 | | writer.write_all(b":\n")?; [INFO] [stderr] 340 | | } [INFO] [stderr] ... | [INFO] [stderr] 384 | | } [INFO] [stderr] 385 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 337 | } else if let YValue::Sequence(ref s) = *doc { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 339 | | writer.write_all(b":\n")?; [INFO] [stderr] 340 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 338 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:344:12 [INFO] [stderr] | [INFO] [stderr] 344 | } else if let &YValue::String(ref s) = doc { [INFO] [stderr] | ____________^ [INFO] [stderr] 345 | | // Search for newlines [INFO] [stderr] 346 | | if s.len() > 0 && s.bytes().position(|x| x == b'\n').is_some() && [INFO] [stderr] 347 | | s.bytes().last().unwrap() == b'\n' [INFO] [stderr] ... | [INFO] [stderr] 384 | | } [INFO] [stderr] 385 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 344 | } else if let YValue::String(ref s) = *doc { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:346:12 [INFO] [stderr] | [INFO] [stderr] 346 | if s.len() > 0 && s.bytes().position(|x| x == b'\n').is_some() && [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:346:27 [INFO] [stderr] | [INFO] [stderr] 346 | if s.len() > 0 && s.bytes().position(|x| x == b'\n').is_some() && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `position(|x| x == b'\n').is_some()` with `any(|x| x == b'\n')` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 350 | | writer.write_all(b": |\n")?; [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 349 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 359 | | writer.write_all(b": ")?; [INFO] [stderr] 360 | | } else if let &YValue::Sequence(_) = parent { [INFO] [stderr] 361 | | write_indent(writer, indent)?; [INFO] [stderr] 362 | | writer.write_all(b"- ")?; [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 358 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:360:20 [INFO] [stderr] | [INFO] [stderr] 360 | } else if let &YValue::Sequence(_) = parent { [INFO] [stderr] | ____________________^ [INFO] [stderr] 361 | | write_indent(writer, indent)?; [INFO] [stderr] 362 | | writer.write_all(b"- ")?; [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 360 | } else if let YValue::Sequence(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 370 | | writer.write_all(b": ")?; [INFO] [stderr] 371 | | } else if let &YValue::Sequence(_) = parent { [INFO] [stderr] 372 | | write_indent(writer, indent)?; [INFO] [stderr] 373 | | writer.write_all(b"- ")?; [INFO] [stderr] 374 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 369 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:371:16 [INFO] [stderr] | [INFO] [stderr] 371 | } else if let &YValue::Sequence(_) = parent { [INFO] [stderr] | ________________^ [INFO] [stderr] 372 | | write_indent(writer, indent)?; [INFO] [stderr] 373 | | writer.write_all(b"- ")?; [INFO] [stderr] 374 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 371 | } else if let YValue::Sequence(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shyaml`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:169:20 [INFO] [stderr] | [INFO] [stderr] 169 | fn prefix_lines(s: &String, prefix: &'static str) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | / match value1 { [INFO] [stderr] 198 | | &YValue::Sequence(ref s1) => { [INFO] [stderr] 199 | | match value2.as_sequence() { [INFO] [stderr] 200 | | None => (), [INFO] [stderr] ... | [INFO] [stderr] 270 | | } [INFO] [stderr] 271 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 197 | match *value1 { [INFO] [stderr] 198 | YValue::Sequence(ref s1) => { [INFO] [stderr] 199 | match value2.as_sequence() { [INFO] [stderr] 200 | None => (), [INFO] [stderr] 201 | Some(s2) => { [INFO] [stderr] 202 | let mut s2 = s2.iter(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:240:96 [INFO] [stderr] | [INFO] [stderr] 240 | } else if value1.is_u64() && value2.is_u64() && value1.as_u64() == value2.as_u64() { [INFO] [stderr] | ________________________________________________________________________________________________^ [INFO] [stderr] 241 | | return Ok(()); [INFO] [stderr] 242 | | } else if value1.is_i64() && value2.is_i64() && value1.as_i64() == value2.as_i64() { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | / { [INFO] [stderr] 239 | | return Ok(()); [INFO] [stderr] 240 | | } else if value1.is_u64() && value2.is_u64() && value1.as_u64() == value2.as_u64() { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | / match doc { [INFO] [stderr] 278 | | &YValue::Mapping(ref m) => { [INFO] [stderr] 279 | | let mut keys: Vec<(YValue, YValue)> = m.clone().into_iter().collect(); [INFO] [stderr] 280 | | keys.sort_unstable_by(|a, b| a.0.partial_cmp(&b.0).unwrap()); [INFO] [stderr] ... | [INFO] [stderr] 297 | | &YValue::String(ref s) => YValue::String(s.clone()), [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 277 | match *doc { [INFO] [stderr] 278 | YValue::Mapping(ref m) => { [INFO] [stderr] 279 | let mut keys: Vec<(YValue, YValue)> = m.clone().into_iter().collect(); [INFO] [stderr] 280 | keys.sort_unstable_by(|a, b| a.0.partial_cmp(&b.0).unwrap()); [INFO] [stderr] 281 | YValue::Mapping(serde_yaml::Mapping::from_iter(keys.iter().map( [INFO] [stderr] 282 | |kv| (kv.0.clone(), sort_mapping_keys(&kv.1)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:295:46 [INFO] [stderr] | [INFO] [stderr] 295 | &YValue::Bool(ref b) => YValue::Bool(b.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:326:5 [INFO] [stderr] | [INFO] [stderr] 326 | / if let &YValue::Mapping(ref m) = doc { [INFO] [stderr] 327 | | if let &YValue::Mapping(_) = parent { [INFO] [stderr] 328 | | writer.write_all(b":\n")?; [INFO] [stderr] 329 | | } [INFO] [stderr] ... | [INFO] [stderr] 384 | | } [INFO] [stderr] 385 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 326 | if let YValue::Mapping(ref m) = *doc { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 328 | | writer.write_all(b":\n")?; [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 327 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:337:12 [INFO] [stderr] | [INFO] [stderr] 337 | } else if let &YValue::Sequence(ref s) = doc { [INFO] [stderr] | ____________^ [INFO] [stderr] 338 | | if let &YValue::Mapping(_) = parent { [INFO] [stderr] 339 | | writer.write_all(b":\n")?; [INFO] [stderr] 340 | | } [INFO] [stderr] ... | [INFO] [stderr] 384 | | } [INFO] [stderr] 385 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 337 | } else if let YValue::Sequence(ref s) = *doc { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 339 | | writer.write_all(b":\n")?; [INFO] [stderr] 340 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 338 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:344:12 [INFO] [stderr] | [INFO] [stderr] 344 | } else if let &YValue::String(ref s) = doc { [INFO] [stderr] | ____________^ [INFO] [stderr] 345 | | // Search for newlines [INFO] [stderr] 346 | | if s.len() > 0 && s.bytes().position(|x| x == b'\n').is_some() && [INFO] [stderr] 347 | | s.bytes().last().unwrap() == b'\n' [INFO] [stderr] ... | [INFO] [stderr] 384 | | } [INFO] [stderr] 385 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 344 | } else if let YValue::String(ref s) = *doc { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:346:12 [INFO] [stderr] | [INFO] [stderr] 346 | if s.len() > 0 && s.bytes().position(|x| x == b'\n').is_some() && [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:346:27 [INFO] [stderr] | [INFO] [stderr] 346 | if s.len() > 0 && s.bytes().position(|x| x == b'\n').is_some() && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `position(|x| x == b'\n').is_some()` with `any(|x| x == b'\n')` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 350 | | writer.write_all(b": |\n")?; [INFO] [stderr] 351 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 349 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 359 | | writer.write_all(b": ")?; [INFO] [stderr] 360 | | } else if let &YValue::Sequence(_) = parent { [INFO] [stderr] 361 | | write_indent(writer, indent)?; [INFO] [stderr] 362 | | writer.write_all(b"- ")?; [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 358 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:360:20 [INFO] [stderr] | [INFO] [stderr] 360 | } else if let &YValue::Sequence(_) = parent { [INFO] [stderr] | ____________________^ [INFO] [stderr] 361 | | write_indent(writer, indent)?; [INFO] [stderr] 362 | | writer.write_all(b"- ")?; [INFO] [stderr] 363 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 360 | } else if let YValue::Sequence(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | / if let &YValue::Mapping(_) = parent { [INFO] [stderr] 370 | | writer.write_all(b": ")?; [INFO] [stderr] 371 | | } else if let &YValue::Sequence(_) = parent { [INFO] [stderr] 372 | | write_indent(writer, indent)?; [INFO] [stderr] 373 | | writer.write_all(b"- ")?; [INFO] [stderr] 374 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 369 | if let YValue::Mapping(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:371:16 [INFO] [stderr] | [INFO] [stderr] 371 | } else if let &YValue::Sequence(_) = parent { [INFO] [stderr] | ________________^ [INFO] [stderr] 372 | | write_indent(writer, indent)?; [INFO] [stderr] 373 | | writer.write_all(b"- ")?; [INFO] [stderr] 374 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 371 | } else if let YValue::Sequence(_) = *parent { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shyaml`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2b6a0063b33c14c070f6320fc22371ab8c49d5d520a8b4176372867ec6fafcc2"` [INFO] running `"docker" "rm" "-f" "2b6a0063b33c14c070f6320fc22371ab8c49d5d520a8b4176372867ec6fafcc2"` [INFO] [stdout] 2b6a0063b33c14c070f6320fc22371ab8c49d5d520a8b4176372867ec6fafcc2