[INFO] updating cached repository Tomcc/remote_python
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Tomcc/remote_python
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Tomcc/remote_python" "work/ex/clippy-test-run/sources/stable/gh/Tomcc/remote_python"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tomcc/remote_python'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Tomcc/remote_python" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tomcc/remote_python"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tomcc/remote_python'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ea1fa2597ea90b83a47c4401844e6d55b3b5345e
[INFO] sha for GitHub repo Tomcc/remote_python: ea1fa2597ea90b83a47c4401844e6d55b3b5345e
[INFO] validating manifest of Tomcc/remote_python on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Tomcc/remote_python on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Tomcc/remote_python
[INFO] finished frobbing Tomcc/remote_python
[INFO] frobbed toml for Tomcc/remote_python written to work/ex/clippy-test-run/sources/stable/gh/Tomcc/remote_python/Cargo.toml
[INFO] started frobbing Tomcc/remote_python
[INFO] finished frobbing Tomcc/remote_python
[INFO] frobbed toml for Tomcc/remote_python written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tomcc/remote_python/Cargo.toml
[INFO] crate Tomcc/remote_python has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Tomcc/remote_python against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Tomcc/remote_python:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 66f49b537cd2e4f523fe6c4e1d1a494aab1e71b81232b284d0538b7261b6c7fa
[INFO] running `"docker" "start" "-a" "66f49b537cd2e4f523fe6c4e1d1a494aab1e71b81232b284d0538b7261b6c7fa"`
[INFO] [stderr]     Checking serde v1.0.0
[INFO] [stderr]     Checking tiny-keccak v1.2.1
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking app_dirs v1.1.1
[INFO] [stderr]     Checking base64 v0.4.1
[INFO] [stderr]    Compiling serde_derive v1.0.0
[INFO] [stderr]     Checking clap v2.23.2
[INFO] [stderr]     Checking serde_json v1.0.0
[INFO] [stderr]     Checking remote_python v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:206:5
[INFO] [stderr]     |
[INFO] [stderr] 206 |     return "python";
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"python"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:206:5
[INFO] [stderr]     |
[INFO] [stderr] 206 |     return "python";
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"python"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/main.rs:203:12
[INFO] [stderr]     |
[INFO] [stderr] 203 |       if let Ok(_) = Command::new("python3").status() {
[INFO] [stderr]     |  _____-      ^^^^^
[INFO] [stderr] 204 | |         return "python3";
[INFO] [stderr] 205 | |     }
[INFO] [stderr]     | |_____- help: try this: `if Command::new("python3").status().is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:210:5
[INFO] [stderr]     |
[INFO] [stderr] 210 |     socket.write(line.as_bytes())?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:211:5
[INFO] [stderr]     |
[INFO] [stderr] 211 |     socket.write(b"\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/main.rs:222:38
[INFO] [stderr]     |
[INFO] [stderr] 222 |                                 if let Err(_) = tx.send(line) {
[INFO] [stderr]     |  _______________________________-      ^^^^^^
[INFO] [stderr] 223 | |                                   return;
[INFO] [stderr] 224 | |                               }
[INFO] [stderr]     | |_______________________________- help: try this: `if tx.send(line).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:239:22
[INFO] [stderr]     |
[INFO] [stderr] 239 |         .starts_with(".")
[INFO] [stderr]     |                      ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:320:9
[INFO] [stderr]     |
[INFO] [stderr] 320 |         socket.write(b"Downloading new files... ")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:322:9
[INFO] [stderr]     |
[INFO] [stderr] 322 |         socket.write(b"Done\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:333:5
[INFO] [stderr]     |
[INFO] [stderr] 333 |     socket.write(b"Python execution launched\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:341:5
[INFO] [stderr]     |
[INFO] [stderr] 341 | /     loop {
[INFO] [stderr] 342 | |         match rx.recv() {
[INFO] [stderr] 343 | |             Ok(line) => {
[INFO] [stderr] 344 | |                 if let Err(_) = write_server_response(socket, &line) {
[INFO] [stderr] ...   |
[INFO] [stderr] 350 | |         }
[INFO] [stderr] 351 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Ok(line) = rx.recv() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/main.rs:344:24
[INFO] [stderr]     |
[INFO] [stderr] 344 |                   if let Err(_) = write_server_response(socket, &line) {
[INFO] [stderr]     |  _________________-      ^^^^^^
[INFO] [stderr] 345 | |                     println!("Connection dropped, aborting");
[INFO] [stderr] 346 | |                     break;
[INFO] [stderr] 347 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if write_server_response(socket, &line).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:389:13
[INFO] [stderr]     |
[INFO] [stderr] 389 | /             match stream {
[INFO] [stderr] 390 | |                 Ok(mut stream) => {
[INFO] [stderr] 391 | |                     if let Err(e) = server_function(&mut stream) {
[INFO] [stderr] 392 | |                         println!("Something went wrong: {:?}", e);
[INFO] [stderr] ...   |
[INFO] [stderr] 395 | |                 Err(_) => { /* connection failed */ }
[INFO] [stderr] 396 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 389 |             if let Ok(mut stream) = stream {
[INFO] [stderr] 390 |     if let Err(e) = server_function(&mut stream) {
[INFO] [stderr] 391 |         println!("Something went wrong: {:?}", e);
[INFO] [stderr] 392 |     }
[INFO] [stderr] 393 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `remote_python`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/main.rs:203:12
[INFO] [stderr]     |
[INFO] [stderr] 203 |       if let Ok(_) = Command::new("python3").status() {
[INFO] [stderr]     |  _____-      ^^^^^
[INFO] [stderr] 204 | |         return "python3";
[INFO] [stderr] 205 | |     }
[INFO] [stderr]     | |_____- help: try this: `if Command::new("python3").status().is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:210:5
[INFO] [stderr]     |
[INFO] [stderr] 210 |     socket.write(line.as_bytes())?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:211:5
[INFO] [stderr]     |
[INFO] [stderr] 211 |     socket.write(b"\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/main.rs:222:38
[INFO] [stderr]     |
[INFO] [stderr] 222 |                                 if let Err(_) = tx.send(line) {
[INFO] [stderr]     |  _______________________________-      ^^^^^^
[INFO] [stderr] 223 | |                                   return;
[INFO] [stderr] 224 | |                               }
[INFO] [stderr]     | |_______________________________- help: try this: `if tx.send(line).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:239:22
[INFO] [stderr]     |
[INFO] [stderr] 239 |         .starts_with(".")
[INFO] [stderr]     |                      ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:320:9
[INFO] [stderr]     |
[INFO] [stderr] 320 |         socket.write(b"Downloading new files... ")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:322:9
[INFO] [stderr]     |
[INFO] [stderr] 322 |         socket.write(b"Done\n")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:333:5
[INFO] [stderr]     |
[INFO] [stderr] 333 |     socket.write(b"Python execution launched\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:341:5
[INFO] [stderr]     |
[INFO] [stderr] 341 | /     loop {
[INFO] [stderr] 342 | |         match rx.recv() {
[INFO] [stderr] 343 | |             Ok(line) => {
[INFO] [stderr] 344 | |                 if let Err(_) = write_server_response(socket, &line) {
[INFO] [stderr] ...   |
[INFO] [stderr] 350 | |         }
[INFO] [stderr] 351 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Ok(line) = rx.recv() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/main.rs:344:24
[INFO] [stderr]     |
[INFO] [stderr] 344 |                   if let Err(_) = write_server_response(socket, &line) {
[INFO] [stderr]     |  _________________-      ^^^^^^
[INFO] [stderr] 345 | |                     println!("Connection dropped, aborting");
[INFO] [stderr] 346 | |                     break;
[INFO] [stderr] 347 | |                 }
[INFO] [stderr]     | |_________________- help: try this: `if write_server_response(socket, &line).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:389:13
[INFO] [stderr]     |
[INFO] [stderr] 389 | /             match stream {
[INFO] [stderr] 390 | |                 Ok(mut stream) => {
[INFO] [stderr] 391 | |                     if let Err(e) = server_function(&mut stream) {
[INFO] [stderr] 392 | |                         println!("Something went wrong: {:?}", e);
[INFO] [stderr] ...   |
[INFO] [stderr] 395 | |                 Err(_) => { /* connection failed */ }
[INFO] [stderr] 396 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 389 |             if let Ok(mut stream) = stream {
[INFO] [stderr] 390 |     if let Err(e) = server_function(&mut stream) {
[INFO] [stderr] 391 |         println!("Something went wrong: {:?}", e);
[INFO] [stderr] 392 |     }
[INFO] [stderr] 393 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `remote_python`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "66f49b537cd2e4f523fe6c4e1d1a494aab1e71b81232b284d0538b7261b6c7fa"`
[INFO] running `"docker" "rm" "-f" "66f49b537cd2e4f523fe6c4e1d1a494aab1e71b81232b284d0538b7261b6c7fa"`
[INFO] [stdout] 66f49b537cd2e4f523fe6c4e1d1a494aab1e71b81232b284d0538b7261b6c7fa