[INFO] updating cached repository Tobi823/eaw_dat_exporter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Tobi823/eaw_dat_exporter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Tobi823/eaw_dat_exporter" "work/ex/clippy-test-run/sources/stable/gh/Tobi823/eaw_dat_exporter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tobi823/eaw_dat_exporter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Tobi823/eaw_dat_exporter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tobi823/eaw_dat_exporter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tobi823/eaw_dat_exporter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] da99a87e7d7754493e0a734dbf9737b1e26901fc [INFO] sha for GitHub repo Tobi823/eaw_dat_exporter: da99a87e7d7754493e0a734dbf9737b1e26901fc [INFO] validating manifest of Tobi823/eaw_dat_exporter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Tobi823/eaw_dat_exporter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Tobi823/eaw_dat_exporter [INFO] finished frobbing Tobi823/eaw_dat_exporter [INFO] frobbed toml for Tobi823/eaw_dat_exporter written to work/ex/clippy-test-run/sources/stable/gh/Tobi823/eaw_dat_exporter/Cargo.toml [INFO] started frobbing Tobi823/eaw_dat_exporter [INFO] finished frobbing Tobi823/eaw_dat_exporter [INFO] frobbed toml for Tobi823/eaw_dat_exporter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tobi823/eaw_dat_exporter/Cargo.toml [INFO] crate Tobi823/eaw_dat_exporter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Tobi823/eaw_dat_exporter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Tobi823/eaw_dat_exporter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7028737a1cc9533d253856efb003182670a4d8163640308d965b10809335fd8 [INFO] running `"docker" "start" "-a" "a7028737a1cc9533d253856efb003182670a4d8163640308d965b10809335fd8"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking log v0.4.5 [INFO] [stderr] Checking csv v1.0.1 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Checking eaw_dat_exporter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CSV_LINE_SEPARATOR` [INFO] [stderr] --> src/main.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | const CSV_LINE_SEPARATOR: &str = "\r\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:116:81 [INFO] [stderr] | [INFO] [stderr] 116 | fn read_translations_from_file(file_reader: &mut BufReader, reservations: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Reservation]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `current_number` is used to index `reservations` [INFO] [stderr] --> src/main.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | for current_number in 0..number_of_translations { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 121 | for (current_number, ) in reservations.iter().enumerate().take(number_of_translations) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | fn sanitize_str(text: &String) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:150:56 [INFO] [stderr] | [INFO] [stderr] 150 | fn write_result_to_file(file_name: &str, translations: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Translation]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::error::Error` [INFO] [stderr] --> src/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | use std::error::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:158:26 [INFO] [stderr] | [INFO] [stderr] 158 | if name.contains("\n") || name.contains("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:158:49 [INFO] [stderr] | [INFO] [stderr] 158 | if name.contains("\n") || name.contains("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:164:26 [INFO] [stderr] | [INFO] [stderr] 164 | if text.contains("\n") || text.contains("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:164:49 [INFO] [stderr] | [INFO] [stderr] 164 | if text.contains("\n") || text.contains("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | writer.write_record(&[id, name, text]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CSV_LINE_SEPARATOR` [INFO] [stderr] --> src/main.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | const CSV_LINE_SEPARATOR: &str = "\r\n"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:116:81 [INFO] [stderr] | [INFO] [stderr] 116 | fn read_translations_from_file(file_reader: &mut BufReader, reservations: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Reservation]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `current_number` is used to index `reservations` [INFO] [stderr] --> src/main.rs:121:27 [INFO] [stderr] | [INFO] [stderr] 121 | for current_number in 0..number_of_translations { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 121 | for (current_number, ) in reservations.iter().enumerate().take(number_of_translations) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | fn sanitize_str(text: &String) -> String{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:150:56 [INFO] [stderr] | [INFO] [stderr] 150 | fn write_result_to_file(file_name: &str, translations: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Translation]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:158:26 [INFO] [stderr] | [INFO] [stderr] 158 | if name.contains("\n") || name.contains("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:158:49 [INFO] [stderr] | [INFO] [stderr] 158 | if name.contains("\n") || name.contains("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:164:26 [INFO] [stderr] | [INFO] [stderr] 164 | if text.contains("\n") || text.contains("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:164:49 [INFO] [stderr] | [INFO] [stderr] 164 | if text.contains("\n") || text.contains("\r") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | writer.write_record(&[id, name, text]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.24s [INFO] running `"docker" "inspect" "a7028737a1cc9533d253856efb003182670a4d8163640308d965b10809335fd8"` [INFO] running `"docker" "rm" "-f" "a7028737a1cc9533d253856efb003182670a4d8163640308d965b10809335fd8"` [INFO] [stdout] a7028737a1cc9533d253856efb003182670a4d8163640308d965b10809335fd8