[INFO] updating cached repository Tjulen/Rust_raw_openGl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Tjulen/Rust_raw_openGl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Tjulen/Rust_raw_openGl" "work/ex/clippy-test-run/sources/stable/gh/Tjulen/Rust_raw_openGl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tjulen/Rust_raw_openGl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Tjulen/Rust_raw_openGl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tjulen/Rust_raw_openGl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tjulen/Rust_raw_openGl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f2ee9a03d2380f277f11617b5c51609354929cc9 [INFO] sha for GitHub repo Tjulen/Rust_raw_openGl: f2ee9a03d2380f277f11617b5c51609354929cc9 [INFO] validating manifest of Tjulen/Rust_raw_openGl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Tjulen/Rust_raw_openGl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Tjulen/Rust_raw_openGl [INFO] finished frobbing Tjulen/Rust_raw_openGl [INFO] frobbed toml for Tjulen/Rust_raw_openGl written to work/ex/clippy-test-run/sources/stable/gh/Tjulen/Rust_raw_openGl/Cargo.toml [INFO] started frobbing Tjulen/Rust_raw_openGl [INFO] finished frobbing Tjulen/Rust_raw_openGl [INFO] frobbed toml for Tjulen/Rust_raw_openGl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tjulen/Rust_raw_openGl/Cargo.toml [INFO] crate Tjulen/Rust_raw_openGl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Tjulen/Rust_raw_openGl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Tjulen/Rust_raw_openGl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1fead28d1ff8232eadb95ece0101c888ab33ae4a43c96162c0e8b7a9f9d15d5e [INFO] running `"docker" "start" "-a" "1fead28d1ff8232eadb95ece0101c888ab33ae4a43c96162c0e8b7a9f9d15d5e"` [INFO] [stderr] Checking x11-dl v2.17.3 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking glutin v0.12.2 [INFO] [stderr] Checking open_gl_learning v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | return shader_program as gl::types::GLuint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `shader_program as gl::types::GLuint` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | return shader_program as gl::types::GLuint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `shader_program as gl::types::GLuint` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/main.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:46 [INFO] [stderr] | [INFO] [stderr] 42 | let mut shader_compile_success = gl::FALSE as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | if shader_compile_success != gl::TRUE as gl::types::GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:42 [INFO] [stderr] | [INFO] [stderr] 82 | if shader_compile_success != gl::TRUE as gl::types::GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:47 [INFO] [stderr] | [INFO] [stderr] 102 | let mut program_compile_success = gl::FALSE as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:108:43 [INFO] [stderr] | [INFO] [stderr] 108 | if program_compile_success != gl::TRUE as gl::types::GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:213:41 [INFO] [stderr] | [INFO] [stderr] 213 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 214 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 215 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 216 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 219 | | _ => (), [INFO] [stderr] 220 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 213 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 214 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 215 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 216 | _ => (), [INFO] [stderr] 217 | } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/main.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:46 [INFO] [stderr] | [INFO] [stderr] 42 | let mut shader_compile_success = gl::FALSE as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | if shader_compile_success != gl::TRUE as gl::types::GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:82:42 [INFO] [stderr] | [INFO] [stderr] 82 | if shader_compile_success != gl::TRUE as gl::types::GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:47 [INFO] [stderr] | [INFO] [stderr] 102 | let mut program_compile_success = gl::FALSE as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:108:43 [INFO] [stderr] | [INFO] [stderr] 108 | if program_compile_success != gl::TRUE as gl::types::GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:213:41 [INFO] [stderr] | [INFO] [stderr] 213 | events_loop.poll_events(|event| match event { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 214 | | glutin::Event::WindowEvent { event, .. } => match event { [INFO] [stderr] 215 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 216 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 219 | | _ => (), [INFO] [stderr] 220 | | }); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 213 | events_loop.poll_events(|event| if let glutin::Event::WindowEvent { event, .. } = event { match event { [INFO] [stderr] 214 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 215 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 216 | _ => (), [INFO] [stderr] 217 | } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.35s [INFO] running `"docker" "inspect" "1fead28d1ff8232eadb95ece0101c888ab33ae4a43c96162c0e8b7a9f9d15d5e"` [INFO] running `"docker" "rm" "-f" "1fead28d1ff8232eadb95ece0101c888ab33ae4a43c96162c0e8b7a9f9d15d5e"` [INFO] [stdout] 1fead28d1ff8232eadb95ece0101c888ab33ae4a43c96162c0e8b7a9f9d15d5e