[INFO] updating cached repository ThomasLarson/shunting_yard [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ThomasLarson/shunting_yard [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ThomasLarson/shunting_yard" "work/ex/clippy-test-run/sources/stable/gh/ThomasLarson/shunting_yard"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ThomasLarson/shunting_yard'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ThomasLarson/shunting_yard" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThomasLarson/shunting_yard"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThomasLarson/shunting_yard'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6a8bab44d6eba393987342cca7908be95475e7f1 [INFO] sha for GitHub repo ThomasLarson/shunting_yard: 6a8bab44d6eba393987342cca7908be95475e7f1 [INFO] validating manifest of ThomasLarson/shunting_yard on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ThomasLarson/shunting_yard on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ThomasLarson/shunting_yard [INFO] finished frobbing ThomasLarson/shunting_yard [INFO] frobbed toml for ThomasLarson/shunting_yard written to work/ex/clippy-test-run/sources/stable/gh/ThomasLarson/shunting_yard/Cargo.toml [INFO] started frobbing ThomasLarson/shunting_yard [INFO] finished frobbing ThomasLarson/shunting_yard [INFO] frobbed toml for ThomasLarson/shunting_yard written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThomasLarson/shunting_yard/Cargo.toml [INFO] crate ThomasLarson/shunting_yard has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ThomasLarson/shunting_yard against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ThomasLarson/shunting_yard:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c8dff366e688c293cfcb985a2a9ca7c7b34c5ca7ec55c8a21fb67a0e6d8d1b2c [INFO] running `"docker" "start" "-a" "c8dff366e688c293cfcb985a2a9ca7c7b34c5ca7ec55c8a21fb67a0e6d8d1b2c"` [INFO] [stderr] Checking shunting_yard v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/main.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | } [INFO] [stderr] | ______________^ [INFO] [stderr] 56 | | //else if operator_info(operator_stack[operator_stack.len() - 1]).0 < operator_info(t).0 [INFO] [stderr] 57 | | else if operator_info(operator_stack[operator_stack.len() - 1]).0 < operator_info(t).0 [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / { [INFO] [stderr] 59 | | operator_stack.push(t); [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | / { [INFO] [stderr] 54 | | operator_stack.push(t); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:112:11 [INFO] [stderr] | [INFO] [stderr] 112 | while operator_stack.is_empty() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!operator_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shunting_yard`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/main.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | } [INFO] [stderr] | ______________^ [INFO] [stderr] 56 | | //else if operator_info(operator_stack[operator_stack.len() - 1]).0 < operator_info(t).0 [INFO] [stderr] 57 | | else if operator_info(operator_stack[operator_stack.len() - 1]).0 < operator_info(t).0 [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | / { [INFO] [stderr] 59 | | operator_stack.push(t); [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | / { [INFO] [stderr] 54 | | operator_stack.push(t); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:112:11 [INFO] [stderr] | [INFO] [stderr] 112 | while operator_stack.is_empty() == false [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!operator_stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `shunting_yard`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c8dff366e688c293cfcb985a2a9ca7c7b34c5ca7ec55c8a21fb67a0e6d8d1b2c"` [INFO] running `"docker" "rm" "-f" "c8dff366e688c293cfcb985a2a9ca7c7b34c5ca7ec55c8a21fb67a0e6d8d1b2c"` [INFO] [stdout] c8dff366e688c293cfcb985a2a9ca7c7b34c5ca7ec55c8a21fb67a0e6d8d1b2c