[INFO] updating cached repository ThomasColliers/mtmigrate [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ThomasColliers/mtmigrate [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ThomasColliers/mtmigrate" "work/ex/clippy-test-run/sources/stable/gh/ThomasColliers/mtmigrate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ThomasColliers/mtmigrate'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ThomasColliers/mtmigrate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThomasColliers/mtmigrate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThomasColliers/mtmigrate'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2013f5f38156705c3cb63ed7f0f61a25ce49af76 [INFO] sha for GitHub repo ThomasColliers/mtmigrate: 2013f5f38156705c3cb63ed7f0f61a25ce49af76 [INFO] validating manifest of ThomasColliers/mtmigrate on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ThomasColliers/mtmigrate on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ThomasColliers/mtmigrate [INFO] finished frobbing ThomasColliers/mtmigrate [INFO] frobbed toml for ThomasColliers/mtmigrate written to work/ex/clippy-test-run/sources/stable/gh/ThomasColliers/mtmigrate/Cargo.toml [INFO] started frobbing ThomasColliers/mtmigrate [INFO] finished frobbing ThomasColliers/mtmigrate [INFO] frobbed toml for ThomasColliers/mtmigrate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ThomasColliers/mtmigrate/Cargo.toml [INFO] crate ThomasColliers/mtmigrate has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ThomasColliers/mtmigrate against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ThomasColliers/mtmigrate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 62b401d3fd83cf4230c5d064fc31d49c44a4acbb0c817a5b9a38f7d87e7a27f9 [INFO] running `"docker" "start" "-a" "62b401d3fd83cf4230c5d064fc31d49c44a4acbb0c817a5b9a38f7d87e7a27f9"` [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Checking bip_bencode v0.4.4 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking preferences v1.1.0 [INFO] [stderr] Checking bip_util v0.5.0 [INFO] [stderr] Checking bip_metainfo v0.12.0 [INFO] [stderr] Checking mtmigrate v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/migration/matching.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | / if (fileresult.good as f32/fileresult.total as f32) < 0.2 { [INFO] [stderr] 242 | | if !rejected_search { [INFO] [stderr] 243 | | if !agreed_to_search { [INFO] [stderr] 244 | | println!("Realign not succesful on at least one file, want to try a (slow and CPU heavy) piece search? (y/n) [n]"); [INFO] [stderr] ... | [INFO] [stderr] 262 | | } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 241 | if (fileresult.good as f32/fileresult.total as f32) < 0.2 && !rejected_search { [INFO] [stderr] 242 | if !agreed_to_search { [INFO] [stderr] 243 | println!("Realign not succesful on at least one file, want to try a (slow and CPU heavy) piece search? (y/n) [n]"); [INFO] [stderr] 244 | let mut reply = String::new(); [INFO] [stderr] 245 | io::stdin().read_line(&mut reply).unwrap(); [INFO] [stderr] 246 | match reply.trim() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/migration/matching.rs:241:17 [INFO] [stderr] | [INFO] [stderr] 241 | / if (fileresult.good as f32/fileresult.total as f32) < 0.2 { [INFO] [stderr] 242 | | if !rejected_search { [INFO] [stderr] 243 | | if !agreed_to_search { [INFO] [stderr] 244 | | println!("Realign not succesful on at least one file, want to try a (slow and CPU heavy) piece search? (y/n) [n]"); [INFO] [stderr] ... | [INFO] [stderr] 262 | | } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 241 | if (fileresult.good as f32/fileresult.total as f32) < 0.2 && !rejected_search { [INFO] [stderr] 242 | if !agreed_to_search { [INFO] [stderr] 243 | println!("Realign not succesful on at least one file, want to try a (slow and CPU heavy) piece search? (y/n) [n]"); [INFO] [stderr] 244 | let mut reply = String::new(); [INFO] [stderr] 245 | io::stdin().read_line(&mut reply).unwrap(); [INFO] [stderr] 246 | match reply.trim() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/migration/filemapping.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | / match targets.iter().position(|target| { [INFO] [stderr] 9 | | if input.size == target.size && input.extension == target.extension { [INFO] [stderr] 10 | | true [INFO] [stderr] 11 | | }else{ [INFO] [stderr] ... | [INFO] [stderr] 16 | | None => {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | if let Some(pos) = targets.iter().position(|target| { [INFO] [stderr] 9 | if input.size == target.size && input.extension == target.extension { [INFO] [stderr] 10 | true [INFO] [stderr] 11 | }else{ [INFO] [stderr] 12 | false [INFO] [stderr] 13 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/migration/filemapping.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | / if input.size == target.size && input.extension == target.extension { [INFO] [stderr] 10 | | true [INFO] [stderr] 11 | | }else{ [INFO] [stderr] 12 | | false [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `input.size == target.size && input.extension == target.extension` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | fn print_mapping(inputs: &Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[SourceFile]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | fn print_mapping(inputs: &Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:84:59 [INFO] [stderr] | [INFO] [stderr] 84 | fn map_by_filename(inputs: &mut Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:97:55 [INFO] [stderr] | [INFO] [stderr] 97 | fn map_by_size(inputs: &mut Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:112:54 [INFO] [stderr] | [INFO] [stderr] 112 | fn map_manual(inputs: &mut Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | fn hash_check(torrent_meta:&Metainfo, inputs:&Vec, targets:&Vec, onlyscanfile:Option) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[SourceFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:25:72 [INFO] [stderr] | [INFO] [stderr] 25 | fn hash_check(torrent_meta:&Metainfo, inputs:&Vec, targets:&Vec, onlyscanfile:Option) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:154:60 [INFO] [stderr] | [INFO] [stderr] 154 | fn piece_search(index:usize,torrent_meta:&Metainfo, inputs:&Vec, targets:&Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[SourceFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:154:86 [INFO] [stderr] | [INFO] [stderr] 154 | fn piece_search(index:usize,torrent_meta:&Metainfo, inputs:&Vec, targets:&Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:201:29 [INFO] [stderr] | [INFO] [stderr] 201 | fn print_hash_result(result:&Vec, targets:&Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[FileResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:201:55 [INFO] [stderr] | [INFO] [stderr] 201 | fn print_hash_result(result:&Vec, targets:&Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/migration/mod.rs:51:55 [INFO] [stderr] | [INFO] [stderr] 51 | let audio_formats:HashSet = AUDIO_FORMATS.into_iter().map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/migration/filemapping.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | / match targets.iter().position(|target| { [INFO] [stderr] 9 | | if input.size == target.size && input.extension == target.extension { [INFO] [stderr] 10 | | true [INFO] [stderr] 11 | | }else{ [INFO] [stderr] ... | [INFO] [stderr] 16 | | None => {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | if let Some(pos) = targets.iter().position(|target| { [INFO] [stderr] 9 | if input.size == target.size && input.extension == target.extension { [INFO] [stderr] 10 | true [INFO] [stderr] 11 | }else{ [INFO] [stderr] 12 | false [INFO] [stderr] 13 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/migration/filemapping.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | / if input.size == target.size && input.extension == target.extension { [INFO] [stderr] 10 | | true [INFO] [stderr] 11 | | }else{ [INFO] [stderr] 12 | | false [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____________^ help: you can reduce it to: `input.size == target.size && input.extension == target.extension` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | fn print_mapping(inputs: &Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[SourceFile]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | fn print_mapping(inputs: &Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:84:59 [INFO] [stderr] | [INFO] [stderr] 84 | fn map_by_filename(inputs: &mut Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:97:55 [INFO] [stderr] | [INFO] [stderr] 97 | fn map_by_size(inputs: &mut Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/filemapping.rs:112:54 [INFO] [stderr] | [INFO] [stderr] 112 | fn map_manual(inputs: &mut Vec, targets: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | fn hash_check(torrent_meta:&Metainfo, inputs:&Vec, targets:&Vec, onlyscanfile:Option) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[SourceFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:25:72 [INFO] [stderr] | [INFO] [stderr] 25 | fn hash_check(torrent_meta:&Metainfo, inputs:&Vec, targets:&Vec, onlyscanfile:Option) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:154:60 [INFO] [stderr] | [INFO] [stderr] 154 | fn piece_search(index:usize,torrent_meta:&Metainfo, inputs:&Vec, targets:&Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[SourceFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:154:86 [INFO] [stderr] | [INFO] [stderr] 154 | fn piece_search(index:usize,torrent_meta:&Metainfo, inputs:&Vec, targets:&Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:201:29 [INFO] [stderr] | [INFO] [stderr] 201 | fn print_hash_result(result:&Vec, targets:&Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[FileResult]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/migration/matching.rs:201:55 [INFO] [stderr] | [INFO] [stderr] 201 | fn print_hash_result(result:&Vec, targets:&Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[TargetFile]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/migration/mod.rs:51:55 [INFO] [stderr] | [INFO] [stderr] 51 | let audio_formats:HashSet = AUDIO_FORMATS.into_iter().map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.74s [INFO] running `"docker" "inspect" "62b401d3fd83cf4230c5d064fc31d49c44a4acbb0c817a5b9a38f7d87e7a27f9"` [INFO] running `"docker" "rm" "-f" "62b401d3fd83cf4230c5d064fc31d49c44a4acbb0c817a5b9a38f7d87e7a27f9"` [INFO] [stdout] 62b401d3fd83cf4230c5d064fc31d49c44a4acbb0c817a5b9a38f7d87e7a27f9