[INFO] updating cached repository Thinkofname/rust-quake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Thinkofname/rust-quake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Thinkofname/rust-quake" "work/ex/clippy-test-run/sources/stable/gh/Thinkofname/rust-quake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Thinkofname/rust-quake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Thinkofname/rust-quake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Thinkofname/rust-quake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Thinkofname/rust-quake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 77d4de4d7a67832bda84aea6982aa8ea16eaadaa [INFO] sha for GitHub repo Thinkofname/rust-quake: 77d4de4d7a67832bda84aea6982aa8ea16eaadaa [INFO] validating manifest of Thinkofname/rust-quake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Thinkofname/rust-quake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Thinkofname/rust-quake [INFO] finished frobbing Thinkofname/rust-quake [INFO] frobbed toml for Thinkofname/rust-quake written to work/ex/clippy-test-run/sources/stable/gh/Thinkofname/rust-quake/Cargo.toml [INFO] started frobbing Thinkofname/rust-quake [INFO] finished frobbing Thinkofname/rust-quake [INFO] frobbed toml for Thinkofname/rust-quake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Thinkofname/rust-quake/Cargo.toml [INFO] crate Thinkofname/rust-quake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Thinkofname/rust-quake against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Thinkofname/rust-quake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d3d2b7a5365d9052ae8895ad4e48fd50694850d1b9c9b89edacfccb1fefd9c09 [INFO] running `"docker" "start" "-a" "d3d2b7a5365d9052ae8895ad4e48fd50694850d1b9c9b89edacfccb1fefd9c09"` [INFO] [stderr] Compiling libc v0.2.29 [INFO] [stderr] Compiling either v1.1.0 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking backtrace-sys v0.1.12 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Compiling rand v0.3.16 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking gfx_core v0.7.1 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.9 [INFO] [stderr] Checking wayland-client v0.9.9 [INFO] [stderr] Checking wayland-window v0.6.1 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking winit v0.7.5 [INFO] [stderr] Checking glutin v0.9.2 [INFO] [stderr] Checking gfx_device_gl v0.14.1 [INFO] [stderr] Checking gfx v0.16.1 [INFO] [stderr] Checking gfx_window_glutin v0.17.0 [INFO] [stderr] Checking quake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pak/mod.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/atlas.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | padding: padding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/atlas.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/atlas.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:304:25 [INFO] [stderr] | [INFO] [stderr] 304 | light: light, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `light` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:337:25 [INFO] [stderr] | [INFO] [stderr] 337 | light: light, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `light` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:376:25 [INFO] [stderr] | [INFO] [stderr] 376 | light: light, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `light` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | buffer_sky_box: buffer_sky_box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_sky_box` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:411:13 [INFO] [stderr] | [INFO] [stderr] 411 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | texture_light: texture_light, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_light` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | colour_map: colour_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `colour_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | pak: pak, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pak` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | main_pipeline: main_pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `main_pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | depth_pipeline: depth_pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `depth_pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | sky_pipeline: sky_pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sky_pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | main_color: main_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `main_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | main_depth: main_depth, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `main_depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | light_maps: light_maps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_maps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | textures: textures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `textures` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pak/mod.rs:54:13 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] 54 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | texture_info: texture_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_info` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | edges: edges, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/atlas.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | padding: padding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | ledges: ledges, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ledges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | planes: planes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `planes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | models: models, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `models` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | vector_s: vector_s, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vector_s` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:273:17 [INFO] [stderr] | [INFO] [stderr] 273 | dist_s: dist_s, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `dist_s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:274:17 [INFO] [stderr] | [INFO] [stderr] 274 | vector_t: vector_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vector_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | dist_t: dist_t, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `dist_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:277:17 [INFO] [stderr] | [INFO] [stderr] 277 | animated: animated, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `animated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:327:17 [INFO] [stderr] | [INFO] [stderr] 327 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:328:17 [INFO] [stderr] | [INFO] [stderr] 328 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:348:21 [INFO] [stderr] | [INFO] [stderr] 348 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/atlas.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/atlas.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:304:25 [INFO] [stderr] | [INFO] [stderr] 304 | light: light, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `light` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:337:25 [INFO] [stderr] | [INFO] [stderr] 337 | light: light, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `light` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:376:25 [INFO] [stderr] | [INFO] [stderr] 376 | light: light, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `light` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:409:13 [INFO] [stderr] | [INFO] [stderr] 409 | buffer_sky_box: buffer_sky_box, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_sky_box` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:411:13 [INFO] [stderr] | [INFO] [stderr] 411 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:413:13 [INFO] [stderr] | [INFO] [stderr] 413 | texture_light: texture_light, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_light` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/qmap.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | colour_map: colour_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `colour_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | pak: pak, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pak` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | main_pipeline: main_pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `main_pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | depth_pipeline: depth_pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `depth_pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | sky_pipeline: sky_pipeline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sky_pipeline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | main_color: main_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `main_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/mod.rs:213:13 [INFO] [stderr] | [INFO] [stderr] 213 | main_depth: main_depth, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `main_depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | light_maps: light_maps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_maps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | textures: textures, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `textures` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | texture_info: texture_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `texture_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | edges: edges, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `edges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | ledges: ledges, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ledges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | planes: planes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `planes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | faces: faces, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `faces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | models: models, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `models` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | vector_s: vector_s, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vector_s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:273:17 [INFO] [stderr] | [INFO] [stderr] 273 | dist_s: dist_s, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `dist_s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:274:17 [INFO] [stderr] | [INFO] [stderr] 274 | vector_t: vector_t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vector_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | dist_t: dist_t, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `dist_t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:277:17 [INFO] [stderr] | [INFO] [stderr] 277 | animated: animated, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `animated` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:327:17 [INFO] [stderr] | [INFO] [stderr] 327 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:328:17 [INFO] [stderr] | [INFO] [stderr] 328 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bsp/mod.rs:348:21 [INFO] [stderr] | [INFO] [stderr] 348 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::memory` [INFO] [stderr] --> src/render/qmap.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gfx::memory; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Texture` [INFO] [stderr] --> src/render/qmap.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | Texture, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::memory` [INFO] [stderr] --> src/render/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | use gfx::memory; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Texture` [INFO] [stderr] --> src/render/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Texture, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `DeviceEvent` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | DeviceEvent, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | const LEVELS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | const LEVELS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::memory` [INFO] [stderr] --> src/render/qmap.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use gfx::memory; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Texture` [INFO] [stderr] --> src/render/qmap.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | Texture, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::memory` [INFO] [stderr] --> src/render/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | use gfx::memory; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Texture` [INFO] [stderr] --> src/render/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Texture, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `DeviceEvent` [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | DeviceEvent, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | const LEVELS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | const LEVELS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `device` [INFO] [stderr] --> src/render/qmap.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | device: &mut D, factory: &mut F, [INFO] [stderr] | ^^^^^^ help: consider using `_device` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `device` [INFO] [stderr] --> src/render/qmap.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | device: &mut D, factory: &mut F, encoder: &mut gfx::Encoder, [INFO] [stderr] | ^^^^^^ help: consider using `_device` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `factory` [INFO] [stderr] --> src/render/qmap.rs:423:25 [INFO] [stderr] | [INFO] [stderr] 423 | device: &mut D, factory: &mut F, encoder: &mut gfx::Encoder, [INFO] [stderr] | ^^^^^^^ help: consider using `_factory` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `pak` [INFO] [stderr] --> src/render/mod.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | pak: Rc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/mod.rs:51:10 [INFO] [stderr] | [INFO] [stderr] 51 | .unwrap_or(data.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| data.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused variable: `device` [INFO] [stderr] --> src/render/qmap.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | device: &mut D, factory: &mut F, [INFO] [stderr] | ^^^^^^ help: consider using `_device` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `device` [INFO] [stderr] --> src/render/qmap.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | device: &mut D, factory: &mut F, encoder: &mut gfx::Encoder, [INFO] [stderr] | ^^^^^^ help: consider using `_device` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `factory` [INFO] [stderr] --> src/render/qmap.rs:423:25 [INFO] [stderr] | [INFO] [stderr] 423 | device: &mut D, factory: &mut F, encoder: &mut gfx::Encoder, [INFO] [stderr] | ^^^^^^^ help: consider using `_factory` instead [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/render/qmap.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new( [INFO] [stderr] 47 | | b: bsp::BspFile, [INFO] [stderr] 48 | | device: &mut D, factory: &mut F, [INFO] [stderr] 49 | | ) -> error::Result> [INFO] [stderr] ... | [INFO] [stderr] 417 | | }) [INFO] [stderr] 418 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/qmap.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | for y in -1.. v.height as i32 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `-1..=v.height as i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/qmap.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | for x in -1 .. v.width as i32 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `-1..=v.width as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/render/qmap.rs:420:5 [INFO] [stderr] | [INFO] [stderr] 420 | / pub fn draw( [INFO] [stderr] 421 | | &mut self, [INFO] [stderr] 422 | | delta: f32, [INFO] [stderr] 423 | | device: &mut D, factory: &mut F, encoder: &mut gfx::Encoder, [INFO] [stderr] ... | [INFO] [stderr] 477 | | Ok(()) [INFO] [stderr] 478 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/qmap.rs:480:30 [INFO] [stderr] | [INFO] [stderr] 480 | fn gen_sky_box(textures: &Vec, tex: i32, min: Vector3, max: Vector3) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[atlas::Rect]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/qmap.rs:488:26 [INFO] [stderr] | [INFO] [stderr] 488 | let offset = z as f32 * 100.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `pak` [INFO] [stderr] --> src/render/mod.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | pak: Rc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/mod.rs:51:10 [INFO] [stderr] | [INFO] [stderr] 51 | .unwrap_or(data.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| data.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/render/qmap.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new( [INFO] [stderr] 47 | | b: bsp::BspFile, [INFO] [stderr] 48 | | device: &mut D, factory: &mut F, [INFO] [stderr] 49 | | ) -> error::Result> [INFO] [stderr] ... | [INFO] [stderr] 417 | | }) [INFO] [stderr] 418 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/qmap.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | for y in -1.. v.height as i32 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `-1..=v.height as i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/render/qmap.rs:158:30 [INFO] [stderr] | [INFO] [stderr] 158 | for x in -1 .. v.width as i32 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `-1..=v.width as i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/render/qmap.rs:420:5 [INFO] [stderr] | [INFO] [stderr] 420 | / pub fn draw( [INFO] [stderr] 421 | | &mut self, [INFO] [stderr] 422 | | delta: f32, [INFO] [stderr] 423 | | device: &mut D, factory: &mut F, encoder: &mut gfx::Encoder, [INFO] [stderr] ... | [INFO] [stderr] 477 | | Ok(()) [INFO] [stderr] 478 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/render/qmap.rs:480:30 [INFO] [stderr] | [INFO] [stderr] 480 | fn gen_sky_box(textures: &Vec, tex: i32, min: Vector3, max: Vector3) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[atlas::Rect]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/qmap.rs:488:26 [INFO] [stderr] | [INFO] [stderr] 488 | let offset = z as f32 * 100.0; [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(z)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bsp/mod.rs:339:35 [INFO] [stderr] | [INFO] [stderr] 339 | for (i, o) in offsets.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bsp/mod.rs:340:70 [INFO] [stderr] | [INFO] [stderr] 340 | r.seek(SeekFrom::Start(base_offset + offset as u64 + *o as u64))?; [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:47 [INFO] [stderr] | [INFO] [stderr] 72 | (diff.as_secs() * 1_000_000_000 + diff.subsec_nanos() as u64) as f32 / (1_000_000_000.0 / 60.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(diff.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | let dx = (width as f64 * 0.5) - position.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | let dy = (height as f64 * 0.5) - position.1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quake`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/bsp/mod.rs:339:35 [INFO] [stderr] | [INFO] [stderr] 339 | for (i, o) in offsets.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bsp/mod.rs:340:70 [INFO] [stderr] | [INFO] [stderr] 340 | r.seek(SeekFrom::Start(base_offset + offset as u64 + *o as u64))?; [INFO] [stderr] | ^^^^^^^^^ help: try: `u64::from(*o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:47 [INFO] [stderr] | [INFO] [stderr] 72 | (diff.as_secs() * 1_000_000_000 + diff.subsec_nanos() as u64) as f32 / (1_000_000_000.0 / 60.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(diff.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:108:31 [INFO] [stderr] | [INFO] [stderr] 108 | let dx = (width as f64 * 0.5) - position.0; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | let dy = (height as f64 * 0.5) - position.1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quake`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d3d2b7a5365d9052ae8895ad4e48fd50694850d1b9c9b89edacfccb1fefd9c09"` [INFO] running `"docker" "rm" "-f" "d3d2b7a5365d9052ae8895ad4e48fd50694850d1b9c9b89edacfccb1fefd9c09"` [INFO] [stdout] d3d2b7a5365d9052ae8895ad4e48fd50694850d1b9c9b89edacfccb1fefd9c09