[INFO] updating cached repository Thermatix/wercker_build_status [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Thermatix/wercker_build_status [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Thermatix/wercker_build_status" "work/ex/clippy-test-run/sources/stable/gh/Thermatix/wercker_build_status"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Thermatix/wercker_build_status'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Thermatix/wercker_build_status" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Thermatix/wercker_build_status"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Thermatix/wercker_build_status'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0f4a83eff8dc62dfff4f4b8d7afebe67fbeafb2f [INFO] sha for GitHub repo Thermatix/wercker_build_status: 0f4a83eff8dc62dfff4f4b8d7afebe67fbeafb2f [INFO] validating manifest of Thermatix/wercker_build_status on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Thermatix/wercker_build_status on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Thermatix/wercker_build_status [INFO] finished frobbing Thermatix/wercker_build_status [INFO] frobbed toml for Thermatix/wercker_build_status written to work/ex/clippy-test-run/sources/stable/gh/Thermatix/wercker_build_status/Cargo.toml [INFO] started frobbing Thermatix/wercker_build_status [INFO] finished frobbing Thermatix/wercker_build_status [INFO] frobbed toml for Thermatix/wercker_build_status written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Thermatix/wercker_build_status/Cargo.toml [INFO] crate Thermatix/wercker_build_status has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Thermatix/wercker_build_status against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Thermatix/wercker_build_status:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d40ac29f331eb474b79bee9a6221c381a0f913cb31e1b894217967bbbedc1427 [INFO] running `"docker" "start" "-a" "d40ac29f331eb474b79bee9a6221c381a0f913cb31e1b894217967bbbedc1427"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking socket2 v0.3.4 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking libz-sys v1.0.18 [INFO] [stderr] Checking serde-hjson v0.8.1 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking curl-sys v0.4.1 [INFO] [stderr] Checking curl v0.4.11 [INFO] [stderr] Checking config v0.8.0 [INFO] [stderr] Checking wercker_build_status v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | None => print!("{}","None Found") [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:63:37 [INFO] [stderr] | [INFO] [stderr] 63 | None => print!("{}","None Found") [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/urls.rs:6:28 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn runs(pipline_id: &String,author: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/urls.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn runs(pipline_id: &String,author: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/mod.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn set_up(token: &String) -> Easy { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/mod.rs:21:46 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn get_runs(curl: &mut Easy, pipline_id: &String, author: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/mod.rs:21:63 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn get_runs(curl: &mut Easy, pipline_id: &String, author: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/urls.rs:6:28 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn runs(pipline_id: &String,author: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/urls.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn runs(pipline_id: &String,author: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/mod.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn set_up(token: &String) -> Easy { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/mod.rs:21:46 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn get_runs(curl: &mut Easy, pipline_id: &String, author: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/client/mod.rs:21:63 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn get_runs(curl: &mut Easy, pipline_id: &String, author: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | &run.user.meta.username.to_lowercase() == &settings["author"].to_lowercase() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 43 | run.user.meta.username.to_lowercase() == settings["author"].to_lowercase() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:47:57 [INFO] [stderr] | [INFO] [stderr] 47 | if settings.contains_key("tmux") && &settings["tmux"] == &"true".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 47 | if settings.contains_key("tmux") && settings["tmux"] == "true".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | &run.user.meta.username.to_lowercase() == &settings["author"].to_lowercase() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 43 | run.user.meta.username.to_lowercase() == settings["author"].to_lowercase() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:47:57 [INFO] [stderr] | [INFO] [stderr] 47 | if settings.contains_key("tmux") && &settings["tmux"] == &"true".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 47 | if settings.contains_key("tmux") && settings["tmux"] == "true".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.55s [INFO] running `"docker" "inspect" "d40ac29f331eb474b79bee9a6221c381a0f913cb31e1b894217967bbbedc1427"` [INFO] running `"docker" "rm" "-f" "d40ac29f331eb474b79bee9a6221c381a0f913cb31e1b894217967bbbedc1427"` [INFO] [stdout] d40ac29f331eb474b79bee9a6221c381a0f913cb31e1b894217967bbbedc1427