[INFO] updating cached repository TheoLeanse/rust-wasm-crackle-pop [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheoLeanse/rust-wasm-crackle-pop [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheoLeanse/rust-wasm-crackle-pop" "work/ex/clippy-test-run/sources/stable/gh/TheoLeanse/rust-wasm-crackle-pop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheoLeanse/rust-wasm-crackle-pop'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheoLeanse/rust-wasm-crackle-pop" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheoLeanse/rust-wasm-crackle-pop"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheoLeanse/rust-wasm-crackle-pop'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fc0ecf003a30a99cd4ad2bff5fb196f1a5d01f6f [INFO] sha for GitHub repo TheoLeanse/rust-wasm-crackle-pop: fc0ecf003a30a99cd4ad2bff5fb196f1a5d01f6f [INFO] validating manifest of TheoLeanse/rust-wasm-crackle-pop on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheoLeanse/rust-wasm-crackle-pop on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheoLeanse/rust-wasm-crackle-pop [INFO] finished frobbing TheoLeanse/rust-wasm-crackle-pop [INFO] frobbed toml for TheoLeanse/rust-wasm-crackle-pop written to work/ex/clippy-test-run/sources/stable/gh/TheoLeanse/rust-wasm-crackle-pop/Cargo.toml [INFO] started frobbing TheoLeanse/rust-wasm-crackle-pop [INFO] finished frobbing TheoLeanse/rust-wasm-crackle-pop [INFO] frobbed toml for TheoLeanse/rust-wasm-crackle-pop written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheoLeanse/rust-wasm-crackle-pop/Cargo.toml [INFO] crate TheoLeanse/rust-wasm-crackle-pop has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheoLeanse/rust-wasm-crackle-pop against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TheoLeanse/rust-wasm-crackle-pop:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ddd0b6d366fdd66f7281dfffdabae04f30e8f5fa7721887163acc499abaf7666 [INFO] running `"docker" "start" "-a" "ddd0b6d366fdd66f7281dfffdabae04f30e8f5fa7721887163acc499abaf7666"` [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.27 [INFO] [stderr] Compiling wasm-bindgen v0.2.27 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.27 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.27 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.27 [INFO] [stderr] Checking rust-wasm-crackle-pop v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return String::from("CracklePop"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("CracklePop")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return String::from("Crackle"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Crackle")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return String::from("Pop"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Pop")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return x.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return y % x == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `y % x == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | for number in 1..limit+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return String::from("CracklePop"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("CracklePop")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return String::from("Crackle"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Crackle")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return String::from("Pop"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Pop")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return x.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return y % x == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `y % x == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | for number in 1..limit+1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.82s [INFO] running `"docker" "inspect" "ddd0b6d366fdd66f7281dfffdabae04f30e8f5fa7721887163acc499abaf7666"` [INFO] running `"docker" "rm" "-f" "ddd0b6d366fdd66f7281dfffdabae04f30e8f5fa7721887163acc499abaf7666"` [INFO] [stdout] ddd0b6d366fdd66f7281dfffdabae04f30e8f5fa7721887163acc499abaf7666