[INFO] updating cached repository TheStilbruch/bind-shell.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheStilbruch/bind-shell.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheStilbruch/bind-shell.rs" "work/ex/clippy-test-run/sources/stable/gh/TheStilbruch/bind-shell.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheStilbruch/bind-shell.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheStilbruch/bind-shell.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheStilbruch/bind-shell.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheStilbruch/bind-shell.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d6aaad4c0939919de59dc1ff232c029f328910e1 [INFO] sha for GitHub repo TheStilbruch/bind-shell.rs: d6aaad4c0939919de59dc1ff232c029f328910e1 [INFO] validating manifest of TheStilbruch/bind-shell.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheStilbruch/bind-shell.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheStilbruch/bind-shell.rs [INFO] finished frobbing TheStilbruch/bind-shell.rs [INFO] frobbed toml for TheStilbruch/bind-shell.rs written to work/ex/clippy-test-run/sources/stable/gh/TheStilbruch/bind-shell.rs/Cargo.toml [INFO] started frobbing TheStilbruch/bind-shell.rs [INFO] finished frobbing TheStilbruch/bind-shell.rs [INFO] frobbed toml for TheStilbruch/bind-shell.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheStilbruch/bind-shell.rs/Cargo.toml [INFO] crate TheStilbruch/bind-shell.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheStilbruch/bind-shell.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TheStilbruch/bind-shell.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0fc208cdeb3c3edac2e307ec9fa3d6377a95fefee322c9fcde1c40d563ac8c55 [INFO] running `"docker" "start" "-a" "0fc208cdeb3c3edac2e307ec9fa3d6377a95fefee322c9fcde1c40d563ac8c55"` [INFO] [stderr] Checking rust-bind-shell v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match connection { [INFO] [stderr] 58 | | Ok(stream) => { [INFO] [stderr] 59 | | thread::spawn(|| unsafe { [INFO] [stderr] 60 | | handle_client(stream); [INFO] [stderr] ... | [INFO] [stderr] 63 | | Err(_) => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match connection { [INFO] [stderr] 58 | | Ok(stream) => { [INFO] [stderr] 59 | | thread::spawn(|| unsafe { [INFO] [stderr] 60 | | handle_client(stream); [INFO] [stderr] ... | [INFO] [stderr] 63 | | Err(_) => {} [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 57 | if let Ok(stream) = connection { [INFO] [stderr] 58 | thread::spawn(|| unsafe { [INFO] [stderr] 59 | handle_client(stream); [INFO] [stderr] 60 | }); [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 57 | if let Ok(stream) = connection { [INFO] [stderr] 58 | thread::spawn(|| unsafe { [INFO] [stderr] 59 | handle_client(stream); [INFO] [stderr] 60 | }); [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.05s [INFO] running `"docker" "inspect" "0fc208cdeb3c3edac2e307ec9fa3d6377a95fefee322c9fcde1c40d563ac8c55"` [INFO] running `"docker" "rm" "-f" "0fc208cdeb3c3edac2e307ec9fa3d6377a95fefee322c9fcde1c40d563ac8c55"` [INFO] [stdout] 0fc208cdeb3c3edac2e307ec9fa3d6377a95fefee322c9fcde1c40d563ac8c55