[INFO] updating cached repository TheSpiritXIII/Texture-Atlas [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheSpiritXIII/Texture-Atlas [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheSpiritXIII/Texture-Atlas" "work/ex/clippy-test-run/sources/stable/gh/TheSpiritXIII/Texture-Atlas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheSpiritXIII/Texture-Atlas'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheSpiritXIII/Texture-Atlas" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheSpiritXIII/Texture-Atlas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheSpiritXIII/Texture-Atlas'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] db428558dbd12004264960ce884e9e9dcb6ccdba [INFO] sha for GitHub repo TheSpiritXIII/Texture-Atlas: db428558dbd12004264960ce884e9e9dcb6ccdba [INFO] validating manifest of TheSpiritXIII/Texture-Atlas on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheSpiritXIII/Texture-Atlas on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheSpiritXIII/Texture-Atlas [INFO] finished frobbing TheSpiritXIII/Texture-Atlas [INFO] frobbed toml for TheSpiritXIII/Texture-Atlas written to work/ex/clippy-test-run/sources/stable/gh/TheSpiritXIII/Texture-Atlas/Cargo.toml [INFO] started frobbing TheSpiritXIII/Texture-Atlas [INFO] finished frobbing TheSpiritXIII/Texture-Atlas [INFO] frobbed toml for TheSpiritXIII/Texture-Atlas written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheSpiritXIII/Texture-Atlas/Cargo.toml [INFO] crate TheSpiritXIII/Texture-Atlas has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheSpiritXIII/Texture-Atlas against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TheSpiritXIII/Texture-Atlas:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c75c6f4c856dfe97fdb2aaa06dd857fcaeaa46d892e4c8c0e78640d1573ab1a [INFO] running `"docker" "start" "-a" "8c75c6f4c856dfe97fdb2aaa06dd857fcaeaa46d892e4c8c0e78640d1573ab1a"` [INFO] [stderr] Checking texture_atlas v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:63:4 [INFO] [stderr] | [INFO] [stderr] 63 | bin: bin, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:64:4 [INFO] [stderr] | [INFO] [stderr] 64 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:63:4 [INFO] [stderr] | [INFO] [stderr] 63 | bin: bin, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:64:4 [INFO] [stderr] | [INFO] [stderr] 64 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:66:4 [INFO] [stderr] | [INFO] [stderr] 66 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:65:4 [INFO] [stderr] | [INFO] [stderr] 65 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:66:4 [INFO] [stderr] | [INFO] [stderr] 66 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gen/binary_tree.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | let sat = self.data[1] as f32 / u8::max_value() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | let sat = self.data[1] as f32 / u8::max_value() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | let val = self.data[2] as f32 / u8::max_value() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:150:35 [INFO] [stderr] | [INFO] [stderr] 150 | let val = self.data[2] as f32 / u8::max_value() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | let h_prime = self.data[0] as f32 / u8::max_value() as f32 * (359.0 / 60.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:153:39 [INFO] [stderr] | [INFO] [stderr] 153 | let h_prime = self.data[0] as f32 / u8::max_value() as f32 * (359.0 / 60.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:172:24 [INFO] [stderr] | [INFO] [stderr] 172 | ((result[0] + m) * u8::max_value() as f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | ((result[1] + m) * u8::max_value() as f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:174:24 [INFO] [stderr] | [INFO] [stderr] 174 | ((result[2] + m) * u8::max_value() as f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | self.width() as u64 * self.height() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | self.width() as u64 * self.height() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:147:6 [INFO] [stderr] | [INFO] [stderr] 147 | if (self.width() >= self.height() && rotate) || !rotate [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 147 | if !rotate || self.width() >= self.height() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 147 | if !(self.width() < self.height() && rotate) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `AtlasRectList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:264:1 [INFO] [stderr] | [INFO] [stderr] 264 | / impl AtlasRectList where T: AtlasRect [INFO] [stderr] 265 | | { [INFO] [stderr] 266 | | /// Constructs a new, empty list. [INFO] [stderr] 267 | | pub fn new() -> Self [INFO] [stderr] ... | [INFO] [stderr] 318 | | } [INFO] [stderr] 319 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `AtlasRectList` [INFO] [stderr] --> src/lib.rs:267:2 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn new() -> Self [INFO] [stderr] | _____^ [INFO] [stderr] 268 | | { [INFO] [stderr] 269 | | AtlasRectList [INFO] [stderr] 270 | | { [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 258 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | let sat = self.data[1] as f32 / u8::max_value() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:149:35 [INFO] [stderr] | [INFO] [stderr] 149 | let sat = self.data[1] as f32 / u8::max_value() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | let val = self.data[2] as f32 / u8::max_value() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:150:35 [INFO] [stderr] | [INFO] [stderr] 150 | let val = self.data[2] as f32 / u8::max_value() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | let h_prime = self.data[0] as f32 / u8::max_value() as f32 * (359.0 / 60.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:153:39 [INFO] [stderr] | [INFO] [stderr] 153 | let h_prime = self.data[0] as f32 / u8::max_value() as f32 * (359.0 / 60.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:172:24 [INFO] [stderr] | [INFO] [stderr] 172 | ((result[0] + m) * u8::max_value() as f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | ((result[1] + m) * u8::max_value() as f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/util/img.rs:174:24 [INFO] [stderr] | [INFO] [stderr] 174 | ((result[2] + m) * u8::max_value() as f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:110:3 [INFO] [stderr] | [INFO] [stderr] 110 | self.width() as u64 * self.height() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | self.width() as u64 * self.height() as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:147:6 [INFO] [stderr] | [INFO] [stderr] 147 | if (self.width() >= self.height() && rotate) || !rotate [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 147 | if !rotate || self.width() >= self.height() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 147 | if !(self.width() < self.height() && rotate) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: item `AtlasRectList` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:264:1 [INFO] [stderr] | [INFO] [stderr] 264 | / impl AtlasRectList where T: AtlasRect [INFO] [stderr] 265 | | { [INFO] [stderr] 266 | | /// Constructs a new, empty list. [INFO] [stderr] 267 | | pub fn new() -> Self [INFO] [stderr] ... | [INFO] [stderr] 318 | | } [INFO] [stderr] 319 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `AtlasRectList` [INFO] [stderr] --> src/lib.rs:267:2 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn new() -> Self [INFO] [stderr] | _____^ [INFO] [stderr] 268 | | { [INFO] [stderr] 269 | | AtlasRectList [INFO] [stderr] 270 | | { [INFO] [stderr] ... | [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 258 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests.rs:21:4 [INFO] [stderr] | [INFO] [stderr] 21 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests.rs:22:4 [INFO] [stderr] | [INFO] [stderr] 22 | rect_index: rect_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rect_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests.rs:23:4 [INFO] [stderr] | [INFO] [stderr] 23 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.31s [INFO] running `"docker" "inspect" "8c75c6f4c856dfe97fdb2aaa06dd857fcaeaa46d892e4c8c0e78640d1573ab1a"` [INFO] running `"docker" "rm" "-f" "8c75c6f4c856dfe97fdb2aaa06dd857fcaeaa46d892e4c8c0e78640d1573ab1a"` [INFO] [stdout] 8c75c6f4c856dfe97fdb2aaa06dd857fcaeaa46d892e4c8c0e78640d1573ab1a