[INFO] updating cached repository TheSoftwareFactory/pulurobot-sequencer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheSoftwareFactory/pulurobot-sequencer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheSoftwareFactory/pulurobot-sequencer" "work/ex/clippy-test-run/sources/stable/gh/TheSoftwareFactory/pulurobot-sequencer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheSoftwareFactory/pulurobot-sequencer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheSoftwareFactory/pulurobot-sequencer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheSoftwareFactory/pulurobot-sequencer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheSoftwareFactory/pulurobot-sequencer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0a2bee1ba827cdbde52f9b828e773481d552b701 [INFO] sha for GitHub repo TheSoftwareFactory/pulurobot-sequencer: 0a2bee1ba827cdbde52f9b828e773481d552b701 [INFO] validating manifest of TheSoftwareFactory/pulurobot-sequencer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheSoftwareFactory/pulurobot-sequencer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheSoftwareFactory/pulurobot-sequencer [INFO] finished frobbing TheSoftwareFactory/pulurobot-sequencer [INFO] frobbed toml for TheSoftwareFactory/pulurobot-sequencer written to work/ex/clippy-test-run/sources/stable/gh/TheSoftwareFactory/pulurobot-sequencer/Cargo.toml [INFO] started frobbing TheSoftwareFactory/pulurobot-sequencer [INFO] finished frobbing TheSoftwareFactory/pulurobot-sequencer [INFO] frobbed toml for TheSoftwareFactory/pulurobot-sequencer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheSoftwareFactory/pulurobot-sequencer/Cargo.toml [INFO] crate TheSoftwareFactory/pulurobot-sequencer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheSoftwareFactory/pulurobot-sequencer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TheSoftwareFactory/pulurobot-sequencer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c3d4a5c32e6d6702ab481c9c958cb1df215e1ec58de484124fb65ff35a4bb53 [INFO] running `"docker" "start" "-a" "6c3d4a5c32e6d6702ab481c9c958cb1df215e1ec58de484124fb65ff35a4bb53"` [INFO] [stderr] Checking pulurobot-sequencer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | stream.as_mut().unwrap().read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | stream.as_mut().unwrap().read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | self.signal_ch.send(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | self.signal_ch.send(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | / match stream.read_to_end(&mut buf).is_ok() && buf.len() > 0 { [INFO] [stderr] 153 | | true => { [INFO] [stderr] 154 | | read_conn.stop(); [INFO] [stderr] 155 | | write_conn.start(); [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 152 | if stream.read_to_end(&mut buf).is_ok() && buf.len() > 0 { [INFO] [stderr] 153 | read_conn.stop(); [INFO] [stderr] 154 | write_conn.start(); [INFO] [stderr] 155 | [INFO] [stderr] 156 | println!("buf {:?}", buf); [INFO] [stderr] 157 | write_conn.data_ch.send(buf).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:152:67 [INFO] [stderr] | [INFO] [stderr] 152 | match stream.read_to_end(&mut buf).is_ok() && buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:180:29 [INFO] [stderr] | [INFO] [stderr] 180 | stream.write(&slice[..]).expect("write slice failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pulurobot-sequencer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | stream.as_mut().unwrap().read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/main.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | stream.as_mut().unwrap().read(&mut buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | self.signal_ch.send(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | self.signal_ch.send(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | / match stream.read_to_end(&mut buf).is_ok() && buf.len() > 0 { [INFO] [stderr] 153 | | true => { [INFO] [stderr] 154 | | read_conn.stop(); [INFO] [stderr] 155 | | write_conn.start(); [INFO] [stderr] ... | [INFO] [stderr] 182 | | } [INFO] [stderr] 183 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 152 | if stream.read_to_end(&mut buf).is_ok() && buf.len() > 0 { [INFO] [stderr] 153 | read_conn.stop(); [INFO] [stderr] 154 | write_conn.start(); [INFO] [stderr] 155 | [INFO] [stderr] 156 | println!("buf {:?}", buf); [INFO] [stderr] 157 | write_conn.data_ch.send(buf).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:152:67 [INFO] [stderr] | [INFO] [stderr] 152 | match stream.read_to_end(&mut buf).is_ok() && buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:180:29 [INFO] [stderr] | [INFO] [stderr] 180 | stream.write(&slice[..]).expect("write slice failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pulurobot-sequencer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6c3d4a5c32e6d6702ab481c9c958cb1df215e1ec58de484124fb65ff35a4bb53"` [INFO] running `"docker" "rm" "-f" "6c3d4a5c32e6d6702ab481c9c958cb1df215e1ec58de484124fb65ff35a4bb53"` [INFO] [stdout] 6c3d4a5c32e6d6702ab481c9c958cb1df215e1ec58de484124fb65ff35a4bb53