[INFO] updating cached repository TheRealBluesun/vm_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheRealBluesun/vm_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheRealBluesun/vm_rust" "work/ex/clippy-test-run/sources/stable/gh/TheRealBluesun/vm_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheRealBluesun/vm_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheRealBluesun/vm_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheRealBluesun/vm_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheRealBluesun/vm_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 689c4c427e58c8b45711ff92cb69fcd4e33aeb2f [INFO] sha for GitHub repo TheRealBluesun/vm_rust: 689c4c427e58c8b45711ff92cb69fcd4e33aeb2f [INFO] validating manifest of TheRealBluesun/vm_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheRealBluesun/vm_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheRealBluesun/vm_rust [INFO] finished frobbing TheRealBluesun/vm_rust [INFO] frobbed toml for TheRealBluesun/vm_rust written to work/ex/clippy-test-run/sources/stable/gh/TheRealBluesun/vm_rust/Cargo.toml [INFO] started frobbing TheRealBluesun/vm_rust [INFO] finished frobbing TheRealBluesun/vm_rust [INFO] frobbed toml for TheRealBluesun/vm_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheRealBluesun/vm_rust/Cargo.toml [INFO] crate TheRealBluesun/vm_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheRealBluesun/vm_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TheRealBluesun/vm_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9d222b6d12af1706722b827b566f3178cb3d189c8104e6ff7dd5734b19195c40 [INFO] running `"docker" "start" "-a" "9d222b6d12af1706722b827b566f3178cb3d189c8104e6ff7dd5734b19195c40"` [INFO] [stderr] Checking vm_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | Instruction { opcode: opcode } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/instruction.rs:25:19 [INFO] [stderr] | [INFO] [stderr] 25 | Instruction { opcode: opcode } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return opcode; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | 0 => return Opcode::HLT, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::HLT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | 1 => return Opcode::LOAD, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::LOAD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | 2 => return Opcode::ADD, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::ADD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | 3 => return Opcode::MUL, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::MUL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | 4 => return Opcode::DIV, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::DIV` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | 5 => return Opcode::JMP, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMP` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | 6 => return Opcode::JMPF, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | 7 => return Opcode::JMPB, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | 8 => return Opcode::EQ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::EQ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | 9 => return Opcode::JEQ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JEQ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | 10 => return Opcode::JNE, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JNE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | 11 => return Opcode::NOP, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::NOP` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | _ => return Opcode::IGL, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::IGL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vm.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | return opcode; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | 0 => return Opcode::HLT, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::HLT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | 1 => return Opcode::LOAD, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::LOAD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:34:12 [INFO] [stderr] | [INFO] [stderr] 34 | 2 => return Opcode::ADD, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::ADD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | 3 => return Opcode::MUL, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::MUL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | 4 => return Opcode::DIV, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::DIV` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | 5 => return Opcode::JMP, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMP` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | 6 => return Opcode::JMPF, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:39:12 [INFO] [stderr] | [INFO] [stderr] 39 | 7 => return Opcode::JMPB, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JMPB` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:40:12 [INFO] [stderr] | [INFO] [stderr] 40 | 8 => return Opcode::EQ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::EQ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:41:12 [INFO] [stderr] | [INFO] [stderr] 41 | 9 => return Opcode::JEQ, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JEQ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | 10 => return Opcode::JNE, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::JNE` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | 11 => return Opcode::NOP, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::NOP` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/instruction.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | _ => return Opcode::IGL, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Opcode::IGL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> VM { [INFO] [stderr] 14 | | VM { [INFO] [stderr] 15 | | registers: [0; 32], [INFO] [stderr] 16 | | program: vec![], [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | self.registers[register] = val as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | let result = (self.program[self.pc] as u16) << 8 | (self.program[self.pc + 1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:111:60 [INFO] [stderr] | [INFO] [stderr] 111 | let result = (self.program[self.pc] as u16) << 8 | (self.program[self.pc + 1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> VM { [INFO] [stderr] 14 | | VM { [INFO] [stderr] 15 | | registers: [0; 32], [INFO] [stderr] 16 | | program: vec![], [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | self.registers[register] = val as i32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:111:22 [INFO] [stderr] | [INFO] [stderr] 111 | let result = (self.program[self.pc] as u16) << 8 | (self.program[self.pc + 1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:111:60 [INFO] [stderr] | [INFO] [stderr] 111 | let result = (self.program[self.pc] as u16) << 8 | (self.program[self.pc + 1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.program[self.pc + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:174:56 [INFO] [stderr] | [INFO] [stderr] 174 | assert_eq!(test_vm.registers[0x02] as u32, val1 as u32 + val2 as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(val1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:174:70 [INFO] [stderr] | [INFO] [stderr] 174 | assert_eq!(test_vm.registers[0x02] as u32, val1 as u32 + val2 as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:190:56 [INFO] [stderr] | [INFO] [stderr] 190 | assert_eq!(test_vm.registers[0x02] as u32, val1 as u32 * val2 as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(val1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:190:70 [INFO] [stderr] | [INFO] [stderr] 190 | assert_eq!(test_vm.registers[0x02] as u32, val1 as u32 * val2 as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:206:56 [INFO] [stderr] | [INFO] [stderr] 206 | assert_eq!(test_vm.registers[0x02] as u32, val1 as u32 / val2 as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(val1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:206:70 [INFO] [stderr] | [INFO] [stderr] 206 | assert_eq!(test_vm.registers[0x02] as u32, val1 as u32 / val2 as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:207:43 [INFO] [stderr] | [INFO] [stderr] 207 | assert_eq!(test_vm.remainder, val1 as u32 % val2 as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(val1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/vm.rs:207:57 [INFO] [stderr] | [INFO] [stderr] 207 | assert_eq!(test_vm.remainder, val1 as u32 % val2 as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "9d222b6d12af1706722b827b566f3178cb3d189c8104e6ff7dd5734b19195c40"` [INFO] running `"docker" "rm" "-f" "9d222b6d12af1706722b827b566f3178cb3d189c8104e6ff7dd5734b19195c40"` [INFO] [stdout] 9d222b6d12af1706722b827b566f3178cb3d189c8104e6ff7dd5734b19195c40