[INFO] updating cached repository TheNumerus/DistanceFieldComputer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheNumerus/DistanceFieldComputer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheNumerus/DistanceFieldComputer" "work/ex/clippy-test-run/sources/stable/gh/TheNumerus/DistanceFieldComputer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheNumerus/DistanceFieldComputer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheNumerus/DistanceFieldComputer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheNumerus/DistanceFieldComputer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheNumerus/DistanceFieldComputer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dd27554fd6adb25725175ad50248ebf4263633b7 [INFO] sha for GitHub repo TheNumerus/DistanceFieldComputer: dd27554fd6adb25725175ad50248ebf4263633b7 [INFO] validating manifest of TheNumerus/DistanceFieldComputer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheNumerus/DistanceFieldComputer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheNumerus/DistanceFieldComputer [INFO] finished frobbing TheNumerus/DistanceFieldComputer [INFO] frobbed toml for TheNumerus/DistanceFieldComputer written to work/ex/clippy-test-run/sources/stable/gh/TheNumerus/DistanceFieldComputer/Cargo.toml [INFO] started frobbing TheNumerus/DistanceFieldComputer [INFO] finished frobbing TheNumerus/DistanceFieldComputer [INFO] frobbed toml for TheNumerus/DistanceFieldComputer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheNumerus/DistanceFieldComputer/Cargo.toml [INFO] crate TheNumerus/DistanceFieldComputer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheNumerus/DistanceFieldComputer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TheNumerus/DistanceFieldComputer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e34b86367f8a5672b62a3bdcd449d5dc82920266913085957dcd9f6789f1bd95 [INFO] running `"docker" "start" "-a" "e34b86367f8a5672b62a3bdcd449d5dc82920266913085957dcd9f6789f1bd95"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling syn v0.13.10 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Compiling num-derive v0.2.1 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking distance_field v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/generator.rs:12:38 [INFO] [stderr] | [INFO] [stderr] 12 | CaptureHeight::Generated => (ext.max as f32 / 255.0) * settings.radius as f32 * settings.img_height_mult, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(ext.max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/generator.rs:13:45 [INFO] [stderr] | [INFO] [stderr] 13 | CaptureHeight::UserDefined(val) => (val as f32 / 255.0) * settings.radius as f32 * settings.img_height_mult, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:83:89 [INFO] [stderr] | [INFO] [stderr] 83 | unsafe fn get_distance_avx2_repeat(x: isize, y: isize, capture_height: f32, spiral: &Vec<(isize, isize)>, mesh: &Mesh, zero_index: isize) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(isize, isize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:105:88 [INFO] [stderr] | [INFO] [stderr] 105 | unsafe fn get_distance_avx2_clamp(x: isize, y: isize, capture_height: f32, spiral: &Vec<(isize, isize)>, mesh: &Mesh, zero_index: isize) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(isize, isize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:189:55 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn generate_image(dim: (usize, usize), distances: &Vec) -> ImageBuffer, Vec> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dist]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: item `vec3::Vec3` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/vec3.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl Vec3 { [INFO] [stderr] 12 | | pub fn new(coords: (f32, f32, f32)) -> Vec3 { [INFO] [stderr] 13 | | Vec3 { [INFO] [stderr] 14 | | x: coords.0, [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/generator.rs:12:38 [INFO] [stderr] | [INFO] [stderr] 12 | CaptureHeight::Generated => (ext.max as f32 / 255.0) * settings.radius as f32 * settings.img_height_mult, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f32::from(ext.max)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/generator.rs:13:45 [INFO] [stderr] | [INFO] [stderr] 13 | CaptureHeight::UserDefined(val) => (val as f32 / 255.0) * settings.radius as f32 * settings.img_height_mult, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:83:89 [INFO] [stderr] | [INFO] [stderr] 83 | unsafe fn get_distance_avx2_repeat(x: isize, y: isize, capture_height: f32, spiral: &Vec<(isize, isize)>, mesh: &Mesh, zero_index: isize) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(isize, isize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:105:88 [INFO] [stderr] | [INFO] [stderr] 105 | unsafe fn get_distance_avx2_clamp(x: isize, y: isize, capture_height: f32, spiral: &Vec<(isize, isize)>, mesh: &Mesh, zero_index: isize) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(isize, isize)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:189:55 [INFO] [stderr] | [INFO] [stderr] 189 | pub fn generate_image(dim: (usize, usize), distances: &Vec) -> ImageBuffer, Vec> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Dist]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: item `vec3::Vec3` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/vec3.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl Vec3 { [INFO] [stderr] 12 | | pub fn new(coords: (f32, f32, f32)) -> Vec3 { [INFO] [stderr] 13 | | Vec3 { [INFO] [stderr] 14 | | x: coords.0, [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.86s [INFO] running `"docker" "inspect" "e34b86367f8a5672b62a3bdcd449d5dc82920266913085957dcd9f6789f1bd95"` [INFO] running `"docker" "rm" "-f" "e34b86367f8a5672b62a3bdcd449d5dc82920266913085957dcd9f6789f1bd95"` [INFO] [stdout] e34b86367f8a5672b62a3bdcd449d5dc82920266913085957dcd9f6789f1bd95