[INFO] updating cached repository TheNeikos/rustdock [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheNeikos/rustdock [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheNeikos/rustdock" "work/ex/clippy-test-run/sources/stable/gh/TheNeikos/rustdock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheNeikos/rustdock'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheNeikos/rustdock" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheNeikos/rustdock"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheNeikos/rustdock'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bdcd606a19eac6a619d7c4aa7b9f829e545c9b9f [INFO] sha for GitHub repo TheNeikos/rustdock: bdcd606a19eac6a619d7c4aa7b9f829e545c9b9f [INFO] validating manifest of TheNeikos/rustdock on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheNeikos/rustdock on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheNeikos/rustdock [INFO] finished frobbing TheNeikos/rustdock [INFO] frobbed toml for TheNeikos/rustdock written to work/ex/clippy-test-run/sources/stable/gh/TheNeikos/rustdock/Cargo.toml [INFO] started frobbing TheNeikos/rustdock [INFO] finished frobbing TheNeikos/rustdock [INFO] frobbed toml for TheNeikos/rustdock written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheNeikos/rustdock/Cargo.toml [INFO] crate TheNeikos/rustdock has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheNeikos/rustdock against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TheNeikos/rustdock:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fabe5689be00c7f5b80cdaddab307df31ce0a56fcb144c3fa67c96056a29b293 [INFO] running `"docker" "start" "-a" "fabe5689be00c7f5b80cdaddab307df31ce0a56fcb144c3fa67c96056a29b293"` [INFO] [stderr] Compiling x11 v2.18.0 [INFO] [stderr] Checking textwidth v1.1.0 [INFO] [stderr] Checking rustdock v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | return *width; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `*width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return toml::from_str(&content).expect("Config file is an invalid toml file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `toml::from_str(&content).expect("Config file is an invalid toml file")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return config; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return Some(from_path(path.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(from_path(path.into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return from_path(config_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from_path(config_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | return *width; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `*width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:48:17 [INFO] [stderr] | [INFO] [stderr] 48 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return toml::from_str(&content).expect("Config file is an invalid toml file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `toml::from_str(&content).expect("Config file is an invalid toml file")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return config; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return Some(from_path(path.into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(from_path(path.into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return from_path(config_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from_path(config_path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `elem` [INFO] [stderr] --> src/main.rs:175:18 [INFO] [stderr] | [INFO] [stderr] 175 | for (elem, idx) in config.elements[last_index..].iter().zip(last_index..) { [INFO] [stderr] | ^^^^ help: consider using `_elem` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `elem` [INFO] [stderr] --> src/main.rs:175:18 [INFO] [stderr] | [INFO] [stderr] 175 | for (elem, idx) in config.elements[last_index..].iter().zip(last_index..) { [INFO] [stderr] | ^^^^ help: consider using `_elem` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/config.rs:62:38 [INFO] [stderr] | [INFO] [stderr] 62 | let mut file = File::open(&path).expect(&format!("Could not open file {}", path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open file {}", path.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/config.rs:62:38 [INFO] [stderr] | [INFO] [stderr] 62 | let mut file = File::open(&path).expect(&format!("Could not open file {}", path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open file {}", path.display()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:90:51 [INFO] [stderr] | [INFO] [stderr] 90 | let shell = env::var("SHELL").unwrap_or("/bin/sh".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/bin/sh".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:117:51 [INFO] [stderr] | [INFO] [stderr] 117 | let shell = env::var("SHELL").unwrap_or("/bin/sh".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/bin/sh".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | let time = Duration::from_millis(time as u64) - start.elapsed(); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(time)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:90:51 [INFO] [stderr] | [INFO] [stderr] 90 | let shell = env::var("SHELL").unwrap_or("/bin/sh".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/bin/sh".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:117:51 [INFO] [stderr] | [INFO] [stderr] 117 | let shell = env::var("SHELL").unwrap_or("/bin/sh".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/bin/sh".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | let time = Duration::from_millis(time as u64) - start.elapsed(); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(time)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.20s [INFO] running `"docker" "inspect" "fabe5689be00c7f5b80cdaddab307df31ce0a56fcb144c3fa67c96056a29b293"` [INFO] running `"docker" "rm" "-f" "fabe5689be00c7f5b80cdaddab307df31ce0a56fcb144c3fa67c96056a29b293"` [INFO] [stdout] fabe5689be00c7f5b80cdaddab307df31ce0a56fcb144c3fa67c96056a29b293