[INFO] updating cached repository TheGizmoDojo/UltrasonicPiPiano [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheGizmoDojo/UltrasonicPiPiano [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheGizmoDojo/UltrasonicPiPiano" "work/ex/clippy-test-run/sources/stable/gh/TheGizmoDojo/UltrasonicPiPiano"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheGizmoDojo/UltrasonicPiPiano'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheGizmoDojo/UltrasonicPiPiano" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheGizmoDojo/UltrasonicPiPiano"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheGizmoDojo/UltrasonicPiPiano'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ceb3f3be1a3455b58d4c22a1f5fad547135ab97d [INFO] sha for GitHub repo TheGizmoDojo/UltrasonicPiPiano: ceb3f3be1a3455b58d4c22a1f5fad547135ab97d [INFO] validating manifest of TheGizmoDojo/UltrasonicPiPiano on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheGizmoDojo/UltrasonicPiPiano on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheGizmoDojo/UltrasonicPiPiano [INFO] finished frobbing TheGizmoDojo/UltrasonicPiPiano [INFO] frobbed toml for TheGizmoDojo/UltrasonicPiPiano written to work/ex/clippy-test-run/sources/stable/gh/TheGizmoDojo/UltrasonicPiPiano/Cargo.toml [INFO] started frobbing TheGizmoDojo/UltrasonicPiPiano [INFO] finished frobbing TheGizmoDojo/UltrasonicPiPiano [INFO] frobbed toml for TheGizmoDojo/UltrasonicPiPiano written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheGizmoDojo/UltrasonicPiPiano/Cargo.toml [INFO] crate TheGizmoDojo/UltrasonicPiPiano has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheGizmoDojo/UltrasonicPiPiano against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TheGizmoDojo/UltrasonicPiPiano:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef68d3e86729262686b3ffe5886306e0d6e81e1da1b6ca74b0248b9ca80c5207 [INFO] running `"docker" "start" "-a" "ef68d3e86729262686b3ffe5886306e0d6e81e1da1b6ca74b0248b9ca80c5207"` [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking nix v0.6.0 [INFO] [stderr] Checking spidev v0.2.1 [INFO] [stderr] Checking sysfs_gpio v0.4.4 [INFO] [stderr] Checking sysfs_gpio v0.5.0 [INFO] [stderr] Checking octasonic v0.1.0 [INFO] [stderr] Checking ultrasonic_piano v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | / fn main() { [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | //speak(format!("Raspberry Pi Piano Starting Up")); [INFO] [stderr] 55 | | [INFO] [stderr] ... | [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | Err(_) => panic!("Failed to initialize SPI - have you enabled SPI in the Raspberry Pi Configuration Utility?") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | key[i].counter = key[i].counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key[i].counter += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:269:33 [INFO] [stderr] | [INFO] [stderr] 269 | fn shutdown(synth: &Synth, key: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/main.rs:52:1 [INFO] [stderr] | [INFO] [stderr] 52 | / fn main() { [INFO] [stderr] 53 | | [INFO] [stderr] 54 | | //speak(format!("Raspberry Pi Piano Starting Up")); [INFO] [stderr] 55 | | [INFO] [stderr] ... | [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | Err(_) => panic!("Failed to initialize SPI - have you enabled SPI in the Raspberry Pi Configuration Utility?") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | key[i].counter = key[i].counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key[i].counter += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:269:33 [INFO] [stderr] | [INFO] [stderr] 269 | fn shutdown(synth: &Synth, key: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.56s [INFO] running `"docker" "inspect" "ef68d3e86729262686b3ffe5886306e0d6e81e1da1b6ca74b0248b9ca80c5207"` [INFO] running `"docker" "rm" "-f" "ef68d3e86729262686b3ffe5886306e0d6e81e1da1b6ca74b0248b9ca80c5207"` [INFO] [stdout] ef68d3e86729262686b3ffe5886306e0d6e81e1da1b6ca74b0248b9ca80c5207