[INFO] updating cached repository TheEighthByte/Snake-Game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TheEighthByte/Snake-Game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TheEighthByte/Snake-Game" "work/ex/clippy-test-run/sources/stable/gh/TheEighthByte/Snake-Game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TheEighthByte/Snake-Game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TheEighthByte/Snake-Game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheEighthByte/Snake-Game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheEighthByte/Snake-Game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 53f9882444fb97794193169b1f00b4e48180352d [INFO] sha for GitHub repo TheEighthByte/Snake-Game: 53f9882444fb97794193169b1f00b4e48180352d [INFO] validating manifest of TheEighthByte/Snake-Game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TheEighthByte/Snake-Game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TheEighthByte/Snake-Game [INFO] finished frobbing TheEighthByte/Snake-Game [INFO] frobbed toml for TheEighthByte/Snake-Game written to work/ex/clippy-test-run/sources/stable/gh/TheEighthByte/Snake-Game/Cargo.toml [INFO] started frobbing TheEighthByte/Snake-Game [INFO] finished frobbing TheEighthByte/Snake-Game [INFO] frobbed toml for TheEighthByte/Snake-Game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TheEighthByte/Snake-Game/Cargo.toml [INFO] crate TheEighthByte/Snake-Game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TheEighthByte/Snake-Game against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TheEighthByte/Snake-Game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 52c292ce1fba29e226b7406d10a8e4c69a7b058039e3c816e7e19a939a285392 [INFO] running `"docker" "start" "-a" "52c292ce1fba29e226b7406d10a8e4c69a7b058039e3c816e7e19a939a285392"` [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking snake_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | if let Some(u) = e.update_args() [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | self.dir = match btn [INFO] [stderr] | ____________________^ [INFO] [stderr] 34 | | { [INFO] [stderr] 35 | | &Button::Keyboard(Key::Up) if last_direction != Direction::Down => Direction::Up, [INFO] [stderr] 36 | | &Button::Keyboard(Key::Down) if last_direction != Direction::Up => Direction::Down, [INFO] [stderr] ... | [INFO] [stderr] 39 | | _ => last_direction, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | self.dir = match *btn [INFO] [stderr] 34 | { [INFO] [stderr] 35 | Button::Keyboard(Key::Up) if last_direction != Direction::Down => Direction::Up, [INFO] [stderr] 36 | Button::Keyboard(Key::Down) if last_direction != Direction::Up => Direction::Down, [INFO] [stderr] 37 | Button::Keyboard(Key::Left) if last_direction != Direction::Right => Direction::Left, [INFO] [stderr] 38 | Button::Keyboard(Key::Right) if last_direction != Direction::Left => Direction::Right, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:100:48 [INFO] [stderr] | [INFO] [stderr] 100 | .map(|p| rectangle::square(p.0 as f64, p.1 as f64, snake.length as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:100:60 [INFO] [stderr] | [INFO] [stderr] 100 | .map(|p| rectangle::square(p.0 as f64, p.1 as f64, snake.length as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:100:72 [INFO] [stderr] | [INFO] [stderr] 100 | .map(|p| rectangle::square(p.0 as f64, p.1 as f64, snake.length as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(snake.length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused variable: `u` [INFO] [stderr] --> src/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | if let Some(u) = e.update_args() [INFO] [stderr] | ^ help: consider using `_u` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | self.dir = match btn [INFO] [stderr] | ____________________^ [INFO] [stderr] 34 | | { [INFO] [stderr] 35 | | &Button::Keyboard(Key::Up) if last_direction != Direction::Down => Direction::Up, [INFO] [stderr] 36 | | &Button::Keyboard(Key::Down) if last_direction != Direction::Up => Direction::Down, [INFO] [stderr] ... | [INFO] [stderr] 39 | | _ => last_direction, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | self.dir = match *btn [INFO] [stderr] 34 | { [INFO] [stderr] 35 | Button::Keyboard(Key::Up) if last_direction != Direction::Down => Direction::Up, [INFO] [stderr] 36 | Button::Keyboard(Key::Down) if last_direction != Direction::Up => Direction::Down, [INFO] [stderr] 37 | Button::Keyboard(Key::Left) if last_direction != Direction::Right => Direction::Left, [INFO] [stderr] 38 | Button::Keyboard(Key::Right) if last_direction != Direction::Left => Direction::Right, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:100:48 [INFO] [stderr] | [INFO] [stderr] 100 | .map(|p| rectangle::square(p.0 as f64, p.1 as f64, snake.length as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:100:60 [INFO] [stderr] | [INFO] [stderr] 100 | .map(|p| rectangle::square(p.0 as f64, p.1 as f64, snake.length as f64)) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:100:72 [INFO] [stderr] | [INFO] [stderr] 100 | .map(|p| rectangle::square(p.0 as f64, p.1 as f64, snake.length as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(snake.length)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.25s [INFO] running `"docker" "inspect" "52c292ce1fba29e226b7406d10a8e4c69a7b058039e3c816e7e19a939a285392"` [INFO] running `"docker" "rm" "-f" "52c292ce1fba29e226b7406d10a8e4c69a7b058039e3c816e7e19a939a285392"` [INFO] [stdout] 52c292ce1fba29e226b7406d10a8e4c69a7b058039e3c816e7e19a939a285392