[INFO] updating cached repository The-Geek-Squad/subnetter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/The-Geek-Squad/subnetter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/The-Geek-Squad/subnetter" "work/ex/clippy-test-run/sources/stable/gh/The-Geek-Squad/subnetter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/The-Geek-Squad/subnetter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/The-Geek-Squad/subnetter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/The-Geek-Squad/subnetter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/The-Geek-Squad/subnetter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd4f9e45eb908da7d5cefada9ba2d5f3673fa4a2 [INFO] sha for GitHub repo The-Geek-Squad/subnetter: cd4f9e45eb908da7d5cefada9ba2d5f3673fa4a2 [INFO] validating manifest of The-Geek-Squad/subnetter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of The-Geek-Squad/subnetter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing The-Geek-Squad/subnetter [INFO] finished frobbing The-Geek-Squad/subnetter [INFO] frobbed toml for The-Geek-Squad/subnetter written to work/ex/clippy-test-run/sources/stable/gh/The-Geek-Squad/subnetter/Cargo.toml [INFO] started frobbing The-Geek-Squad/subnetter [INFO] finished frobbing The-Geek-Squad/subnetter [INFO] frobbed toml for The-Geek-Squad/subnetter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/The-Geek-Squad/subnetter/Cargo.toml [INFO] crate The-Geek-Squad/subnetter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting The-Geek-Squad/subnetter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/The-Geek-Squad/subnetter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdca834e464a5a5ae98e36e9ec2364f45ddb960a1ed6afb39317c1cbbeaba23f [INFO] running `"docker" "start" "-a" "fdca834e464a5a5ae98e36e9ec2364f45ddb960a1ed6afb39317c1cbbeaba23f"` [INFO] [stderr] Checking clap v2.27.1 [INFO] [stderr] Checking ipaddress v0.1.2 [INFO] [stderr] Checking subnetter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subnetter.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | phex: phex, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `phex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/subnetter.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | phex: phex, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `phex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subnetter.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / return Ok(Subnetter { [INFO] [stderr] 21 | | u_ip: _addr.to_string(), [INFO] [stderr] 22 | | ip_addr: _ip, [INFO] [stderr] 23 | | pbinary: pbin, [INFO] [stderr] ... | [INFO] [stderr] 26 | | as_hex: "".to_string() [INFO] [stderr] 27 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | Ok(Subnetter { [INFO] [stderr] 21 | u_ip: _addr.to_string(), [INFO] [stderr] 22 | ip_addr: _ip, [INFO] [stderr] 23 | pbinary: pbin, [INFO] [stderr] 24 | phex: phex, [INFO] [stderr] 25 | as_bin: "".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/subnetter.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / return Ok(Subnetter { [INFO] [stderr] 21 | | u_ip: _addr.to_string(), [INFO] [stderr] 22 | | ip_addr: _ip, [INFO] [stderr] 23 | | pbinary: pbin, [INFO] [stderr] ... | [INFO] [stderr] 26 | | as_hex: "".to_string() [INFO] [stderr] 27 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | Ok(Subnetter { [INFO] [stderr] 21 | u_ip: _addr.to_string(), [INFO] [stderr] 22 | ip_addr: _ip, [INFO] [stderr] 23 | pbinary: pbin, [INFO] [stderr] 24 | phex: phex, [INFO] [stderr] 25 | as_bin: "".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.42s [INFO] running `"docker" "inspect" "fdca834e464a5a5ae98e36e9ec2364f45ddb960a1ed6afb39317c1cbbeaba23f"` [INFO] running `"docker" "rm" "-f" "fdca834e464a5a5ae98e36e9ec2364f45ddb960a1ed6afb39317c1cbbeaba23f"` [INFO] [stdout] fdca834e464a5a5ae98e36e9ec2364f45ddb960a1ed6afb39317c1cbbeaba23f