[INFO] updating cached repository TerminalWitchcraft/shigoto [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TerminalWitchcraft/shigoto [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TerminalWitchcraft/shigoto" "work/ex/clippy-test-run/sources/stable/gh/TerminalWitchcraft/shigoto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TerminalWitchcraft/shigoto'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TerminalWitchcraft/shigoto" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TerminalWitchcraft/shigoto"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TerminalWitchcraft/shigoto'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0d0b20c1d3d181be1b1f1f192ea1ec3b4636f36b [INFO] sha for GitHub repo TerminalWitchcraft/shigoto: 0d0b20c1d3d181be1b1f1f192ea1ec3b4636f36b [INFO] validating manifest of TerminalWitchcraft/shigoto on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TerminalWitchcraft/shigoto on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TerminalWitchcraft/shigoto [INFO] finished frobbing TerminalWitchcraft/shigoto [INFO] frobbed toml for TerminalWitchcraft/shigoto written to work/ex/clippy-test-run/sources/stable/gh/TerminalWitchcraft/shigoto/Cargo.toml [INFO] started frobbing TerminalWitchcraft/shigoto [INFO] finished frobbing TerminalWitchcraft/shigoto [INFO] frobbed toml for TerminalWitchcraft/shigoto written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TerminalWitchcraft/shigoto/Cargo.toml [INFO] crate TerminalWitchcraft/shigoto has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TerminalWitchcraft/shigoto against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TerminalWitchcraft/shigoto:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6628bb0c1b036d8bc05b529a7d5347be5a4739a98e1d26592d94afcb3e41fca0 [INFO] running `"docker" "start" "-a" "6628bb0c1b036d8bc05b529a7d5347be5a4739a98e1d26592d94afcb3e41fca0"` [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking shigoto v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | data_file: data_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | Ok(Config { data_file: data_file, user_data: user_data }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:168:43 [INFO] [stderr] | [INFO] [stderr] 168 | Ok(Config { data_file: data_file, user_data: user_data }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | data_file: data_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | Ok(Config { data_file: data_file, user_data: user_data }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:168:43 [INFO] [stderr] | [INFO] [stderr] 168 | Ok(Config { data_file: data_file, user_data: user_data }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `user_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:145:28 [INFO] [stderr] | [INFO] [stderr] 145 | let home = env::home_dir().expect("No Home directory"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:145:28 [INFO] [stderr] | [INFO] [stderr] 145 | let home = env::home_dir().expect("No Home directory"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `config::UserData` [INFO] [stderr] --> src/config.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> UserData{ [INFO] [stderr] 35 | | let tasks: HashMap = HashMap::new(); [INFO] [stderr] 36 | | UserData { [INFO] [stderr] 37 | | tasks, [INFO] [stderr] 38 | | count: 0, [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.count = self.count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | self.count = self.count -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.count -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/config.rs:121:74 [INFO] [stderr] | [INFO] [stderr] 121 | .with_style(Attr::ForegroundColor(match task.is_completed { [INFO] [stderr] | __________________________________________________________________________^ [INFO] [stderr] 122 | | true => color::BRIGHT_GREEN, [INFO] [stderr] 123 | | false => color::BRIGHT_YELLOW [INFO] [stderr] 124 | | })), [INFO] [stderr] | |________________________________________^ help: consider using an if/else expression: `if task.is_completed { color::BRIGHT_GREEN } else { color::BRIGHT_YELLOW }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cmd/add.rs:12:31 [INFO] [stderr] | [INFO] [stderr] 12 | .map(|v| String::from(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd/add.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self { [INFO] [stderr] 23 | | &Exact::Dmy => "DMY".to_string(), [INFO] [stderr] 24 | | &Exact::Mdy => "MDY".to_string() [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *self { [INFO] [stderr] 23 | Exact::Dmy => "DMY".to_string(), [INFO] [stderr] 24 | Exact::Mdy => "MDY".to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / match self { [INFO] [stderr] 41 | | &Start::Sow => "sow".to_string(), [INFO] [stderr] 42 | | &Start::Socw => "socw".to_string(), [INFO] [stderr] 43 | | &Start::Som => "som".to_string(), [INFO] [stderr] 44 | | &Start::Soq => "soq".to_string(), [INFO] [stderr] 45 | | &Start::Soy => "soy".to_string(), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *self { [INFO] [stderr] 41 | Start::Sow => "sow".to_string(), [INFO] [stderr] 42 | Start::Socw => "socw".to_string(), [INFO] [stderr] 43 | Start::Som => "som".to_string(), [INFO] [stderr] 44 | Start::Soq => "soq".to_string(), [INFO] [stderr] 45 | Start::Soy => "soy".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match self { [INFO] [stderr] 62 | | &End::Eow => "eow".to_string(), [INFO] [stderr] 63 | | &End::Eocw => "eocw".to_string(), [INFO] [stderr] 64 | | &End::Eom => "eom".to_string(), [INFO] [stderr] 65 | | &End::Eoq => "eoq".to_string(), [INFO] [stderr] 66 | | &End::Eoy => "eoy".to_string(), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *self { [INFO] [stderr] 62 | End::Eow => "eow".to_string(), [INFO] [stderr] 63 | End::Eocw => "eocw".to_string(), [INFO] [stderr] 64 | End::Eom => "eom".to_string(), [INFO] [stderr] 65 | End::Eoq => "eoq".to_string(), [INFO] [stderr] 66 | End::Eoy => "eoy".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/task.rs:77:49 [INFO] [stderr] | [INFO] [stderr] 77 | NaiveDate::from_ymd_opt(year, month + 1, 1).unwrap_or(NaiveDate::from_ymd(year + 1, 1, 1)).pred().day() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| NaiveDate::from_ymd(year + 1, 1, 1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/task.rs:88:41 [INFO] [stderr] | [INFO] [stderr] 88 | dt + Duration::days(last_day as i64 - dt.day() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(last_day)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/task.rs:88:59 [INFO] [stderr] | [INFO] [stderr] 88 | dt + Duration::days(last_day as i64 - dt.day() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(dt.day())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/task.rs:113:52 [INFO] [stderr] | [INFO] [stderr] 113 | dt + Duration::days(7 as i64 - num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/task.rs:117:52 [INFO] [stderr] | [INFO] [stderr] 117 | dt + Duration::days(7 as i64 - num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / match self { [INFO] [stderr] 159 | | &Priority::High => "High".to_string(), [INFO] [stderr] 160 | | &Priority::Medium => "Medium".to_string(), [INFO] [stderr] 161 | | &Priority::Low => "Low".to_string(), [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 158 | match *self { [INFO] [stderr] 159 | Priority::High => "High".to_string(), [INFO] [stderr] 160 | Priority::Medium => "Medium".to_string(), [INFO] [stderr] 161 | Priority::Low => "Low".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `config::UserData` [INFO] [stderr] --> src/config.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> UserData{ [INFO] [stderr] 35 | | let tasks: HashMap = HashMap::new(); [INFO] [stderr] 36 | | UserData { [INFO] [stderr] 37 | | tasks, [INFO] [stderr] 38 | | count: 0, [INFO] [stderr] 39 | | } [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.count = self.count + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/config.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | self.count = self.count -1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.count -= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/config.rs:121:74 [INFO] [stderr] | [INFO] [stderr] 121 | .with_style(Attr::ForegroundColor(match task.is_completed { [INFO] [stderr] | __________________________________________________________________________^ [INFO] [stderr] 122 | | true => color::BRIGHT_GREEN, [INFO] [stderr] 123 | | false => color::BRIGHT_YELLOW [INFO] [stderr] 124 | | })), [INFO] [stderr] | |________________________________________^ help: consider using an if/else expression: `if task.is_completed { color::BRIGHT_GREEN } else { color::BRIGHT_YELLOW }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cmd/add.rs:12:31 [INFO] [stderr] | [INFO] [stderr] 12 | .map(|v| String::from(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cmd/add.rs:11:33 [INFO] [stderr] | [INFO] [stderr] 11 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | / match self { [INFO] [stderr] 23 | | &Exact::Dmy => "DMY".to_string(), [INFO] [stderr] 24 | | &Exact::Mdy => "MDY".to_string() [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | match *self { [INFO] [stderr] 23 | Exact::Dmy => "DMY".to_string(), [INFO] [stderr] 24 | Exact::Mdy => "MDY".to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / match self { [INFO] [stderr] 41 | | &Start::Sow => "sow".to_string(), [INFO] [stderr] 42 | | &Start::Socw => "socw".to_string(), [INFO] [stderr] 43 | | &Start::Som => "som".to_string(), [INFO] [stderr] 44 | | &Start::Soq => "soq".to_string(), [INFO] [stderr] 45 | | &Start::Soy => "soy".to_string(), [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *self { [INFO] [stderr] 41 | Start::Sow => "sow".to_string(), [INFO] [stderr] 42 | Start::Socw => "socw".to_string(), [INFO] [stderr] 43 | Start::Som => "som".to_string(), [INFO] [stderr] 44 | Start::Soq => "soq".to_string(), [INFO] [stderr] 45 | Start::Soy => "soy".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match self { [INFO] [stderr] 62 | | &End::Eow => "eow".to_string(), [INFO] [stderr] 63 | | &End::Eocw => "eocw".to_string(), [INFO] [stderr] 64 | | &End::Eom => "eom".to_string(), [INFO] [stderr] 65 | | &End::Eoq => "eoq".to_string(), [INFO] [stderr] 66 | | &End::Eoy => "eoy".to_string(), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *self { [INFO] [stderr] 62 | End::Eow => "eow".to_string(), [INFO] [stderr] 63 | End::Eocw => "eocw".to_string(), [INFO] [stderr] 64 | End::Eom => "eom".to_string(), [INFO] [stderr] 65 | End::Eoq => "eoq".to_string(), [INFO] [stderr] 66 | End::Eoy => "eoy".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/task.rs:77:49 [INFO] [stderr] | [INFO] [stderr] 77 | NaiveDate::from_ymd_opt(year, month + 1, 1).unwrap_or(NaiveDate::from_ymd(year + 1, 1, 1)).pred().day() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| NaiveDate::from_ymd(year + 1, 1, 1))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/task.rs:88:41 [INFO] [stderr] | [INFO] [stderr] 88 | dt + Duration::days(last_day as i64 - dt.day() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(last_day)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/task.rs:88:59 [INFO] [stderr] | [INFO] [stderr] 88 | dt + Duration::days(last_day as i64 - dt.day() as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(dt.day())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/task.rs:113:52 [INFO] [stderr] | [INFO] [stderr] 113 | dt + Duration::days(7 as i64 - num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/task.rs:117:52 [INFO] [stderr] | [INFO] [stderr] 117 | dt + Duration::days(7 as i64 - num as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/task.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | / match self { [INFO] [stderr] 159 | | &Priority::High => "High".to_string(), [INFO] [stderr] 160 | | &Priority::Medium => "Medium".to_string(), [INFO] [stderr] 161 | | &Priority::Low => "Low".to_string(), [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 158 | match *self { [INFO] [stderr] 159 | Priority::High => "High".to_string(), [INFO] [stderr] 160 | Priority::Medium => "Medium".to_string(), [INFO] [stderr] 161 | Priority::Low => "Low".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.17s [INFO] running `"docker" "inspect" "6628bb0c1b036d8bc05b529a7d5347be5a4739a98e1d26592d94afcb3e41fca0"` [INFO] running `"docker" "rm" "-f" "6628bb0c1b036d8bc05b529a7d5347be5a4739a98e1d26592d94afcb3e41fca0"` [INFO] [stdout] 6628bb0c1b036d8bc05b529a7d5347be5a4739a98e1d26592d94afcb3e41fca0