[INFO] updating cached repository TerminalWitchcraft/marcos [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TerminalWitchcraft/marcos [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TerminalWitchcraft/marcos" "work/ex/clippy-test-run/sources/stable/gh/TerminalWitchcraft/marcos"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TerminalWitchcraft/marcos'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TerminalWitchcraft/marcos" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TerminalWitchcraft/marcos"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TerminalWitchcraft/marcos'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 20d266c90b23df9d0d33ad30ca6ab7c098d1d94f [INFO] sha for GitHub repo TerminalWitchcraft/marcos: 20d266c90b23df9d0d33ad30ca6ab7c098d1d94f [INFO] validating manifest of TerminalWitchcraft/marcos on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TerminalWitchcraft/marcos on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TerminalWitchcraft/marcos [INFO] finished frobbing TerminalWitchcraft/marcos [INFO] frobbed toml for TerminalWitchcraft/marcos written to work/ex/clippy-test-run/sources/stable/gh/TerminalWitchcraft/marcos/Cargo.toml [INFO] started frobbing TerminalWitchcraft/marcos [INFO] finished frobbing TerminalWitchcraft/marcos [INFO] frobbed toml for TerminalWitchcraft/marcos written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TerminalWitchcraft/marcos/Cargo.toml [INFO] crate TerminalWitchcraft/marcos has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TerminalWitchcraft/marcos against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TerminalWitchcraft/marcos:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a80714b7cf2eca142fca7d9b95d8cb09071bc91bd71766010458e86dd2bd786 [INFO] running `"docker" "start" "-a" "7a80714b7cf2eca142fca7d9b95d8cb09071bc91bd71766010458e86dd2bd786"` [INFO] [stderr] Checking bytesize v0.1.3 [INFO] [stderr] Checking alphanumeric-sort v1.0.6 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking users v0.8.1 [INFO] [stderr] Checking uname v0.1.1 [INFO] [stderr] Compiling enum-map-derive v0.4.0 [INFO] [stderr] Compiling enumset_derive v0.2.0 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking enum-map v0.4.1 [INFO] [stderr] Checking enumset v0.3.14 [INFO] [stderr] Checking cursive v0.9.2 [INFO] [stderr] Checking systemstat v0.1.3 [INFO] [stderr] Checking marcos v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:71:1 [INFO] [stderr] | [INFO] [stderr] 71 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `cursive::event::Key` [INFO] [stderr] --> src/config/keys.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use cursive::event::Key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::error::*` [INFO] [stderr] --> src/config/keys.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use crate::error::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/config/keys.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | takes_count: _, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `KeySequence { modifier: Modifier::Shift, key: c, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/config/keys.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | takes_count: _, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `KeySequence { modifier: Modifier::NoMod, key: c, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/config/options.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | preview_max_size: 102400, [INFO] [stderr] | ^^^^^^ help: consider: `102_400` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/core/app.rs:482:5 [INFO] [stderr] | [INFO] [stderr] 482 | layout [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/core/app.rs:479:18 [INFO] [stderr] | [INFO] [stderr] 479 | let layout = LinearLayout::horizontal() [INFO] [stderr] | __________________^ [INFO] [stderr] 480 | | .child(prefix_view) [INFO] [stderr] 481 | | .child(edit_view.full_width()); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:71:1 [INFO] [stderr] | [INFO] [stderr] 71 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `cursive::event::Key` [INFO] [stderr] --> src/config/keys.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use cursive::event::Key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `crate::error::*` [INFO] [stderr] --> src/config/keys.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use crate::error::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/config/keys.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | takes_count: _, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `KeySequence { modifier: Modifier::Shift, key: c, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/config/keys.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | takes_count: _, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `KeySequence { modifier: Modifier::NoMod, key: c, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/config/options.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | preview_max_size: 102400, [INFO] [stderr] | ^^^^^^ help: consider: `102_400` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/core/app.rs:482:5 [INFO] [stderr] | [INFO] [stderr] 482 | layout [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/core/app.rs:479:18 [INFO] [stderr] | [INFO] [stderr] 479 | let layout = LinearLayout::horizontal() [INFO] [stderr] | __________________^ [INFO] [stderr] 480 | | .child(prefix_view) [INFO] [stderr] 481 | | .child(edit_view.full_width()); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/app.rs:188:41 [INFO] [stderr] | [INFO] [stderr] 188 | if let Some(mut tab) = v_clone2.borrow_mut().get_mut(&1) { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Alt` [INFO] [stderr] --> src/config/keys.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Alt, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Ctrl` [INFO] [stderr] --> src/config/keys.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Ctrl, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Shift` [INFO] [stderr] --> src/config/keys.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Shift, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AltCtrl` [INFO] [stderr] --> src/config/keys.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | AltCtrl, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AltShift` [INFO] [stderr] --> src/config/keys.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | AltShift, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlShift` [INFO] [stderr] --> src/config/keys.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | CtrlShift, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NoMod` [INFO] [stderr] --> src/config/keys.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | NoMod, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `takes_count` [INFO] [stderr] --> src/config/keys.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | takes_count: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `max_count` [INFO] [stderr] --> src/config/keys.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | max_count: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `modifier` [INFO] [stderr] --> src/config/keys.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | modifier: Modifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `key` [INFO] [stderr] --> src/config/keys.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | key: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `operation` [INFO] [stderr] --> src/config/keys.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | operation: fn(&mut Cursive), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `emit_sequence` [INFO] [stderr] --> src/config/keys.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn emit_sequence(self) -> (bool, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `input_count` [INFO] [stderr] --> src/ui/multi_select.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | input_count: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_alphabete` [INFO] [stderr] --> src/ui/multi_select.rs:785:1 [INFO] [stderr] | [INFO] [stderr] 785 | fn is_alphabete(event: &Event) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/app.rs:188:41 [INFO] [stderr] | [INFO] [stderr] 188 | if let Some(mut tab) = v_clone2.borrow_mut().get_mut(&1) { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `KeyMaps` should have a snake case name such as `key_maps` [INFO] [stderr] --> src/config/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | KeyMaps: keys::KeyMaps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `Options` should have a snake case name such as `options` [INFO] [stderr] --> src/config/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Options: options::ConfigOptions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:270:21 [INFO] [stderr] | [INFO] [stderr] 270 | / match entry.file_name().to_str() { [INFO] [stderr] 271 | | Some(c) => { [INFO] [stderr] 272 | | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | None => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 270 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 271 | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 272 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:281:21 [INFO] [stderr] | [INFO] [stderr] 281 | / match entry.file_name().to_str() { [INFO] [stderr] 282 | | Some(c) => { [INFO] [stderr] 283 | | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 284 | | } [INFO] [stderr] 285 | | None => {} [INFO] [stderr] 286 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 281 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 282 | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 283 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/core/app.rs:309:32 [INFO] [stderr] | [INFO] [stderr] 309 | if entry.path() == &tab.c_view { [INFO] [stderr] | ^^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `tab.c_view` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:312:29 [INFO] [stderr] | [INFO] [stderr] 312 | / match entry.file_name().to_str() { [INFO] [stderr] 313 | | Some(c) => view [INFO] [stderr] 314 | | .add_item(format!("  {}", c), PathBuf::from(entry.path())), [INFO] [stderr] 315 | | None => {} [INFO] [stderr] 316 | | }; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 312 | if let Some(c) = entry.file_name().to_str() { view [INFO] [stderr] 313 | .add_item(format!("  {}", c), PathBuf::from(entry.path())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | / match entry.file_name().to_str() { [INFO] [stderr] 323 | | Some(c) => view [INFO] [stderr] 324 | | .add_item(format!("  {}", c), PathBuf::from(entry.path())), [INFO] [stderr] 325 | | None => {} [INFO] [stderr] 326 | | }; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 322 | if let Some(c) = entry.file_name().to_str() { view [INFO] [stderr] 323 | .add_item(format!("  {}", c), PathBuf::from(entry.path())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:360:21 [INFO] [stderr] | [INFO] [stderr] 360 | / match entry.file_name().to_str() { [INFO] [stderr] 361 | | Some(c) => { [INFO] [stderr] 362 | | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 363 | | } [INFO] [stderr] 364 | | None => {} [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 361 | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 362 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:371:21 [INFO] [stderr] | [INFO] [stderr] 371 | / match entry.file_name().to_str() { [INFO] [stderr] 372 | | Some(c) => { [INFO] [stderr] 373 | | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | None => {} [INFO] [stderr] 376 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 371 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 372 | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 373 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/core/app.rs:398:28 [INFO] [stderr] | [INFO] [stderr] 398 | if entry.path() == &tab.c_view { [INFO] [stderr] | ^^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `tab.c_view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:401:25 [INFO] [stderr] | [INFO] [stderr] 401 | / match entry.file_name().to_str() { [INFO] [stderr] 402 | | Some(c) => { [INFO] [stderr] 403 | | view.add_item(format!("  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 404 | | } [INFO] [stderr] 405 | | None => {} [INFO] [stderr] 406 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 401 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 402 | view.add_item(format!("  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 403 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:412:25 [INFO] [stderr] | [INFO] [stderr] 412 | / match entry.file_name().to_str() { [INFO] [stderr] 413 | | Some(c) => { [INFO] [stderr] 414 | | view.add_item(format!("  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 415 | | } [INFO] [stderr] 416 | | None => {} [INFO] [stderr] 417 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 412 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 413 | view.add_item(format!("  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 414 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Alt` [INFO] [stderr] --> src/config/keys.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Alt, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Ctrl` [INFO] [stderr] --> src/config/keys.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Ctrl, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Shift` [INFO] [stderr] --> src/config/keys.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Shift, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AltCtrl` [INFO] [stderr] --> src/config/keys.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | AltCtrl, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AltShift` [INFO] [stderr] --> src/config/keys.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | AltShift, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CtrlShift` [INFO] [stderr] --> src/config/keys.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | CtrlShift, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `NoMod` [INFO] [stderr] --> src/config/keys.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | NoMod, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `takes_count` [INFO] [stderr] --> src/config/keys.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | takes_count: bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `max_count` [INFO] [stderr] --> src/config/keys.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | max_count: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `modifier` [INFO] [stderr] --> src/config/keys.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | modifier: Modifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `key` [INFO] [stderr] --> src/config/keys.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | key: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `operation` [INFO] [stderr] --> src/config/keys.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | operation: fn(&mut Cursive), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `emit_sequence` [INFO] [stderr] --> src/config/keys.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | fn emit_sequence(self) -> (bool, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `input_count` [INFO] [stderr] --> src/ui/multi_select.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | input_count: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `is_alphabete` [INFO] [stderr] --> src/ui/multi_select.rs:785:1 [INFO] [stderr] | [INFO] [stderr] 785 | fn is_alphabete(event: &Event) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/multi_select.rs:776:5 [INFO] [stderr] | [INFO] [stderr] 776 | / match event { [INFO] [stderr] 777 | | Event::Char(c) => if c.is_numeric() { [INFO] [stderr] 778 | | return true; [INFO] [stderr] 779 | | }, [INFO] [stderr] 780 | | _ => {} [INFO] [stderr] 781 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 776 | if let Event::Char(c) = event { if c.is_numeric() { [INFO] [stderr] 777 | return true; [INFO] [stderr] 778 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/multi_select.rs:786:5 [INFO] [stderr] | [INFO] [stderr] 786 | / match event { [INFO] [stderr] 787 | | Event::Char(c) => if c.is_alphabetic() { [INFO] [stderr] 788 | | return true; [INFO] [stderr] 789 | | }, [INFO] [stderr] 790 | | _ => {} [INFO] [stderr] 791 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 786 | if let Event::Char(c) = event { if c.is_alphabetic() { [INFO] [stderr] 787 | return true; [INFO] [stderr] 788 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ui/multi_select.rs:795:20 [INFO] [stderr] | [INFO] [stderr] 795 | fn get_number(seq: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ui/multi_select.rs:798:18 [INFO] [stderr] | [INFO] [stderr] 798 | for i in seq.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/tab.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match path.parent() { [INFO] [stderr] 66 | | Some(d) => { [INFO] [stderr] 67 | | self.p_view = d.to_path_buf(); [INFO] [stderr] 68 | | self.c_view = PathBuf::from(c); [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | None => {} [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(d) = path.parent() { [INFO] [stderr] 66 | self.p_view = d.to_path_buf(); [INFO] [stderr] 67 | self.c_view = PathBuf::from(c); [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/filter.rs:10:32 [INFO] [stderr] | [INFO] [stderr] 10 | .map(|s| s.starts_with(".")) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/utils/info.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | let user_name = get_current_username().unwrap_or(OsString::from("NA")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsString::from("NA"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: structure field `KeyMaps` should have a snake case name such as `key_maps` [INFO] [stderr] --> src/config/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | KeyMaps: keys::KeyMaps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `Options` should have a snake case name such as `options` [INFO] [stderr] --> src/config/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Options: options::ConfigOptions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:270:21 [INFO] [stderr] | [INFO] [stderr] 270 | / match entry.file_name().to_str() { [INFO] [stderr] 271 | | Some(c) => { [INFO] [stderr] 272 | | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 273 | | } [INFO] [stderr] 274 | | None => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 270 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 271 | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 272 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:281:21 [INFO] [stderr] | [INFO] [stderr] 281 | / match entry.file_name().to_str() { [INFO] [stderr] 282 | | Some(c) => { [INFO] [stderr] 283 | | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 284 | | } [INFO] [stderr] 285 | | None => {} [INFO] [stderr] 286 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 281 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 282 | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 283 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/core/app.rs:309:32 [INFO] [stderr] | [INFO] [stderr] 309 | if entry.path() == &tab.c_view { [INFO] [stderr] | ^^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `tab.c_view` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:312:29 [INFO] [stderr] | [INFO] [stderr] 312 | / match entry.file_name().to_str() { [INFO] [stderr] 313 | | Some(c) => view [INFO] [stderr] 314 | | .add_item(format!("  {}", c), PathBuf::from(entry.path())), [INFO] [stderr] 315 | | None => {} [INFO] [stderr] 316 | | }; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 312 | if let Some(c) = entry.file_name().to_str() { view [INFO] [stderr] 313 | .add_item(format!("  {}", c), PathBuf::from(entry.path())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:322:29 [INFO] [stderr] | [INFO] [stderr] 322 | / match entry.file_name().to_str() { [INFO] [stderr] 323 | | Some(c) => view [INFO] [stderr] 324 | | .add_item(format!("  {}", c), PathBuf::from(entry.path())), [INFO] [stderr] 325 | | None => {} [INFO] [stderr] 326 | | }; [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 322 | if let Some(c) = entry.file_name().to_str() { view [INFO] [stderr] 323 | .add_item(format!("  {}", c), PathBuf::from(entry.path())) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:360:21 [INFO] [stderr] | [INFO] [stderr] 360 | / match entry.file_name().to_str() { [INFO] [stderr] 361 | | Some(c) => { [INFO] [stderr] 362 | | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 363 | | } [INFO] [stderr] 364 | | None => {} [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 361 | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 362 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:371:21 [INFO] [stderr] | [INFO] [stderr] 371 | / match entry.file_name().to_str() { [INFO] [stderr] 372 | | Some(c) => { [INFO] [stderr] 373 | | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 374 | | } [INFO] [stderr] 375 | | None => {} [INFO] [stderr] 376 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 371 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 372 | view.add_item(format!(r"  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 373 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/core/app.rs:398:28 [INFO] [stderr] | [INFO] [stderr] 398 | if entry.path() == &tab.c_view { [INFO] [stderr] | ^^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `tab.c_view` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:401:25 [INFO] [stderr] | [INFO] [stderr] 401 | / match entry.file_name().to_str() { [INFO] [stderr] 402 | | Some(c) => { [INFO] [stderr] 403 | | view.add_item(format!("  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 404 | | } [INFO] [stderr] 405 | | None => {} [INFO] [stderr] 406 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 401 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 402 | view.add_item(format!("  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 403 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/core/app.rs:412:25 [INFO] [stderr] | [INFO] [stderr] 412 | / match entry.file_name().to_str() { [INFO] [stderr] 413 | | Some(c) => { [INFO] [stderr] 414 | | view.add_item(format!("  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 415 | | } [INFO] [stderr] 416 | | None => {} [INFO] [stderr] 417 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 412 | if let Some(c) = entry.file_name().to_str() { [INFO] [stderr] 413 | view.add_item(format!("  {}", c), PathBuf::from(entry.path())) [INFO] [stderr] 414 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/multi_select.rs:776:5 [INFO] [stderr] | [INFO] [stderr] 776 | / match event { [INFO] [stderr] 777 | | Event::Char(c) => if c.is_numeric() { [INFO] [stderr] 778 | | return true; [INFO] [stderr] 779 | | }, [INFO] [stderr] 780 | | _ => {} [INFO] [stderr] 781 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 776 | if let Event::Char(c) = event { if c.is_numeric() { [INFO] [stderr] 777 | return true; [INFO] [stderr] 778 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/multi_select.rs:786:5 [INFO] [stderr] | [INFO] [stderr] 786 | / match event { [INFO] [stderr] 787 | | Event::Char(c) => if c.is_alphabetic() { [INFO] [stderr] 788 | | return true; [INFO] [stderr] 789 | | }, [INFO] [stderr] 790 | | _ => {} [INFO] [stderr] 791 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 786 | if let Event::Char(c) = event { if c.is_alphabetic() { [INFO] [stderr] 787 | return true; [INFO] [stderr] 788 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ui/multi_select.rs:795:20 [INFO] [stderr] | [INFO] [stderr] 795 | fn get_number(seq: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/ui/multi_select.rs:798:18 [INFO] [stderr] | [INFO] [stderr] 798 | for i in seq.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ui/tab.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | / match path.parent() { [INFO] [stderr] 66 | | Some(d) => { [INFO] [stderr] 67 | | self.p_view = d.to_path_buf(); [INFO] [stderr] 68 | | self.c_view = PathBuf::from(c); [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | None => {} [INFO] [stderr] 71 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 65 | if let Some(d) = path.parent() { [INFO] [stderr] 66 | self.p_view = d.to_path_buf(); [INFO] [stderr] 67 | self.c_view = PathBuf::from(c); [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/filter.rs:10:32 [INFO] [stderr] | [INFO] [stderr] 10 | .map(|s| s.starts_with(".")) [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/utils/info.rs:14:44 [INFO] [stderr] | [INFO] [stderr] 14 | let user_name = get_current_username().unwrap_or(OsString::from("NA")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsString::from("NA"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.08s [INFO] running `"docker" "inspect" "7a80714b7cf2eca142fca7d9b95d8cb09071bc91bd71766010458e86dd2bd786"` [INFO] running `"docker" "rm" "-f" "7a80714b7cf2eca142fca7d9b95d8cb09071bc91bd71766010458e86dd2bd786"` [INFO] [stdout] 7a80714b7cf2eca142fca7d9b95d8cb09071bc91bd71766010458e86dd2bd786