[INFO] updating cached repository Tembocs/rup_mongodb [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Tembocs/rup_mongodb [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Tembocs/rup_mongodb" "work/ex/clippy-test-run/sources/stable/gh/Tembocs/rup_mongodb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tembocs/rup_mongodb'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Tembocs/rup_mongodb" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tembocs/rup_mongodb"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tembocs/rup_mongodb'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce5bee4d4e9cd15d3b34a10afaffc875ab6ed5a1 [INFO] sha for GitHub repo Tembocs/rup_mongodb: ce5bee4d4e9cd15d3b34a10afaffc875ab6ed5a1 [INFO] validating manifest of Tembocs/rup_mongodb on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Tembocs/rup_mongodb on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Tembocs/rup_mongodb [INFO] finished frobbing Tembocs/rup_mongodb [INFO] frobbed toml for Tembocs/rup_mongodb written to work/ex/clippy-test-run/sources/stable/gh/Tembocs/rup_mongodb/Cargo.toml [INFO] started frobbing Tembocs/rup_mongodb [INFO] finished frobbing Tembocs/rup_mongodb [INFO] frobbed toml for Tembocs/rup_mongodb written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tembocs/rup_mongodb/Cargo.toml [INFO] crate Tembocs/rup_mongodb has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Tembocs/rup_mongodb against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Tembocs/rup_mongodb:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a751cc8b1baf0b01680d2af75e84b026597e08bd68622d0ba9cb1fc1e595193 [INFO] running `"docker" "start" "-a" "6a751cc8b1baf0b01680d2af75e84b026597e08bd68622d0ba9cb1fc1e595193"` [INFO] [stderr] Checking try_from v0.2.2 [INFO] [stderr] Checking data-encoding v2.1.1 [INFO] [stderr] Checking separator v0.3.1 [INFO] [stderr] Checking semver v0.8.0 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking hmac v0.6.3 [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Checking md-5 v0.7.0 [INFO] [stderr] Checking pbkdf2 v0.2.3 [INFO] [stderr] Checking scan_fmt v0.1.3 [INFO] [stderr] Checking textnonce v0.6.4 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking bson v0.13.0 [INFO] [stderr] Checking mongodb v0.3.12 [INFO] [stderr] Checking rup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/utils.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/utils.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utils.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | coll [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utils.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | let coll = client.db("opensource") [INFO] [stderr] | ________________^ [INFO] [stderr] 160 | | .collection("repositories"); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logic.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `update_document` [INFO] [stderr] --> src/crud.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn update_one(update_document: Document, collection: &Collection) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_update_document` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `collection` [INFO] [stderr] --> src/crud.rs:24:46 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn update_one(update_document: Document, collection: &Collection) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_collection` instead [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/utils.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | coll [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/utils.rs:159:16 [INFO] [stderr] | [INFO] [stderr] 159 | let coll = client.db("opensource") [INFO] [stderr] | ________________^ [INFO] [stderr] 160 | | .collection("repositories"); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/logic.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/utils.rs:98:27 [INFO] [stderr] | [INFO] [stderr] 98 | let mut coll_cursor = collection.find(Some(new_doc), None) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 99 | | .ok().expect("Failed to execute find."); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: unused variable: `update_document` [INFO] [stderr] --> src/crud.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn update_one(update_document: Document, collection: &Collection) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_update_document` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `collection` [INFO] [stderr] --> src/crud.rs:24:46 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn update_one(update_document: Document, collection: &Collection) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_collection` instead [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/utils.rs:98:27 [INFO] [stderr] | [INFO] [stderr] 98 | let mut coll_cursor = collection.find(Some(new_doc), None) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 99 | | .ok().expect("Failed to execute find."); [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rup`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:12:15 [INFO] [stderr] | [INFO] [stderr] 12 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rup`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6a751cc8b1baf0b01680d2af75e84b026597e08bd68622d0ba9cb1fc1e595193"` [INFO] running `"docker" "rm" "-f" "6a751cc8b1baf0b01680d2af75e84b026597e08bd68622d0ba9cb1fc1e595193"` [INFO] [stdout] 6a751cc8b1baf0b01680d2af75e84b026597e08bd68622d0ba9cb1fc1e595193