[INFO] updating cached repository Tehforsch/rustPlanetSimulation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Tehforsch/rustPlanetSimulation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Tehforsch/rustPlanetSimulation" "work/ex/clippy-test-run/sources/stable/gh/Tehforsch/rustPlanetSimulation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tehforsch/rustPlanetSimulation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Tehforsch/rustPlanetSimulation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tehforsch/rustPlanetSimulation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tehforsch/rustPlanetSimulation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e588b9b3bc14522b3c3d4991b5af9621304f9913 [INFO] sha for GitHub repo Tehforsch/rustPlanetSimulation: e588b9b3bc14522b3c3d4991b5af9621304f9913 [INFO] validating manifest of Tehforsch/rustPlanetSimulation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Tehforsch/rustPlanetSimulation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Tehforsch/rustPlanetSimulation [INFO] finished frobbing Tehforsch/rustPlanetSimulation [INFO] frobbed toml for Tehforsch/rustPlanetSimulation written to work/ex/clippy-test-run/sources/stable/gh/Tehforsch/rustPlanetSimulation/Cargo.toml [INFO] started frobbing Tehforsch/rustPlanetSimulation [INFO] finished frobbing Tehforsch/rustPlanetSimulation [INFO] frobbed toml for Tehforsch/rustPlanetSimulation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tehforsch/rustPlanetSimulation/Cargo.toml [INFO] crate Tehforsch/rustPlanetSimulation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Tehforsch/rustPlanetSimulation against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Tehforsch/rustPlanetSimulation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8aa66d7712d450986d6f0d6a6a3899f0e7fb228266f33b048ec405a92e8ec2db [INFO] running `"docker" "start" "-a" "8aa66d7712d450986d6f0d6a6a3899f0e7fb228266f33b048ec405a92e8ec2db"` [INFO] [stderr] Checking gfx_core v0.6.1 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking piston2d-opengl_graphics v0.42.1 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking gfx v0.14.1 [INFO] [stderr] Checking gfx_device_gl v0.13.1 [INFO] [stderr] Checking piston-gfx_texture v0.22.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.38.0 [INFO] [stderr] Checking piston_window v0.64.0 [INFO] [stderr] Checking engine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/body.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/body.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | mass: mass, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/mod.rs:65:42 [INFO] [stderr] | [INFO] [stderr] 65 | bodies.push(body::get_body(Point{x: x, y: y}, mass)); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/mod.rs:65:48 [INFO] [stderr] | [INFO] [stderr] 65 | bodies.push(body::get_body(Point{x: x, y: y}, mass)); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/mod.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | bodies: bodies [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bodies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/draw.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/body.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/body.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | mass: mass, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mass` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/mod.rs:65:42 [INFO] [stderr] | [INFO] [stderr] 65 | bodies.push(body::get_body(Point{x: x, y: y}, mass)); [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/mod.rs:65:48 [INFO] [stderr] | [INFO] [stderr] 65 | bodies.push(body::get_body(Point{x: x, y: y}, mass)); [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/simulation/mod.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | bodies: bodies [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bodies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/render/draw.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/simulation/mod.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | sim [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/simulation/mod.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | let mut sim = Simulation { [INFO] [stderr] | ___________________^ [INFO] [stderr] 68 | | bodies: bodies [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/simulation/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let mut slice = &mut self.bodies[..]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/simulation/mod.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | let mut sim = Simulation { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/simulation/mod.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | sim [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/simulation/mod.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | let mut sim = Simulation { [INFO] [stderr] | ___________________^ [INFO] [stderr] 68 | | bodies: bodies [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/simulation/mod.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let mut slice = &mut self.bodies[..]; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/simulation/mod.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | let mut sim = Simulation { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 53.72s [INFO] running `"docker" "inspect" "8aa66d7712d450986d6f0d6a6a3899f0e7fb228266f33b048ec405a92e8ec2db"` [INFO] running `"docker" "rm" "-f" "8aa66d7712d450986d6f0d6a6a3899f0e7fb228266f33b048ec405a92e8ec2db"` [INFO] [stdout] 8aa66d7712d450986d6f0d6a6a3899f0e7fb228266f33b048ec405a92e8ec2db