[INFO] updating cached repository TechnoCrunch/huffman-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TechnoCrunch/huffman-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TechnoCrunch/huffman-rs" "work/ex/clippy-test-run/sources/stable/gh/TechnoCrunch/huffman-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TechnoCrunch/huffman-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TechnoCrunch/huffman-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TechnoCrunch/huffman-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TechnoCrunch/huffman-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9873df86b7f1175b7797e634811ed0887fa53532 [INFO] sha for GitHub repo TechnoCrunch/huffman-rs: 9873df86b7f1175b7797e634811ed0887fa53532 [INFO] validating manifest of TechnoCrunch/huffman-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TechnoCrunch/huffman-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TechnoCrunch/huffman-rs [INFO] finished frobbing TechnoCrunch/huffman-rs [INFO] frobbed toml for TechnoCrunch/huffman-rs written to work/ex/clippy-test-run/sources/stable/gh/TechnoCrunch/huffman-rs/Cargo.toml [INFO] started frobbing TechnoCrunch/huffman-rs [INFO] finished frobbing TechnoCrunch/huffman-rs [INFO] frobbed toml for TechnoCrunch/huffman-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TechnoCrunch/huffman-rs/Cargo.toml [INFO] crate TechnoCrunch/huffman-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TechnoCrunch/huffman-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TechnoCrunch/huffman-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c14fc489804cfa4ab2015916411e8a1625b7d4198ef0ae1357c4e6dcebd93d9 [INFO] running `"docker" "start" "-a" "7c14fc489804cfa4ab2015916411e8a1625b7d4198ef0ae1357c4e6dcebd93d9"` [INFO] [stderr] Checking huffman v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | ch: ch, [INFO] [stderr] | ^^^^^^ help: replace it with: `ch` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | frequency: frequency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | ch: ch, [INFO] [stderr] | ^^^^^^ help: replace it with: `ch` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | frequency: frequency, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frequency` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:65:43 [INFO] [stderr] | [INFO] [stderr] 65 | generate_code(l, huffman_map, (s.clone() + "0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:68:43 [INFO] [stderr] | [INFO] [stderr] 68 | generate_code(r, huffman_map, (s.clone() + "1")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 96 | | if let Some(ref r) = node_ptr.right { [INFO] [stderr] 97 | | node_ptr = r; [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | } else if let Some(ref r) = node_ptr.right { [INFO] [stderr] 96 | node_ptr = r; [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:65:43 [INFO] [stderr] | [INFO] [stderr] 65 | generate_code(l, huffman_map, (s.clone() + "0")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/main.rs:68:43 [INFO] [stderr] | [INFO] [stderr] 68 | generate_code(r, huffman_map, (s.clone() + "1")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:95:16 [INFO] [stderr] | [INFO] [stderr] 95 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 96 | | if let Some(ref r) = node_ptr.right { [INFO] [stderr] 97 | | node_ptr = r; [INFO] [stderr] 98 | | } [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | } else if let Some(ref r) = node_ptr.right { [INFO] [stderr] 96 | node_ptr = r; [INFO] [stderr] 97 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "7c14fc489804cfa4ab2015916411e8a1625b7d4198ef0ae1357c4e6dcebd93d9"` [INFO] running `"docker" "rm" "-f" "7c14fc489804cfa4ab2015916411e8a1625b7d4198ef0ae1357c4e6dcebd93d9"` [INFO] [stdout] 7c14fc489804cfa4ab2015916411e8a1625b7d4198ef0ae1357c4e6dcebd93d9