[INFO] updating cached repository TeaAndPotatoes/upman
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/TeaAndPotatoes/upman
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/TeaAndPotatoes/upman" "work/ex/clippy-test-run/sources/stable/gh/TeaAndPotatoes/upman"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TeaAndPotatoes/upman'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/TeaAndPotatoes/upman" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TeaAndPotatoes/upman"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TeaAndPotatoes/upman'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e0f153d4096344aa6a43d5436ffc92a69f2a0478
[INFO] sha for GitHub repo TeaAndPotatoes/upman: e0f153d4096344aa6a43d5436ffc92a69f2a0478
[INFO] validating manifest of TeaAndPotatoes/upman on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of TeaAndPotatoes/upman on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing TeaAndPotatoes/upman
[INFO] finished frobbing TeaAndPotatoes/upman
[INFO] frobbed toml for TeaAndPotatoes/upman written to work/ex/clippy-test-run/sources/stable/gh/TeaAndPotatoes/upman/Cargo.toml
[INFO] started frobbing TeaAndPotatoes/upman
[INFO] finished frobbing TeaAndPotatoes/upman
[INFO] frobbed toml for TeaAndPotatoes/upman written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TeaAndPotatoes/upman/Cargo.toml
[INFO] crate TeaAndPotatoes/upman has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting TeaAndPotatoes/upman against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TeaAndPotatoes/upman:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9ffe3ca72d505ae3d1cef982aeec835f0d76e9997e0f3e706fbd2d00d1680a02
[INFO] running `"docker" "start" "-a" "9ffe3ca72d505ae3d1cef982aeec835f0d76e9997e0f3e706fbd2d00d1680a02"`
[INFO] [stderr]     Checking open v1.2.1
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking console v0.6.1
[INFO] [stderr]     Checking indicatif v0.9.0
[INFO] [stderr]     Checking dialoguer v0.1.0
[INFO] [stderr]     Checking upman v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/app.rs:4:5
[INFO] [stderr]    |
[INFO] [stderr] 4  | /     return App::new("Update Manager")
[INFO] [stderr] 5  | |         .version("0.1.0-Beta")
[INFO] [stderr] 6  | |         .author("Brendan Doney <bre.doney@gmail.com>")
[INFO] [stderr] 7  | |         .about("Cross-platform, command-line update manager for easily checking and scheduling updates for different tools")
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |             .about("Open the upman configuration file with the system's default text editor")
[INFO] [stderr] 67 | |         );
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 4  |     App::new("Update Manager")
[INFO] [stderr] 5  |         .version("0.1.0-Beta")
[INFO] [stderr] 6  |         .author("Brendan Doney <bre.doney@gmail.com>")
[INFO] [stderr] 7  |         .about("Cross-platform, command-line update manager for easily checking and scheduling updates for different tools")
[INFO] [stderr] 8  |         .subcommand(SubCommand::with_name("list")
[INFO] [stderr] 9  |             .about("List all of the update commands added to this tool")
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             return Vec::new();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             return results;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             return "";
[INFO] [stderr]    |             ^^^^^^^^^^ help: remove `return` as shown: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             return commands[0];
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `commands[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:90:9
[INFO] [stderr]    |
[INFO] [stderr] 90 |         return self.subset_left(pattern).subset_right(pattern);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.subset_left(pattern).subset_right(pattern)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/command.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |         return command;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `command`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:153:33
[INFO] [stderr]     |
[INFO] [stderr] 153 | /                                 if show_output && output.trim().is_empty() {
[INFO] [stderr] 154 | |                                     if !output.trim().is_empty() {
[INFO] [stderr] 155 | |                                         println!("No output\n");
[INFO] [stderr] 156 | |                                     }
[INFO] [stderr] 157 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 153 |                                 if show_output && output.trim().is_empty() && !output.trim().is_empty() {
[INFO] [stderr] 154 |     println!("No output\n");
[INFO] [stderr] 155 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:20:50
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let config_directory = format!("{}/.upman/", std::env::home_dir().unwrap().display());
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/app.rs:4:5
[INFO] [stderr]    |
[INFO] [stderr] 4  | /     return App::new("Update Manager")
[INFO] [stderr] 5  | |         .version("0.1.0-Beta")
[INFO] [stderr] 6  | |         .author("Brendan Doney <bre.doney@gmail.com>")
[INFO] [stderr] 7  | |         .about("Cross-platform, command-line update manager for easily checking and scheduling updates for different tools")
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |             .about("Open the upman configuration file with the system's default text editor")
[INFO] [stderr] 67 | |         );
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 4  |     App::new("Update Manager")
[INFO] [stderr] 5  |         .version("0.1.0-Beta")
[INFO] [stderr] 6  |         .author("Brendan Doney <bre.doney@gmail.com>")
[INFO] [stderr] 7  |         .about("Cross-platform, command-line update manager for easily checking and scheduling updates for different tools")
[INFO] [stderr] 8  |         .subcommand(SubCommand::with_name("list")
[INFO] [stderr] 9  |             .about("List all of the update commands added to this tool")
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             return Vec::new();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             return results;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             return "";
[INFO] [stderr]    |             ^^^^^^^^^^ help: remove `return` as shown: `""`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             return commands[0];
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `commands[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/command.rs:90:9
[INFO] [stderr]    |
[INFO] [stderr] 90 |         return self.subset_left(pattern).subset_right(pattern);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.subset_left(pattern).subset_right(pattern)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/command.rs:116:9
[INFO] [stderr]     |
[INFO] [stderr] 116 |         return command;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `command`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:153:33
[INFO] [stderr]     |
[INFO] [stderr] 153 | /                                 if show_output && output.trim().is_empty() {
[INFO] [stderr] 154 | |                                     if !output.trim().is_empty() {
[INFO] [stderr] 155 | |                                         println!("No output\n");
[INFO] [stderr] 156 | |                                     }
[INFO] [stderr] 157 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 153 |                                 if show_output && output.trim().is_empty() && !output.trim().is_empty() {
[INFO] [stderr] 154 |     println!("No output\n");
[INFO] [stderr] 155 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:20:50
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let config_directory = format!("{}/.upman/", std::env::home_dir().unwrap().display());
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/command.rs:30:12
[INFO] [stderr]    |
[INFO] [stderr] 30 |         if commands.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `commands.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/command.rs:100:41
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let mut str_iter = string.split(" ");
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `' '`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/messages.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if self.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:67:26
[INFO] [stderr]    |
[INFO] [stderr] 67 | fn list_tools(file_path: &String) {
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/main.rs:79:17
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let l = line.unwrap_or(String::new());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `line.unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:99:27
[INFO] [stderr]    |
[INFO] [stderr] 99 | fn run_updates(file_path: &String, show_output: bool) {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:178:27
[INFO] [stderr]     |
[INFO] [stderr] 178 | fn add_command(file_path: &String, command: &str, line_number: Option<usize>) -> Result<(), std::io::Error> {
[INFO] [stderr]     |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/command.rs:30:12
[INFO] [stderr]    |
[INFO] [stderr] 30 |         if commands.len() < 1 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `commands.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:210:43
[INFO] [stderr]     |
[INFO] [stderr] 210 |             contents.insert(line_num - 1, String::from(prefixed_command));
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `prefixed_command`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:212:27
[INFO] [stderr]     |
[INFO] [stderr] 212 |             contents.push(String::from(prefixed_command));
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `prefixed_command`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:227:35
[INFO] [stderr]     |
[INFO] [stderr] 227 | fn remove_command_line(file_path: &String, line_number: usize) -> Result<(), std::io::Error> {
[INFO] [stderr]     |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/command.rs:100:41
[INFO] [stderr]     |
[INFO] [stderr] 100 |         let mut str_iter = string.split(" ");
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `' '`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:257:35
[INFO] [stderr]     |
[INFO] [stderr] 257 | fn remove_command_name(file_path: &String, command: &str) -> Result<(), std::io::Error> {
[INFO] [stderr]     |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:296:30
[INFO] [stderr]     |
[INFO] [stderr] 296 | fn clear_commands(file_path: &String) {
[INFO] [stderr]     |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/messages.rs:53:12
[INFO] [stderr]    |
[INFO] [stderr] 53 |         if self.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:67:26
[INFO] [stderr]    |
[INFO] [stderr] 67 | fn list_tools(file_path: &String) {
[INFO] [stderr]    |                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/main.rs:79:17
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let l = line.unwrap_or(String::new());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `line.unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:99:27
[INFO] [stderr]    |
[INFO] [stderr] 99 | fn run_updates(file_path: &String, show_output: bool) {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:178:27
[INFO] [stderr]     |
[INFO] [stderr] 178 | fn add_command(file_path: &String, command: &str, line_number: Option<usize>) -> Result<(), std::io::Error> {
[INFO] [stderr]     |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:210:43
[INFO] [stderr]     |
[INFO] [stderr] 210 |             contents.insert(line_num - 1, String::from(prefixed_command));
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `prefixed_command`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:212:27
[INFO] [stderr]     |
[INFO] [stderr] 212 |             contents.push(String::from(prefixed_command));
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `prefixed_command`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:227:35
[INFO] [stderr]     |
[INFO] [stderr] 227 | fn remove_command_line(file_path: &String, line_number: usize) -> Result<(), std::io::Error> {
[INFO] [stderr]     |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:257:35
[INFO] [stderr]     |
[INFO] [stderr] 257 | fn remove_command_name(file_path: &String, command: &str) -> Result<(), std::io::Error> {
[INFO] [stderr]     |                                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:296:30
[INFO] [stderr]     |
[INFO] [stderr] 296 | fn clear_commands(file_path: &String) {
[INFO] [stderr]     |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 11.93s
[INFO] running `"docker" "inspect" "9ffe3ca72d505ae3d1cef982aeec835f0d76e9997e0f3e706fbd2d00d1680a02"`
[INFO] running `"docker" "rm" "-f" "9ffe3ca72d505ae3d1cef982aeec835f0d76e9997e0f3e706fbd2d00d1680a02"`
[INFO] [stdout] 9ffe3ca72d505ae3d1cef982aeec835f0d76e9997e0f3e706fbd2d00d1680a02