[INFO] updating cached repository Tarv3/animator_lib
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Tarv3/animator_lib
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Tarv3/animator_lib" "work/ex/clippy-test-run/sources/stable/gh/Tarv3/animator_lib"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tarv3/animator_lib'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Tarv3/animator_lib" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tarv3/animator_lib"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tarv3/animator_lib'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 808ffcabea64d92477ec01a1997cd2cbb50279fd
[INFO] sha for GitHub repo Tarv3/animator_lib: 808ffcabea64d92477ec01a1997cd2cbb50279fd
[INFO] validating manifest of Tarv3/animator_lib on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Tarv3/animator_lib on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Tarv3/animator_lib
[INFO] finished frobbing Tarv3/animator_lib
[INFO] frobbed toml for Tarv3/animator_lib written to work/ex/clippy-test-run/sources/stable/gh/Tarv3/animator_lib/Cargo.toml
[INFO] started frobbing Tarv3/animator_lib
[INFO] finished frobbing Tarv3/animator_lib
[INFO] frobbed toml for Tarv3/animator_lib written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tarv3/animator_lib/Cargo.toml
[INFO] crate Tarv3/animator_lib has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Tarv3/animator_lib against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Tarv3/animator_lib:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c85d98322c34617c6a3657e7c5652207d30a44cedeec5da3eedadcdbc9d91df1
[INFO] running `"docker" "start" "-a" "c85d98322c34617c6a3657e7c5652207d30a44cedeec5da3eedadcdbc9d91df1"`
[INFO] [stderr]     Checking rand v0.5.5
[INFO] [stderr]     Checking collada v0.8.0
[INFO] [stderr]     Checking alga v0.7.2
[INFO] [stderr]     Checking nalgebra v0.16.4
[INFO] [stderr]     Checking nalgebra-glm v0.1.3
[INFO] [stderr]     Checking animator_lib v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/math.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         print!("\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/math.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         print!("\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/math.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         print!("\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/math.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 |         print!("\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `collada::document::ColladaDocument`
[INFO] [stderr]  --> src/collada_loader/animation_loader.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use collada::document::ColladaDocument;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ops::Range`
[INFO] [stderr]  --> src/math.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::ops::Range;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `collada::document::ColladaDocument`
[INFO] [stderr]  --> src/collada_loader/animation_loader.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use collada::document::ColladaDocument;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ops::Range`
[INFO] [stderr]  --> src/math.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use std::ops::Range;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `buffer`
[INFO] [stderr]   --> src/skeleton/mod.rs:45:18
[INFO] [stderr]    |
[INFO] [stderr] 45 |         for i in 0..len {
[INFO] [stderr]    |                  ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 45 |         for (i, <item>) in buffer.iter_mut().enumerate().take(len) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `poses`
[INFO] [stderr]    --> src/skeleton/mod.rs:102:18
[INFO] [stderr]     |
[INFO] [stderr] 102 |         for i in 0..poses.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 102 |         for (i, <item>) in poses.iter().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/pose.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     let rotation;
[INFO] [stderr] 12 | |     if dot(&a.rotation.coords, &b.rotation.coords) < 0.0 {
[INFO] [stderr] 13 | |         rotation = quat_fast_mix(&-a.rotation, &b.rotation, f);
[INFO] [stderr] 14 | |     } else {
[INFO] [stderr] 15 | |         rotation = quat_fast_mix(&a.rotation, &b.rotation, f);
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let rotation = if dot(&a.rotation.coords, &b.rotation.coords) < 0.0 { quat_fast_mix(&-a.rotation, &b.rotation, f) } else { quat_fast_mix(&a.rotation, &b.rotation, f) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/pose.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     let rotation;
[INFO] [stderr] 32 | |     if dot(&a.rotation.coords, &b.rotation.coords) < 0.0 {
[INFO] [stderr] 33 | |         rotation = quat_slerp(&-a.rotation, &b.rotation, f);
[INFO] [stderr] 34 | |     } else {
[INFO] [stderr] 35 | |         rotation = quat_slerp(&a.rotation, &b.rotation, f);
[INFO] [stderr] 36 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let rotation = if dot(&a.rotation.coords, &b.rotation.coords) < 0.0 { quat_slerp(&-a.rotation, &b.rotation, f) } else { quat_slerp(&a.rotation, &b.rotation, f) };`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/pose.rs:90:14
[INFO] [stderr]    |
[INFO] [stderr] 90 |     for i in 0..to.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^ help: try replacing the loop by: `to.clone_from_slice(&a[..to.len()])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/pose.rs:98:9
[INFO] [stderr]    |
[INFO] [stderr] 98 |         *pose = *pose * base;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*pose *= base`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]    --> src/pose.rs:234:52
[INFO] [stderr]     |
[INFO] [stderr] 234 |         let translation = vec4_to_vec3(&rot_trans) + self.translation;
[INFO] [stderr]     |                                                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/pose.rs:252:17
[INFO] [stderr]     |
[INFO] [stderr] 252 |         *self = &*self * &rhs;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 252 |         *self = *self * rhs;
[INFO] [stderr]     |                 ^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]    --> src/pose.rs:260:52
[INFO] [stderr]     |
[INFO] [stderr] 260 |         let translation = vec4_to_vec3(&rot_trans) + self.translation;
[INFO] [stderr]     |                                                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/pose.rs:278:17
[INFO] [stderr]     |
[INFO] [stderr] 278 |         *self = &*self * rhs;
[INFO] [stderr]     |                 ------^^^^^^
[INFO] [stderr]     |                 |
[INFO] [stderr]     |                 help: use the left value directly: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]    --> src/pose.rs:286:52
[INFO] [stderr]     |
[INFO] [stderr] 286 |         let translation = vec4_to_vec3(&rot_trans) + self.translation;
[INFO] [stderr]     |                                                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]    --> src/pose.rs:306:52
[INFO] [stderr]     |
[INFO] [stderr] 306 |         let translation = vec4_to_vec3(&rot_trans) + self.translation;
[INFO] [stderr]     |                                                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/animation/animator.rs:92:22
[INFO] [stderr]    |
[INFO] [stderr] 92 |           let second = match first == animation.times.len() - 1 {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 93 | |             true => 0,
[INFO] [stderr] 94 | |             false => first + 1,
[INFO] [stderr] 95 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if first == animation.times.len() - 1 { 0 } else { first + 1 }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/animation/animator.rs:125:9
[INFO] [stderr]     |
[INFO] [stderr] 125 | /         let second;
[INFO] [stderr] 126 | |         if self.between.0 == animation.times.len() - 1 {
[INFO] [stderr] 127 | |             second = match self.ani_type {
[INFO] [stderr] 128 | |                 AniType::Looping(duration) => first + duration,
[INFO] [stderr] ...   |
[INFO] [stderr] 132 | |             second = animation.times[self.between.1].into_inner();
[INFO] [stderr] 133 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 125 |         let second = if self.between.0 == animation.times.len() - 1 { match self.ani_type {
[INFO] [stderr] 126 |                 AniType::Looping(duration) => first + duration,
[INFO] [stderr] 127 |                 _ => first,
[INFO] [stderr] 128 |             } } else { animation.times[self.between.1].into_inner() };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/animation/animator.rs:143:30
[INFO] [stderr]     |
[INFO] [stderr] 143 |             AniType::Once => last.into_inner() == self.time,
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(last.into_inner() - self.time).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/animation/animator.rs:143:30
[INFO] [stderr]     |
[INFO] [stderr] 143 |             AniType::Once => last.into_inner() == self.time,
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/animation/mod.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         match times_iter.next() {
[INFO] [stderr] 23 | |             Some(time) => {
[INFO] [stderr] 24 | |                 times.push(OrderedFloat(*time));   
[INFO] [stderr] 25 | |                 times.extend(times_iter.map(|t| OrderedFloat(t - time)));
[INFO] [stderr] 26 | |             },
[INFO] [stderr] 27 | |             None => (),
[INFO] [stderr] 28 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 |         if let Some(time) = times_iter.next() {
[INFO] [stderr] 23 |     times.push(OrderedFloat(*time));   
[INFO] [stderr] 24 |     times.extend(times_iter.map(|t| OrderedFloat(t - time)));
[INFO] [stderr] 25 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/animation/mod.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |             poses: poses.iter().map(|pose| *pose).collect(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `poses.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/collada_loader/animation_loader.rs:28:42
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let target = &animation.target.split("/").next()?;
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/collada_loader/skeleton_loader.rs:14:22
[INFO] [stderr]    |
[INFO] [stderr] 14 |           let parent = match joint.is_root() {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 15 | |             true => None,
[INFO] [stderr] 16 | |             false => Some(joint.parent_index as usize),
[INFO] [stderr] 17 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if joint.is_root() { None } else { Some(joint.parent_index as usize) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/math.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 |             amount = amount % length;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount %= length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/math.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             amount = amount % length;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount %= length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 5 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `animator_lib`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: the loop variable `i` is used to index `buffer`
[INFO] [stderr]   --> src/skeleton/mod.rs:45:18
[INFO] [stderr]    |
[INFO] [stderr] 45 |         for i in 0..len {
[INFO] [stderr]    |                  ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 45 |         for (i, <item>) in buffer.iter_mut().enumerate().take(len) {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `poses`
[INFO] [stderr]    --> src/skeleton/mod.rs:102:18
[INFO] [stderr]     |
[INFO] [stderr] 102 |         for i in 0..poses.len() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 102 |         for (i, <item>) in poses.iter().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/pose.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     let rotation;
[INFO] [stderr] 12 | |     if dot(&a.rotation.coords, &b.rotation.coords) < 0.0 {
[INFO] [stderr] 13 | |         rotation = quat_fast_mix(&-a.rotation, &b.rotation, f);
[INFO] [stderr] 14 | |     } else {
[INFO] [stderr] 15 | |         rotation = quat_fast_mix(&a.rotation, &b.rotation, f);
[INFO] [stderr] 16 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let rotation = if dot(&a.rotation.coords, &b.rotation.coords) < 0.0 { quat_fast_mix(&-a.rotation, &b.rotation, f) } else { quat_fast_mix(&a.rotation, &b.rotation, f) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/pose.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 | /     let rotation;
[INFO] [stderr] 32 | |     if dot(&a.rotation.coords, &b.rotation.coords) < 0.0 {
[INFO] [stderr] 33 | |         rotation = quat_slerp(&-a.rotation, &b.rotation, f);
[INFO] [stderr] 34 | |     } else {
[INFO] [stderr] 35 | |         rotation = quat_slerp(&a.rotation, &b.rotation, f);
[INFO] [stderr] 36 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let rotation = if dot(&a.rotation.coords, &b.rotation.coords) < 0.0 { quat_slerp(&-a.rotation, &b.rotation, f) } else { quat_slerp(&a.rotation, &b.rotation, f) };`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/pose.rs:90:14
[INFO] [stderr]    |
[INFO] [stderr] 90 |     for i in 0..to.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^ help: try replacing the loop by: `to.clone_from_slice(&a[..to.len()])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/pose.rs:98:9
[INFO] [stderr]    |
[INFO] [stderr] 98 |         *pose = *pose * base;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*pose *= base`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]    --> src/pose.rs:234:52
[INFO] [stderr]     |
[INFO] [stderr] 234 |         let translation = vec4_to_vec3(&rot_trans) + self.translation;
[INFO] [stderr]     |                                                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/pose.rs:252:17
[INFO] [stderr]     |
[INFO] [stderr] 252 |         *self = &*self * &rhs;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 252 |         *self = *self * rhs;
[INFO] [stderr]     |                 ^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]    --> src/pose.rs:260:52
[INFO] [stderr]     |
[INFO] [stderr] 260 |         let translation = vec4_to_vec3(&rot_trans) + self.translation;
[INFO] [stderr]     |                                                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/pose.rs:278:17
[INFO] [stderr]     |
[INFO] [stderr] 278 |         *self = &*self * rhs;
[INFO] [stderr]     |                 ------^^^^^^
[INFO] [stderr]     |                 |
[INFO] [stderr]     |                 help: use the left value directly: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]    --> src/pose.rs:286:52
[INFO] [stderr]     |
[INFO] [stderr] 286 |         let translation = vec4_to_vec3(&rot_trans) + self.translation;
[INFO] [stderr]     |                                                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl
[INFO] [stderr]    --> src/pose.rs:306:52
[INFO] [stderr]     |
[INFO] [stderr] 306 |         let translation = vec4_to_vec3(&rot_trans) + self.translation;
[INFO] [stderr]     |                                                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/animation/animator.rs:92:22
[INFO] [stderr]    |
[INFO] [stderr] 92 |           let second = match first == animation.times.len() - 1 {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 93 | |             true => 0,
[INFO] [stderr] 94 | |             false => first + 1,
[INFO] [stderr] 95 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if first == animation.times.len() - 1 { 0 } else { first + 1 }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/animation/animator.rs:125:9
[INFO] [stderr]     |
[INFO] [stderr] 125 | /         let second;
[INFO] [stderr] 126 | |         if self.between.0 == animation.times.len() - 1 {
[INFO] [stderr] 127 | |             second = match self.ani_type {
[INFO] [stderr] 128 | |                 AniType::Looping(duration) => first + duration,
[INFO] [stderr] ...   |
[INFO] [stderr] 132 | |             second = animation.times[self.between.1].into_inner();
[INFO] [stderr] 133 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 125 |         let second = if self.between.0 == animation.times.len() - 1 { match self.ani_type {
[INFO] [stderr] 126 |                 AniType::Looping(duration) => first + duration,
[INFO] [stderr] 127 |                 _ => first,
[INFO] [stderr] 128 |             } } else { animation.times[self.between.1].into_inner() };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/animation/animator.rs:143:30
[INFO] [stderr]     |
[INFO] [stderr] 143 |             AniType::Once => last.into_inner() == self.time,
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(last.into_inner() - self.time).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/animation/animator.rs:143:30
[INFO] [stderr]     |
[INFO] [stderr] 143 |             AniType::Once => last.into_inner() == self.time,
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/animation/mod.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 | /         match times_iter.next() {
[INFO] [stderr] 23 | |             Some(time) => {
[INFO] [stderr] 24 | |                 times.push(OrderedFloat(*time));   
[INFO] [stderr] 25 | |                 times.extend(times_iter.map(|t| OrderedFloat(t - time)));
[INFO] [stderr] 26 | |             },
[INFO] [stderr] 27 | |             None => (),
[INFO] [stderr] 28 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 22 |         if let Some(time) = times_iter.next() {
[INFO] [stderr] 23 |     times.push(OrderedFloat(*time));   
[INFO] [stderr] 24 |     times.extend(times_iter.map(|t| OrderedFloat(t - time)));
[INFO] [stderr] 25 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/animation/mod.rs:33:20
[INFO] [stderr]    |
[INFO] [stderr] 33 |             poses: poses.iter().map(|pose| *pose).collect(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `poses.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/collada_loader/animation_loader.rs:28:42
[INFO] [stderr]    |
[INFO] [stderr] 28 |     let target = &animation.target.split("/").next()?;
[INFO] [stderr]    |                                          ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/collada_loader/skeleton_loader.rs:14:22
[INFO] [stderr]    |
[INFO] [stderr] 14 |           let parent = match joint.is_root() {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 15 | |             true => None,
[INFO] [stderr] 16 | |             false => Some(joint.parent_index as usize),
[INFO] [stderr] 17 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if joint.is_root() { None } else { Some(joint.parent_index as usize) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/math.rs:74:13
[INFO] [stderr]    |
[INFO] [stderr] 74 |             amount = amount % length;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount %= length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/math.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             amount = amount % length;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount %= length`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/math.rs:147:17
[INFO] [stderr]     |
[INFO] [stderr] 147 |         assert!(time2 == 0.5);
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: consider comparing them within some error: `(time2 - 0.5).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/math.rs:147:17
[INFO] [stderr]     |
[INFO] [stderr] 147 |         assert!(time2 == 0.5);
[INFO] [stderr]     |                 ^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 6 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `animator_lib`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "c85d98322c34617c6a3657e7c5652207d30a44cedeec5da3eedadcdbc9d91df1"`
[INFO] running `"docker" "rm" "-f" "c85d98322c34617c6a3657e7c5652207d30a44cedeec5da3eedadcdbc9d91df1"`
[INFO] [stdout] c85d98322c34617c6a3657e7c5652207d30a44cedeec5da3eedadcdbc9d91df1