[INFO] updating cached repository Tarouka/rust-co-toolkit
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Tarouka/rust-co-toolkit
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Tarouka/rust-co-toolkit" "work/ex/clippy-test-run/sources/stable/gh/Tarouka/rust-co-toolkit"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Tarouka/rust-co-toolkit'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Tarouka/rust-co-toolkit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tarouka/rust-co-toolkit"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tarouka/rust-co-toolkit'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] db527e1a2f16022fa7fd9fba7ad0f8bff6d63a22
[INFO] sha for GitHub repo Tarouka/rust-co-toolkit: db527e1a2f16022fa7fd9fba7ad0f8bff6d63a22
[INFO] validating manifest of Tarouka/rust-co-toolkit on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Tarouka/rust-co-toolkit on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Tarouka/rust-co-toolkit
[INFO] finished frobbing Tarouka/rust-co-toolkit
[INFO] frobbed toml for Tarouka/rust-co-toolkit written to work/ex/clippy-test-run/sources/stable/gh/Tarouka/rust-co-toolkit/Cargo.toml
[INFO] started frobbing Tarouka/rust-co-toolkit
[INFO] finished frobbing Tarouka/rust-co-toolkit
[INFO] frobbed toml for Tarouka/rust-co-toolkit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Tarouka/rust-co-toolkit/Cargo.toml
[INFO] crate Tarouka/rust-co-toolkit has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Tarouka/rust-co-toolkit against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Tarouka/rust-co-toolkit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 484c5425c2dd635411712bf98bd11f0ca24a2a33e25c5b5bffc99b6ed0bd8270
[INFO] running `"docker" "start" "-a" "484c5425c2dd635411712bf98bd11f0ca24a2a33e25c5b5bffc99b6ed0bd8270"`
[INFO] [stderr]     Checking nom v3.0.0
[INFO] [stderr]     Checking rust-ini v0.9.12
[INFO] [stderr]     Checking toolkit v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/levelexp.rs:38:29
[INFO] [stderr]    |
[INFO] [stderr] 38 |             let level_data = Level { level: level, experience: exp };
[INFO] [stderr]    |                                      ^^^^^^^^^^^^ help: replace it with: `level`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/itemtype.rs:327:19
[INFO] [stderr]     |
[INFO] [stderr] 327 |         Some(ItemType { header: header, entries: entries })
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/itemtype.rs:327:35
[INFO] [stderr]     |
[INFO] [stderr] 327 |         Some(ItemType { header: header, entries: entries })
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^ help: replace it with: `entries`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/magictype.rs:354:20
[INFO] [stderr]     |
[INFO] [stderr] 354 |         Some(MagicType { header: header, entries: entries })
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/magictype.rs:354:36
[INFO] [stderr]     |
[INFO] [stderr] 354 |         Some(MagicType { header: header, entries: entries })
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: replace it with: `entries`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/levelexp.rs:38:29
[INFO] [stderr]    |
[INFO] [stderr] 38 |             let level_data = Level { level: level, experience: exp };
[INFO] [stderr]    |                                      ^^^^^^^^^^^^ help: replace it with: `level`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/itemtype.rs:327:19
[INFO] [stderr]     |
[INFO] [stderr] 327 |         Some(ItemType { header: header, entries: entries })
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/itemtype.rs:327:35
[INFO] [stderr]     |
[INFO] [stderr] 327 |         Some(ItemType { header: header, entries: entries })
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^ help: replace it with: `entries`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/magictype.rs:354:20
[INFO] [stderr]     |
[INFO] [stderr] 354 |         Some(MagicType { header: header, entries: entries })
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/magictype.rs:354:36
[INFO] [stderr]     |
[INFO] [stderr] 354 |         Some(MagicType { header: header, entries: entries })
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^ help: replace it with: `entries`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io`
[INFO] [stderr]  --> src/main.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::io;
[INFO] [stderr]   |     ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::prelude::*`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::io::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fs`
[INFO] [stderr]  --> src/main.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 | use std::fs;
[INFO] [stderr]   |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::process::Command`
[INFO] [stderr]  --> src/main.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::process::Command;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::collections::HashMap`
[INFO] [stderr]  --> src/main.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 | use std::collections::HashMap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::Cursor`
[INFO] [stderr]   --> src/main.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | use std::io::Cursor;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::env`
[INFO] [stderr]   --> src/main.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use std::env;
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/main.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/datfiles.rs:37:34
[INFO] [stderr]    |
[INFO] [stderr] 37 |         seed = seed.wrapping_mul(214013).wrapping_add(2531011);
[INFO] [stderr]    |                                  ^^^^^^ help: consider: `214_013`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/datfiles.rs:37:55
[INFO] [stderr]    |
[INFO] [stderr] 37 |         seed = seed.wrapping_mul(214013).wrapping_add(2531011);
[INFO] [stderr]    |                                                       ^^^^^^^ help: consider: `2_531_011`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `ErrorKind`, `IResult`, `not_line_ending`
[INFO] [stderr]   --> src/datfiles.rs:46:15
[INFO] [stderr]    |
[INFO] [stderr] 46 |     use nom::{not_line_ending, IResult, ErrorKind};
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/datfiles.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 |         result
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/datfiles.rs:81:22
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let result = str::replace(&input, "~", " ");
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/datfiles.rs:89:9
[INFO] [stderr]    |
[INFO] [stderr] 89 |         result
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/datfiles.rs:87:22
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let result = str::replace(&input, " ", "~");
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/datfiles.rs:167:17
[INFO] [stderr]     |
[INFO] [stderr] 167 |                 return Result::Ok(res > 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(res > 0)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/datfiles.rs:171:17
[INFO] [stderr]     |
[INFO] [stderr] 171 |                 return Result::Err(idx);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(idx)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io`
[INFO] [stderr]  --> src/levelexp.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::io;
[INFO] [stderr]   |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fs`
[INFO] [stderr]   --> src/levelexp.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | use std::fs;
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `nom::IResult`
[INFO] [stderr]    --> src/itemtype.rs:117:6
[INFO] [stderr]     |
[INFO] [stderr] 117 |     use nom::IResult;
[INFO] [stderr]     |         ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `nom::IResult::Done`
[INFO] [stderr]    --> src/itemtype.rs:118:6
[INFO] [stderr]     |
[INFO] [stderr] 118 |     use nom::IResult::Done;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `datfiles::parser`
[INFO] [stderr]    --> src/magictype.rs:128:6
[INFO] [stderr]     |
[INFO] [stderr] 128 |     use datfiles::parser;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `nom::*`
[INFO] [stderr]    --> src/magictype.rs:133:6
[INFO] [stderr]     |
[INFO] [stderr] 133 |     use nom::*;
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monster.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |                 return Result::Ok(found_key.to_owned());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(found_key.to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monster.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |                 return Result::Err(GetKeyError::KeyNotFound(String::from(key)));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(GetKeyError::KeyNotFound(String::from(key)))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monster.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 return Result::Ok(parsed);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(parsed)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monster.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 return Result::Err(GetKeyError::FailedToParse(String::from(key)));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(GetKeyError::FailedToParse(String::from(key)))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io`
[INFO] [stderr]  --> src/main.rs:3:5
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::io;
[INFO] [stderr]   |     ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::prelude::*`
[INFO] [stderr]  --> src/main.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::io::prelude::*;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fs`
[INFO] [stderr]  --> src/main.rs:7:5
[INFO] [stderr]   |
[INFO] [stderr] 7 | use std::fs;
[INFO] [stderr]   |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::process::Command`
[INFO] [stderr]  --> src/main.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::process::Command;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::collections::HashMap`
[INFO] [stderr]  --> src/main.rs:9:5
[INFO] [stderr]   |
[INFO] [stderr] 9 | use std::collections::HashMap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::Cursor`
[INFO] [stderr]   --> src/main.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | use std::io::Cursor;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::env`
[INFO] [stderr]   --> src/main.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | use std::env;
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/main.rs:15:1
[INFO] [stderr]    |
[INFO] [stderr] 15 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/datfiles.rs:37:34
[INFO] [stderr]    |
[INFO] [stderr] 37 |         seed = seed.wrapping_mul(214013).wrapping_add(2531011);
[INFO] [stderr]    |                                  ^^^^^^ help: consider: `214_013`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/datfiles.rs:37:55
[INFO] [stderr]    |
[INFO] [stderr] 37 |         seed = seed.wrapping_mul(214013).wrapping_add(2531011);
[INFO] [stderr]    |                                                       ^^^^^^^ help: consider: `2_531_011`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused imports: `ErrorKind`, `IResult`, `not_line_ending`
[INFO] [stderr]   --> src/datfiles.rs:46:15
[INFO] [stderr]    |
[INFO] [stderr] 46 |     use nom::{not_line_ending, IResult, ErrorKind};
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^  ^^^^^^^  ^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/datfiles.rs:83:9
[INFO] [stderr]    |
[INFO] [stderr] 83 |         result
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/datfiles.rs:81:22
[INFO] [stderr]    |
[INFO] [stderr] 81 |         let result = str::replace(&input, "~", " ");
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/datfiles.rs:89:9
[INFO] [stderr]    |
[INFO] [stderr] 89 |         result
[INFO] [stderr]    |         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/datfiles.rs:87:22
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let result = str::replace(&input, " ", "~");
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/datfiles.rs:167:17
[INFO] [stderr]     |
[INFO] [stderr] 167 |                 return Result::Ok(res > 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(res > 0)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/datfiles.rs:171:17
[INFO] [stderr]     |
[INFO] [stderr] 171 |                 return Result::Err(idx);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(idx)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io`
[INFO] [stderr]  --> src/levelexp.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::io;
[INFO] [stderr]   |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fs`
[INFO] [stderr]   --> src/levelexp.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 | use std::fs;
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `nom::IResult`
[INFO] [stderr]    --> src/itemtype.rs:117:6
[INFO] [stderr]     |
[INFO] [stderr] 117 |     use nom::IResult;
[INFO] [stderr]     |         ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `nom::IResult::Done`
[INFO] [stderr]    --> src/itemtype.rs:118:6
[INFO] [stderr]     |
[INFO] [stderr] 118 |     use nom::IResult::Done;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/itemtype.rs:397:56
[INFO] [stderr]     |
[INFO] [stderr] 397 |             assert_item_type_field_eq!(SAMPLE_ITEM_ENTRY_1, id, 100000);
[INFO] [stderr]     |                                                                 ^^^^^^ help: consider: `100_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/itemtype.rs:398:56
[INFO] [stderr]     |
[INFO] [stderr] 398 |             assert_item_type_field_eq!(SAMPLE_ITEM_ENTRY_2, id, 150000);
[INFO] [stderr]     |                                                                 ^^^^^^ help: consider: `150_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/itemtype.rs:399:56
[INFO] [stderr]     |
[INFO] [stderr] 399 |             assert_item_type_field_eq!(SAMPLE_ITEM_ENTRY_3, id, 2000000);
[INFO] [stderr]     |                                                                 ^^^^^^^ help: consider: `2_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `datfiles::parser`
[INFO] [stderr]    --> src/magictype.rs:128:6
[INFO] [stderr]     |
[INFO] [stderr] 128 |     use datfiles::parser;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `nom::*`
[INFO] [stderr]    --> src/magictype.rs:133:6
[INFO] [stderr]     |
[INFO] [stderr] 133 |     use nom::*;
[INFO] [stderr]     |         ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/magictype.rs:571:67
[INFO] [stderr]     |
[INFO] [stderr] 571 |             assert_magic_type_field_eq!(SAMPLE_MAGIC_ENTRY_1, xp_required, 1000000);
[INFO] [stderr]     |                                                                            ^^^^^^^ help: consider: `1_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/magictype.rs:572:67
[INFO] [stderr]     |
[INFO] [stderr] 572 |             assert_magic_type_field_eq!(SAMPLE_MAGIC_ENTRY_2, xp_required, 14000000);
[INFO] [stderr]     |                                                                            ^^^^^^^^ help: consider: `14_000_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monster.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |                 return Result::Ok(found_key.to_owned());
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(found_key.to_owned())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monster.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |                 return Result::Err(GetKeyError::KeyNotFound(String::from(key)));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(GetKeyError::KeyNotFound(String::from(key)))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monster.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 return Result::Ok(parsed);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(parsed)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/monster.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |                 return Result::Err(GetKeyError::FailedToParse(String::from(key)));
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Err(GetKeyError::FailedToParse(String::from(key)))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ReadBytesExt`
[INFO] [stderr]   --> src/levelexp.rs:16:42
[INFO] [stderr]    |
[INFO] [stderr] 16 | use byteorder::{ByteOrder, LittleEndian, ReadBytesExt};
[INFO] [stderr]    |                                          ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `header`
[INFO] [stderr]    --> src/itemtype.rs:298:11
[INFO] [stderr]     |
[INFO] [stderr] 298 |                         let header = item_type_header_parsed;
[INFO] [stderr]     |                             ^^^^^^ help: consider using `_header` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `header`
[INFO] [stderr]    --> src/magictype.rs:325:11
[INFO] [stderr]     |
[INFO] [stderr] 325 |                         let header = magic_type_header_parsed;
[INFO] [stderr]     |                             ^^^^^^ help: consider using `_header` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `entry_idx`
[INFO] [stderr]    --> src/magictype.rs:348:17
[INFO] [stderr]     |
[INFO] [stderr] 348 |                 Result::Err(entry_idx) => {
[INFO] [stderr]     |                             ^^^^^^^^^ help: consider using `_entry_idx` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `bytes_read`
[INFO] [stderr]    --> src/main.rs:210:9
[INFO] [stderr]     |
[INFO] [stderr] 210 |     let bytes_read = f.read_to_end(&mut buffer).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^ help: consider using `_bytes_read` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `encoded_bytes` is never read
[INFO] [stderr]    --> src/main.rs:309:17
[INFO] [stderr]     |
[INFO] [stderr] 309 |         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `encoded_bytes` is never read
[INFO] [stderr]    --> src/main.rs:351:17
[INFO] [stderr]     |
[INFO] [stderr] 351 |         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `encoded_bytes` is never read
[INFO] [stderr]    --> src/main.rs:402:17
[INFO] [stderr]     |
[INFO] [stderr] 402 |         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `bytes_read_mb`
[INFO] [stderr]   --> src/levelexp.rs:82:10
[INFO] [stderr]    |
[INFO] [stderr] 82 |         let bytes_read_mb: f64 = (bytes_read as f64) / 1024.0 / 1024.0;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: consider using `_bytes_read_mb` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:317:13
[INFO] [stderr]     |
[INFO] [stderr] 317 |         let mut bytes_to_write = if args.encrypt { encrypt_cofac_bytes(encoded_bytes) } else { encoded_bytes };
[INFO] [stderr]     |             ----^^^^^^^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:359:13
[INFO] [stderr]     |
[INFO] [stderr] 359 |         let mut bytes_to_write = if args.encrypt { encrypt_cofac_bytes(encoded_bytes) } else { encoded_bytes };
[INFO] [stderr]     |             ----^^^^^^^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:411:13
[INFO] [stderr]     |
[INFO] [stderr] 411 |         let mut bytes_to_write = if args.encrypt { encrypt_cofac_bytes(encoded_bytes) } else { encoded_bytes };
[INFO] [stderr]     |             ----^^^^^^^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Level`
[INFO] [stderr]   --> src/levelexp.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub struct Level {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `LevelExpFile`
[INFO] [stderr]   --> src/levelexp.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub struct LevelExpFile {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_levels`
[INFO] [stderr]   --> src/levelexp.rs:29:2
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn get_levels(&self) -> Vec<Level> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_levels_as_map`
[INFO] [stderr]   --> src/levelexp.rs:46:2
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn get_levels_as_map(&self) -> HashMap<u8, i32> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_levels_count`
[INFO] [stderr]   --> src/levelexp.rs:61:2
[INFO] [stderr]    |
[INFO] [stderr] 61 |     fn get_levels_count(&self, levels_data: &Vec<u8>) -> usize {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_level_from_idx`
[INFO] [stderr]   --> src/levelexp.rs:65:2
[INFO] [stderr]    |
[INFO] [stderr] 65 |     fn get_level_from_idx(&self, idx: &usize) -> u8 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_exp_from_level`
[INFO] [stderr]   --> src/levelexp.rs:69:2
[INFO] [stderr]    |
[INFO] [stderr] 69 |     fn get_exp_from_level(&self, levels: &Vec<u8>, idx: &usize) -> i32 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_file_bytes`
[INFO] [stderr]   --> src/levelexp.rs:76:2
[INFO] [stderr]    |
[INFO] [stderr] 76 |     fn get_file_bytes(&self) -> Vec<u8> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `serialize_monster_entries_to_str`
[INFO] [stderr]    --> src/monster.rs:108:2
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn serialize_monster_entries_to_str(entries: &Vec<MonsterEntry>) -> String {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/datfiles.rs:3:33
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn decrypt_bytes(bytes_enc: &Vec<u8>, key: &[u8; 128]) -> Vec<u8> {
[INFO] [stderr]   |                                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/datfiles.rs:7:24
[INFO] [stderr]   |
[INFO] [stderr] 7 |         let tmp: u16 = (bytes_enc[b] ^ key[b % 128]) as u16;
[INFO] [stderr]   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes_enc[b] ^ key[b % 128])`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/datfiles.rs:17:33
[INFO] [stderr]    |
[INFO] [stderr] 17 | pub fn encrypt_bytes(bytes_dec: &Vec<u8>, key: &[u8; 128]) -> Vec<u8> {
[INFO] [stderr]    |                                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/datfiles.rs:21:30
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let curr_byte: u16 = bytes_dec[b] as u16;
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes_dec[b])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/datfiles.rs:34:25
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let mut seed: i32 = COFAC_BASE_SEED as i32; // itemtype.dat & magictype.dat initial seed
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(COFAC_BASE_SEED)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `b` is only used to index `key`.
[INFO] [stderr]   --> src/datfiles.rs:36:14
[INFO] [stderr]    |
[INFO] [stderr] 36 |     for b in 0..128 {
[INFO] [stderr]    |              ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 36 |     for <item> in &mut key {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:140:39
[INFO] [stderr]     |
[INFO] [stderr] 140 |     pub fn parse_match_to_u8(matches: &Vec<String>, idx: usize) -> Result<u8, usize> {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:144:40
[INFO] [stderr]     |
[INFO] [stderr] 144 |     pub fn parse_match_to_u16(matches: &Vec<String>, idx: usize) -> Result<u16, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:148:40
[INFO] [stderr]     |
[INFO] [stderr] 148 |     pub fn parse_match_to_u32(matches: &Vec<String>, idx: usize) -> Result<u32, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:152:40
[INFO] [stderr]     |
[INFO] [stderr] 152 |     pub fn parse_match_to_i32(matches: &Vec<String>, idx: usize) -> Result<i32, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:156:40
[INFO] [stderr]     |
[INFO] [stderr] 156 |     pub fn parse_match_to_u64(matches: &Vec<String>, idx: usize) -> Result<u64, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:160:40
[INFO] [stderr]     |
[INFO] [stderr] 160 |     pub fn parse_match_to_i64(matches: &Vec<String>, idx: usize) -> Result<i64, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:164:41
[INFO] [stderr]     |
[INFO] [stderr] 164 |     pub fn parse_match_to_bool(matches: &Vec<String>, idx: usize) -> Result<bool, usize> {
[INFO] [stderr]     |                                         ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/levelexp.rs:61:42
[INFO] [stderr]    |
[INFO] [stderr] 61 |     fn get_levels_count(&self, levels_data: &Vec<u8>) -> usize {
[INFO] [stderr]    |                                             ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/levelexp.rs:65:36
[INFO] [stderr]    |
[INFO] [stderr] 65 |     fn get_level_from_idx(&self, idx: &usize) -> u8 {
[INFO] [stderr]    |                                       ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/levelexp.rs:69:39
[INFO] [stderr]    |
[INFO] [stderr] 69 |     fn get_exp_from_level(&self, levels: &Vec<u8>, idx: &usize) -> i32 {
[INFO] [stderr]    |                                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/levelexp.rs:69:54
[INFO] [stderr]    |
[INFO] [stderr] 69 |     fn get_exp_from_level(&self, levels: &Vec<u8>, idx: &usize) -> i32 {
[INFO] [stderr]    |                                                         ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/itemtype.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 | /     pub fn item_type_header<'a>(val: &'a [u8]) -> Result<ItemTypeHeader, ParseIntError> {
[INFO] [stderr] 213 | |         let val_as_str = String::from_utf8_lossy(val).into_owned();
[INFO] [stderr] 214 | |         let reg_parser_items = Regex::new(r"Amount=(\d+)").unwrap();
[INFO] [stderr] 215 | |         let captures = reg_parser_items.captures(&val_as_str).unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 222 | |         Result::Ok(entry)
[INFO] [stderr] 223 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/itemtype.rs:225:2
[INFO] [stderr]     |
[INFO] [stderr] 225 |       pub fn item_type_entry<'a>(val: &'a [u8]) -> Result<ItemTypeEntry, usize> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 226 | |         let val_as_str = String::from_utf8_lossy(val).into_owned();
[INFO] [stderr] 227 | |         let reg_parser_items = Regex::new(r"(\S+)\s*").unwrap();
[INFO] [stderr] 228 | |         let mut packed_strs: Vec<String> = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 285 | |         Result::Ok(entry)
[INFO] [stderr] 286 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/itemtype.rs:289:2
[INFO] [stderr]     |
[INFO] [stderr] 289 |       pub fn parse_item_type<'a>(bytes: &'a [u8]) -> Option<ItemType> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 290 | |         let mut entries: Vec<ItemTypeEntry> = Vec::new();
[INFO] [stderr] 291 | |         let bytes_split = split_bytes_by_lines(Vec::from(bytes));
[INFO] [stderr] 292 | |         let header = ItemTypeHeader { amount: 30 };
[INFO] [stderr] ...   |
[INFO] [stderr] 327 | |         Some(ItemType { header: header, entries: entries })
[INFO] [stderr] 328 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/itemtype.rs:314:15
[INFO] [stderr]     |
[INFO] [stderr] 314 |             let line = bytes_split.get(idx).unwrap();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes_split[idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/magictype.rs:233:5
[INFO] [stderr]     |
[INFO] [stderr] 233 | /     pub fn magic_type_header<'a>(val: &'a [u8]) -> Result<MagicTypeHeader, ParseIntError> {
[INFO] [stderr] 234 | |         let val_as_str = String::from_utf8_lossy(val).into_owned();
[INFO] [stderr] 235 | |         let reg_parser_items = Regex::new(r"Amount=(\d+)").unwrap();
[INFO] [stderr] 236 | |         let captures = reg_parser_items.captures(&val_as_str).unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 243 | |         Result::Ok(entry)
[INFO] [stderr] 244 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/magictype.rs:246:2
[INFO] [stderr]     |
[INFO] [stderr] 246 |       pub fn magic_type_entry<'a>(val: &'a [u8]) -> Result<MagicTypeEntry, usize> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 247 | |         let val_as_str = String::from_utf8_lossy(val).into_owned();
[INFO] [stderr] 248 | |         let reg_parser_items = Regex::new(r"(\S+)\s*").unwrap();
[INFO] [stderr] 249 | |         let mut packed_strs: Vec<String> = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 313 | |         Result::Ok(entry)
[INFO] [stderr] 314 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/magictype.rs:316:2
[INFO] [stderr]     |
[INFO] [stderr] 316 |       pub fn parse_magic_type<'a>(bytes: &'a [u8]) -> Option<MagicType> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 317 | |         let mut entries: Vec<MagicTypeEntry> = Vec::new();
[INFO] [stderr] 318 | |         let bytes_split = split_bytes_by_lines(Vec::from(bytes));
[INFO] [stderr] 319 | |         let header = MagicTypeHeader { amount: 30 };
[INFO] [stderr] ...   |
[INFO] [stderr] 354 | |         Some(MagicType { header: header, entries: entries })
[INFO] [stderr] 355 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/magictype.rs:341:15
[INFO] [stderr]     |
[INFO] [stderr] 341 |             let line = bytes_split.get(idx).unwrap();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes_split[idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monster.rs:108:51
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn serialize_monster_entries_to_str(entries: &Vec<MonsterEntry>) -> String {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^ help: change this to: `&[MonsterEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monster.rs:369:41
[INFO] [stderr]     |
[INFO] [stderr] 369 |     pub fn decode_monster_to_json(entries: &Vec<MonsterEntry>) -> Vec<u8> {
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^ help: change this to: `&[MonsterEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:218:5
[INFO] [stderr]     |
[INFO] [stderr] 218 |     f.write_all(&bytes);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:260:5
[INFO] [stderr]     |
[INFO] [stderr] 260 | /     pub fn exec_decrypt_dat<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 261 | |         let src_filename = matches.value_of("SRC_FILENAME").unwrap();
[INFO] [stderr] 262 | |         let dst_filename = matches.value_of("DST_FILENAME").unwrap();
[INFO] [stderr] 263 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 267 | |         println!("Wrote decrypted file to {} successfully.", dst_filename);
[INFO] [stderr] 268 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:270:5
[INFO] [stderr]     |
[INFO] [stderr] 270 | /     pub fn exec_encrypt_dat<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 271 | |         let src_filename = matches.value_of("SRC_FILENAME").unwrap();
[INFO] [stderr] 272 | |         let dst_filename = matches.value_of("DST_FILENAME").unwrap();
[INFO] [stderr] 273 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 277 | |         println!("Wrote encrypted file to {} successfully.", dst_filename);
[INFO] [stderr] 278 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:280:5
[INFO] [stderr]     |
[INFO] [stderr] 280 | /     pub fn exec_itemtype_decode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 281 | |         let args = get_decoder_args(matches);
[INFO] [stderr] 282 | |
[INFO] [stderr] 283 | |         let src_bytes = if args.decrypt { decrypt_cofac_dat(args.src_filename) } else { read_all_bytes(&args.src_filename) };
[INFO] [stderr] ...   |
[INFO] [stderr] 300 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 301 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:303:5
[INFO] [stderr]     |
[INFO] [stderr] 303 | /     pub fn exec_itemtype_encode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 304 | |         let args = get_encoder_args(matches);
[INFO] [stderr] 305 | |
[INFO] [stderr] 306 | |         let src_bytes = read_all_bytes(&args.src_filename);
[INFO] [stderr] ...   |
[INFO] [stderr] 319 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 320 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:309:9
[INFO] [stderr]     |
[INFO] [stderr] 309 | /         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr] 310 | |
[INFO] [stderr] 311 | |         if args.format == "json" {
[INFO] [stderr] 312 | |             encoded_bytes = decoded_file.serialize_to_string().into_bytes();
[INFO] [stderr] 313 | |         } else {
[INFO] [stderr] 314 | |             panic!("Unsupported format");
[INFO] [stderr] 315 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> encoded_bytes = if args.format == "json" { decoded_file.serialize_to_string().into_bytes() } else { ..; Vec::new() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:322:5
[INFO] [stderr]     |
[INFO] [stderr] 322 | /     pub fn exec_magictype_decode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 323 | |         let args = get_decoder_args(matches);
[INFO] [stderr] 324 | |
[INFO] [stderr] 325 | |         let src_bytes = if args.decrypt { decrypt_cofac_dat(args.src_filename) } else { read_all_bytes(&args.src_filename) };
[INFO] [stderr] ...   |
[INFO] [stderr] 342 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 343 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:345:5
[INFO] [stderr]     |
[INFO] [stderr] 345 | /     pub fn exec_magictype_encode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 346 | |         let args = get_encoder_args(matches);
[INFO] [stderr] 347 | |
[INFO] [stderr] 348 | |         let src_bytes = read_all_bytes(&args.src_filename);
[INFO] [stderr] ...   |
[INFO] [stderr] 361 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 362 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:351:9
[INFO] [stderr]     |
[INFO] [stderr] 351 | /         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr] 352 | |
[INFO] [stderr] 353 | |         if args.format == "json" {
[INFO] [stderr] 354 | |             encoded_bytes = decoded_file.serialize_to_string().into_bytes();
[INFO] [stderr] 355 | |         } else {
[INFO] [stderr] 356 | |             panic!("Unsupported format");
[INFO] [stderr] 357 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> encoded_bytes = if args.format == "json" { decoded_file.serialize_to_string().into_bytes() } else { ..; Vec::new() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:364:5
[INFO] [stderr]     |
[INFO] [stderr] 364 | /     pub fn exec_monster_decode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 365 | |         let args = get_decoder_args(matches);
[INFO] [stderr] 366 | |
[INFO] [stderr] 367 | |         let src_bytes = if args.decrypt { decrypt_cofac_dat(args.src_filename) } else { read_all_bytes(&args.src_filename) };
[INFO] [stderr] ...   |
[INFO] [stderr] 393 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 394 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:396:5
[INFO] [stderr]     |
[INFO] [stderr] 396 | /     pub fn exec_monster_encode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 397 | |         let args = get_encoder_args(matches);
[INFO] [stderr] 398 | |
[INFO] [stderr] 399 | |         let src_bytes = read_all_bytes(&args.src_filename);
[INFO] [stderr] ...   |
[INFO] [stderr] 413 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 414 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:402:9
[INFO] [stderr]     |
[INFO] [stderr] 402 | /         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr] 403 | |
[INFO] [stderr] 404 | |         if args.format == "json" {
[INFO] [stderr] 405 | |             let str_bytes: Vec<String> = decoded_file.iter().map(|bytes| bytes.serialize_to_string() + "\n\n").collect();
[INFO] [stderr] ...   |
[INFO] [stderr] 408 | |             panic!("Unsupported format");
[INFO] [stderr] 409 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> encoded_bytes = if args.format == "json" { ..; str_bytes.concat().into_bytes() } else { ..; Vec::new() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `ReadBytesExt`
[INFO] [stderr]   --> src/levelexp.rs:16:42
[INFO] [stderr]    |
[INFO] [stderr] 16 | use byteorder::{ByteOrder, LittleEndian, ReadBytesExt};
[INFO] [stderr]    |                                          ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `header`
[INFO] [stderr]    --> src/itemtype.rs:298:11
[INFO] [stderr]     |
[INFO] [stderr] 298 |                         let header = item_type_header_parsed;
[INFO] [stderr]     |                             ^^^^^^ help: consider using `_header` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `header`
[INFO] [stderr]    --> src/magictype.rs:325:11
[INFO] [stderr]     |
[INFO] [stderr] 325 |                         let header = magic_type_header_parsed;
[INFO] [stderr]     |                             ^^^^^^ help: consider using `_header` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `entry_idx`
[INFO] [stderr]    --> src/magictype.rs:348:17
[INFO] [stderr]     |
[INFO] [stderr] 348 |                 Result::Err(entry_idx) => {
[INFO] [stderr]     |                             ^^^^^^^^^ help: consider using `_entry_idx` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `bytes_read`
[INFO] [stderr]    --> src/main.rs:210:9
[INFO] [stderr]     |
[INFO] [stderr] 210 |     let bytes_read = f.read_to_end(&mut buffer).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^ help: consider using `_bytes_read` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `encoded_bytes` is never read
[INFO] [stderr]    --> src/main.rs:309:17
[INFO] [stderr]     |
[INFO] [stderr] 309 |         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `encoded_bytes` is never read
[INFO] [stderr]    --> src/main.rs:351:17
[INFO] [stderr]     |
[INFO] [stderr] 351 |         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `encoded_bytes` is never read
[INFO] [stderr]    --> src/main.rs:402:17
[INFO] [stderr]     |
[INFO] [stderr] 402 |         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `bytes_read_mb`
[INFO] [stderr]   --> src/levelexp.rs:82:10
[INFO] [stderr]    |
[INFO] [stderr] 82 |         let bytes_read_mb: f64 = (bytes_read as f64) / 1024.0 / 1024.0;
[INFO] [stderr]    |             ^^^^^^^^^^^^^ help: consider using `_bytes_read_mb` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:317:13
[INFO] [stderr]     |
[INFO] [stderr] 317 |         let mut bytes_to_write = if args.encrypt { encrypt_cofac_bytes(encoded_bytes) } else { encoded_bytes };
[INFO] [stderr]     |             ----^^^^^^^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:359:13
[INFO] [stderr]     |
[INFO] [stderr] 359 |         let mut bytes_to_write = if args.encrypt { encrypt_cofac_bytes(encoded_bytes) } else { encoded_bytes };
[INFO] [stderr]     |             ----^^^^^^^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:411:13
[INFO] [stderr]     |
[INFO] [stderr] 411 |         let mut bytes_to_write = if args.encrypt { encrypt_cofac_bytes(encoded_bytes) } else { encoded_bytes };
[INFO] [stderr]     |             ----^^^^^^^^^^^^^^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Level`
[INFO] [stderr]   --> src/levelexp.rs:19:1
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub struct Level {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `LevelExpFile`
[INFO] [stderr]   --> src/levelexp.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub struct LevelExpFile {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_levels`
[INFO] [stderr]   --> src/levelexp.rs:29:2
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn get_levels(&self) -> Vec<Level> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_levels_as_map`
[INFO] [stderr]   --> src/levelexp.rs:46:2
[INFO] [stderr]    |
[INFO] [stderr] 46 |     pub fn get_levels_as_map(&self) -> HashMap<u8, i32> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_levels_count`
[INFO] [stderr]   --> src/levelexp.rs:61:2
[INFO] [stderr]    |
[INFO] [stderr] 61 |     fn get_levels_count(&self, levels_data: &Vec<u8>) -> usize {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_level_from_idx`
[INFO] [stderr]   --> src/levelexp.rs:65:2
[INFO] [stderr]    |
[INFO] [stderr] 65 |     fn get_level_from_idx(&self, idx: &usize) -> u8 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_exp_from_level`
[INFO] [stderr]   --> src/levelexp.rs:69:2
[INFO] [stderr]    |
[INFO] [stderr] 69 |     fn get_exp_from_level(&self, levels: &Vec<u8>, idx: &usize) -> i32 {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `get_file_bytes`
[INFO] [stderr]   --> src/levelexp.rs:76:2
[INFO] [stderr]    |
[INFO] [stderr] 76 |     fn get_file_bytes(&self) -> Vec<u8> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `serialize_monster_entries_to_str`
[INFO] [stderr]    --> src/monster.rs:108:2
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn serialize_monster_entries_to_str(entries: &Vec<MonsterEntry>) -> String {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `MONSTER_ENTRY_UNFORMATTED`
[INFO] [stderr]    --> src/monster.rs:209:3
[INFO] [stderr]     |
[INFO] [stderr] 209 |           const MONSTER_ENTRY_UNFORMATTED: &str = "[AMonster]
[INFO] [stderr]     |  _________^
[INFO] [stderr] 210 | | SizeAdd=2
[INFO] [stderr] 211 | | ZoomPercent=90
[INFO] [stderr] 212 | | MaxLife=1000
[INFO] [stderr] ...   |
[INFO] [stderr] 231 | | ExtraExp=100
[INFO] [stderr] 232 | | StcType=18";
[INFO] [stderr]     | |____________^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `test_monster_entry_parse_then_reformat_returns_start_val`
[INFO] [stderr]    --> src/monster.rs:245:3
[INFO] [stderr]     |
[INFO] [stderr] 245 |         fn test_monster_entry_parse_then_reformat_returns_start_val() {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/datfiles.rs:3:33
[INFO] [stderr]   |
[INFO] [stderr] 3 | pub fn decrypt_bytes(bytes_enc: &Vec<u8>, key: &[u8; 128]) -> Vec<u8> {
[INFO] [stderr]   |                                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]  --> src/datfiles.rs:7:24
[INFO] [stderr]   |
[INFO] [stderr] 7 |         let tmp: u16 = (bytes_enc[b] ^ key[b % 128]) as u16;
[INFO] [stderr]   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes_enc[b] ^ key[b % 128])`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/datfiles.rs:17:33
[INFO] [stderr]    |
[INFO] [stderr] 17 | pub fn encrypt_bytes(bytes_dec: &Vec<u8>, key: &[u8; 128]) -> Vec<u8> {
[INFO] [stderr]    |                                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/datfiles.rs:21:30
[INFO] [stderr]    |
[INFO] [stderr] 21 |         let curr_byte: u16 = bytes_dec[b] as u16;
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bytes_dec[b])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/datfiles.rs:34:25
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let mut seed: i32 = COFAC_BASE_SEED as i32; // itemtype.dat & magictype.dat initial seed
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(COFAC_BASE_SEED)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `b` is only used to index `key`.
[INFO] [stderr]   --> src/datfiles.rs:36:14
[INFO] [stderr]    |
[INFO] [stderr] 36 |     for b in 0..128 {
[INFO] [stderr]    |              ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 36 |     for <item> in &mut key {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:140:39
[INFO] [stderr]     |
[INFO] [stderr] 140 |     pub fn parse_match_to_u8(matches: &Vec<String>, idx: usize) -> Result<u8, usize> {
[INFO] [stderr]     |                                       ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:144:40
[INFO] [stderr]     |
[INFO] [stderr] 144 |     pub fn parse_match_to_u16(matches: &Vec<String>, idx: usize) -> Result<u16, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:148:40
[INFO] [stderr]     |
[INFO] [stderr] 148 |     pub fn parse_match_to_u32(matches: &Vec<String>, idx: usize) -> Result<u32, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:152:40
[INFO] [stderr]     |
[INFO] [stderr] 152 |     pub fn parse_match_to_i32(matches: &Vec<String>, idx: usize) -> Result<i32, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:156:40
[INFO] [stderr]     |
[INFO] [stderr] 156 |     pub fn parse_match_to_u64(matches: &Vec<String>, idx: usize) -> Result<u64, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:160:40
[INFO] [stderr]     |
[INFO] [stderr] 160 |     pub fn parse_match_to_i64(matches: &Vec<String>, idx: usize) -> Result<i64, usize> {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/datfiles.rs:164:41
[INFO] [stderr]     |
[INFO] [stderr] 164 |     pub fn parse_match_to_bool(matches: &Vec<String>, idx: usize) -> Result<bool, usize> {
[INFO] [stderr]     |                                         ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/levelexp.rs:61:42
[INFO] [stderr]    |
[INFO] [stderr] 61 |     fn get_levels_count(&self, levels_data: &Vec<u8>) -> usize {
[INFO] [stderr]    |                                             ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/levelexp.rs:65:36
[INFO] [stderr]    |
[INFO] [stderr] 65 |     fn get_level_from_idx(&self, idx: &usize) -> u8 {
[INFO] [stderr]    |                                       ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/levelexp.rs:69:39
[INFO] [stderr]    |
[INFO] [stderr] 69 |     fn get_exp_from_level(&self, levels: &Vec<u8>, idx: &usize) -> i32 {
[INFO] [stderr]    |                                          ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/levelexp.rs:69:54
[INFO] [stderr]    |
[INFO] [stderr] 69 |     fn get_exp_from_level(&self, levels: &Vec<u8>, idx: &usize) -> i32 {
[INFO] [stderr]    |                                                         ^^^^^^ help: consider passing by value instead: `usize`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/itemtype.rs:212:5
[INFO] [stderr]     |
[INFO] [stderr] 212 | /     pub fn item_type_header<'a>(val: &'a [u8]) -> Result<ItemTypeHeader, ParseIntError> {
[INFO] [stderr] 213 | |         let val_as_str = String::from_utf8_lossy(val).into_owned();
[INFO] [stderr] 214 | |         let reg_parser_items = Regex::new(r"Amount=(\d+)").unwrap();
[INFO] [stderr] 215 | |         let captures = reg_parser_items.captures(&val_as_str).unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 222 | |         Result::Ok(entry)
[INFO] [stderr] 223 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/itemtype.rs:225:2
[INFO] [stderr]     |
[INFO] [stderr] 225 |       pub fn item_type_entry<'a>(val: &'a [u8]) -> Result<ItemTypeEntry, usize> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 226 | |         let val_as_str = String::from_utf8_lossy(val).into_owned();
[INFO] [stderr] 227 | |         let reg_parser_items = Regex::new(r"(\S+)\s*").unwrap();
[INFO] [stderr] 228 | |         let mut packed_strs: Vec<String> = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 285 | |         Result::Ok(entry)
[INFO] [stderr] 286 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/itemtype.rs:289:2
[INFO] [stderr]     |
[INFO] [stderr] 289 |       pub fn parse_item_type<'a>(bytes: &'a [u8]) -> Option<ItemType> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 290 | |         let mut entries: Vec<ItemTypeEntry> = Vec::new();
[INFO] [stderr] 291 | |         let bytes_split = split_bytes_by_lines(Vec::from(bytes));
[INFO] [stderr] 292 | |         let header = ItemTypeHeader { amount: 30 };
[INFO] [stderr] ...   |
[INFO] [stderr] 327 | |         Some(ItemType { header: header, entries: entries })
[INFO] [stderr] 328 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/itemtype.rs:314:15
[INFO] [stderr]     |
[INFO] [stderr] 314 |             let line = bytes_split.get(idx).unwrap();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes_split[idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/magictype.rs:233:5
[INFO] [stderr]     |
[INFO] [stderr] 233 | /     pub fn magic_type_header<'a>(val: &'a [u8]) -> Result<MagicTypeHeader, ParseIntError> {
[INFO] [stderr] 234 | |         let val_as_str = String::from_utf8_lossy(val).into_owned();
[INFO] [stderr] 235 | |         let reg_parser_items = Regex::new(r"Amount=(\d+)").unwrap();
[INFO] [stderr] 236 | |         let captures = reg_parser_items.captures(&val_as_str).unwrap();
[INFO] [stderr] ...   |
[INFO] [stderr] 243 | |         Result::Ok(entry)
[INFO] [stderr] 244 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/magictype.rs:246:2
[INFO] [stderr]     |
[INFO] [stderr] 246 |       pub fn magic_type_entry<'a>(val: &'a [u8]) -> Result<MagicTypeEntry, usize> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 247 | |         let val_as_str = String::from_utf8_lossy(val).into_owned();
[INFO] [stderr] 248 | |         let reg_parser_items = Regex::new(r"(\S+)\s*").unwrap();
[INFO] [stderr] 249 | |         let mut packed_strs: Vec<String> = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 313 | |         Result::Ok(entry)
[INFO] [stderr] 314 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/magictype.rs:316:2
[INFO] [stderr]     |
[INFO] [stderr] 316 |       pub fn parse_magic_type<'a>(bytes: &'a [u8]) -> Option<MagicType> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 317 | |         let mut entries: Vec<MagicTypeEntry> = Vec::new();
[INFO] [stderr] 318 | |         let bytes_split = split_bytes_by_lines(Vec::from(bytes));
[INFO] [stderr] 319 | |         let header = MagicTypeHeader { amount: 30 };
[INFO] [stderr] ...   |
[INFO] [stderr] 354 | |         Some(MagicType { header: header, entries: entries })
[INFO] [stderr] 355 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/magictype.rs:341:15
[INFO] [stderr]     |
[INFO] [stderr] 341 |             let line = bytes_split.get(idx).unwrap();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `bytes_split[idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monster.rs:108:51
[INFO] [stderr]     |
[INFO] [stderr] 108 |     pub fn serialize_monster_entries_to_str(entries: &Vec<MonsterEntry>) -> String {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^ help: change this to: `&[MonsterEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/monster.rs:248:31
[INFO] [stderr]     |
[INFO] [stderr] 248 |                 let first_monster_entry = monster_entries.get(0).unwrap();
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&monster_entries[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/monster.rs:369:41
[INFO] [stderr]     |
[INFO] [stderr] 369 |     pub fn decode_monster_to_json(entries: &Vec<MonsterEntry>) -> Vec<u8> {
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^ help: change this to: `&[MonsterEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:218:5
[INFO] [stderr]     |
[INFO] [stderr] 218 |     f.write_all(&bytes);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:260:5
[INFO] [stderr]     |
[INFO] [stderr] 260 | /     pub fn exec_decrypt_dat<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 261 | |         let src_filename = matches.value_of("SRC_FILENAME").unwrap();
[INFO] [stderr] 262 | |         let dst_filename = matches.value_of("DST_FILENAME").unwrap();
[INFO] [stderr] 263 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 267 | |         println!("Wrote decrypted file to {} successfully.", dst_filename);
[INFO] [stderr] 268 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:270:5
[INFO] [stderr]     |
[INFO] [stderr] 270 | /     pub fn exec_encrypt_dat<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 271 | |         let src_filename = matches.value_of("SRC_FILENAME").unwrap();
[INFO] [stderr] 272 | |         let dst_filename = matches.value_of("DST_FILENAME").unwrap();
[INFO] [stderr] 273 | |
[INFO] [stderr] ...   |
[INFO] [stderr] 277 | |         println!("Wrote encrypted file to {} successfully.", dst_filename);
[INFO] [stderr] 278 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:280:5
[INFO] [stderr]     |
[INFO] [stderr] 280 | /     pub fn exec_itemtype_decode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 281 | |         let args = get_decoder_args(matches);
[INFO] [stderr] 282 | |
[INFO] [stderr] 283 | |         let src_bytes = if args.decrypt { decrypt_cofac_dat(args.src_filename) } else { read_all_bytes(&args.src_filename) };
[INFO] [stderr] ...   |
[INFO] [stderr] 300 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 301 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:303:5
[INFO] [stderr]     |
[INFO] [stderr] 303 | /     pub fn exec_itemtype_encode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 304 | |         let args = get_encoder_args(matches);
[INFO] [stderr] 305 | |
[INFO] [stderr] 306 | |         let src_bytes = read_all_bytes(&args.src_filename);
[INFO] [stderr] ...   |
[INFO] [stderr] 319 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 320 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:309:9
[INFO] [stderr]     |
[INFO] [stderr] 309 | /         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr] 310 | |
[INFO] [stderr] 311 | |         if args.format == "json" {
[INFO] [stderr] 312 | |             encoded_bytes = decoded_file.serialize_to_string().into_bytes();
[INFO] [stderr] 313 | |         } else {
[INFO] [stderr] 314 | |             panic!("Unsupported format");
[INFO] [stderr] 315 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> encoded_bytes = if args.format == "json" { decoded_file.serialize_to_string().into_bytes() } else { ..; Vec::new() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:322:5
[INFO] [stderr]     |
[INFO] [stderr] 322 | /     pub fn exec_magictype_decode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 323 | |         let args = get_decoder_args(matches);
[INFO] [stderr] 324 | |
[INFO] [stderr] 325 | |         let src_bytes = if args.decrypt { decrypt_cofac_dat(args.src_filename) } else { read_all_bytes(&args.src_filename) };
[INFO] [stderr] ...   |
[INFO] [stderr] 342 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 343 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:345:5
[INFO] [stderr]     |
[INFO] [stderr] 345 | /     pub fn exec_magictype_encode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 346 | |         let args = get_encoder_args(matches);
[INFO] [stderr] 347 | |
[INFO] [stderr] 348 | |         let src_bytes = read_all_bytes(&args.src_filename);
[INFO] [stderr] ...   |
[INFO] [stderr] 361 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 362 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:351:9
[INFO] [stderr]     |
[INFO] [stderr] 351 | /         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr] 352 | |
[INFO] [stderr] 353 | |         if args.format == "json" {
[INFO] [stderr] 354 | |             encoded_bytes = decoded_file.serialize_to_string().into_bytes();
[INFO] [stderr] 355 | |         } else {
[INFO] [stderr] 356 | |             panic!("Unsupported format");
[INFO] [stderr] 357 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> encoded_bytes = if args.format == "json" { decoded_file.serialize_to_string().into_bytes() } else { ..; Vec::new() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:364:5
[INFO] [stderr]     |
[INFO] [stderr] 364 | /     pub fn exec_monster_decode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 365 | |         let args = get_decoder_args(matches);
[INFO] [stderr] 366 | |
[INFO] [stderr] 367 | |         let src_bytes = if args.decrypt { decrypt_cofac_dat(args.src_filename) } else { read_all_bytes(&args.src_filename) };
[INFO] [stderr] ...   |
[INFO] [stderr] 393 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 394 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:396:5
[INFO] [stderr]     |
[INFO] [stderr] 396 | /     pub fn exec_monster_encode<'a>(matches: &'a ArgMatches) {
[INFO] [stderr] 397 | |         let args = get_encoder_args(matches);
[INFO] [stderr] 398 | |
[INFO] [stderr] 399 | |         let src_bytes = read_all_bytes(&args.src_filename);
[INFO] [stderr] ...   |
[INFO] [stderr] 413 | |         write_all_bytes(&args.dst_filename, bytes_to_write);
[INFO] [stderr] 414 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:402:9
[INFO] [stderr]     |
[INFO] [stderr] 402 | /         let mut encoded_bytes: Vec<u8> = Vec::new();
[INFO] [stderr] 403 | |
[INFO] [stderr] 404 | |         if args.format == "json" {
[INFO] [stderr] 405 | |             let str_bytes: Vec<String> = decoded_file.iter().map(|bytes| bytes.serialize_to_string() + "\n\n").collect();
[INFO] [stderr] ...   |
[INFO] [stderr] 408 | |             panic!("Unsupported format");
[INFO] [stderr] 409 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> encoded_bytes = if args.format == "json" { ..; str_bytes.concat().into_bytes() } else { ..; Vec::new() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 11.34s
[INFO] running `"docker" "inspect" "484c5425c2dd635411712bf98bd11f0ca24a2a33e25c5b5bffc99b6ed0bd8270"`
[INFO] running `"docker" "rm" "-f" "484c5425c2dd635411712bf98bd11f0ca24a2a33e25c5b5bffc99b6ed0bd8270"`
[INFO] [stdout] 484c5425c2dd635411712bf98bd11f0ca24a2a33e25c5b5bffc99b6ed0bd8270