[INFO] updating cached repository TangoJP/rust_vectorizer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TangoJP/rust_vectorizer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TangoJP/rust_vectorizer" "work/ex/clippy-test-run/sources/stable/gh/TangoJP/rust_vectorizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TangoJP/rust_vectorizer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TangoJP/rust_vectorizer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TangoJP/rust_vectorizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TangoJP/rust_vectorizer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5ea603fb937f31da1fb90ba37b483996921a48c0 [INFO] sha for GitHub repo TangoJP/rust_vectorizer: 5ea603fb937f31da1fb90ba37b483996921a48c0 [INFO] validating manifest of TangoJP/rust_vectorizer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TangoJP/rust_vectorizer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TangoJP/rust_vectorizer [INFO] finished frobbing TangoJP/rust_vectorizer [INFO] frobbed toml for TangoJP/rust_vectorizer written to work/ex/clippy-test-run/sources/stable/gh/TangoJP/rust_vectorizer/Cargo.toml [INFO] started frobbing TangoJP/rust_vectorizer [INFO] finished frobbing TangoJP/rust_vectorizer [INFO] frobbed toml for TangoJP/rust_vectorizer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TangoJP/rust_vectorizer/Cargo.toml [INFO] crate TangoJP/rust_vectorizer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TangoJP/rust_vectorizer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TangoJP/rust_vectorizer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d61d840080c54315ac9c1f0754afceb0b937ed01d80355a5578bbf50b573f2ae [INFO] running `"docker" "start" "-a" "d61d840080c54315ac9c1f0754afceb0b937ed01d80355a5578bbf50b573f2ae"` [INFO] [stderr] Checking num-bigint v0.2.1 [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking ndarray v0.12.0 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking vectorizer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | ngram_range: ngram_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/countvectorizer.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | ngram_range: ngram_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tfidfvectorizer.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | ngram_range : ngram_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | ngram_range: ngram_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/countvectorizer.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | ngram_range: ngram_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tfidfvectorizer.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | ngram_range : ngram_range, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ngram_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ndarray_extension.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | array_f64 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ndarray_extension.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | let array_f64 = array.mapv(|e| e.to_f64().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/countvectorizer.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | sorted_vec // Return the Vec of count HashMaps [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/countvectorizer.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | let sorted_vec = self._sort_vocabulary_count(vec_of_map); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tfidfvectorizer.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | tfidfvector [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tfidfvectorizer.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | let tfidfvector = self._tfidi_transform(countvector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ndarray_extension.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | array_f64 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ndarray_extension.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | let array_f64 = array.mapv(|e| e.to_f64().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/countvectorizer.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | sorted_vec // Return the Vec of count HashMaps [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/countvectorizer.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | let sorted_vec = self._sort_vocabulary_count(vec_of_map); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tfidfvectorizer.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | tfidfvector [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tfidfvectorizer.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | let tfidfvector = self._tfidi_transform(countvector); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tokenizer.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | let i_s = 0..(num_tokens - n + 1); // iterate over i-th unigram position [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=num_tokens - n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/countvectorizer.rs:55:53 [INFO] [stderr] | [INFO] [stderr] 55 | sorted_vec[[i, (*key as usize)]] = *vec_of_map[i].get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&vec_of_map[i][key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/countvectorizer.rs:144:53 [INFO] [stderr] | [INFO] [stderr] 144 | self.vocabulary_.insert(_token, vocab_indexer.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `vocab_indexer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/countvectorizer.rs:145:42 [INFO] [stderr] | [INFO] [stderr] 145 | _vocab_counts.insert(vocab_indexer.clone(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `vocab_indexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/countvectorizer.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | vocab_indexer = vocab_indexer + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vocab_indexer += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tfidfvectorizer.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | let smoother = (self.smooth_idf as u8) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.smooth_idf as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tfidfvectorizer.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | df = df + smoother; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `df += smoother` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tokenizer.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | let i_s = 0..(num_tokens - n + 1); // iterate over i-th unigram position [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=num_tokens - n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/countvectorizer.rs:55:53 [INFO] [stderr] | [INFO] [stderr] 55 | sorted_vec[[i, (*key as usize)]] = *vec_of_map[i].get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&vec_of_map[i][key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/countvectorizer.rs:144:53 [INFO] [stderr] | [INFO] [stderr] 144 | self.vocabulary_.insert(_token, vocab_indexer.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `vocab_indexer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/countvectorizer.rs:145:42 [INFO] [stderr] | [INFO] [stderr] 145 | _vocab_counts.insert(vocab_indexer.clone(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `vocab_indexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/countvectorizer.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | vocab_indexer = vocab_indexer + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vocab_indexer += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/tfidfvectorizer.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | let smoother = (self.smooth_idf as u8) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.smooth_idf as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tfidfvectorizer.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | df = df + smoother; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `df += smoother` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> tests/ndarray_extension_test.rs:15:36 [INFO] [stderr] | [INFO] [stderr] 15 | let x_f64 = x.clone().mapv(|e| e as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(e)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.12s [INFO] running `"docker" "inspect" "d61d840080c54315ac9c1f0754afceb0b937ed01d80355a5578bbf50b573f2ae"` [INFO] running `"docker" "rm" "-f" "d61d840080c54315ac9c1f0754afceb0b937ed01d80355a5578bbf50b573f2ae"` [INFO] [stdout] d61d840080c54315ac9c1f0754afceb0b937ed01d80355a5578bbf50b573f2ae