[INFO] updating cached repository TangiFavennec/RustSample [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TangiFavennec/RustSample [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TangiFavennec/RustSample" "work/ex/clippy-test-run/sources/stable/gh/TangiFavennec/RustSample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TangiFavennec/RustSample'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TangiFavennec/RustSample" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TangiFavennec/RustSample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TangiFavennec/RustSample'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 68075a140cf982397bba633269b399ca98a5447a [INFO] sha for GitHub repo TangiFavennec/RustSample: 68075a140cf982397bba633269b399ca98a5447a [INFO] validating manifest of TangiFavennec/RustSample on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TangiFavennec/RustSample on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TangiFavennec/RustSample [INFO] finished frobbing TangiFavennec/RustSample [INFO] frobbed toml for TangiFavennec/RustSample written to work/ex/clippy-test-run/sources/stable/gh/TangiFavennec/RustSample/Cargo.toml [INFO] started frobbing TangiFavennec/RustSample [INFO] finished frobbing TangiFavennec/RustSample [INFO] frobbed toml for TangiFavennec/RustSample written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TangiFavennec/RustSample/Cargo.toml [INFO] crate TangiFavennec/RustSample has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TangiFavennec/RustSample against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TangiFavennec/RustSample:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51979f0a3ea407017461bd578ab59bd69c2fb63e1a9e9fd1404c5d57fa9baec2 [INFO] running `"docker" "start" "-a" "51979f0a3ea407017461bd578ab59bd69c2fb63e1a9e9fd1404c5d57fa9baec2"` [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Checking rust_sample v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:76:27 [INFO] [stderr] | [INFO] [stderr] 76 | let points_diff = &self.get_points() - other.get_points(); [INFO] [stderr] | ------------------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.get_points()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | / let mut score = "Not Played Yet".to_string(); [INFO] [stderr] 135 | | if x.is_played { [INFO] [stderr] 136 | | score = format!(" {} - {}", x.receiving_team_count, x.coming_team_count); [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let score = if x.is_played { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { "Not Played Yet".to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:224:30 [INFO] [stderr] | [INFO] [stderr] 224 | for (_key, value) in &rankings { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 224 | for value in rankings.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:76:27 [INFO] [stderr] | [INFO] [stderr] 76 | let points_diff = &self.get_points() - other.get_points(); [INFO] [stderr] | ------------------^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.get_points()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | / let mut score = "Not Played Yet".to_string(); [INFO] [stderr] 135 | | if x.is_played { [INFO] [stderr] 136 | | score = format!(" {} - {}", x.receiving_team_count, x.coming_team_count); [INFO] [stderr] 137 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let score = if x.is_played { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { "Not Played Yet".to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:224:30 [INFO] [stderr] | [INFO] [stderr] 224 | for (_key, value) in &rankings { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 224 | for value in rankings.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.15s [INFO] running `"docker" "inspect" "51979f0a3ea407017461bd578ab59bd69c2fb63e1a9e9fd1404c5d57fa9baec2"` [INFO] running `"docker" "rm" "-f" "51979f0a3ea407017461bd578ab59bd69c2fb63e1a9e9fd1404c5d57fa9baec2"` [INFO] [stdout] 51979f0a3ea407017461bd578ab59bd69c2fb63e1a9e9fd1404c5d57fa9baec2