[INFO] updating cached repository Taidgh-Robinson/html_text_highlighting [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Taidgh-Robinson/html_text_highlighting [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Taidgh-Robinson/html_text_highlighting" "work/ex/clippy-test-run/sources/stable/gh/Taidgh-Robinson/html_text_highlighting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Taidgh-Robinson/html_text_highlighting'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Taidgh-Robinson/html_text_highlighting" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Taidgh-Robinson/html_text_highlighting"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Taidgh-Robinson/html_text_highlighting'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 960d66aaef8a6fbc6b9b27f4b49b77e223591738 [INFO] sha for GitHub repo Taidgh-Robinson/html_text_highlighting: 960d66aaef8a6fbc6b9b27f4b49b77e223591738 [INFO] validating manifest of Taidgh-Robinson/html_text_highlighting on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Taidgh-Robinson/html_text_highlighting on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Taidgh-Robinson/html_text_highlighting [INFO] finished frobbing Taidgh-Robinson/html_text_highlighting [INFO] frobbed toml for Taidgh-Robinson/html_text_highlighting written to work/ex/clippy-test-run/sources/stable/gh/Taidgh-Robinson/html_text_highlighting/Cargo.toml [INFO] started frobbing Taidgh-Robinson/html_text_highlighting [INFO] finished frobbing Taidgh-Robinson/html_text_highlighting [INFO] frobbed toml for Taidgh-Robinson/html_text_highlighting written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Taidgh-Robinson/html_text_highlighting/Cargo.toml [INFO] crate Taidgh-Robinson/html_text_highlighting has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Taidgh-Robinson/html_text_highlighting against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Taidgh-Robinson/html_text_highlighting:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c5b8ad0153b5aa402c2007f599ff4fa27c863c245b9947b385f23944e49c209d [INFO] running `"docker" "start" "-a" "c5b8ad0153b5aa402c2007f599ff4fa27c863c245b9947b385f23944e49c209d"` [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling markup5ever v0.7.3 [INFO] [stderr] Checking html5ever v0.22.3 [INFO] [stderr] Checking html_text_highlighting v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return string_form.replace("\n", ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string_form.replace("\n", "")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return f.replace(key, &template[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f.replace(key, &template[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / match node.data { [INFO] [stderr] 60 | | NodeData::Element { ref name, ref attrs, .. } => { [INFO] [stderr] 61 | | assert!(name.ns == ns!(html)); [INFO] [stderr] 62 | | print!(" {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let NodeData::Element { ref name, ref attrs, .. } = node.data { [INFO] [stderr] 60 | assert!(name.ns == ns!(html)); [INFO] [stderr] 61 | print!(" src/main.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return string_form.replace("\n", ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `string_form.replace("\n", "")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return f.replace(key, &template[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f.replace(key, &template[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / match node.data { [INFO] [stderr] 60 | | NodeData::Element { ref name, ref attrs, .. } => { [INFO] [stderr] 61 | | assert!(name.ns == ns!(html)); [INFO] [stderr] 62 | | print!(" {} [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let NodeData::Element { ref name, ref attrs, .. } = node.data { [INFO] [stderr] 60 | assert!(name.ns == ns!(html)); [INFO] [stderr] 61 | print!("