[INFO] updating cached repository TNkemdilim/hut [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TNkemdilim/hut [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TNkemdilim/hut" "work/ex/clippy-test-run/sources/stable/gh/TNkemdilim/hut"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TNkemdilim/hut'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TNkemdilim/hut" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TNkemdilim/hut"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TNkemdilim/hut'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7eac5f7b764d97898ccb41556e4e6941e9294bab [INFO] sha for GitHub repo TNkemdilim/hut: 7eac5f7b764d97898ccb41556e4e6941e9294bab [INFO] validating manifest of TNkemdilim/hut on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TNkemdilim/hut on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TNkemdilim/hut [INFO] finished frobbing TNkemdilim/hut [INFO] frobbed toml for TNkemdilim/hut written to work/ex/clippy-test-run/sources/stable/gh/TNkemdilim/hut/Cargo.toml [INFO] started frobbing TNkemdilim/hut [INFO] finished frobbing TNkemdilim/hut [INFO] frobbed toml for TNkemdilim/hut written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TNkemdilim/hut/Cargo.toml [INFO] crate TNkemdilim/hut has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TNkemdilim/hut against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TNkemdilim/hut:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c3f1e5b6a52257d387f920b48fe922996de8b76e077f9c773cfbfd58432b141 [INFO] running `"docker" "start" "-a" "0c3f1e5b6a52257d387f920b48fe922996de8b76e077f9c773cfbfd58432b141"` [INFO] [stderr] Checking hut v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variant is never constructed: `String` [INFO] [stderr] --> src/analysis/mod.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | String(&'a str), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/analysis/lexer.rs:42:60 [INFO] [stderr] | [INFO] [stderr] 42 | let name: String = self.text[start..self.position].into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/analysis/lexer.rs:69:60 [INFO] [stderr] | [INFO] [stderr] 69 | let name: String = self.text[start..self.position].into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match token.syntax_type { [INFO] [stderr] 23 | | SyntaxType::EndOfFileToken => break, [INFO] [stderr] 24 | | _ => {} [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ help: try this: `if let SyntaxType::EndOfFileToken = token.syntax_type { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `String` [INFO] [stderr] --> src/analysis/mod.rs:21:3 [INFO] [stderr] | [INFO] [stderr] 21 | String(&'a str), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/analysis/lexer.rs:42:60 [INFO] [stderr] | [INFO] [stderr] 42 | let name: String = self.text[start..self.position].into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/analysis/lexer.rs:69:60 [INFO] [stderr] | [INFO] [stderr] 69 | let name: String = self.text[start..self.position].into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / match token.syntax_type { [INFO] [stderr] 23 | | SyntaxType::EndOfFileToken => break, [INFO] [stderr] 24 | | _ => {} [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ help: try this: `if let SyntaxType::EndOfFileToken = token.syntax_type { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `"docker" "inspect" "0c3f1e5b6a52257d387f920b48fe922996de8b76e077f9c773cfbfd58432b141"` [INFO] running `"docker" "rm" "-f" "0c3f1e5b6a52257d387f920b48fe922996de8b76e077f9c773cfbfd58432b141"` [INFO] [stdout] 0c3f1e5b6a52257d387f920b48fe922996de8b76e077f9c773cfbfd58432b141