[INFO] updating cached repository THE108/prnotifier [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/THE108/prnotifier [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/THE108/prnotifier" "work/ex/clippy-test-run/sources/stable/gh/THE108/prnotifier"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/THE108/prnotifier'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/THE108/prnotifier" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/THE108/prnotifier"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/THE108/prnotifier'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7ef59347ec9f4345cf479d8338c851d8499a0cd7 [INFO] sha for GitHub repo THE108/prnotifier: 7ef59347ec9f4345cf479d8338c851d8499a0cd7 [INFO] validating manifest of THE108/prnotifier on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of THE108/prnotifier on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing THE108/prnotifier [INFO] finished frobbing THE108/prnotifier [INFO] frobbed toml for THE108/prnotifier written to work/ex/clippy-test-run/sources/stable/gh/THE108/prnotifier/Cargo.toml [INFO] started frobbing THE108/prnotifier [INFO] finished frobbing THE108/prnotifier [INFO] frobbed toml for THE108/prnotifier written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/THE108/prnotifier/Cargo.toml [INFO] crate THE108/prnotifier has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting THE108/prnotifier against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/THE108/prnotifier:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1964514d276f5e97939719b827156c14392bd7137ddfbeefe32ec2faaa72867b [INFO] running `"docker" "start" "-a" "1964514d276f5e97939719b827156c14392bd7137ddfbeefe32ec2faaa72867b"` [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking slack-hook v0.6.0 [INFO] [stderr] Checking prnotifier v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:184:18 [INFO] [stderr] | [INFO] [stderr] 184 | .or_insert(NotificationHistoryEntry::new(now)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| NotificationHistoryEntry::new(now))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:231:48 [INFO] [stderr] | [INFO] [stderr] 231 | let config_filename = matches.opt_str("c").unwrap_or(String::from("config.toml")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("config.toml"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:233:63 [INFO] [stderr] | [INFO] [stderr] 233 | let cfg: config::Config = config::parse(&config_filename).expect(&format!("can't parse config '{}'", config_filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("can't parse config '{}'", config_filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:253:52 [INFO] [stderr] | [INFO] [stderr] 253 | let sleep_interval = time::Duration::from_secs(cfg.sleep_interval as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cfg.sleep_interval)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:259:33 [INFO] [stderr] | [INFO] [stderr] 259 | max_age: Duration::days(cfg.pr_max_age as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cfg.pr_max_age)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:262:49 [INFO] [stderr] | [INFO] [stderr] 262 | notification_timeout: Duration::seconds(cfg.notification_timeout as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cfg.notification_timeout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:184:18 [INFO] [stderr] | [INFO] [stderr] 184 | .or_insert(NotificationHistoryEntry::new(now)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| NotificationHistoryEntry::new(now))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:231:48 [INFO] [stderr] | [INFO] [stderr] 231 | let config_filename = matches.opt_str("c").unwrap_or(String::from("config.toml")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("config.toml"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:233:63 [INFO] [stderr] | [INFO] [stderr] 233 | let cfg: config::Config = config::parse(&config_filename).expect(&format!("can't parse config '{}'", config_filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("can't parse config '{}'", config_filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:253:52 [INFO] [stderr] | [INFO] [stderr] 253 | let sleep_interval = time::Duration::from_secs(cfg.sleep_interval as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cfg.sleep_interval)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:259:33 [INFO] [stderr] | [INFO] [stderr] 259 | max_age: Duration::days(cfg.pr_max_age as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cfg.pr_max_age)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:262:49 [INFO] [stderr] | [INFO] [stderr] 262 | notification_timeout: Duration::seconds(cfg.notification_timeout as i64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(cfg.notification_timeout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.69s [INFO] running `"docker" "inspect" "1964514d276f5e97939719b827156c14392bd7137ddfbeefe32ec2faaa72867b"` [INFO] running `"docker" "rm" "-f" "1964514d276f5e97939719b827156c14392bd7137ddfbeefe32ec2faaa72867b"` [INFO] [stdout] 1964514d276f5e97939719b827156c14392bd7137ddfbeefe32ec2faaa72867b