[INFO] updating cached repository THE108/pdautomator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/THE108/pdautomator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/THE108/pdautomator" "work/ex/clippy-test-run/sources/stable/gh/THE108/pdautomator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/THE108/pdautomator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/THE108/pdautomator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/THE108/pdautomator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/THE108/pdautomator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f223bdf85d86d19b0fa434024bb7fab7a324c6b5 [INFO] sha for GitHub repo THE108/pdautomator: f223bdf85d86d19b0fa434024bb7fab7a324c6b5 [INFO] validating manifest of THE108/pdautomator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of THE108/pdautomator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing THE108/pdautomator [INFO] finished frobbing THE108/pdautomator [INFO] frobbed toml for THE108/pdautomator written to work/ex/clippy-test-run/sources/stable/gh/THE108/pdautomator/Cargo.toml [INFO] started frobbing THE108/pdautomator [INFO] finished frobbing THE108/pdautomator [INFO] frobbed toml for THE108/pdautomator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/THE108/pdautomator/Cargo.toml [INFO] crate THE108/pdautomator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting THE108/pdautomator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/THE108/pdautomator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a12d01869272a3e69c33916b840e3bd2273446e0073b33bb76eee8d256094cb [INFO] running `"docker" "start" "-a" "4a12d01869272a3e69c33916b840e3bd2273446e0073b33bb76eee8d256094cb"` [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking pdautomator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pagerduty.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &IncidentStatus::Triggered => "triggered", [INFO] [stderr] 88 | | &IncidentStatus::Acknowledged => "acknowledged", [INFO] [stderr] 89 | | &IncidentStatus::Resolved => "resolved", [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | IncidentStatus::Triggered => "triggered", [INFO] [stderr] 88 | IncidentStatus::Acknowledged => "acknowledged", [INFO] [stderr] 89 | IncidentStatus::Resolved => "resolved", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pagerduty.rs:120:134 [INFO] [stderr] | [INFO] [stderr] 120 | fn make_url(&self, since: Option>, until: Option>, offset: u32, status: &Option, fields: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pagerduty.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / if let &Some(ref status) = status { [INFO] [stderr] 132 | | params.push(format!("status={}", status.as_str())); [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(ref status) = *status { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:79:41 [INFO] [stderr] | [INFO] [stderr] 79 | cmd_by_action.entry(action).or_insert(Vec::new()).push((incident_id.clone(), command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:132:48 [INFO] [stderr] | [INFO] [stderr] 132 | let config_filename = matches.opt_str("c").unwrap_or(String::from("config.toml")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("config.toml"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pagerduty.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / match self { [INFO] [stderr] 87 | | &IncidentStatus::Triggered => "triggered", [INFO] [stderr] 88 | | &IncidentStatus::Acknowledged => "acknowledged", [INFO] [stderr] 89 | | &IncidentStatus::Resolved => "resolved", [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 86 | match *self { [INFO] [stderr] 87 | IncidentStatus::Triggered => "triggered", [INFO] [stderr] 88 | IncidentStatus::Acknowledged => "acknowledged", [INFO] [stderr] 89 | IncidentStatus::Resolved => "resolved", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pagerduty.rs:120:134 [INFO] [stderr] | [INFO] [stderr] 120 | fn make_url(&self, since: Option>, until: Option>, offset: u32, status: &Option, fields: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/pagerduty.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / if let &Some(ref status) = status { [INFO] [stderr] 132 | | params.push(format!("status={}", status.as_str())); [INFO] [stderr] 133 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 131 | if let Some(ref status) = *status { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:79:41 [INFO] [stderr] | [INFO] [stderr] 79 | cmd_by_action.entry(action).or_insert(Vec::new()).push((incident_id.clone(), command)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:132:48 [INFO] [stderr] | [INFO] [stderr] 132 | let config_filename = matches.opt_str("c").unwrap_or(String::from("config.toml")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("config.toml"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.92s [INFO] running `"docker" "inspect" "4a12d01869272a3e69c33916b840e3bd2273446e0073b33bb76eee8d256094cb"` [INFO] running `"docker" "rm" "-f" "4a12d01869272a3e69c33916b840e3bd2273446e0073b33bb76eee8d256094cb"` [INFO] [stdout] 4a12d01869272a3e69c33916b840e3bd2273446e0073b33bb76eee8d256094cb