[INFO] updating cached repository TGElder/isometric [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TGElder/isometric [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TGElder/isometric" "work/ex/clippy-test-run/sources/stable/gh/TGElder/isometric"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TGElder/isometric'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TGElder/isometric" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TGElder/isometric"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TGElder/isometric'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 52af3c9d21d2a8d536f81a67ca820cc8d05cddfd [INFO] sha for GitHub repo TGElder/isometric: 52af3c9d21d2a8d536f81a67ca820cc8d05cddfd [INFO] validating manifest of TGElder/isometric on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TGElder/isometric on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TGElder/isometric [INFO] finished frobbing TGElder/isometric [INFO] frobbed toml for TGElder/isometric written to work/ex/clippy-test-run/sources/stable/gh/TGElder/isometric/Cargo.toml [INFO] started frobbing TGElder/isometric [INFO] finished frobbing TGElder/isometric [INFO] frobbed toml for TGElder/isometric written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TGElder/isometric/Cargo.toml [INFO] crate TGElder/isometric has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TGElder/isometric against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TGElder/isometric:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ad4326d93ccfd64629dc62b7afdb6756dd9d73a9f6fb838229891c6c9faa818b [INFO] running `"docker" "start" "-a" "ad4326d93ccfd64629dc62b7afdb6756dd9d73a9f6fb838229891c6c9faa818b"` [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.72 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking piston2d-drag_controller v0.22.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking isometric v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `piston::event_loop::*` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use piston::event_loop::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return Coord2D{x, y}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Coord2D{x, y}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return Coord3D{x, y, z}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Coord3D{x, y, z}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/geometry.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn to_isometric(self: Coord3D) -> Coord2D { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | fn render(&mut self, lines: &Vec<[[f64; 4]; 4]>, polygons: &Vec<[[f64; 2]; 4]>, args: &RenderArgs, drag: &[f64; 2], scale: &f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[[[f64; 4]; 4]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:27:64 [INFO] [stderr] | [INFO] [stderr] 27 | fn render(&mut self, lines: &Vec<[[f64; 4]; 4]>, polygons: &Vec<[[f64; 2]; 4]>, args: &RenderArgs, drag: &[f64; 2], scale: &f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[[[f64; 2]; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:27:128 [INFO] [stderr] | [INFO] [stderr] 27 | fn render(&mut self, lines: &Vec<[[f64; 4]; 4]>, polygons: &Vec<[[f64; 2]; 4]>, args: &RenderArgs, drag: &[f64; 2], scale: &f64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:62 [INFO] [stderr] | [INFO] [stderr] 71 | screen_coords[x as usize][y as usize] = Coord3D::new(x as f64, y as f64, pixel.data[0] as f64).to_isometric(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:72 [INFO] [stderr] | [INFO] [stderr] 71 | screen_coords[x as usize][y as usize] = Coord3D::new(x as f64, y as f64, pixel.data[0] as f64).to_isometric(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:82 [INFO] [stderr] | [INFO] [stderr] 71 | screen_coords[x as usize][y as usize] = Coord3D::new(x as f64, y as f64, pixel.data[0] as f64).to_isometric(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if s[1] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(s[1] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if s[1] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:149:23 [INFO] [stderr] | [INFO] [stderr] 149 | } else if s[1] == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(s[1] - -1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:149:23 [INFO] [stderr] | [INFO] [stderr] 149 | } else if s[1] == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `isometric`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `piston::event_loop::*` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use piston::event_loop::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return Coord2D{x, y}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Coord2D{x, y}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geometry.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return Coord3D{x, y, z}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Coord3D{x, y, z}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/geometry.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn to_isometric(self: Coord3D) -> Coord2D { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:27:33 [INFO] [stderr] | [INFO] [stderr] 27 | fn render(&mut self, lines: &Vec<[[f64; 4]; 4]>, polygons: &Vec<[[f64; 2]; 4]>, args: &RenderArgs, drag: &[f64; 2], scale: &f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[[[f64; 4]; 4]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:27:64 [INFO] [stderr] | [INFO] [stderr] 27 | fn render(&mut self, lines: &Vec<[[f64; 4]; 4]>, polygons: &Vec<[[f64; 2]; 4]>, args: &RenderArgs, drag: &[f64; 2], scale: &f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[[[f64; 2]; 4]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:27:128 [INFO] [stderr] | [INFO] [stderr] 27 | fn render(&mut self, lines: &Vec<[[f64; 4]; 4]>, polygons: &Vec<[[f64; 2]; 4]>, args: &RenderArgs, drag: &[f64; 2], scale: &f64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:62 [INFO] [stderr] | [INFO] [stderr] 71 | screen_coords[x as usize][y as usize] = Coord3D::new(x as f64, y as f64, pixel.data[0] as f64).to_isometric(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:72 [INFO] [stderr] | [INFO] [stderr] 71 | screen_coords[x as usize][y as usize] = Coord3D::new(x as f64, y as f64, pixel.data[0] as f64).to_isometric(); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:82 [INFO] [stderr] | [INFO] [stderr] 71 | screen_coords[x as usize][y as usize] = Coord3D::new(x as f64, y as f64, pixel.data[0] as f64).to_isometric(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if s[1] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(s[1] - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if s[1] == 1.0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/main.rs:149:23 [INFO] [stderr] | [INFO] [stderr] 149 | } else if s[1] == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider comparing them within some error: `(s[1] - -1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/main.rs:149:23 [INFO] [stderr] | [INFO] [stderr] 149 | } else if s[1] == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `isometric`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ad4326d93ccfd64629dc62b7afdb6756dd9d73a9f6fb838229891c6c9faa818b"` [INFO] running `"docker" "rm" "-f" "ad4326d93ccfd64629dc62b7afdb6756dd9d73a9f6fb838229891c6c9faa818b"` [INFO] [stdout] ad4326d93ccfd64629dc62b7afdb6756dd9d73a9f6fb838229891c6c9faa818b