[INFO] updating cached repository TBeihammer/Snake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/TBeihammer/Snake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/TBeihammer/Snake" "work/ex/clippy-test-run/sources/stable/gh/TBeihammer/Snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/TBeihammer/Snake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/TBeihammer/Snake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TBeihammer/Snake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TBeihammer/Snake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0ca57e1ed2f23c386c2c5b45af67c3bf272f86ad [INFO] sha for GitHub repo TBeihammer/Snake: 0ca57e1ed2f23c386c2c5b45af67c3bf272f86ad [INFO] validating manifest of TBeihammer/Snake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of TBeihammer/Snake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing TBeihammer/Snake [INFO] finished frobbing TBeihammer/Snake [INFO] frobbed toml for TBeihammer/Snake written to work/ex/clippy-test-run/sources/stable/gh/TBeihammer/Snake/Cargo.toml [INFO] started frobbing TBeihammer/Snake [INFO] finished frobbing TBeihammer/Snake [INFO] frobbed toml for TBeihammer/Snake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/TBeihammer/Snake/Cargo.toml [INFO] crate TBeihammer/Snake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting TBeihammer/Snake against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/TBeihammer/Snake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b70e928946788329adc1606715b50b3035029937c1bb4d7683d358395ff9835 [INFO] running `"docker" "start" "-a" "8b70e928946788329adc1606715b50b3035029937c1bb4d7683d358395ff9835"` [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking piston2d-opengl_graphics v0.40.0 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking Snake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/snake.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | NoCollision, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/snake.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | rect [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/snake.rs:254:20 [INFO] [stderr] | [INFO] [stderr] 254 | let rect = graphics::rectangle::rectangle_by_corners(snake_pos_x - block_size_x * 0.5, snake_pos_y - block_size_y * 0.5, [INFO] [stderr] | ____________________^ [INFO] [stderr] 255 | | snake_pos_x + block_size_x * 0.5, snake_pos_y + block_size_y * 0.5); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/snake.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | NoCollision, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/snake.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | rect [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/snake.rs:254:20 [INFO] [stderr] | [INFO] [stderr] 254 | let rect = graphics::rectangle::rectangle_by_corners(snake_pos_x - block_size_x * 0.5, snake_pos_y - block_size_y * 0.5, [INFO] [stderr] | ____________________^ [INFO] [stderr] 255 | | snake_pos_x + block_size_x * 0.5, snake_pos_y + block_size_y * 0.5); [INFO] [stderr] | |_______________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fruit` [INFO] [stderr] --> src/snake.rs:133:34 [INFO] [stderr] | [INFO] [stderr] 133 | Collision::WithFruit(fruit) =>{ [INFO] [stderr] | ^^^^^ help: consider using `_fruit` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `fruit` [INFO] [stderr] --> src/snake.rs:133:34 [INFO] [stderr] | [INFO] [stderr] 133 | Collision::WithFruit(fruit) =>{ [INFO] [stderr] | ^^^^^ help: consider using `_fruit` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/snake.rs:341:16 [INFO] [stderr] | [INFO] [stderr] 341 | mut window: &mut Window, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/snake.rs:342:16 [INFO] [stderr] | [INFO] [stderr] 342 | mut gl: &mut GlGraphics, [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/snake.rs:343:16 [INFO] [stderr] | [INFO] [stderr] 343 | mut e: &mut Events, [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/snake.rs:344:16 [INFO] [stderr] | [INFO] [stderr] 344 | mut glyph_cache: &mut GlyphCache){ [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `LIGHTBLUE` [INFO] [stderr] --> src/snake.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub const LIGHTBLUE: [f32; 4] = [0.0, 1.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ORANGE` [INFO] [stderr] --> src/snake.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub const ORANGE: [f32; 4] = [1.0, 0.5, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PINK` [INFO] [stderr] --> src/snake.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub const PINK: [f32; 4] = [1.0, 0.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ANGEL` [INFO] [stderr] --> src/snake.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub const ANGEL: [f32; 4 ] = [0.5,0.5,1.0,0.5]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/snake.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub const GREEN: [f32; 4 ] = [0.0,0.5,0.0,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `Snake` should have a snake case name such as `snake` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | let center_x = ((width as f64) * 0.5) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | let center_y = ((height as f64) * 0.5) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/snake.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | fn is_collision(&mut self) -> Collision{ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/snake.rs:341:16 [INFO] [stderr] | [INFO] [stderr] 341 | mut window: &mut Window, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/snake.rs:342:16 [INFO] [stderr] | [INFO] [stderr] 342 | mut gl: &mut GlGraphics, [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/snake.rs:343:16 [INFO] [stderr] | [INFO] [stderr] 343 | mut e: &mut Events, [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/snake.rs:344:16 [INFO] [stderr] | [INFO] [stderr] 344 | mut glyph_cache: &mut GlyphCache){ [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `LIGHTBLUE` [INFO] [stderr] --> src/snake.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub const LIGHTBLUE: [f32; 4] = [0.0, 1.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ORANGE` [INFO] [stderr] --> src/snake.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub const ORANGE: [f32; 4] = [1.0, 0.5, 0.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PINK` [INFO] [stderr] --> src/snake.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub const PINK: [f32; 4] = [1.0, 0.0, 1.0, 1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ANGEL` [INFO] [stderr] --> src/snake.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub const ANGEL: [f32; 4 ] = [0.5,0.5,1.0,0.5]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `GREEN` [INFO] [stderr] --> src/snake.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub const GREEN: [f32; 4 ] = [0.0,0.5,0.0,1.0]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `Snake` should have a snake case name such as `snake` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | let center_x = ((width as f64) * 0.5) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | let center_y = ((height as f64) * 0.5) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/snake.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | fn is_collision(&mut self) -> Collision{ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | fn on_update(&mut self, upd: &UpdateArgs){ [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/snake.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | self.snake_head.pos_x = self.snake_head.pos_x + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.snake_head.pos_x += x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/snake.rs:130:34 [INFO] [stderr] | [INFO] [stderr] 130 | fn on_update(&mut self, upd: &UpdateArgs){ [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/snake.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | self.snake_head.pos_y = self.snake_head.pos_y + y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.snake_head.pos_y += y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/snake.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | self.snake_head.pos_x = self.snake_head.pos_x + x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.snake_head.pos_x += x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/snake.rs:182:13 [INFO] [stderr] | [INFO] [stderr] 182 | self.snake_head.pos_y = self.snake_head.pos_y + y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.snake_head.pos_y += y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:250:28 [INFO] [stderr] | [INFO] [stderr] 250 | let block_size_x = (args.width as f64) / (self.dimensions[0] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:250:50 [INFO] [stderr] | [INFO] [stderr] 250 | let block_size_x = (args.width as f64) / (self.dimensions[0] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimensions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:251:28 [INFO] [stderr] | [INFO] [stderr] 251 | let block_size_y = (args.height as f64) / (self.dimensions[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:251:51 [INFO] [stderr] | [INFO] [stderr] 251 | let block_size_y = (args.height as f64) / (self.dimensions[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimensions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:252:27 [INFO] [stderr] | [INFO] [stderr] 252 | let snake_pos_x = (pos_x as f64) * block_size_x; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pos_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:253:27 [INFO] [stderr] | [INFO] [stderr] 253 | let snake_pos_y = (pos_y as f64) * block_size_y; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pos_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:280:30 [INFO] [stderr] | [INFO] [stderr] 280 | let line_width = (args.width as f64) / (self.dimensions[0] as f64) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:280:52 [INFO] [stderr] | [INFO] [stderr] 280 | let line_width = (args.width as f64) / (self.dimensions[0] as f64) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimensions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:281:31 [INFO] [stderr] | [INFO] [stderr] 281 | let line_height = (args.height as f64) / (self.dimensions[1] as f64) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:281:54 [INFO] [stderr] | [INFO] [stderr] 281 | let line_height = (args.height as f64) / (self.dimensions[1] as f64) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimensions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:284:33 [INFO] [stderr] | [INFO] [stderr] 284 | [0.0, 0.0, 0.0, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:289:18 [INFO] [stderr] | [INFO] [stderr] 289 | [args.width as f64, 0.0, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:289:42 [INFO] [stderr] | [INFO] [stderr] 289 | [args.width as f64, 0.0, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:289:61 [INFO] [stderr] | [INFO] [stderr] 289 | [args.width as f64, 0.0, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:250:28 [INFO] [stderr] | [INFO] [stderr] 250 | let block_size_x = (args.width as f64) / (self.dimensions[0] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:294:28 [INFO] [stderr] | [INFO] [stderr] 294 | [0.0, 0.0, args.width as f64, 0.0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:299:23 [INFO] [stderr] | [INFO] [stderr] 299 | [0.0, args.height as f64, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:299:43 [INFO] [stderr] | [INFO] [stderr] 299 | [0.0, args.height as f64, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:299:62 [INFO] [stderr] | [INFO] [stderr] 299 | [0.0, args.height as f64, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:250:50 [INFO] [stderr] | [INFO] [stderr] 250 | let block_size_x = (args.width as f64) / (self.dimensions[0] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimensions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:251:28 [INFO] [stderr] | [INFO] [stderr] 251 | let block_size_y = (args.height as f64) / (self.dimensions[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:251:51 [INFO] [stderr] | [INFO] [stderr] 251 | let block_size_y = (args.height as f64) / (self.dimensions[1] as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimensions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:252:27 [INFO] [stderr] | [INFO] [stderr] 252 | let snake_pos_x = (pos_x as f64) * block_size_x; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pos_x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:253:27 [INFO] [stderr] | [INFO] [stderr] 253 | let snake_pos_y = (pos_y as f64) * block_size_y; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pos_y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/snake.rs:322:21 [INFO] [stderr] | [INFO] [stderr] 322 | format!("Game over! Press Space to restart, Escape to quit!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Game over! Press Space to restart, Escape to quit!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | / match button { [INFO] [stderr] 351 | | Button::Keyboard(key) => self.on_keypress(key), [INFO] [stderr] 352 | | _ => {} [INFO] [stderr] 353 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Button::Keyboard(key) = button { self.on_keypress(key) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:280:30 [INFO] [stderr] | [INFO] [stderr] 280 | let line_width = (args.width as f64) / (self.dimensions[0] as f64) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:280:52 [INFO] [stderr] | [INFO] [stderr] 280 | let line_width = (args.width as f64) / (self.dimensions[0] as f64) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimensions[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:281:31 [INFO] [stderr] | [INFO] [stderr] 281 | let line_height = (args.height as f64) / (self.dimensions[1] as f64) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:281:54 [INFO] [stderr] | [INFO] [stderr] 281 | let line_height = (args.height as f64) / (self.dimensions[1] as f64) * 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.dimensions[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:284:33 [INFO] [stderr] | [INFO] [stderr] 284 | [0.0, 0.0, 0.0, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:289:18 [INFO] [stderr] | [INFO] [stderr] 289 | [args.width as f64, 0.0, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:289:42 [INFO] [stderr] | [INFO] [stderr] 289 | [args.width as f64, 0.0, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:289:61 [INFO] [stderr] | [INFO] [stderr] 289 | [args.width as f64, 0.0, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:294:28 [INFO] [stderr] | [INFO] [stderr] 294 | [0.0, 0.0, args.width as f64, 0.0], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:299:23 [INFO] [stderr] | [INFO] [stderr] 299 | [0.0, args.height as f64, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:299:43 [INFO] [stderr] | [INFO] [stderr] 299 | [0.0, args.height as f64, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/snake.rs:299:62 [INFO] [stderr] | [INFO] [stderr] 299 | [0.0, args.height as f64, args.width as f64, args.height as f64], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/snake.rs:322:21 [INFO] [stderr] | [INFO] [stderr] 322 | format!("Game over! Press Space to restart, Escape to quit!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Game over! Press Space to restart, Escape to quit!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/snake.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | / match button { [INFO] [stderr] 351 | | Button::Keyboard(key) => self.on_keypress(key), [INFO] [stderr] 352 | | _ => {} [INFO] [stderr] 353 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Button::Keyboard(key) = button { self.on_keypress(key) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.68s [INFO] running `"docker" "inspect" "8b70e928946788329adc1606715b50b3035029937c1bb4d7683d358395ff9835"` [INFO] running `"docker" "rm" "-f" "8b70e928946788329adc1606715b50b3035029937c1bb4d7683d358395ff9835"` [INFO] [stdout] 8b70e928946788329adc1606715b50b3035029937c1bb4d7683d358395ff9835